48854 2010-11-02 11:02:46 -0700 Web Inspector: Remove obsolete code. 2010-11-03 09:43:37 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 303484 0 loislo 2010-11-02 11:02:46 -0700 It is not required to push onload and DOMContentLoaded events times to the fresh instance of Inspector. Network Panel is showing the markers only after reloading the inspected page. 303487 1 72700 loislo 2010-11-02 11:04:47 -0700 Created attachment 72700 [patch] initial version. 303500 2 72700 pfeldman 2010-11-02 11:16:02 -0700 Comment on attachment 72700 [patch] initial version. You should remove m_domContentEventTime and m_loadEventTime fields as well. 303514 3 72706 loislo 2010-11-02 11:37:09 -0700 Created attachment 72706 [patch] second iteration 303804 4 72706 commit-queue 2010-11-02 17:07:50 -0700 Comment on attachment 72706 [patch] second iteration Rejecting patch 72706 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/5050003 304068 5 72706 loislo 2010-11-03 09:43:28 -0700 Comment on attachment 72706 [patch] second iteration Committed r71235 M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h r71235 = ae0c22099bdd2445d99c74576c53c36a30cc9d3f (refs/remotes/trunk) 72700 2010-11-02 11:04:47 -0700 2010-11-02 11:37:09 -0700 [patch] initial version. patch text/plain 1385 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTc0NjNhMi4uNWJlNjE0YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMS0wMiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIG9ic29sZXRlIGNvZGUu CisgICAgICAgIEl0IGlzIG5vdCByZXF1aXJlZCB0byBwdXNoIG9ubG9hZCBhbmQgRE9NQ29udGVu dExvYWRlZCBldmVudHMgdGltZXMgdG8gdGhlIGZyZXNoIGluc3RhbmNlIG9mIEluc3BlY3Rvci4K KyAgICAgICAgTmV0d29yayBQYW5lbCBpcyBzaG93aW5nIHRoZSBtYXJrZXJzIG9ubHkgYWZ0ZXIg cmVsb2FkaW5nIHRoZSBpbnNwZWN0ZWQgcGFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4ODU0CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVy Ojpwb3B1bGF0ZVNjcmlwdE9iamVjdHMpOgorCiAyMDEwLTExLTAxICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXou CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBi L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IDVhNGFiYzAu Ljk0NDAxZjIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBA IC02MjksMTEgKzYyOSw2IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6cG9wdWxhdGVTY3Jp cHRPYmplY3RzKCkKICAgICAgICAgbV9mcm9udGVuZC0+cHJvZmlsZXJXYXNFbmFibGVkKCk7CiAj ZW5kaWYKIAotICAgIGlmIChtX2RvbUNvbnRlbnRFdmVudFRpbWUgIT0gLTEuMCkKLSAgICAgICAg bV9mcm9udGVuZC0+ZG9tQ29udGVudEV2ZW50RmlyZWQobV9kb21Db250ZW50RXZlbnRUaW1lKTsK LSAgICBpZiAobV9sb2FkRXZlbnRUaW1lICE9IC0xLjApCi0gICAgICAgIG1fZnJvbnRlbmQtPmxv YWRFdmVudEZpcmVkKG1fbG9hZEV2ZW50VGltZSk7Ci0KICAgICBtX2RvbUFnZW50LT5zZXREb2N1 bWVudChtX2luc3BlY3RlZFBhZ2UtPm1haW5GcmFtZSgpLT5kb2N1bWVudCgpKTsKIAogICAgIGlm IChtX25vZGVUb0ZvY3VzKQo= 72706 2010-11-02 11:37:09 -0700 2010-11-03 09:43:28 -0700 [patch] second iteration patch text/plain 3647 loislo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OTc0NjNhMi4uNWIyNjJjNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMS0wMiAgSWx5YSBUaWtob25v dnNreSAgPGxvaXNsb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVtb3ZlIG9ic29sZXRlIGNvZGUu CisgICAgICAgIEl0IGlzIG5vdCByZXF1aXJlZCB0byBwdXNoIG9ubG9hZCBhbmQgRE9NQ29udGVu dExvYWRlZCBldmVudHMgdGltZXMgdG8gdGhlIGZyZXNoIGluc3RhbmNlIG9mIEluc3BlY3Rvci4K KyAgICAgICAgTmV0d29yayBQYW5lbCBpcyBzaG93aW5nIHRoZSBtYXJrZXJzIG9ubHkgYWZ0ZXIg cmVsb2FkaW5nIHRoZSBpbnNwZWN0ZWQgcGFnZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4ODU0CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVy OjpJbnNwZWN0b3JDb250cm9sbGVyKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRy b2xsZXI6OnBvcHVsYXRlU2NyaXB0T2JqZWN0cyk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0 b3JDb250cm9sbGVyOjptYWluUmVzb3VyY2VGaXJlZERPTUNvbnRlbnRFdmVudCk6CisgICAgICAg IChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjptYWluUmVzb3VyY2VGaXJlZExvYWRFdmVu dCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaDoKKwogMjAxMC0x MS0wMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9s bGVyLmNwcAppbmRleCA1YTRhYmMwLi4wODI1ZGM2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JDb250cm9sbGVyLmNwcApAQCAtMTQzLDggKzE0Myw2IEBAIEluc3BlY3RvckNvbnRyb2xs ZXI6Okluc3BlY3RvckNvbnRyb2xsZXIoUGFnZSogcGFnZSwgSW5zcGVjdG9yQ2xpZW50KiBjbGll bnQpCiAgICAgLCBtX29wZW5pbmdGcm9udGVuZChmYWxzZSkKICAgICAsIG1fY3NzU3RvcmUobmV3 IEluc3BlY3RvckNTU1N0b3JlKHRoaXMpKQogICAgICwgbV9tYWluUmVzb3VyY2VJZGVudGlmaWVy KDApCi0gICAgLCBtX2xvYWRFdmVudFRpbWUoLTEuMCkKLSAgICAsIG1fZG9tQ29udGVudEV2ZW50 VGltZSgtMS4wKQogICAgICwgbV9leHBpcmVkQ29uc29sZU1lc3NhZ2VDb3VudCgwKQogICAgICwg bV9ncm91cExldmVsKDApCiAgICAgLCBtX3ByZXZpb3VzTWVzc2FnZSgwKQpAQCAtNjI5LDExICs2 MjcsNiBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnBvcHVsYXRlU2NyaXB0T2JqZWN0cygp CiAgICAgICAgIG1fZnJvbnRlbmQtPnByb2ZpbGVyV2FzRW5hYmxlZCgpOwogI2VuZGlmCiAKLSAg ICBpZiAobV9kb21Db250ZW50RXZlbnRUaW1lICE9IC0xLjApCi0gICAgICAgIG1fZnJvbnRlbmQt PmRvbUNvbnRlbnRFdmVudEZpcmVkKG1fZG9tQ29udGVudEV2ZW50VGltZSk7Ci0gICAgaWYgKG1f bG9hZEV2ZW50VGltZSAhPSAtMS4wKQotICAgICAgICBtX2Zyb250ZW5kLT5sb2FkRXZlbnRGaXJl ZChtX2xvYWRFdmVudFRpbWUpOwotCiAgICAgbV9kb21BZ2VudC0+c2V0RG9jdW1lbnQobV9pbnNw ZWN0ZWRQYWdlLT5tYWluRnJhbWUoKS0+ZG9jdW1lbnQoKSk7CiAKICAgICBpZiAobV9ub2RlVG9G b2N1cykKQEAgLTgwNCwxMSArNzk3LDEwIEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6bWFp blJlc291cmNlRmlyZWRET01Db250ZW50RXZlbnQoRG9jdW1lbnRMb2FkZXIqIGxvYWRlCiAgICAg aWYgKCFlbmFibGVkKCkgfHwgIWlzTWFpblJlc291cmNlTG9hZGVyKGxvYWRlciwgdXJsKSkKICAg ICAgICAgcmV0dXJuOwogCi0gICAgbV9kb21Db250ZW50RXZlbnRUaW1lID0gY3VycmVudFRpbWUo KTsKICAgICBpZiAobV90aW1lbGluZUFnZW50KQogICAgICAgICBtX3RpbWVsaW5lQWdlbnQtPmRp ZE1hcmtET01Db250ZW50RXZlbnQoKTsKICAgICBpZiAobV9mcm9udGVuZCkKLSAgICAgICAgbV9m cm9udGVuZC0+ZG9tQ29udGVudEV2ZW50RmlyZWQobV9kb21Db250ZW50RXZlbnRUaW1lKTsKKyAg ICAgICAgbV9mcm9udGVuZC0+ZG9tQ29udGVudEV2ZW50RmlyZWQoY3VycmVudFRpbWUoKSk7CiB9 CiAKIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6bWFpblJlc291cmNlRmlyZWRMb2FkRXZlbnQo RG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgY29uc3QgS1VSTCYgdXJsKQpAQCAtODE2LDExICs4MDgs MTAgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjptYWluUmVzb3VyY2VGaXJlZExvYWRFdmVu dChEb2N1bWVudExvYWRlciogbG9hZGVyLCBjb24KICAgICBpZiAoIWVuYWJsZWQoKSB8fCAhaXNN YWluUmVzb3VyY2VMb2FkZXIobG9hZGVyLCB1cmwpKQogICAgICAgICByZXR1cm47CiAKLSAgICBt X2xvYWRFdmVudFRpbWUgPSBjdXJyZW50VGltZSgpOwogICAgIGlmIChtX3RpbWVsaW5lQWdlbnQp CiAgICAgICAgIG1fdGltZWxpbmVBZ2VudC0+ZGlkTWFya0xvYWRFdmVudCgpOwogICAgIGlmICht X2Zyb250ZW5kKQotICAgICAgICBtX2Zyb250ZW5kLT5sb2FkRXZlbnRGaXJlZChtX2xvYWRFdmVu dFRpbWUpOworICAgICAgICBtX2Zyb250ZW5kLT5sb2FkRXZlbnRGaXJlZChjdXJyZW50VGltZSgp KTsKIH0KIAogYm9vbCBJbnNwZWN0b3JDb250cm9sbGVyOjppc01haW5SZXNvdXJjZUxvYWRlcihE b2N1bWVudExvYWRlciogbG9hZGVyLCBjb25zdCBLVVJMJiByZXF1ZXN0VXJsKQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oIGIvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCmluZGV4IGFiNzI4YTEuLjg2ZmVhNjcgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAorKysgYi9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgKQEAgLTM0OSw4ICszNDksNiBAQCBw cml2YXRlOgogICAgIFJlZlB0cjxOb2RlPiBtX25vZGVUb0ZvY3VzOwogICAgIFJlZlB0cjxJbnNw ZWN0b3JSZXNvdXJjZUFnZW50PiBtX3Jlc291cmNlQWdlbnQ7CiAgICAgdW5zaWduZWQgbG9uZyBt X21haW5SZXNvdXJjZUlkZW50aWZpZXI7Ci0gICAgZG91YmxlIG1fbG9hZEV2ZW50VGltZTsKLSAg ICBkb3VibGUgbV9kb21Db250ZW50RXZlbnRUaW1lOwogICAgIFZlY3RvcjxPd25QdHI8Q29uc29s ZU1lc3NhZ2U+ID4gbV9jb25zb2xlTWVzc2FnZXM7CiAgICAgdW5zaWduZWQgbV9leHBpcmVkQ29u c29sZU1lc3NhZ2VDb3VudDsKICAgICBIYXNoTWFwPFN0cmluZywgZG91YmxlPiBtX3RpbWVzOwo=