48853 2010-11-02 11:01:44 -0700 WebProcessManager informed about crashes too late (pages may have already tried to load a new URL) 2010-11-10 14:21:39 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.6 RESOLVED FIXED P2 Normal --- 1 mthole mthole eric oldest_to_newest 303482 0 mthole 2010-11-02 11:01:44 -0700 The WebProcessProxy informs the WebProcessManager about crashes AFTER it informs the individual pages about the crash. This can cause individual pages to try to reload a new URL using the dead WebProcess. The WebProcessProxy should tell the shared WebProcessManager abut the crash before telling the individual pages. 303486 1 72699 mthole 2010-11-02 11:04:28 -0700 Created attachment 72699 Proposed patch 307548 2 eric 2010-11-10 14:15:03 -0800 Attachment 72699 was posted by a committer and has review+, assigning to Mike Thole for commit. 307554 3 mthole 2010-11-10 14:21:39 -0800 <rdar://problem/8610451> Committed revision 71135. 72699 2010-11-02 11:04:28 -0700 2010-11-02 11:06:48 -0700 Proposed patch textmate stdin iVMIpG.txt text/plain 2561 mthole SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTEyOCkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMDIgIE1pa2UgVGhvbGUgIDxtdGhvbGVAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYlBy b2Nlc3NNYW5hZ2VyIGluZm9ybWVkIGFib3V0IGNyYXNoZXMgdG9vIGxhdGUgKHBhZ2VzIG1heSBo YXZlIGFscmVhZHkgdHJpZWQgdG8gbG9hZCBhIG5ldyBVUkwpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODg1MworCisgICAgICAgIFRoaXMgYWxzbyBm aXhlczogPHJkYXI6Ly9wcm9ibGVtLzg2MTA0NTE+IFdlYmtpdDI6IENyYXNoIGluIFdlYktpdCFX ZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6c2VuZE1lc3NhZ2Ugb3BlbmluZyBnb29nbGUuY29tIHBh Z2UKKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQcm9jZXNzUHJveHk6On5XZWJQcm9jZXNzUHJveHkpOgorICAgICAgICBSZW1v dmVkIGludmFsaWQgYXNzZXJ0aW9uIHRoYXQgaXMgaGl0IHdoZW4gdGhlIFdlYlByb2Nlc3MgZGll cyB1bmV4cGVjdGVkbHkuCisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3NQcm94eTo6ZGlkQ2xv c2UpOgorICAgICAgICBSZW9yZGVyZWQgc28gdGhhdCB0aGUgaW5kaXZpZHVhbCBwYWdlcyBhcmUg aW5mb3JtZWQgdGhhdCB0aGUgcHJvY2Vzc0RpZENyYXNoKCkgYWZ0ZXIgdGhlIHNoYXJlZAorICAg ICAgICBXZWJQcm9jZXNzTWFuYWdlciBoYXMgYmVlbi4gVGhpcyBhbGxvd3MgdGhlIHBhZ2VzIHRv IHByb3Blcmx5IHRyaWdnZXIgYSBuZXcgcHJvY2VzcyB0byBiZSBsYXVuY2hlZC4KKwogMjAxMC0x MS0wMiAgQ2hyaXN0aWFuIFNlamVyc2VuICA8Y2hyaXN0aWFuLndlYmtpdEBnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KSW5kZXg6IFdlYktpdDIvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Byb3h5LmNwcAkocmV2aXNpb24gNzExMjMpCisrKyBXZWJLaXQyL1VJUHJvY2Vz cy9XZWJQcm9jZXNzUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Myw4ICs2Myw2IEBAIFdl YlByb2Nlc3NQcm94eTo6V2ViUHJvY2Vzc1Byb3h5KFdlYkNvbnQKIAogV2ViUHJvY2Vzc1Byb3h5 Ojp+V2ViUHJvY2Vzc1Byb3h5KCkKIHsKLSAgICBBU1NFUlQobV9wYWdlTWFwLmlzRW1wdHkoKSk7 Ci0KICAgICBpZiAobV9jb25uZWN0aW9uKQogICAgICAgICBtX2Nvbm5lY3Rpb24tPmludmFsaWRh dGUoKTsKICAgICAKQEAgLTQwMSw2ICszOTksMTAgQEAgQ29yZUlQQzo6U3luY1JlcGx5TW9kZSBX ZWJQcm9jZXNzUHJveHk6OgogCiB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGlkQ2xvc2UoQ29yZUlQ Qzo6Q29ubmVjdGlvbiopCiB7CisgICAgLy8gUHJvdGVjdCBvdXJzZWx2ZXMsIGFzIHRoZSBjYWxs IHRvIHRoZSBzaGFyZWQgV2ViUHJvY2Vzc01hbmFnZXIncyBwcm9jZXNzRGlkQ2xvc2UoKQorICAg IC8vIGJlbG93IG1heSBvdGhlcndpc2UgY2F1c2UgdXMgdG8gYmUgZGVsZXRlZCBiZWZvcmUgd2Ug Y2FuIGZpbmlzaCBvdXIgd29yay4KKyAgICBSZWZQdHI8V2ViUHJvY2Vzc1Byb3h5PiBwcm90ZWN0 KHRoaXMpOworICAgIAogICAgIG1fY29ubmVjdGlvbiA9IDA7CiAgICAgbV9yZXNwb25zaXZlbmVz c1RpbWVyLnN0b3AoKTsKIApAQCAtNDE0LDEzICs0MTYsMTMgQEAgdm9pZCBXZWJQcm9jZXNzUHJv eHk6OmRpZENsb3NlKENvcmVJUEM6OgogICAgIFZlY3RvcjxSZWZQdHI8V2ViUGFnZVByb3h5PiA+ IHBhZ2VzOwogICAgIGNvcHlWYWx1ZXNUb1ZlY3RvcihtX3BhZ2VNYXAsIHBhZ2VzKTsKIAotICAg IGZvciAoc2l6ZV90IGkgPSAwLCBzaXplID0gcGFnZXMuc2l6ZSgpOyBpIDwgc2l6ZTsgKytpKQot ICAgICAgICBwYWdlc1tpXS0+cHJvY2Vzc0RpZENyYXNoKCk7Ci0KICAgICBtX2NvbnRleHQtPnBy b2Nlc3NEaWRDbG9zZSh0aGlzKTsKIAotICAgIC8vIFRoaXMgbWF5IGNhdXNlIHVzIHRvIGJlIGRl bGV0ZWQuCiAgICAgV2ViUHJvY2Vzc01hbmFnZXI6OnNoYXJlZCgpLnByb2Nlc3NEaWRDbG9zZSh0 aGlzLCBtX2NvbnRleHQpOworCisgICAgZm9yIChzaXplX3QgaSA9IDAsIHNpemUgPSBwYWdlcy5z aXplKCk7IGkgPCBzaXplOyArK2kpCisgICAgICAgIHBhZ2VzW2ldLT5wcm9jZXNzRGlkQ3Jhc2go KTsKKwogfQogCiB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZGlkUmVjZWl2ZUludmFsaWRNZXNzYWdl KENvcmVJUEM6OkNvbm5lY3Rpb24qLCBDb3JlSVBDOjpNZXNzYWdlSUQgbWVzc2FnZUlEKQo=