48851 2010-11-02 10:55:37 -0700 [Chromium] Build failure with clang 2010-11-02 14:38:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 48414 P2 Normal --- 0 ctruta webkit-unassigned dglazkov sgjesse thakis oldest_to_newest 303476 0 ctruta 2010-11-02 10:55:37 -0700 I tried building Chromium with clang, according to the instructions posted at http://code.google.com/p/chromium/wiki/Clang The build failed because of the following compiler warning-turned-error: DumpRenderTree/chromium/TestShell.h:147:68: error: comparison of unsigned expression >= 0 is always true [-Wtautological-compare] This was introduced in changeset 70537: http://trac.webkit.org/changeset/70537 303522 1 72708 ctruta 2010-11-02 11:46:23 -0700 Created attachment 72708 Fix Here is the fix. Since gcc doesn't issue this warning by default, would it not be worth adding -Wtype-limits (and possibly others) to all CFLAGS, to ensure a smoother gcc <-> clang transition in the future? 303532 2 72708 dglazkov 2010-11-02 11:57:39 -0700 Comment on attachment 72708 Fix ok. 303597 3 72723 ctruta 2010-11-02 13:08:07 -0700 Created attachment 72723 Fix (fixed) Oops, I accidentally made changes in the wrong git branch, and my previous patch turned out backwards. Here is the correct fix. 303600 4 72723 dglazkov 2010-11-02 13:11:06 -0700 Comment on attachment 72723 Fix (fixed) ok. 303648 5 sgjesse 2010-11-02 14:07:07 -0700 Isn't this what is already fixed by https://bugs.webkit.org/show_bug.cgi?id=48414? 303667 6 ctruta 2010-11-02 14:31:21 -0700 (In reply to comment #5) > Isn't this what is already fixed by https://bugs.webkit.org/show_bug.cgi?id=48414? Oh, yeah, it is... I had a 1-day-old copy of WebKit that I should have refreshed... 303673 7 72723 ctruta 2010-11-02 14:35:20 -0700 Comment on attachment 72723 Fix (fixed) Setting cq-. This was already fixed yesterday in bug 48414, and I haven't noticed. 303676 8 ctruta 2010-11-02 14:38:57 -0700 *** This bug has been marked as a duplicate of bug 48414 *** 72708 2010-11-02 11:46:23 -0700 2010-11-02 13:08:07 -0700 Fix wk48851.diff.submit text/plain 1701 ctruta ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmZjgyMWFiLi5jMzA3OWUyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEt MDIgIENvc21pbiBUcnV0YSAgPGN0cnV0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBCdWlsZCBmYWlsdXJl IHdpdGggY2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ4ODUxCisKKyAgICAgICAgUmVtb3ZlZCBhbiB1bm5lY2Vzc2FyeSBjb21wYXJpc29uIG9m IGFuIHVuc2lnbmVkIGludGVnZXIgdmFyaWFibGUgd2l0aCAwLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmg6CisgICAgICAgIChUZXN0U2hlbGw6OmphdmFT Y3JpcHRGbGFnc0ZvckxvYWQpOgorCiAyMDEwLTExLTAyICBBZGFtIFJvYmVuICA8YXJvYmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBPbmx5IHRyYWNrIHJlc291cmNlIGlkZW50aWZpZXJzIGluIERS VCB3aGVuIGR1bXBSZXNvdXJjZUxvYWRDYWxsYmFja3MKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgKaW5kZXggMDZlNzdjYy4uY2EwNjgxMiAxMDA2 NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgK KysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgKQEAg LTE0NCw3ICsxNDQsNyBAQCBwdWJsaWM6CiAgICAgLy8gVGhlIEphdmFTY3JpcHQgZmxhZ3MgYXJl IHNwZWNpZmllZCBhcyBhIHZlY3RvciBvZiBzdHJpbmdzLiBFYWNoIGVsZW1lbnQgb2YgdGhlIHZl Y3RvciBpcyBmdWxsIGZsYWdzIHN0cmluZwogICAgIC8vIHdoaWNoIGNhbiBjb250YWluIG11bHRp cGxlIGZsYWdzIChlLmcuICItLXh4eCAtLXl5eSIpLiBXaXRoIG11bHRpcGxlIGxvYWQgdGVzdGlu ZyBpdCBpcyBwb3NzaWJsZSB0byBzcGVjaWZ5CiAgICAgLy8gc2VwYXJhdGUgc2V0cyBvZiBmbGFn cyB0byBlYWNoIGxvYWQuCi0gICAgc3RkOjpzdHJpbmcgamF2YVNjcmlwdEZsYWdzRm9yTG9hZChz aXplX3QgbG9hZCkgeyByZXR1cm4gKGxvYWQgPCBtX2phdmFTY3JpcHRGbGFncy5zaXplKCkpID8g bV9qYXZhU2NyaXB0RmxhZ3NbbG9hZF0gOiAiIjsgfQorICAgIHN0ZDo6c3RyaW5nIGphdmFTY3Jp cHRGbGFnc0ZvckxvYWQoc2l6ZV90IGxvYWQpIHsgcmV0dXJuIChsb2FkID49IDAgJiYgbG9hZCA8 IG1famF2YVNjcmlwdEZsYWdzLnNpemUoKSkgPyBtX2phdmFTY3JpcHRGbGFnc1tsb2FkXSA6ICIi OyB9CiAgICAgdm9pZCBzZXRKYXZhU2NyaXB0RmxhZ3MoVmVjdG9yPHN0ZDo6c3RyaW5nPiBqYXZh U2NyaXB0RmxhZ3MpIHsgbV9qYXZhU2NyaXB0RmxhZ3MgPSBqYXZhU2NyaXB0RmxhZ3M7IH0KIAog ICAgIC8vIFNldCB3aGV0aGVyIHRvIGR1bXAgd2hlbiB0aGUgbG9hZGVkIHBhZ2UgaGFzIGZpbmlz aGVkIHByb2Nlc3NpbmcuIFRoaXMgaXMgdXNlZCB3aXRoIG11bHRpcGxlIGxvYWQK 72723 2010-11-02 13:08:07 -0700 2010-11-02 14:35:20 -0700 Fix (fixed) wk48851.diff.submit text/plain 1703 ctruta ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwOTIxYzYyLi5kYjc3ZTUxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEt MDIgIENvc21pbiBUcnV0YSAgPGN0cnV0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBCdWlsZCBmYWlsdXJl IHdpdGggY2xhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ4ODUxCisKKyAgICAgICAgUmVtb3ZlZCBhbiB1bm5lY2Vzc2FyeSBjb21wYXJpc29uIG9m IGFuIHVuc2lnbmVkIGludGVnZXIgdmFyaWFibGUgd2l0aCAwLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmg6CisgICAgICAgIChUZXN0U2hlbGw6OmphdmFT Y3JpcHRGbGFnc0ZvckxvYWQpOgorCiAyMDEwLTExLTAyICBBZGFtIFJvYmVuICA8YXJvYmVuQGFw cGxlLmNvbT4KIAogICAgICAgICBTa2lwIHdlYmtpdHB5LmxheW91dF90ZXN0cy5ydW5fd2Via2l0 X3Rlc3RzX3VuaXR0ZXN0Lk1haW5UZXN0IG9uIEN5Z3dpbgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmggYi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaAppbmRleCBjYTA2ODEyLi4wNmU3N2NjIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwu aAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuaApA QCAtMTQ0LDcgKzE0NCw3IEBAIHB1YmxpYzoKICAgICAvLyBUaGUgSmF2YVNjcmlwdCBmbGFncyBh cmUgc3BlY2lmaWVkIGFzIGEgdmVjdG9yIG9mIHN0cmluZ3MuIEVhY2ggZWxlbWVudCBvZiB0aGUg dmVjdG9yIGlzIGZ1bGwgZmxhZ3Mgc3RyaW5nCiAgICAgLy8gd2hpY2ggY2FuIGNvbnRhaW4gbXVs dGlwbGUgZmxhZ3MgKGUuZy4gIi0teHh4IC0teXl5IikuIFdpdGggbXVsdGlwbGUgbG9hZCB0ZXN0 aW5nIGl0IGlzIHBvc3NpYmxlIHRvIHNwZWNpZnkKICAgICAvLyBzZXBhcmF0ZSBzZXRzIG9mIGZs YWdzIHRvIGVhY2ggbG9hZC4KLSAgICBzdGQ6OnN0cmluZyBqYXZhU2NyaXB0RmxhZ3NGb3JMb2Fk KHNpemVfdCBsb2FkKSB7IHJldHVybiAobG9hZCA+PSAwICYmIGxvYWQgPCBtX2phdmFTY3JpcHRG bGFncy5zaXplKCkpID8gbV9qYXZhU2NyaXB0RmxhZ3NbbG9hZF0gOiAiIjsgfQorICAgIHN0ZDo6 c3RyaW5nIGphdmFTY3JpcHRGbGFnc0ZvckxvYWQoc2l6ZV90IGxvYWQpIHsgcmV0dXJuIChsb2Fk IDwgbV9qYXZhU2NyaXB0RmxhZ3Muc2l6ZSgpKSA/IG1famF2YVNjcmlwdEZsYWdzW2xvYWRdIDog IiI7IH0KICAgICB2b2lkIHNldEphdmFTY3JpcHRGbGFncyhWZWN0b3I8c3RkOjpzdHJpbmc+IGph dmFTY3JpcHRGbGFncykgeyBtX2phdmFTY3JpcHRGbGFncyA9IGphdmFTY3JpcHRGbGFnczsgfQog CiAgICAgLy8gU2V0IHdoZXRoZXIgdG8gZHVtcCB3aGVuIHRoZSBsb2FkZWQgcGFnZSBoYXMgZmlu aXNoZWQgcHJvY2Vzc2luZy4gVGhpcyBpcyB1c2VkIHdpdGggbXVsdGlwbGUgbG9hZAo=