48837 2010-11-02 08:23:07 -0700 REGRESSION (r71097): Many http tests failing on Windows 2010-11-02 08:38:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://build.webkit.org/results/Windows%20Release%20(Tests)/r71097%20(5872)/results.html InRadar, LayoutTestFailure, PlatformOnly, Regression P2 Normal --- 1 aroben webkit-unassigned jennb oldest_to_newest 303365 0 aroben 2010-11-02 08:23:07 -0700 r71097 [1] changed DRT to record resource identifiers even when dumpResourceLoadCallbacks is turned off. This made Windows diverge from the expected test results by including URLs for the main resource. 1. http://trac.webkit.org/changeset/71097 303366 1 aroben 2010-11-02 08:25:16 -0700 <rdar://problem/8620351> 303368 2 72670 aroben 2010-11-02 08:28:20 -0700 Created attachment 72670 Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on 303371 3 72670 andersca 2010-11-02 08:29:24 -0700 Comment on attachment 72670 Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on View in context: https://bugs.webkit.org/attachment.cgi?id=72670&action=review > WebKitTools/ChangeLog:59 > + This seems unrelated? 303372 4 72670 aroben 2010-11-02 08:29:51 -0700 Comment on attachment 72670 Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on View in context: https://bugs.webkit.org/attachment.cgi?id=72670&action=review >> WebKitTools/ChangeLog:59 >> + > > This seems unrelated? Yes, whoops! 303377 5 aroben 2010-11-02 08:38:21 -0700 Committed r71116: <http://trac.webkit.org/changeset/71116> 72670 2010-11-02 08:28:20 -0700 2010-11-02 08:29:51 -0700 Only track resource identifiers in DRT when dumpResourceLoadCallbacks is on bug-48837-20101102112823.patch text/plain 4046 aroben ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyMzRjMjkwY2VlYWIxMzQxZTljYTk2ZmI1NDQ4YTlmMjlkMDI5MTFlLi5jOWJlNWJk M2IzMWQ3MWI3ODVjYTEzMDQxODczODViZTMyMGZiZjNhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDQgKzEsMjggQEAK LTIwMTAtMTEtMDEgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgorMjAxMC0xMS0wMiAg QWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgT25seSB0cmFjayByZXNv dXJjZSBpZGVudGlmaWVycyBpbiBEUlQgd2hlbiBkdW1wUmVzb3VyY2VMb2FkQ2FsbGJhY2tzCisg ICAgICAgIGlzIG9uCisKKyAgICAgICAgVGhpcyByZXZlcnRzIFdpbmRvd3MgdG8gb3VyIHByZS1y NzEwOTcgYmVoYXZpb3IuIFRoYXQgcGF0Y2ggbWFkZSB1cworICAgICAgICB0cmFjayBhbGwgcmVz b3VyY2UgaWRlbnRpZmllcnMsIGluY2x1ZGluZyB0aGUgbWFpbiByZXNvdXJjZSwgc28gdGhlCisg ICAgICAgIG1haW4gcmVzb3VyY2UncyBVUkwgc3RhcnRlZCBhcHBlYXJpbmcgaW4gdGVzdCBvdXRw dXQgaW5zdGVhZCBvZgorICAgICAgICAiPHVua25vd24+Ii4gQXJndWFibHkgaGF2aW5nIHRoZSBt YWluIHJlc291cmNlJ3MgVVJMIGlzIGJldHRlciwgYnV0IGFsbAorICAgICAgICBvdGhlciBwbGF0 Zm9ybXMgcHJpbnQgIjx1bmtub3duPiIgYW5kIHdlIHdhbnQgdG8gbWF0Y2guCisKKyAgICAgICAg Rml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvNDg4Mzc+IDxyZGFyOi8vcHJvYmxlbS84NjIwMzUx PiBSRUdSRVNTSU9OCisgICAgICAgIChyNzEwOTcpOiBNYW55IGh0dHAgdGVzdHMgZmFpbGluZyBv biBXaW5kb3dzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBEdW1wUmVuZGVyVHJlZS93aW4vUmVzb3VyY2VMb2FkRGVsZWdhdGUuY3BwOgorICAgICAg ICAoUmVzb3VyY2VMb2FkRGVsZWdhdGU6OmlkZW50aWZpZXJGb3JJbml0aWFsUmVxdWVzdCk6IERv bid0IGFkZCB0aGUKKyAgICAgICAgaWRlbnRpZmllciB0byB0aGUgVVJMIG1hcCBpZiB3ZSdyZSBu b3Qgc3VwcG9zZWQgdG8gZHVtcCByZXNvdXJjZSBsb2FkCisgICAgICAgIGNhbGxiYWNrcy4KKyAg ICAgICAgKFJlc291cmNlTG9hZERlbGVnYXRlOjpyZW1vdmVJZGVudGlmaWVyRm9yUmVxdWVzdCk6 IEFsd2F5cyByZW1vdmUgdGhlCisgICAgICAgIGlkZW50aWZpZXIgZnJvbSB0aGUgVVJMIG1hcCBl dmVuIGlmIHdlJ3JlIGFscmVhZHkgImRvbmUiLiBUaGVyZSdzIG5vCisgICAgICAgIHBvaW50IGlu IGtlZXBpbmcgb3V0LW9mLWRhdGUgaWRlbnRpZmllcnMgYXJvdW5kLgorCisyMDEwLTExLTAyICBB ZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBTa2lwIHdlYmtpdHB5Lmxh eW91dF90ZXN0cy5ydW5fd2Via2l0X3Rlc3RzX3VuaXR0ZXN0Lk1haW5UZXN0IG9uIEN5Z3dpbgog ICAgICAgICBQeXRob24gMi41LngKQEAgLTE0LDEwICszOCwyNSBAQAogICAgICAgICAqIFNjcmlw dHMvd2Via2l0cHkvdGVzdC9za2lwLnB5OiBBZGRlZC4KICAgICAgICAgKHNraXBfaWYpOiBJZiB0 aGUgcGFzc2VkLWluIGNvbmRpdGlvbiBpcyBmYWxzZSwgZmluZCBhbGwgdGhlIHRlc3RfKgogICAg ICAgICBtZXRob2RzIG9mIHRoZSBnaXZlbiBjbGFzcyBhbmQgcmVwbGFjZSB0aGVtIHdpdGggYSBm dW5jdGlvbiB0aGF0IGp1c3QKLSAgICAgICAgbG9ncyB0aGF0IHdlJ3JlIHNraXBwaW5nIHRoZXNl IHRlc3RzLgorICAgICAgICBsb2dzIHRoYXQgd2UncmUgc2tpcHBpbmcgdGhlc2UgdGVzdHMuIFRo aXMgaXMgbG9vc2VseSBiYXNlZCBvbiB0aGUKKyAgICAgICAgdW5pdHRlc3Quc2tpcF9pZiBkZWNv cmF0b3IgYWRkZWQgaW4gUHl0aG9uIDMuMS4KICAgICAgICAgKF9za2lwcGVkX21ldGhvZCk6IFJl dHVybnMgYSBmdW5jdGlvbiB0aGF0IGp1c3QgbG9ncyB0aGF0IHRoZSB0ZXN0cyBhcmUKICAgICAg ICAgYmVpbmcgc2tpcHBlZC4gVGhpcyBpcyB1c2VkIGluIHBsYWNlIG9mIHRoZSBhY3R1YWwgdGVz dF8qIGZ1bmN0aW9ucy4KIAorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdGVzdC9za2lwX3Vu aXR0ZXN0LnB5OiBBZGRlZC4KKyAgICAgICAgKFNraXBUZXN0LnNldFVwKTogQ3JlYXRlIGEgbG9n Z2VyIGZvciBvdXJzZWx2ZXMgYW5kIGdpdmUgaXQgYSBoYW5kbGVyCisgICAgICAgIHRoYXQgbG9n cyB0byBhIHByaXZhdGUgc3RyZWFtLgorICAgICAgICAoU2tpcFRlc3QudGVhckRvd24pOiBSZXNl dCB0aGUgbG9nZ2VyLgorICAgICAgICAoU2tpcFRlc3QuY3JlYXRlX2ZpeHR1cmVfY2xhc3MpOiBS ZXR1cm5zIGEgY2xhc3MgdGhhdCB3ZSB1c2UgdG8gdGVzdAorICAgICAgICBza2lwX2lmLiBJdCBo YXMgYSBzaW5nbGUgdGVzdF8qIG1ldGhvZCwgdGVzdF9mb28sIHRoYXQganVzdCBjYWxscworICAg ICAgICB0aHJvdWdoIHRvIGEgY2FsbGJhY2suCisgICAgICAgIChTa2lwVGVzdC5mb29fY2FsbGJh Y2spOiBSZWNvcmQgdGhhdCB0ZXN0X2ZvbyB3YXMgY2FsbGVkLgorICAgICAgICAoU2tpcFRlc3Qu dGVzdF9za2lwX2lmX2ZhbHNlKTogUGFzcyBza2lwX2lmIGEgRmFsc2UgY29uZGl0aW9uIGFuZCB0 ZXN0CisgICAgICAgIHRoYXQgdGVzdF9mb28gZG9lcyBnZXQgY2FsbGVkLgorICAgICAgICAoU2tp cFRlc3QudGVzdF9za2lwX2lmX3RydWUpOiBQYXNzIHNraXBfaWYgYSBUcnVlIGNvbmRpdGlvbiBh bmQgdGVzdAorICAgICAgICB0aGF0IHRlc3RfZm9vIGRvZXMgbm90IGdldCBjYWxsZWQgYW5kIHRo ZSBhcHByb3ByaWF0ZSBtZXNzYWdlIGdldHMKKyAgICAgICAgbG9nZ2VkLgorCiAyMDEwLTExLTAx ICBKZW5uIEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFkYW0gUm9iZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS93aW4vUmVzb3VyY2VMb2FkRGVsZWdhdGUuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvd2luL1Jlc291cmNlTG9hZERlbGVnYXRlLmNwcAppbmRleCBjZjE3OTg3YTU5NTliZWYzNjhj YmYyZjg1ZWFmYmY5NWEzN2ZmMjQzLi4wOWIwN2Q2OTBhMGYzN2JhNDNkMTllMjRkYjZkMTU5NjY5 MDllOWYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vUmVzb3Vy Y2VMb2FkRGVsZWdhdGUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9S ZXNvdXJjZUxvYWREZWxlZ2F0ZS5jcHAKQEAgLTIxNiw3ICsyMTYsNyBAQCBIUkVTVUxUIFNURE1F VEhPRENBTExUWVBFIFJlc291cmNlTG9hZERlbGVnYXRlOjppZGVudGlmaWVyRm9ySW5pdGlhbFJl cXVlc3QoCiAgICAgLyogW2luXSAqLyBJV2ViRGF0YVNvdXJjZSogZGF0YVNvdXJjZSwKICAgICAv KiBbaW5dICovIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllcikKIHsgCi0gICAgaWYgKCFkb25lKSB7 CisgICAgaWYgKCFkb25lICYmIGdMYXlvdXRUZXN0Q29udHJvbGxlci0+ZHVtcFJlc291cmNlTG9h ZENhbGxiYWNrcygpKSB7CiAgICAgICAgIEJTVFIgdXJsU3RyOwogICAgICAgICBpZiAoRkFJTEVE KHJlcXVlc3QtPlVSTCgmdXJsU3RyKSkpCiAgICAgICAgICAgICByZXR1cm4gRV9GQUlMOwpAQCAt MjMyLDEwICsyMzIsNyBAQCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIFJlc291cmNlTG9hZERl bGVnYXRlOjpyZW1vdmVJZGVudGlmaWVyRm9yUmVxdWVzdCgKICAgICAvKiBbaW5dICovIElXZWJW aWV3KiB3ZWJWaWV3LAogICAgIC8qIFtpbl0gKi8gdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyKQog ewotICAgIGlmICghZG9uZSkgewotICAgICAgICBBU1NFUlQodXJsTWFwKCkuY29udGFpbnMoaWRl bnRpZmllcikpOwotICAgICAgICB1cmxNYXAoKS5yZW1vdmUoaWRlbnRpZmllcik7Ci0gICAgfQor ICAgIHVybE1hcCgpLnJlbW92ZShpZGVudGlmaWVyKTsKIAogICAgIHJldHVybiBTX09LOwogfQo=