48835 2010-11-02 07:08:13 -0700 Unused class: JSFastMath with JSValue64 2010-11-03 01:22:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Trivial --- 1 loki webkit-unassigned barraclough commit-queue oliver oldest_to_newest 303344 0 loki 2010-11-02 07:08:13 -0700 There is an unused class in JSImmediate.h: JSFastMath. It can be safely removed. 303348 1 72661 loki 2010-11-02 07:11:26 -0700 Created attachment 72661 remove JSFastMath class 303356 2 72661 ggaren 2010-11-02 08:02:04 -0700 Comment on attachment 72661 remove JSFastMath class r=me 303722 3 72661 commit-queue 2010-11-02 15:28:44 -0700 Comment on attachment 72661 remove JSFastMath class Rejecting patch 72661 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: ..... fast/tokenizer ........................................ fast/transforms ....................... fast/url .................... fast/workers ............................................. fast/workers/storage .......................... fast/workers/storage/use-same-database-in-page-and-workers.html -> failed Exiting early after 1 failures. 16101 tests run. 502.96s total testing time 16100 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4930021 303906 4 72661 loki 2010-11-03 00:24:07 -0700 Comment on attachment 72661 remove JSFastMath class It should be a flaky test, works here. CQ, try again! 303925 5 72661 commit-queue 2010-11-03 01:22:19 -0700 Comment on attachment 72661 remove JSFastMath class Clearing flags on attachment: 72661 Committed r71220: <http://trac.webkit.org/changeset/71220> 303927 6 commit-queue 2010-11-03 01:22:24 -0700 All reviewed patches have been landed. Closing bug. 72661 2010-11-02 07:11:26 -0700 2010-11-03 01:22:19 -0700 remove JSFastMath class 0001-Unused-class-JSFastMath-with-JSValue64.patch text/plain 6017 loki RnJvbSBjMzIyZjE1Y2Y5ZWI1YjUzNGFjMmU1YjkxNWI3MjQ0NGRmNjI3ZGJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVHVlLCAyIE5vdiAyMDEwIDE1OjExOjE4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gVW51c2Vk IGNsYXNzOiBKU0Zhc3RNYXRoIHdpdGggSlNWYWx1ZTY0CgpTaWduZWQtb2ZmLWJ5OiBHYWJvciBM b2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgfCAgIDExICsrKysKIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNJbW1lZGlh dGUuaCB8ICAgOTQgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBj aGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCA5NCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXgg N2I5MzVkNC4uYWZkZWZmNyAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisr KyBiL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEwLTExLTAy ICBHYWJvciBMb2tpICA8bG9raUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFVudXNlZCBjbGFzczogSlNGYXN0TWF0aCB3aXRoIEpT VmFsdWU2NAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDg4MzUKKworICAgICAgICBSZW1vdmUgdW51c2VkIEpTRmFzdE1hdGggY2xhc3MuCisKKyAgICAg ICAgKiBydW50aW1lL0pTSW1tZWRpYXRlLmg6CisKIDIwMTAtMTAtMjkgIE9saXZlciBIdW50ICA8 b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3Vn aC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNJbW1lZGlhdGUuaCBiL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNJbW1lZGlhdGUuaAppbmRleCBmZmE0NDZlLi42OGJhNzVj IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTSW1tZWRpYXRlLmgKKysrIGIv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0ltbWVkaWF0ZS5oCkBAIC0zOSw3ICszOSw2IEBAIG5h bWVzcGFjZSBKU0MgewogCiAgICAgY2xhc3MgRXhlY1N0YXRlOwogICAgIGNsYXNzIEpTQ2VsbDsK LSAgICBjbGFzcyBKU0Zhc3RNYXRoOwogICAgIGNsYXNzIEpTR2xvYmFsRGF0YTsKICAgICBjbGFz cyBKU09iamVjdDsKICAgICBjbGFzcyBVU3RyaW5nOwpAQCAtMTMzLDcgKzEzMiw2IEBAIG5hbWVz cGFjZSBKU0MgewogICAgIHByaXZhdGU6CiAgICAgICAgIGZyaWVuZCBjbGFzcyBKSVQ7CiAgICAg ICAgIGZyaWVuZCBjbGFzcyBKU1ZhbHVlOwotICAgICAgICBmcmllbmQgY2xhc3MgSlNGYXN0TWF0 aDsKICAgICAgICAgZnJpZW5kIGNsYXNzIEpTSW50ZXJmYWNlSklUOwogICAgICAgICBmcmllbmQg Y2xhc3MgU3BlY2lhbGl6ZWRUaHVua0pJVDsKICAgICAgICAgZnJpZW5kIEpTVmFsdWUganNOdW1i ZXIoRXhlY1N0YXRlKiBleGVjLCBkb3VibGUgZCk7CkBAIC01NjMsOTggKzU2MSw2IEBAIG5hbWVz cGFjZSBKU0MgewogICAgICAgICByZXR1cm4gSlNJbW1lZGlhdGU6OmdldFRydW5jYXRlZFVJbnQz Mihhc1ZhbHVlKCkpOwogICAgIH0KIAotICAgIGNsYXNzIEpTRmFzdE1hdGggewotICAgIHB1Ymxp YzoKLSAgICAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBjYW5Eb0Zhc3RCaXR3aXNlT3Bl cmF0aW9ucyhKU1ZhbHVlIHYxLCBKU1ZhbHVlIHYyKQotICAgICAgICB7Ci0gICAgICAgICAgICBy ZXR1cm4gSlNJbW1lZGlhdGU6OmFyZUJvdGhJbW1lZGlhdGVJbnRlZ2VyTnVtYmVycyh2MSwgdjIp OwotICAgICAgICB9Ci0KLSAgICAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBlcXVh bChKU1ZhbHVlIHYxLCBKU1ZhbHVlIHYyKQotICAgICAgICB7Ci0gICAgICAgICAgICBBU1NFUlQo Y2FuRG9GYXN0Qml0d2lzZU9wZXJhdGlvbnModjEsIHYyKSk7Ci0gICAgICAgICAgICByZXR1cm4g anNCb29sZWFuKHYxID09IHYyKTsKLSAgICAgICAgfQotCi0gICAgICAgIHN0YXRpYyBBTFdBWVNf SU5MSU5FIEpTVmFsdWUgbm90RXF1YWwoSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2MikKLSAgICAgICAg ewotICAgICAgICAgICAgQVNTRVJUKGNhbkRvRmFzdEJpdHdpc2VPcGVyYXRpb25zKHYxLCB2Mikp OwotICAgICAgICAgICAgcmV0dXJuIGpzQm9vbGVhbih2MSAhPSB2Mik7Ci0gICAgICAgIH0KLQot ICAgICAgICBzdGF0aWMgQUxXQVlTX0lOTElORSBKU1ZhbHVlIGFuZEltbWVkaWF0ZU51bWJlcnMo SlNWYWx1ZSB2MSwgSlNWYWx1ZSB2MikKLSAgICAgICAgewotICAgICAgICAgICAgQVNTRVJUKGNh bkRvRmFzdEJpdHdpc2VPcGVyYXRpb25zKHYxLCB2MikpOwotICAgICAgICAgICAgcmV0dXJuIEpT SW1tZWRpYXRlOjptYWtlVmFsdWUoSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKHYxKSAmIEpTSW1tZWRp YXRlOjpyYXdWYWx1ZSh2MikpOwotICAgICAgICB9Ci0KLSAgICAgICAgc3RhdGljIEFMV0FZU19J TkxJTkUgSlNWYWx1ZSB4b3JJbW1lZGlhdGVOdW1iZXJzKEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIp Ci0gICAgICAgIHsKLSAgICAgICAgICAgIEFTU0VSVChjYW5Eb0Zhc3RCaXR3aXNlT3BlcmF0aW9u cyh2MSwgdjIpKTsKLSAgICAgICAgICAgIHJldHVybiBKU0ltbWVkaWF0ZTo6bWFrZVZhbHVlKChK U0ltbWVkaWF0ZTo6cmF3VmFsdWUodjEpIF4gSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKHYyKSkgfCBK U0ltbWVkaWF0ZTo6VGFnVHlwZU51bWJlcik7Ci0gICAgICAgIH0KLQotICAgICAgICBzdGF0aWMg QUxXQVlTX0lOTElORSBKU1ZhbHVlIG9ySW1tZWRpYXRlTnVtYmVycyhKU1ZhbHVlIHYxLCBKU1Zh bHVlIHYyKQotICAgICAgICB7Ci0gICAgICAgICAgICBBU1NFUlQoY2FuRG9GYXN0Qml0d2lzZU9w ZXJhdGlvbnModjEsIHYyKSk7Ci0gICAgICAgICAgICByZXR1cm4gSlNJbW1lZGlhdGU6Om1ha2VW YWx1ZShKU0ltbWVkaWF0ZTo6cmF3VmFsdWUodjEpIHwgSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKHYy KSk7Ci0gICAgICAgIH0KLQotICAgICAgICBzdGF0aWMgQUxXQVlTX0lOTElORSBib29sIGNhbkRv RmFzdFJzaGlmdChKU1ZhbHVlIHYxLCBKU1ZhbHVlIHYyKQotICAgICAgICB7Ci0gICAgICAgICAg ICByZXR1cm4gSlNJbW1lZGlhdGU6OmFyZUJvdGhJbW1lZGlhdGVJbnRlZ2VyTnVtYmVycyh2MSwg djIpOwotICAgICAgICB9Ci0KLSAgICAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBjYW5E b0Zhc3RVcnNoaWZ0KEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCi0gICAgICAgIHsKLSAgICAgICAg ICAgIHJldHVybiBKU0ltbWVkaWF0ZTo6YXJlQm90aEltbWVkaWF0ZUludGVnZXJOdW1iZXJzKHYx LCB2MikgJiYgIShKU0ltbWVkaWF0ZTo6cmF3VmFsdWUodjEpICYgSlNJbW1lZGlhdGU6OnNpZ25C aXQpOwotICAgICAgICB9Ci0KLSAgICAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBy aWdodFNoaWZ0SW1tZWRpYXRlTnVtYmVycyhKU1ZhbHVlIHZhbCwgSlNWYWx1ZSBzaGlmdCkKLSAg ICAgICAgewotICAgICAgICAgICAgQVNTRVJUKGNhbkRvRmFzdFJzaGlmdCh2YWwsIHNoaWZ0KSB8 fCBjYW5Eb0Zhc3RVcnNoaWZ0KHZhbCwgc2hpZnQpKTsKLSAgICAgICAgICAgIHJldHVybiBKU0lt bWVkaWF0ZTo6bWFrZVZhbHVlKHN0YXRpY19jYXN0PGludHB0cl90PihzdGF0aWNfY2FzdDx1aW50 MzJfdD4oc3RhdGljX2Nhc3Q8aW50MzJfdD4oSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKHZhbCkpID4+ ICgoSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKHNoaWZ0KSA+PiBKU0ltbWVkaWF0ZTo6SW50ZWdlclBh eWxvYWRTaGlmdCkgJiAweDFmKSkpIHwgSlNJbW1lZGlhdGU6OlRhZ1R5cGVOdW1iZXIpOwotICAg ICAgICB9Ci0KLSAgICAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgYm9vbCBjYW5Eb0Zhc3RBZGRp dGl2ZU9wZXJhdGlvbnMoSlNWYWx1ZSB2KQotICAgICAgICB7Ci0gICAgICAgICAgICAvLyBOdW1i ZXIgaXMgbm9uLW5lZ2F0aXZlIGFuZCBhbiBvcGVyYXRpb24gaW52b2x2aW5nIHR3byBvZiB0aGVz ZSBjYW4ndCBvdmVyZmxvdy4KLSAgICAgICAgICAgIC8vIENoZWNraW5nIGZvciBhbGxvd2VkIG5l Z2F0aXZlIG51bWJlcnMgdGFrZXMgbW9yZSB0aW1lIHRoYW4gaXQncyB3b3J0aCBvbiBTdW5TcGlk ZXIuCi0gICAgICAgICAgICByZXR1cm4gKEpTSW1tZWRpYXRlOjpyYXdWYWx1ZSh2KSAmIChKU0lt bWVkaWF0ZTo6VGFnVHlwZU51bWJlciArIChKU0ltbWVkaWF0ZTo6c2lnbkJpdCB8IChKU0ltbWVk aWF0ZTo6c2lnbkJpdCA+PiAxKSkpKSA9PSBKU0ltbWVkaWF0ZTo6VGFnVHlwZU51bWJlcjsKLSAg ICAgICAgfQotCi0gICAgICAgIHN0YXRpYyBBTFdBWVNfSU5MSU5FIGJvb2wgY2FuRG9GYXN0QWRk aXRpdmVPcGVyYXRpb25zKEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCi0gICAgICAgIHsKLSAgICAg ICAgICAgIC8vIE51bWJlciBpcyBub24tbmVnYXRpdmUgYW5kIGFuIG9wZXJhdGlvbiBpbnZvbHZp bmcgdHdvIG9mIHRoZXNlIGNhbid0IG92ZXJmbG93LgotICAgICAgICAgICAgLy8gQ2hlY2tpbmcg Zm9yIGFsbG93ZWQgbmVnYXRpdmUgbnVtYmVycyB0YWtlcyBtb3JlIHRpbWUgdGhhbiBpdCdzIHdv cnRoIG9uIFN1blNwaWRlci4KLSAgICAgICAgICAgIHJldHVybiBjYW5Eb0Zhc3RBZGRpdGl2ZU9w ZXJhdGlvbnModjEpICYmIGNhbkRvRmFzdEFkZGl0aXZlT3BlcmF0aW9ucyh2Mik7Ci0gICAgICAg IH0KLQotICAgICAgICBzdGF0aWMgQUxXQVlTX0lOTElORSBKU1ZhbHVlIGFkZEltbWVkaWF0ZU51 bWJlcnMoSlNWYWx1ZSB2MSwgSlNWYWx1ZSB2MikKLSAgICAgICAgewotICAgICAgICAgICAgQVNT RVJUKGNhbkRvRmFzdEFkZGl0aXZlT3BlcmF0aW9ucyh2MSwgdjIpKTsKLSAgICAgICAgICAgIHJl dHVybiBKU0ltbWVkaWF0ZTo6bWFrZVZhbHVlKEpTSW1tZWRpYXRlOjpyYXdWYWx1ZSh2MSkgKyBK U0ltbWVkaWF0ZTo6cmF3VmFsdWUodjIpIC0gSlNJbW1lZGlhdGU6OlRhZ1R5cGVOdW1iZXIpOwot ICAgICAgICB9Ci0KLSAgICAgICAgc3RhdGljIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBzdWJJbW1l ZGlhdGVOdW1iZXJzKEpTVmFsdWUgdjEsIEpTVmFsdWUgdjIpCi0gICAgICAgIHsKLSAgICAgICAg ICAgIEFTU0VSVChjYW5Eb0Zhc3RBZGRpdGl2ZU9wZXJhdGlvbnModjEsIHYyKSk7Ci0gICAgICAg ICAgICByZXR1cm4gSlNJbW1lZGlhdGU6Om1ha2VWYWx1ZShKU0ltbWVkaWF0ZTo6cmF3VmFsdWUo djEpIC0gSlNJbW1lZGlhdGU6OnJhd1ZhbHVlKHYyKSArIEpTSW1tZWRpYXRlOjpUYWdUeXBlTnVt YmVyKTsKLSAgICAgICAgfQotCi0gICAgICAgIHN0YXRpYyBBTFdBWVNfSU5MSU5FIEpTVmFsdWUg aW5jSW1tZWRpYXRlTnVtYmVyKEpTVmFsdWUgdikKLSAgICAgICAgewotICAgICAgICAgICAgQVNT RVJUKGNhbkRvRmFzdEFkZGl0aXZlT3BlcmF0aW9ucyh2KSk7Ci0gICAgICAgICAgICByZXR1cm4g SlNJbW1lZGlhdGU6Om1ha2VWYWx1ZShKU0ltbWVkaWF0ZTo6cmF3VmFsdWUodikgKyAoMSA8PCBK U0ltbWVkaWF0ZTo6SW50ZWdlclBheWxvYWRTaGlmdCkpOwotICAgICAgICB9Ci0KLSAgICAgICAg c3RhdGljIEFMV0FZU19JTkxJTkUgSlNWYWx1ZSBkZWNJbW1lZGlhdGVOdW1iZXIoSlNWYWx1ZSB2 KQotICAgICAgICB7Ci0gICAgICAgICAgICBBU1NFUlQoY2FuRG9GYXN0QWRkaXRpdmVPcGVyYXRp b25zKHYpKTsKLSAgICAgICAgICAgIHJldHVybiBKU0ltbWVkaWF0ZTo6bWFrZVZhbHVlKEpTSW1t ZWRpYXRlOjpyYXdWYWx1ZSh2KSAtICgxIDw8IEpTSW1tZWRpYXRlOjpJbnRlZ2VyUGF5bG9hZFNo aWZ0KSk7Ci0gICAgICAgIH0KLSAgICB9OwotCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlm IC8vIFVTRShKU1ZBTFVFNjQpCi0tIAoxLjcuMC40Cgo=