48799 2010-11-01 16:18:37 -0700 Crash when dragging and dropping in a document with an invalid XHTML header 2011-03-15 14:30:00 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P1 Normal --- 1 dcheng webkit-unassigned abarth adele ap ddkilzer morrita rniwa tony oldest_to_newest 303037 0 dcheng 2010-11-01 16:18:37 -0700 http://crbug.com/61182. Open the SVG, then try to drag and drop the XHTML file into the window displaying the SVG. 303048 1 72592 dcheng 2010-11-01 16:25:55 -0700 Created attachment 72592 Patch 303067 2 72592 tony 2010-11-01 16:40:18 -0700 Comment on attachment 72592 Patch Can you write a layout test for this? Maybe you can put the drag target in an iframe and drag link to the svg into the iframe? 303111 3 72592 dcheng 2010-11-01 17:27:09 -0700 Comment on attachment 72592 Patch R- while I work on layout test. 303231 4 ap 2010-11-01 23:09:36 -0700 See also: bug 48791. 305613 5 dcheng 2010-11-05 16:09:36 -0700 Adding morrita to see what he thinks of the fix. Several things I noticed when trying to write a layout test for this: findEventTargetFrom() is being called with an empty selection. In Safari/Chrome, m_frame->document()->body() seems to be returning NULL which causes findEventTargetFrom() to return NULL. However, in DRT, m_frame->document()->body() is *not* NULL. I do not know why there is a difference, but as a result, I am unable to write a layout test to automatically trigger this bug. I can add a manual test to this bug if you want, but I don't think I understand enough to figure out the behavior difference between DRT and an actual browser. Maybe the DRT doesn't have special handling for invalid XML parses? 306433 6 tony 2010-11-08 16:03:20 -0800 I did some testing, it looks like the svg file isn't rendered as svg, it's just parsed as XML. So you can repro this bug by loading a random XML document without a body tag and then dragging anything into the XML document. I'm not exactly sure why this doesn't repro in DRT. It looks like DRT always loads random XML as an HTML document. Maybe abarth has some insight into how we decide if something is an XML document vs an HTML document. Here's an example: http://plexode.com/eval3/#ht=%3Ciframe%20src%3D%22data%3Atext%2Fxml%2C%3Cfoo%3E%3C%2Ffoo%3E%22%3E%3C%2Fiframe%3E&ohh=1&ohj=1&jt=&ojh=1&ojj=1&ms=100&oth=0&otj=0&cex=1 If you drag anything into the iframe (e.g., a bookmark from the bookmark toolbar), we crash trying to reference body. The check seems OK, but it seems better if we can verify that we have an HTML document. 316721 7 rniwa 2010-12-03 01:08:53 -0800 Crash is P1. 332751 8 adele 2011-01-11 15:52:13 -0800 *** Bug 48791 has been marked as a duplicate of this bug. *** 364259 9 adele 2011-03-08 17:43:18 -0800 Any update on this? Daniel, are you still working on it? 366868 10 85652 morrita 2011-03-14 00:03:11 -0700 Created attachment 85652 Patch 366869 11 morrita 2011-03-14 00:05:32 -0700 Hi Adele, Daniel, I'm sorry for passing over the discussion. I attached a fix and test that reproduces the crash. Reviews are welcome. 367042 12 85652 tony 2011-03-14 10:18:25 -0700 Comment on attachment 85652 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85652&action=review > LayoutTests/editing/pasteboard/drop-file-svg.html:23 > +<p>PASS unless crash</p> Nit: Please make this a full sentence. Also, please mention that this test requires DRT. > Source/WebCore/page/DragController.cpp:398 > + if (!m_page->dragCaretController()->isNone()) { > + if (!dispatchTextInputEventFor(innerFrame, dragData)) Nit: Can we just combine these into 1 if statement using && ? 367412 13 morrita 2011-03-14 18:22:51 -0700 (In reply to comment #12) > (From update of attachment 85652 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85652&action=review > > > LayoutTests/editing/pasteboard/drop-file-svg.html:23 > > +<p>PASS unless crash</p> > > Nit: Please make this a full sentence. Also, please mention that this test requires DRT. > > > Source/WebCore/page/DragController.cpp:398 > > + if (!m_page->dragCaretController()->isNone()) { > > + if (!dispatchTextInputEventFor(innerFrame, dragData)) > > Nit: Can we just combine these into 1 if statement using && ? Hi Tony, thank you for your quick review! I'll fix these before landing. 367461 14 morrita 2011-03-14 19:39:09 -0700 Committed r81101: <http://trac.webkit.org/changeset/81101> 367506 15 rniwa 2011-03-14 22:12:56 -0700 It seems like the test has been failing on Windows 7 since it was added: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r81105%20(10397)/editing/pasteboard/drop-file-svg-pretty-diff.html 367945 16 ddkilzer 2011-03-15 14:30:00 -0700 <rdar://problem/8616986> 72592 2010-11-01 16:25:55 -0700 2011-03-14 00:03:05 -0700 Patch bug-48799-20101101162553.patch text/plain 1399 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzhiMmYzZDI3OTFlZjc0MWVjOTMxZjQzY2IwYTg5OTg4YzQ0ZDhmNy4uNzg5MDQzOTQzZmNmYTlj NDg3ZTZhZTMyZjFiMjFiZmU4Yjg2NDZkNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMS0wMSAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDcmFzaCB3aGVuIGRyYWdnaW5nIGFuZCBkcm9wcGlu ZyBpbiBhIGRvY3VtZW50IHdpdGggYW4gaW52YWxpZCBYSFRNTCBoZWFkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4Nzk5CisKKyAgICAgICAgKiBw YWdlL0RyYWdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVy OjpkaXNwYXRjaFRleHRJbnB1dEV2ZW50Rm9yKTogQWRkIG51bGwgY2hlY2suCisKIDIwMTAtMTEt MDEgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIu Y3BwIGIvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAppbmRleCAyZTdkMjQxNzYzYjAx NTVjOTUzMGNmNDUzZGZjYjFmMWZkOTM2ZDkwLi5jNmY0OGFhOTg0MDI5OWQxZmRlMDc3YjAxOWIy YTE0ZTAzZjljZmE4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3Bw CisrKyBiL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKQEAgLTM2OSw2ICszNjksOCBA QCBib29sIERyYWdDb250cm9sbGVyOjpkaXNwYXRjaFRleHRJbnB1dEV2ZW50Rm9yKEZyYW1lKiBp bm5lckZyYW1lLCBEcmFnRGF0YSogZHJhZwogICAgIFZpc2libGVTZWxlY3Rpb24gZHJhZ0NhcmV0 KG1fcGFnZS0+ZHJhZ0NhcmV0Q29udHJvbGxlcigpLT5zZWxlY3Rpb24oKSk7CiAgICAgU3RyaW5n IHRleHQgPSBkcmFnQ2FyZXQuaXNDb250ZW50UmljaGx5RWRpdGFibGUoKSA/ICIiIDogZHJhZ0Rh dGEtPmFzUGxhaW5UZXh0KCk7CiAgICAgTm9kZSogdGFyZ2V0ID0gaW5uZXJGcmFtZS0+ZWRpdG9y KCktPmZpbmRFdmVudFRhcmdldEZyb20oZHJhZ0NhcmV0KTsKKyAgICBpZiAoIXRhcmdldCkKKyAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAgcmV0dXJu IHRhcmdldC0+ZGlzcGF0Y2hFdmVudChUZXh0RXZlbnQ6OmNyZWF0ZUZvckRyb3AoaW5uZXJGcmFt ZS0+ZG9tV2luZG93KCksIHRleHQpLCBlYyk7CiB9Cg== 85652 2011-03-14 00:03:11 -0700 2011-03-14 10:18:25 -0700 Patch bug-48799-20110314160308.patch text/plain 4372 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogODA5OTIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBhYjI2YzlmNzU2Zjc2ZGU1YzdlZDE5 YTY0ODFmNjJmNjEyOTA0Mjg2Li5hZTY2MTE0N2RhNjhmZjVjODM1ODc1YjJkM2YzNmExN2VhZjM3 ZjgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDMtMTMgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ3Jhc2ggd2hlbiBkcmFnZ2luZyBhbmQgZHJvcHBpbmcgaW4gYSBkb2N1bWVu dCB3aXRoIGFuIGludmFsaWQgWEhUTUwgaGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODc5OQorICAgICAgICAKKyAgICAgICAgKiBlZGl0aW5n L3Bhc3RlYm9hcmQvZHJvcC1maWxlLXN2Zy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5n L3Bhc3RlYm9hcmQvcmVzb3VyY2VzL2Ryb3AtZmlsZS1zdmcuc3ZnOiBBZGRlZC4KKwogMjAxMS0w My0xMyAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIHNv bWUgdGVzdCBmYWlsdXJlcyB0aGF0IEkgbmVlZCB0byBpbnZlc3RpZ2F0ZSBmdXJ0aGVyLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3AtZmlsZS1zdmcuaHRt bCBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9kcm9wLWZpbGUtc3ZnLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uN2Y1NWRjYjFlNTUzNjZkOGJhMzBlOGQ3ZWQ2NWE5ZWFkMjNhNWRhZAotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9kcm9wLWZpbGUtc3Zn Lmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CisKK2Z1bmN0 aW9uIG1vdmVNb3VzZVRvQ2VudGVyT2ZFbGVtZW50KGVsZW1lbnQpCit7CisgICAgdmFyIGNlbnRl clggPSBlbGVtZW50Lm9mZnNldExlZnQgKyBlbGVtZW50Lm9mZnNldFdpZHRoIC8gMjsKKyAgICB2 YXIgY2VudGVyWSA9IGVsZW1lbnQub2Zmc2V0VG9wICsgZWxlbWVudC5vZmZzZXRIZWlnaHQgLyAy OworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGNlbnRlclgsIGNlbnRlclkpOworfQorCitm dW5jdGlvbiB0ZXN0KCkKK3sKKyAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQor ICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgZXZlbnRTZW5k ZXIuYmVnaW5EcmFnV2l0aEZpbGVzKFsiZmFrZWZpbGUiXSk7CisgICAgbW92ZU1vdXNlVG9DZW50 ZXJPZkVsZW1lbnQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRhcmdldCIpKTsKKyAgICBldmVu dFNlbmRlci5tb3VzZVVwKCk7Cit9CisKKzwvc2NyaXB0PgorPC9oZWFkPgorPHA+UEFTUyB1bmxl c3MgY3Jhc2g8L3A+Cis8Ym9keSBvbmxvYWQ9InRlc3QoKSI+Cis8aWZyYW1lIGlkPSJ0YXJnZXQi IHNyYz0icmVzb3VyY2VzL2Ryb3AtZmlsZS1zdmcuc3ZnIj48L2lmcmFtZT4KKzwvYm9keT4KKzwv aHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9yZXNvdXJj ZXMvZHJvcC1maWxlLXN2Zy5zdmcgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvcmVz b3VyY2VzL2Ryb3AtZmlsZS1zdmcuc3ZnCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM4NzYwNGM4ZmM4YjkxOWE3YzJh MmI0NTk2ZDI5YjkwMzcyNGZjNmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0 aW5nL3Bhc3RlYm9hcmQvcmVzb3VyY2VzL2Ryb3AtZmlsZS1zdmcuc3ZnCkBAIC0wLDAgKzEsMyBA QAorPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgorICA8cmVjdCB4PSIx MCIgeT0iMTAiIHdpZHRoPSIxMDAiIGhlaWdodD0iMTUwIiBmaWxsPSJncmF5Ii8+Cis8L3N2Zz4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiM2NiNzIzZWVlMDRlODU2YmFmODA5MmIwYTcxZWFlNTMzMWY4ZTNlLi5k MjMyNzlhOTY2M2I5OGMzMjczNDRiNmM3YTRhODdlM2I4MGYxMDJjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTEtMDMtMTMgIE1PUklUQSBIYWppbWUgIDxtb3JyaXRhQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3Jh c2ggd2hlbiBkcmFnZ2luZyBhbmQgZHJvcHBpbmcgaW4gYSBkb2N1bWVudCB3aXRoIGFuIGludmFs aWQgWEhUTUwgaGVhZGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00ODc5OQorCisgICAgICAgIERyYWdDb250cm9sbGVyIHRyaWVkIHRvIGRpc3BhdGNo IHRleHRJbnB1dCBldmVudCBldmVuIHdoZW4gdGhlCisgICAgICAgIGRyYWcgZGVzdGluYXRpb24g aXMgbm90IHRoZSBlZGl0YWJsZSBhcmVhLgorICAgICAgICBUaGlzIGNoYW5nZSBza2lwcyB0aGUg ZXZlbnQgZGlzcGF0Y2hpbmcgb24gdGhhdCBjYXNlLgorICAgICAgICAKKyAgICAgICAgVGVzdDog ZWRpdGluZy9wYXN0ZWJvYXJkL2Ryb3AtZmlsZS1zdmcuaHRtbAorCisgICAgICAgICogcGFnZS9E cmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6ZGlz cGF0Y2hUZXh0SW5wdXRFdmVudEZvcik6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxl cjo6Y29uY2x1ZGVFZGl0RHJhZyk6CisKIDIwMTEtMDMtMTMgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBGaXggd2luZG93cyBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9E cmFnQ29udHJvbGxlci5jcHAKaW5kZXggNmE0YmI3MDc3M2ViMjhhNDExN2UxODMyMTA0YzkxODAx OGIyZjdmNC4uOGM0ZmM4MTc0YTFlYTZiNzc0ZmFlZjU4MzI5ZWY0NjVjYTA1NDRlZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKQEAgLTM3MSw2ICszNzEsNyBAQCBzdGF0 aWMgYm9vbCBzZXRTZWxlY3Rpb25Ub0RyYWdDYXJldChGcmFtZSogZnJhbWUsIFZpc2libGVTZWxl Y3Rpb24mIGRyYWdDYXJldCwgUgogCiBib29sIERyYWdDb250cm9sbGVyOjpkaXNwYXRjaFRleHRJ bnB1dEV2ZW50Rm9yKEZyYW1lKiBpbm5lckZyYW1lLCBEcmFnRGF0YSogZHJhZ0RhdGEpCiB7Cisg ICAgQVNTRVJUKCFtX3BhZ2UtPmRyYWdDYXJldENvbnRyb2xsZXIoKS0+aXNOb25lKCkpOwogICAg IFZpc2libGVTZWxlY3Rpb24gZHJhZ0NhcmV0KG1fcGFnZS0+ZHJhZ0NhcmV0Q29udHJvbGxlcigp LT5zZWxlY3Rpb24oKSk7CiAgICAgU3RyaW5nIHRleHQgPSBkcmFnQ2FyZXQuaXNDb250ZW50Umlj aGx5RWRpdGFibGUoKSA/ICIiIDogZHJhZ0RhdGEtPmFzUGxhaW5UZXh0KGlubmVyRnJhbWUpOwog ICAgIE5vZGUqIHRhcmdldCA9IGlubmVyRnJhbWUtPmVkaXRvcigpLT5maW5kRXZlbnRUYXJnZXRG cm9tKGRyYWdDYXJldCk7CkBAIC0zOTMsOCArMzk0LDEwIEBAIGJvb2wgRHJhZ0NvbnRyb2xsZXI6 OmNvbmNsdWRlRWRpdERyYWcoRHJhZ0RhdGEqIGRyYWdEYXRhKQogICAgIEZyYW1lKiBpbm5lckZy YW1lID0gZWxlbWVudC0+b3duZXJEb2N1bWVudCgpLT5mcmFtZSgpOwogICAgIEFTU0VSVChpbm5l ckZyYW1lKTsKIAotICAgIGlmICghZGlzcGF0Y2hUZXh0SW5wdXRFdmVudEZvcihpbm5lckZyYW1l LCBkcmFnRGF0YSkpCi0gICAgICAgIHJldHVybiB0cnVlOworICAgIGlmICghbV9wYWdlLT5kcmFn Q2FyZXRDb250cm9sbGVyKCktPmlzTm9uZSgpKSB7CisgICAgICAgIGlmICghZGlzcGF0Y2hUZXh0 SW5wdXRFdmVudEZvcihpbm5lckZyYW1lLCBkcmFnRGF0YSkpCisgICAgICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICB9CiAKICAgICBpZiAoZHJhZ0RhdGEtPmNvbnRhaW5zQ29sb3IoKSkgewogICAg ICAgICBDb2xvciBjb2xvciA9IGRyYWdEYXRhLT5hc0NvbG9yKCk7Cg==