48796 2010-11-01 16:08:30 -0700 Add ArgumentCoder specialization for WTF::CString 2010-11-01 17:59:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca abarth eric webkit.review.bot oldest_to_newest 303028 0 andersca 2010-11-01 16:08:30 -0700 Add ArgumentCoder specialization for WTF::CString 303029 1 72586 andersca 2010-11-01 16:09:01 -0700 Created attachment 72586 Patch 303033 2 andersca 2010-11-01 16:15:28 -0700 Committed r71069: <http://trac.webkit.org/changeset/71069> 303125 3 webkit.review.bot 2010-11-01 17:59:53 -0700 http://trac.webkit.org/changeset/71075 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/websocket/tests/alert-in-event-handler.html http/tests/websocket/tests/bad-handshake-crash.html http/tests/websocket/tests/bufferedAmount-after-close.html http/tests/websocket/tests/close-on-navigate-new-location.html http/tests/websocket/tests/close-on-unload-and-force-gc.html http/tests/websocket/tests/close-on-unload-reference-in-parent.html http/tests/websocket/tests/close-on-unload.html http/tests/websocket/tests/cross-origin.html http/tests/websocket/tests/error-detect.html http/tests/websocket/tests/frame-length-longer-than-buffer.html http/tests/websocket/tests/frame-length-overflow.html http/tests/websocket/tests/frame-length-skip.html http/tests/websocket/tests/frame-lengths.html http/tests/websocket/tests/handshake-challenge-randomness.html http/tests/websocket/tests/handshake-error.html http/tests/websocket/tests/handshake-fail-by-cross-origin.html http/tests/websocket/tests/handshake-fail-by-no-cr.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html http/tests/websocket/tests/httponly-cookie.pl http/tests/websocket/tests/long-invalid-header.html 72586 2010-11-01 16:09:01 -0700 2010-11-01 16:10:24 -0700 Patch bug-48796-20101101160900.patch text/plain 3561 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MTE0YmIyZGZhZjk5MjM4MTViN2IxNzU2ZDg1NTYzZGQyNzcyZTI1ZC4uYWIwYTRjYTViMjg2NDdl ZWI5ZTc2ZWNiYzQxNmY2NGNjOTJlNmU3ZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNCBAQAogMjAxMC0xMS0wMSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBBcmd1bWVudENvZGVyIHNwZWNpYWxpemF0 aW9uIGZvciBXVEY6OkNTdHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ4Nzk2CisKKyAgICAgICAgKiBQbGF0Zm9ybS9Db3JlSVBDL0FyZ3VtZW50 Q29kZXJzLmg6CisKKzIwMTAtMTEtMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKwogICAgICAgICBGaXggYnVpbGQuCiAKICAgICAgICAgKiBXZWJLaXQyLnhjb2RlcHJv ai9wcm9qZWN0LnBieHByb2o6CmRpZmYgLS1naXQgYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMv QXJndW1lbnRDb2RlcnMuaCBiL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudENvZGVy cy5oCmluZGV4IDIwNjU5ODgwZjlkY2M3NWRhNjNiNjM1YzA4ZGU4MWUwMDhlZDc4ZmEuLjFjYzFh N2RmODg1ODUzYmNiN2RmNWYzMTExMTc2N2Q0NGEwODQ3MmYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIv UGxhdGZvcm0vQ29yZUlQQy9Bcmd1bWVudENvZGVycy5oCisrKyBiL1dlYktpdDIvUGxhdGZvcm0v Q29yZUlQQy9Bcmd1bWVudENvZGVycy5oCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSA8d3Rm L1R5cGVUcmFpdHMuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAjaW5jbHVkZSA8d3RmL3Rl eHQvQXRvbWljU3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogI2luY2x1 ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgQ29yZUlQQyB7CkBAIC0xOTQs NiArMTk1LDQ4IEBAIHRlbXBsYXRlPHR5cGVuYW1lIEtleUFyZywgdHlwZW5hbWUgTWFwcGVkQXJn LCB0eXBlbmFtZSBIYXNoQXJnLCB0eXBlbmFtZSBLZXlUcmFpCiAgICAgfQogfTsKIAordGVtcGxh dGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxDU3RyaW5nPiB7CisgICAgc3RhdGljIHZvaWQgZW5j b2RlKEFyZ3VtZW50RW5jb2RlciogZW5jb2RlciwgY29uc3QgQ1N0cmluZyYgc3RyaW5nKQorICAg IHsKKyAgICAgICAgLy8gU3BlY2lhbCBjYXNlIHRoZSBudWxsIHN0cmluZy4KKyAgICAgICAgaWYg KHN0cmluZy5pc051bGwoKSkgeworICAgICAgICAgICAgZW5jb2Rlci0+ZW5jb2RlVUludDMyKHN0 ZDo6bnVtZXJpY19saW1pdHM8dWludDMyX3Q+OjptYXgoKSk7CisgICAgICAgICAgICByZXR1cm47 CisgICAgICAgIH0KKworICAgICAgICB1aW50MzJfdCBsZW5ndGggPSBzdHJpbmcubGVuZ3RoKCk7 CisgICAgICAgIGVuY29kZXItPmVuY29kZShsZW5ndGgpOworICAgICAgICBlbmNvZGVyLT5lbmNv ZGVCeXRlcyhyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPihzdHJpbmcuZGF0YSgpKSwg bGVuZ3RoKTsKKyAgICB9CisKKyAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVy KiBkZWNvZGVyLCBDU3RyaW5nJiByZXN1bHQpCisgICAgeworICAgICAgICB1aW50MzJfdCBsZW5n dGg7CisgICAgICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKGxlbmd0aCkpCisgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisKKyAgICAgICAgaWYgKGxlbmd0aCA9PSBzdGQ6Om51bWVyaWNfbGltaXRz PHVpbnQzMl90Pjo6bWF4KCkpIHsKKyAgICAgICAgICAgIC8vIFRoaXMgaXMgdGhlIG51bGwgc3Ry aW5nLgorICAgICAgICAgICAgcmVzdWx0ID0gQ1N0cmluZygpOworICAgICAgICAgICAgcmV0dXJu IHRydWU7CisgICAgICAgIH0KKworICAgICAgICAvLyBCZWZvcmUgYWxsb2NhdGluZyB0aGUgc3Ry aW5nLCBtYWtlIHN1cmUgdGhhdCB0aGUgZGVjb2RlciBidWZmZXIgaXMgYmlnIGVub3VnaC4KKyAg ICAgICAgaWYgKCFkZWNvZGVyLT5idWZmZXJJc0xhcmdlRW5vdWdoVG9Db250YWluPGNoYXI+KGxl bmd0aCkpIHsKKyAgICAgICAgICAgIGRlY29kZXItPm1hcmtJbnZhbGlkKCk7CisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KKworICAgICAgICBjaGFyKiBidWZmZXI7CisgICAg ICAgIENTdHJpbmcgc3RyaW5nID0gQ1N0cmluZzo6bmV3VW5pbml0aWFsaXplZChsZW5ndGgsIGJ1 ZmZlcik7CisgICAgICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlQnl0ZXMocmVpbnRlcnByZXRfY2Fz dDx1aW50OF90Kj4oYnVmZmVyKSwgbGVuZ3RoKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsK KworICAgICAgICByZXN1bHQgPSBzdHJpbmc7CisgICAgICAgIHJldHVybiB0cnVlOworICAgIH0K K307CisKIHRlbXBsYXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8U3RyaW5nPiB7CiAgICAgc3Rh dGljIHZvaWQgZW5jb2RlKEFyZ3VtZW50RW5jb2RlciogZW5jb2RlciwgY29uc3QgU3RyaW5nJiBz dHJpbmcpCiAgICAgewpAQCAtMjA4LDcgKzI1MSw3IEBAIHRlbXBsYXRlPD4gc3RydWN0IEFyZ3Vt ZW50Q29kZXI8U3RyaW5nPiB7CiAgICAgICAgIGVuY29kZXItPmVuY29kZUJ5dGVzKHJlaW50ZXJw cmV0X2Nhc3Q8Y29uc3QgdWludDhfdCo+KHN0cmluZy5jaGFyYWN0ZXJzKCkpLCBsZW5ndGggKiBz aXplb2YoVUNoYXIpKTsKICAgICB9CiAgICAgCi0gICAgc3RhdGljIGJvb2wgZGVjb2RlKEFyZ3Vt ZW50RGVjb2RlciogZGVjb2RlciwgU3RyaW5nJiBzKQorICAgIHN0YXRpYyBib29sIGRlY29kZShB cmd1bWVudERlY29kZXIqIGRlY29kZXIsIFN0cmluZyYgcmVzdWx0KQogICAgIHsKICAgICAgICAg dWludDMyX3QgbGVuZ3RoOwogICAgICAgICBpZiAoIWRlY29kZXItPmRlY29kZShsZW5ndGgpKQpA QCAtMjE2LDcgKzI1OSw3IEBAIHRlbXBsYXRlPD4gc3RydWN0IEFyZ3VtZW50Q29kZXI8U3RyaW5n PiB7CiAKICAgICAgICAgaWYgKGxlbmd0aCA9PSBzdGQ6Om51bWVyaWNfbGltaXRzPHVpbnQzMl90 Pjo6bWF4KCkpIHsKICAgICAgICAgICAgIC8vIFRoaXMgaXMgdGhlIG51bGwgc3RyaW5nLgotICAg ICAgICAgICAgcyA9IFN0cmluZygpOworICAgICAgICAgICAgcmVzdWx0ID0gU3RyaW5nKCk7CiAg ICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogCkBAIC0yMzEsNyArMjc0LDcgQEAg dGVtcGxhdGU8PiBzdHJ1Y3QgQXJndW1lbnRDb2RlcjxTdHJpbmc+IHsKICAgICAgICAgaWYgKCFk ZWNvZGVyLT5kZWNvZGVCeXRlcyhyZWludGVycHJldF9jYXN0PHVpbnQ4X3QqPihidWZmZXIpLCBs ZW5ndGggKiBzaXplb2YoVUNoYXIpKSkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAg ICAgCi0gICAgICAgIHMgPSBzdHJpbmc7CisgICAgICAgIHJlc3VsdCA9IHN0cmluZzsKICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgfQogfTsK