48794 2010-11-01 15:56:02 -0700 new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests 2011-01-18 21:57:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kalman kalman commit-queue noel.gordon ojan oldest_to_newest 303008 0 kalman 2010-11-01 15:56:02 -0700 new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests 303009 1 72579 kalman 2010-11-01 15:57:42 -0700 Created attachment 72579 Patch 303030 2 72579 ojan 2010-11-01 16:11:29 -0700 Comment on attachment 72579 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72579&action=review > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:293 > + test_dir = 'LayoutTests/' As discussed in person, lets make this a constant and use os.sep. 303034 3 72587 kalman 2010-11-01 16:15:59 -0700 Created attachment 72587 Patch 303620 4 commit-queue 2010-11-02 13:41:53 -0700 The commit-queue encountered the following flaky tests while processing attachment 72587: webarchive/test-link-rel-icon.html Please file bugs against the tests. These tests were authored by ddkilzer@webkit.org. The commit-queue is continuing to process your patch. 303621 5 72587 commit-queue 2010-11-02 13:42:58 -0700 Comment on attachment 72587 Patch Clearing flags on attachment: 72587 Committed r71160: <http://trac.webkit.org/changeset/71160> 303622 6 commit-queue 2010-11-02 13:43:02 -0700 All reviewed patches have been landed. Closing bug. 72579 2010-11-01 15:57:42 -0700 2010-11-01 16:15:53 -0700 Patch bug-48794-20101101155740.patch text/plain 1899 kalman ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMTFkNTg1MTI4NGUyZjQ4ZTk0YWFjYjg3OTdhMmFkMjBjN2Q0MmEyLi5iYTBmMTdm OWMyZDdmOTI0YmYwNjlkNGFjZGVmYmQ0MWYyYzNlZjc0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTEtMDEgIEJlbmphbWluIEthbG1hbiAgPGthbG1hbkBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0 LXRlc3RzIGRvZXNuJ3Qgc3RyaXAgIkxheW91dFRlc3RzLyIgZnJvbSBwcmVmaXgsIHVubGlrZSBv bGQtcnVuLXdlYmtpdC10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDg3OTQKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3J1bl93ZWJraXRfdGVzdHMucHk6IFN0cmlwIHRoZSAiTGF5b3V0VGVzdHMvIiBwcmVmaXgg ZnJvbSB0ZXN0IGFyZ3VtZW50IHBhdGhzLgorCiAyMDEwLTExLTAxICBTw7hyZW4gR2plc3NlICA8 c2dqZXNzZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu Zy4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDcwNDE4MGM2MGJhMWNjNzkwYTYyZWUx NWE1NzRmOGQ2YTFhMDdmYTIuLmY4ZTM3NWY3ZWYwMWUyOWE5MWZhZTUwMjJhM2I4ZmVlOWJmNzBl YjUgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtMjgzLDEyICsyODMsMTggQEAgY2xh c3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICBsYXN0X3VuZXhwZWN0ZWRfcmVzdWx0czogbGlzdCBv ZiB1bmV4cGVjdGVkIHJlc3VsdHMgdG8gcmV0ZXN0LCBpZiBhbnkKIAogICAgICAgICAiIiIKLSAg ICAgICAgcGF0aHMgPSBbYXJnIGZvciBhcmcgaW4gYXJncyBpZiBhcmcgYW5kIGFyZyAhPSAnJ10K KyAgICAgICAgcGF0aHMgPSBbc2VsZi5fc3RyaXBfdGVzdF9kaXJfcHJlZml4KGFyZykgZm9yIGFy ZyBpbiBhcmdzIGlmIGFyZyBhbmQgYXJnICE9ICcnXQogICAgICAgICBwYXRocyArPSBsYXN0X3Vu ZXhwZWN0ZWRfcmVzdWx0cwogICAgICAgICBpZiBzZWxmLl9vcHRpb25zLnRlc3RfbGlzdDoKICAg ICAgICAgICAgIHBhdGhzICs9IHJlYWRfdGVzdF9maWxlcyhzZWxmLl9vcHRpb25zLnRlc3RfbGlz dCkKICAgICAgICAgc2VsZi5fdGVzdF9maWxlcyA9IHNlbGYuX3BvcnQudGVzdHMocGF0aHMpCiAK KyAgICBkZWYgX3N0cmlwX3Rlc3RfZGlyX3ByZWZpeChzZWxmLCBwYXRoKToKKyAgICAgICAgdGVz dF9kaXIgPSAnTGF5b3V0VGVzdHMvJworICAgICAgICBpZiBwYXRoLnN0YXJ0c3dpdGgodGVzdF9k aXIpOgorICAgICAgICAgICAgcmV0dXJuIHBhdGhbbGVuKHRlc3RfZGlyKTpdCisgICAgICAgIHJl dHVybiBwYXRoCisKICAgICBkZWYgbGludChzZWxmKToKICAgICAgICAgIyBDcmVhdGluZyB0aGUg ZXhwZWNhdGlvbnMgZm9yIGVhY2ggcGxhdGZvcm0vY29uZmlndXJhdGlvbiBwYWlyIGRvZXMKICAg ICAgICAgIyBhbGwgdGhlIHRlc3QgbGlzdCBwYXJzaW5nIGFuZCBlbnN1cmVzIGl0J3MgY29ycmVj dCBzeW50YXggKGUuZy4gbm8K 72587 2010-11-01 16:15:59 -0700 2010-11-02 13:42:57 -0700 Patch bug-48794-20101101161557.patch text/plain 2821 kalman ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMTFkNTg1MTI4NGUyZjQ4ZTk0YWFjYjg3OTdhMmFkMjBjN2Q0MmEyLi5iYTBmMTdm OWMyZDdmOTI0YmYwNjlkNGFjZGVmYmQ0MWYyYzNlZjc0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMTEtMDEgIEJlbmphbWluIEthbG1hbiAgPGthbG1hbkBnb29nbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG5ldy1ydW4td2Via2l0 LXRlc3RzIGRvZXNuJ3Qgc3RyaXAgIkxheW91dFRlc3RzLyIgZnJvbSBwcmVmaXgsIHVubGlrZSBv bGQtcnVuLXdlYmtpdC10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDg3OTQKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3J1bl93ZWJraXRfdGVzdHMucHk6IFN0cmlwIHRoZSAiTGF5b3V0VGVzdHMvIiBwcmVmaXgg ZnJvbSB0ZXN0IGFyZ3VtZW50IHBhdGhzLgorCiAyMDEwLTExLTAxICBTw7hyZW4gR2plc3NlICA8 c2dqZXNzZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGlu Zy4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDcwNDE4MGM2MGJhMWNjNzkwYTYyZWUx NWE1NzRmOGQ2YTFhMDdmYTIuLmU1MTUzMzAzZWI5MjVlMWQyOTQxNWFjM2I0NmI5OWI1ODI2NDky MDkgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtODUsNiArODUsOCBAQCBfbG9nID0g bG9nZ2luZy5nZXRMb2dnZXIoIndlYmtpdHB5LmxheW91dF90ZXN0cy5ydW5fd2Via2l0X3Rlc3Rz IikKICMgQnVpbGRlciBiYXNlIFVSTCB3aGVyZSB3ZSBoYXZlIHRoZSBhcmNoaXZlZCB0ZXN0IHJl c3VsdHMuCiBCVUlMREVSX0JBU0VfVVJMID0gImh0dHA6Ly9idWlsZC5jaHJvbWl1bS5vcmcvYnVp bGRib3QvbGF5b3V0X3Rlc3RfcmVzdWx0cy8iCiAKK0xBWU9VVF9URVNUU19ESVJFQ1RPUlkgPSAi TGF5b3V0VGVzdHMiICsgb3Muc2VwCisKIFRlc3RFeHBlY3RhdGlvbnNGaWxlID0gdGVzdF9leHBl Y3RhdGlvbnMuVGVzdEV4cGVjdGF0aW9uc0ZpbGUKIAogCkBAIC0yODMsMTIgKzI4NSwxNyBAQCBj bGFzcyBUZXN0UnVubmVyOgogICAgICAgICAgIGxhc3RfdW5leHBlY3RlZF9yZXN1bHRzOiBsaXN0 IG9mIHVuZXhwZWN0ZWQgcmVzdWx0cyB0byByZXRlc3QsIGlmIGFueQogCiAgICAgICAgICIiIgot ICAgICAgICBwYXRocyA9IFthcmcgZm9yIGFyZyBpbiBhcmdzIGlmIGFyZyBhbmQgYXJnICE9ICcn XQorICAgICAgICBwYXRocyA9IFtzZWxmLl9zdHJpcF90ZXN0X2Rpcl9wcmVmaXgoYXJnKSBmb3Ig YXJnIGluIGFyZ3MgaWYgYXJnIGFuZCBhcmcgIT0gJyddCiAgICAgICAgIHBhdGhzICs9IGxhc3Rf dW5leHBlY3RlZF9yZXN1bHRzCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMudGVzdF9saXN0Ogog ICAgICAgICAgICAgcGF0aHMgKz0gcmVhZF90ZXN0X2ZpbGVzKHNlbGYuX29wdGlvbnMudGVzdF9s aXN0KQogICAgICAgICBzZWxmLl90ZXN0X2ZpbGVzID0gc2VsZi5fcG9ydC50ZXN0cyhwYXRocykK IAorICAgIGRlZiBfc3RyaXBfdGVzdF9kaXJfcHJlZml4KHNlbGYsIHBhdGgpOgorICAgICAgICBp ZiBwYXRoLnN0YXJ0c3dpdGgoTEFZT1VUX1RFU1RTX0RJUkVDVE9SWSk6CisgICAgICAgICAgICBy ZXR1cm4gcGF0aFtsZW4oTEFZT1VUX1RFU1RTX0RJUkVDVE9SWSk6XQorICAgICAgICByZXR1cm4g cGF0aAorCiAgICAgZGVmIGxpbnQoc2VsZik6CiAgICAgICAgICMgQ3JlYXRpbmcgdGhlIGV4cGVj YXRpb25zIGZvciBlYWNoIHBsYXRmb3JtL2NvbmZpZ3VyYXRpb24gcGFpciBkb2VzCiAgICAgICAg ICMgYWxsIHRoZSB0ZXN0IGxpc3QgcGFyc2luZyBhbmQgZW5zdXJlcyBpdCdzIGNvcnJlY3Qgc3lu dGF4IChlLmcuIG5vCkBAIC00NzAsOSArNDc3LDkgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICBk ZWYgX2dldF9kaXJfZm9yX3Rlc3RfZmlsZShzZWxmLCB0ZXN0X2ZpbGUpOgogICAgICAgICAiIiJS ZXR1cm5zIHRoZSBoaWdoZXN0LWxldmVsIGRpcmVjdG9yeSBieSB3aGljaCB0byBzaGFyZCB0aGUg Z2l2ZW4KICAgICAgICAgdGVzdCBmaWxlLiIiIgotICAgICAgICBpbmRleCA9IHRlc3RfZmlsZS5y ZmluZChvcy5zZXAgKyAnTGF5b3V0VGVzdHMnICsgb3Muc2VwKQorICAgICAgICBpbmRleCA9IHRl c3RfZmlsZS5yZmluZChvcy5zZXAgKyBMQVlPVVRfVEVTVFNfRElSRUNUT1JZKQogCi0gICAgICAg IHRlc3RfZmlsZSA9IHRlc3RfZmlsZVtpbmRleCArIGxlbignTGF5b3V0VGVzdHMvJyk6XQorICAg ICAgICB0ZXN0X2ZpbGUgPSB0ZXN0X2ZpbGVbaW5kZXggKyBsZW4oTEFZT1VUX1RFU1RTX0RJUkVD VE9SWSk6XQogICAgICAgICB0ZXN0X2ZpbGVfcGFydHMgPSB0ZXN0X2ZpbGUuc3BsaXQob3Muc2Vw LCAxKQogICAgICAgICBkaXJlY3RvcnkgPSB0ZXN0X2ZpbGVfcGFydHNbMF0KICAgICAgICAgdGVz dF9maWxlID0gdGVzdF9maWxlX3BhcnRzWzFdCg==