48793 2010-11-01 15:55:12 -0700 Dragging and dropping into an empty document crashes WebKit 2010-12-03 11:25:46 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P1 Normal --- 1 dcheng webkit-unassigned morrita rniwa tony oldest_to_newest 303007 0 dcheng 2010-11-01 15:55:12 -0700 elementUnderMouse() in DragController.cpp can return null if the document is empty (see test.xhtml attached to crbug.com/61182). 303011 1 72580 dcheng 2010-11-01 15:59:57 -0700 Created attachment 72580 Patch 303040 2 72580 tony 2010-11-01 16:20:35 -0700 Comment on attachment 72580 Patch Can you make a layout test for this? 303110 3 72580 dcheng 2010-11-01 17:26:58 -0700 Comment on attachment 72580 Patch R- while I work on layout test. 305622 4 dcheng 2010-11-05 16:17:37 -0700 This one seems to require an empty top-level document to repro. Given the current testing infrastructure, I do not think it is possible to write a layout test. I can attach a manual test to the bug if you want. 306328 5 tony 2010-11-08 13:34:28 -0800 Sure, let's just go for a manual test. 306446 6 73304 dcheng 2010-11-08 16:23:19 -0800 Created attachment 73304 Patch 306454 7 73304 tony 2010-11-08 16:33:09 -0800 Comment on attachment 73304 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73304&action=review > WebCore/ChangeLog:13 > + * manual-tests/drop-in-empty-doc2.xhtml: Added. drop-in-empty-doc2.xhtml should go in manual-tests/resources/. > WebCore/page/DragController.cpp:271 > +// This can return null if an empty document is loaded. Is this new or have we had this bug for a long time? It seems odd that this is suddenly not working. Do you know which change regressed this? I'm worried we're papering over the crash when the fix is elsewhere. 306533 8 dcheng 2010-11-08 18:09:29 -0800 (In reply to comment #7) > (From update of attachment 73304 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73304&action=review > > > WebCore/ChangeLog:13 > > + * manual-tests/drop-in-empty-doc2.xhtml: Added. > > drop-in-empty-doc2.xhtml should go in manual-tests/resources/. > > > WebCore/page/DragController.cpp:271 > > +// This can return null if an empty document is loaded. > > Is this new or have we had this bug for a long time? It seems odd that this is suddenly not working. Do you know which change regressed this? > > I'm worried we're papering over the crash when the fix is elsewhere. I think we've had this bug for a long time (it crashes Chrome 7 as well). 316720 9 rniwa 2010-12-03 01:08:33 -0800 Crash is P1. 316855 10 73304 tony 2010-12-03 09:53:04 -0800 Comment on attachment 73304 Patch Sorry, I forgot about this. I'm going to do some testing in Safari before landing, so removing cq flag. 316915 11 tony 2010-12-03 11:18:27 -0800 Committed r73276: <http://trac.webkit.org/changeset/73276> 316917 12 tony 2010-12-03 11:25:46 -0800 (In reply to comment #11) > Committed r73276: <http://trac.webkit.org/changeset/73276> I verified that this crashes on both Safari 5.0.x (mac) and Safari with WebKit ToT. The patch fixes it. I also moved the .xhtml test file into the resources subdir. 72580 2010-11-01 15:59:57 -0700 2010-11-08 16:23:15 -0800 Patch bug-48793-20101101155955.patch text/plain 2447 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzhiMmYzZDI3OTFlZjc0MWVjOTMxZjQzY2IwYTg5OTg4YzQ0ZDhmNy4uOTc0NTU4NTEwM2VkZjQw OGI1ZDg0NDUyMTEyYTRlOTEzYTExYzlhYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMS0wMSAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcmFnZ2luZyBhbmQgZHJvcHBpbmcgaW50byBhbiBl bXB0eSBkb2N1bWVudCBjcmFzaGVzIFdlYktpdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NzkzCisKKyAgICAgICAgUmVtb3ZlIHRoZSBhc3NlcnQg YW5kIHVwZGF0ZSBjYWxsZXJzIHRvIGNoZWNrIGZvciBhIG51bGwgcmV0dXJuIHZhbHVlLgorCisg ICAgICAgICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjplbGVt ZW50VW5kZXJNb3VzZSk6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6dHJ5RG9j dW1lbnREcmFnKToKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVyOjpjb25jbHVkZUVk aXREcmFnKToKKwogMjAxMC0xMS0wMSAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGFnZS9EcmFnQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3Bw CmluZGV4IDJlN2QyNDE3NjNiMDE1NWM5NTMwY2Y0NTNkZmNiMWYxZmQ5MzZkOTAuLjdmNTQyNTFl MmIwNzk2NGRhZGI0NjY1OWJkYTNlZWIzOGFmZjFlOWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFn ZS9EcmFnQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNw cApAQCAtMjY4LDYgKzI2OCw3IEBAIHN0YXRpYyBIVE1MSW5wdXRFbGVtZW50KiBhc0ZpbGVJbnB1 dChOb2RlKiBub2RlKQogICAgIHJldHVybiBpbnB1dEVsZW1lbnQ7CiB9CiAKKy8vIFRoaXMgY2Fu IHJldHVybiBudWxsIGlmIGFuIGVtcHR5IGRvY3VtZW50IGlzIGxvYWRlZC4KIHN0YXRpYyBFbGVt ZW50KiBlbGVtZW50VW5kZXJNb3VzZShEb2N1bWVudCogZG9jdW1lbnRVbmRlck1vdXNlLCBjb25z dCBJbnRQb2ludCYgcCkKIHsKICAgICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudFVuZGVyTW91c2Ut PmZyYW1lKCk7CkBAIC0yODQsNyArMjg1LDYgQEAgc3RhdGljIEVsZW1lbnQqIGVsZW1lbnRVbmRl ck1vdXNlKERvY3VtZW50KiBkb2N1bWVudFVuZGVyTW91c2UsIGNvbnN0IEludFBvaW50JgogICAg IGlmIChuKQogICAgICAgICBuID0gbi0+c2hhZG93QW5jZXN0b3JOb2RlKCk7CiAKLSAgICBBU1NF UlQobik7CiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PEVsZW1lbnQqPihuKTsKIH0KIApAQCAtMzI0 LDYgKzMyNCw4IEBAIGJvb2wgRHJhZ0NvbnRyb2xsZXI6OnRyeURvY3VtZW50RHJhZyhEcmFnRGF0 YSogZHJhZ0RhdGEsIERyYWdEZXN0aW5hdGlvbkFjdGlvbiBhCiAKICAgICAgICAgSW50UG9pbnQg cG9pbnQgPSBmcmFtZVZpZXctPndpbmRvd1RvQ29udGVudHMoZHJhZ0RhdGEtPmNsaWVudFBvc2l0 aW9uKCkpOwogICAgICAgICBFbGVtZW50KiBlbGVtZW50ID0gZWxlbWVudFVuZGVyTW91c2UobV9k b2N1bWVudFVuZGVyTW91c2UuZ2V0KCksIHBvaW50KTsKKyAgICAgICAgaWYgKCFlbGVtZW50KQor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBpZiAoIWFzRmlsZUlucHV0KGVsZW1l bnQpKSB7CiAgICAgICAgICAgICBWaXNpYmxlU2VsZWN0aW9uIGRyYWdDYXJldCA9IG1fZG9jdW1l bnRVbmRlck1vdXNlLT5mcmFtZSgpLT52aXNpYmxlUG9zaXRpb25Gb3JQb2ludChwb2ludCk7CiAg ICAgICAgICAgICBtX3BhZ2UtPmRyYWdDYXJldENvbnRyb2xsZXIoKS0+c2V0U2VsZWN0aW9uKGRy YWdDYXJldCk7CkBAIC0zODMsNiArMzg1LDggQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6Y29uY2x1 ZGVFZGl0RHJhZyhEcmFnRGF0YSogZHJhZ0RhdGEpCiAKICAgICBJbnRQb2ludCBwb2ludCA9IG1f ZG9jdW1lbnRVbmRlck1vdXNlLT52aWV3KCktPndpbmRvd1RvQ29udGVudHMoZHJhZ0RhdGEtPmNs aWVudFBvc2l0aW9uKCkpOwogICAgIEVsZW1lbnQqIGVsZW1lbnQgPSBlbGVtZW50VW5kZXJNb3Vz ZShtX2RvY3VtZW50VW5kZXJNb3VzZS5nZXQoKSwgcG9pbnQpOworICAgIGlmICghZWxlbWVudCkK KyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEZyYW1lKiBpbm5lckZyYW1lID0gZWxlbWVudC0+ b3duZXJEb2N1bWVudCgpLT5mcmFtZSgpOwogICAgIEFTU0VSVChpbm5lckZyYW1lKTsKIAo= 73304 2010-11-08 16:23:19 -0800 2010-12-03 09:53:04 -0800 Patch bug-48793-20101108162317.patch text/plain 3338 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzhiMmYzZDI3OTFlZjc0MWVjOTMxZjQzY2IwYTg5OTg4YzQ0ZDhmNy4uZjA2MjBkMjgyNWYxZTAy NjhkMmVkNmRhNWYxNDE5ZGFmZGY5ZWI3MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0xMS0wOCAgRGFu aWVsIENoZW5nICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEcmFnZ2luZyBhbmQgZHJvcHBpbmcgaW50byBhbiBl bXB0eSBkb2N1bWVudCBjcmFzaGVzIFdlYktpdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NzkzCisKKyAgICAgICAgUmVtb3ZlIHRoZSBhc3NlcnQg YW5kIHVwZGF0ZSBjYWxsZXJzIHRvIGNoZWNrIGZvciBhIG51bGwgcmV0dXJuIHZhbHVlLgorCisg ICAgICAgIFRlc3Q6IG1hbnVhbC10ZXN0cy9kcm9wLWluLWVtcHR5LWRvYy5odG1sCisKKyAgICAg ICAgKiBtYW51YWwtdGVzdHMvZHJvcC1pbi1lbXB0eS1kb2MuaHRtbDogQWRkZWQuCisgICAgICAg ICogbWFudWFsLXRlc3RzL2Ryb3AtaW4tZW1wdHktZG9jMi54aHRtbDogQWRkZWQuCisgICAgICAg ICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjplbGVtZW50VW5k ZXJNb3VzZSk6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29udHJvbGxlcjo6dHJ5RG9jdW1lbnRE cmFnKToKKyAgICAgICAgKFdlYkNvcmU6OkRyYWdDb250cm9sbGVyOjpjb25jbHVkZUVkaXREcmFn KToKKwogMjAxMC0xMS0wMSAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbWFudWFs LXRlc3RzL2Ryb3AtaW4tZW1wdHktZG9jLmh0bWwgYi9XZWJDb3JlL21hbnVhbC10ZXN0cy9kcm9w LWluLWVtcHR5LWRvYy5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQzYjM1NTExNjQ3MGIzMThmMDc2NzdkZjVl MDllZjZmMzk4Mjg0ZDcKLS0tIC9kZXYvbnVsbAorKysgYi9XZWJDb3JlL21hbnVhbC10ZXN0cy9k cm9wLWluLWVtcHR5LWRvYy5odG1sCkBAIC0wLDAgKzEsNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8 aHRtbD4KKzxib2R5PgorPHA+Q2xpY2sgPGEgaHJlZj0iamF2YXNjcmlwdDp3aW5kb3cub3Blbign ZHJvcC1pbi1lbXB0eS1kb2MyLnhodG1sJykiPmhlcmU8L2E+IHRvIG9wZW4gYSBuZXcgd2luZG93 LiBEcmFnIGFuZCBkcm9wIGEgZmlsZSBvdmVyIHRoZSBuZXcgd2luZG93LiBJdCBzaG91bGQgbm90 IGNyYXNoLgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9tYW51YWwtdGVz dHMvZHJvcC1pbi1lbXB0eS1kb2MyLnhodG1sIGIvV2ViQ29yZS9tYW51YWwtdGVzdHMvZHJvcC1p bi1lbXB0eS1kb2MyLnhodG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU2OWRlMjliYjJkMWQ2NDM0YjhiMjlhZTc3 NWFkOGMyZTQ4YzUzOTEKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5j cHAgYi9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCmluZGV4IDJlN2QyNDE3NjNiMDE1 NWM5NTMwY2Y0NTNkZmNiMWYxZmQ5MzZkOTAuLjdmNTQyNTFlMmIwNzk2NGRhZGI0NjY1OWJkYTNl ZWIzOGFmZjFlOWIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAK KysrIGIvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcApAQCAtMjY4LDYgKzI2OCw3IEBA IHN0YXRpYyBIVE1MSW5wdXRFbGVtZW50KiBhc0ZpbGVJbnB1dChOb2RlKiBub2RlKQogICAgIHJl dHVybiBpbnB1dEVsZW1lbnQ7CiB9CiAKKy8vIFRoaXMgY2FuIHJldHVybiBudWxsIGlmIGFuIGVt cHR5IGRvY3VtZW50IGlzIGxvYWRlZC4KIHN0YXRpYyBFbGVtZW50KiBlbGVtZW50VW5kZXJNb3Vz ZShEb2N1bWVudCogZG9jdW1lbnRVbmRlck1vdXNlLCBjb25zdCBJbnRQb2ludCYgcCkKIHsKICAg ICBGcmFtZSogZnJhbWUgPSBkb2N1bWVudFVuZGVyTW91c2UtPmZyYW1lKCk7CkBAIC0yODQsNyAr Mjg1LDYgQEAgc3RhdGljIEVsZW1lbnQqIGVsZW1lbnRVbmRlck1vdXNlKERvY3VtZW50KiBkb2N1 bWVudFVuZGVyTW91c2UsIGNvbnN0IEludFBvaW50JgogICAgIGlmIChuKQogICAgICAgICBuID0g bi0+c2hhZG93QW5jZXN0b3JOb2RlKCk7CiAKLSAgICBBU1NFUlQobik7CiAgICAgcmV0dXJuIHN0 YXRpY19jYXN0PEVsZW1lbnQqPihuKTsKIH0KIApAQCAtMzI0LDYgKzMyNCw4IEBAIGJvb2wgRHJh Z0NvbnRyb2xsZXI6OnRyeURvY3VtZW50RHJhZyhEcmFnRGF0YSogZHJhZ0RhdGEsIERyYWdEZXN0 aW5hdGlvbkFjdGlvbiBhCiAKICAgICAgICAgSW50UG9pbnQgcG9pbnQgPSBmcmFtZVZpZXctPndp bmRvd1RvQ29udGVudHMoZHJhZ0RhdGEtPmNsaWVudFBvc2l0aW9uKCkpOwogICAgICAgICBFbGVt ZW50KiBlbGVtZW50ID0gZWxlbWVudFVuZGVyTW91c2UobV9kb2N1bWVudFVuZGVyTW91c2UuZ2V0 KCksIHBvaW50KTsKKyAgICAgICAgaWYgKCFlbGVtZW50KQorICAgICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgICAgICBpZiAoIWFzRmlsZUlucHV0KGVsZW1lbnQpKSB7CiAgICAgICAgICAgICBW aXNpYmxlU2VsZWN0aW9uIGRyYWdDYXJldCA9IG1fZG9jdW1lbnRVbmRlck1vdXNlLT5mcmFtZSgp LT52aXNpYmxlUG9zaXRpb25Gb3JQb2ludChwb2ludCk7CiAgICAgICAgICAgICBtX3BhZ2UtPmRy YWdDYXJldENvbnRyb2xsZXIoKS0+c2V0U2VsZWN0aW9uKGRyYWdDYXJldCk7CkBAIC0zODMsNiAr Mzg1LDggQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6Y29uY2x1ZGVFZGl0RHJhZyhEcmFnRGF0YSog ZHJhZ0RhdGEpCiAKICAgICBJbnRQb2ludCBwb2ludCA9IG1fZG9jdW1lbnRVbmRlck1vdXNlLT52 aWV3KCktPndpbmRvd1RvQ29udGVudHMoZHJhZ0RhdGEtPmNsaWVudFBvc2l0aW9uKCkpOwogICAg IEVsZW1lbnQqIGVsZW1lbnQgPSBlbGVtZW50VW5kZXJNb3VzZShtX2RvY3VtZW50VW5kZXJNb3Vz ZS5nZXQoKSwgcG9pbnQpOworICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIEZyYW1lKiBpbm5lckZyYW1lID0gZWxlbWVudC0+b3duZXJEb2N1bWVudCgpLT5mcmFt ZSgpOwogICAgIEFTU0VSVChpbm5lckZyYW1lKTsKIAo=