48790 2010-11-01 15:31:55 -0700 new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default 2011-02-18 17:47:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke jamesr kbr tony oldest_to_newest 302992 0 dpranke 2010-11-01 15:31:55 -0700 new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default 302993 1 72575 dpranke 2010-11-01 15:32:35 -0700 Created attachment 72575 Patch 302995 2 72575 jamesr 2010-11-01 15:36:39 -0700 Comment on attachment 72575 Patch Okie 303013 3 dpranke 2010-11-01 16:01:17 -0700 Committed r71068: <http://trac.webkit.org/changeset/71068> 353938 4 jamesr 2011-02-18 17:31:20 -0800 I don't remember why we did this - do we still need to limit this? It makes the tests a lot slower and since we're doing everything in software now by default it seems like there's no reason to serialize the tests in the default config. Running with --child-processes=16 on my linux z600 results in the tests running a little better than 2x faster. 353945 5 dpranke 2011-02-18 17:44:29 -0800 Two different issues ... 1) we have to use DRT, because TestShell didn't have the code paths, and it's gone now anyway. As to --child-processes=1, I know the tests were flaky before w/o it. I've been meaning to check w/ Ken or someone to see if we still needed it, but if we don't, feel free to post a patch dropping the restrictions (and/or I will get around to trying it eventually and doing so myself). 353948 6 jamesr 2011-02-18 17:47:08 -0800 I'll ask the trybots if a higher process count is still flaky. 72575 2010-11-01 15:32:35 -0700 2010-11-01 15:36:39 -0700 Patch bug-48790-20101101153234.patch text/plain 4199 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3ZjA0NWFkNTcxYWE5NzExMzE4OTliN2NhMDFiMDE4MTRjNDU4ZTkyLi5hMTM3OGY0 NWY4ZDllZmFmZTIxNWE2MmViOTllNDZlMzgwZWM1ZGM2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTEtMDEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQt dGVzdHM6IHVzZSBEUlQsIGNoaWxkLXByb2Nlc3Nlcz0xIGZvciBHUFUgdGVzdHMgYnkgZGVmYXVs dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg3OTAK KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1f Z3B1LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hy b21pdW1fZ3B1X3VuaXR0ZXN0LnB5OgorCiAyMDEwLTEwLTMwICBBbmRyZWFzIEtsaW5nICA8a2xp bmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9j aHJvbWl1bV9ncHUucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2dwdS5weQppbmRleCA1ZDI4ZmFlZDMzOWEzZTk3MDdkOThlM2NkMTU1 ODJkNDU1MDRkMDZlLi41N2I2OTg5MzM0MmVlOGY5MTY4YjA2YTgyNWM2YmZiMzQ0MzAyZjViIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtX2dwdS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdS5weQpAQCAtNzEsNiArNzEsOCBAQCBkZWYgX3NldF9n cHVfb3B0aW9ucyhvcHRpb25zKToKICAgICAgICAgICAgIG9wdGlvbnMuYWNjZWxlcmF0ZWRfMmRf Y2FudmFzID0gVHJ1ZQogICAgICAgICBpZiBvcHRpb25zLmJ1aWxkZXJfbmFtZSBpcyBub3QgTm9u ZToKICAgICAgICAgICAgIG9wdGlvbnMuYnVpbGRlcl9uYW1lID0gb3B0aW9ucy5idWlsZGVyX25h bWUgKyAnIC0gR1BVJworICAgICAgICBpZiBvcHRpb25zLnVzZV9kcnQgaXMgTm9uZToKKyAgICAg ICAgICAgIG9wdGlvbnMudXNlX2RydCA9IFRydWUKIAogCiBkZWYgX2dwdV9vdmVycmlkZXMocG9y dCk6CkBAIC05Niw2ICs5OCw5IEBAIGNsYXNzIENocm9taXVtR3B1TGludXhQb3J0KGNocm9taXVt X2xpbnV4LkNocm9taXVtTGludXhQb3J0KToKICAgICAgICAgcmV0dXJuIChtYXAoc2VsZi5fd2Vi a2l0X2Jhc2VsaW5lX3BhdGgsIFsnY2hyb21pdW0tZ3B1LWxpbnV4JywgJ2Nocm9taXVtLWdwdS13 aW4nLCAnY2hyb21pdW0tZ3B1J10pICsKICAgICAgICAgICAgICAgICBjaHJvbWl1bV9saW51eC5D aHJvbWl1bUxpbnV4UG9ydC5iYXNlbGluZV9zZWFyY2hfcGF0aChzZWxmKSkKIAorICAgIGRlZiBk ZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcyhzZWxmKToKKyAgICAgICAgcmV0dXJuIDEKKwogICAgIGRl ZiBwYXRoX3RvX3Rlc3RfZXhwZWN0YXRpb25zX2ZpbGUoc2VsZik6CiAgICAgICAgIHJldHVybiBz ZWxmLnBhdGhfZnJvbV93ZWJraXRfYmFzZSgnTGF5b3V0VGVzdHMnLCAncGxhdGZvcm0nLAogICAg ICAgICAgICAgJ2Nocm9taXVtLWdwdScsICd0ZXN0X2V4cGVjdGF0aW9ucy50eHQnKQpAQCAtMTE0 LDYgKzExOSw5IEBAIGNsYXNzIENocm9taXVtR3B1TWFjUG9ydChjaHJvbWl1bV9tYWMuQ2hyb21p dW1NYWNQb3J0KToKICAgICAgICAgcmV0dXJuIChtYXAoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3Bh dGgsIFsnY2hyb21pdW0tZ3B1LW1hYycsICdjaHJvbWl1bS1ncHUnXSkgKwogICAgICAgICAgICAg ICAgIGNocm9taXVtX21hYy5DaHJvbWl1bU1hY1BvcnQuYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2Vs ZikpCiAKKyAgICBkZWYgZGVmYXVsdF9jaGlsZF9wcm9jZXNzZXMoc2VsZik6CisgICAgICAgIHJl dHVybiAxCisKICAgICBkZWYgcGF0aF90b190ZXN0X2V4cGVjdGF0aW9uc19maWxlKHNlbGYpOgog ICAgICAgICByZXR1cm4gc2VsZi5wYXRoX2Zyb21fd2Via2l0X2Jhc2UoJ0xheW91dFRlc3RzJywg J3BsYXRmb3JtJywKICAgICAgICAgICAgICdjaHJvbWl1bS1ncHUnLCAndGVzdF9leHBlY3RhdGlv bnMudHh0JykKQEAgLTEzMiw2ICsxNDAsOSBAQCBjbGFzcyBDaHJvbWl1bUdwdVdpblBvcnQoY2hy b21pdW1fd2luLkNocm9taXVtV2luUG9ydCk6CiAgICAgICAgIHJldHVybiAobWFwKHNlbGYuX3dl YmtpdF9iYXNlbGluZV9wYXRoLCBbJ2Nocm9taXVtLWdwdS13aW4nLCAnY2hyb21pdW0tZ3B1J10p ICsKICAgICAgICAgICAgICAgICBjaHJvbWl1bV93aW4uQ2hyb21pdW1XaW5Qb3J0LmJhc2VsaW5l X3NlYXJjaF9wYXRoKHNlbGYpKQogCisgICAgZGVmIGRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzKHNl bGYpOgorICAgICAgICByZXR1cm4gMQorCiAgICAgZGVmIHBhdGhfdG9fdGVzdF9leHBlY3RhdGlv bnNfZmlsZShzZWxmKToKICAgICAgICAgcmV0dXJuIHNlbGYucGF0aF9mcm9tX3dlYmtpdF9iYXNl KCdMYXlvdXRUZXN0cycsICdwbGF0Zm9ybScsCiAgICAgICAgICAgICAnY2hyb21pdW0tZ3B1Jywg J3Rlc3RfZXhwZWN0YXRpb25zLnR4dCcpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2dwdV91bml0dGVzdC5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1 X3VuaXR0ZXN0LnB5CmluZGV4IDg4NTI0ZmM0MTU4NzQ5MTlmYWVmYjNmYWFkNTQ1OWFkYzJkNTIz Y2UuLjAzYmM5OGFmYjM0MDcwN2MzM2VmMTY0OWZhNDljNDYwMzkxZTQ1OTcgMTAwNjQ0Ci0tLSBh L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1f Z3B1X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3BvcnQvY2hyb21pdW1fZ3B1X3VuaXR0ZXN0LnB5CkBAIC00NSwxMCArNDUsMTQgQEAg Y2xhc3MgQ2hyb21pdW1HcHVUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgIyB0ZXN0 IHRoYXQgd2UgZ290IHRoZSByaWdodCBwb3J0CiAgICAgICAgIG1vY2tfb3B0aW9ucyA9IG1vY2t0 b29sLk1vY2tPcHRpb25zKGFjY2VsZXJhdGVkX2NvbXBvc2l0aW5nPU5vbmUsCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFjY2VsZXJhdGVkXzJkX2NhbnZhcz1O b25lLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBidWlsZGVy X25hbWU9J2ZvbycpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJ1aWxkZXJfbmFtZT0nZm9vJywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdXNlX2RydD1Ob25lLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjaGlsZF9wcm9jZXNzZXM9Tm9uZSkKICAgICAgICAgcG9ydCA9IGNocm9taXVt X2dwdS5nZXQocG9ydF9uYW1lPXBvcnRfbmFtZSwgb3B0aW9ucz1tb2NrX29wdGlvbnMpCiAgICAg ICAgIHNlbGYuYXNzZXJ0VHJ1ZShwb3J0Ll9vcHRpb25zLmFjY2VsZXJhdGVkX2NvbXBvc2l0aW5n KQogICAgICAgICBzZWxmLmFzc2VydFRydWUocG9ydC5fb3B0aW9ucy5hY2NlbGVyYXRlZF8yZF9j YW52YXMpCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShwb3J0Ll9vcHRpb25zLnVzZV9kcnQpCisg ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5kZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcygpLCAx KQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuX29wdGlvbnMuYnVpbGRlcl9uYW1lLCAn Zm9vIC0gR1BVJykKIAogICAgICAgICAjIHdlIHVzZSBzdGFydHN3aXRoKCkgaW5zdGVhZCBvZiBF cXVhbCB0byBnbG9zcyBvdmVyIHBsYXRmb3JtIHZlcnNpb25zLgo=