48785 2010-11-01 14:36:55 -0700 Setting attr repeatDur=0 on SVG element causes hang 2010-11-03 08:38:58 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED http://www.w3.org/1999/07/30/WD-SVG-19990730/animate.html P2 Normal --- 1 mdelaney7 mdelaney7 abarth bdakin eric mdelaney7 webkit.review.bot zimmermann oldest_to_newest 302944 0 mdelaney7 2010-11-01 14:36:55 -0700 There was a hang being caused because the bound checking was just "<0" and not "<=0". As per the spec, a repeatDur of 0 should have no effect: "" repeatDur = "<clock-value>" This causes the element to play repeatedly (loop) for the specified duration. Each repeat iteration lasts for the simple duration. This attribute has no affect if the duration is 0. A repeat duration less than the simple duration specified in dur will cut short the duration. A repeat duration equal to the simple duration is a no-op. Legal values are clock values greater than 0. In addition, "indefinite" may be specified to indicate that the element should repeat indefinitely (subject to the time container semantics). At most one of repeat or repeatDur should be specified (if both are specified, the repeat duration is defined as the minimum of the specified repeatDur, and the simple duration multiplied by the repeat (count). "" 302948 1 72563 mdelaney7 2010-11-01 14:44:20 -0700 Created attachment 72563 Patch 302968 2 72563 simon.fraser 2010-11-01 14:59:36 -0700 Comment on attachment 72563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72563&action=review > WebCore/svg/animation/SVGSMILElement.cpp:531 > - return m_cachedRepeatDur = clockValue < 0 ? SMILTime::unresolved() : clockValue; > + return m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() : clockValue; The assignment in the return statement is pretty grody here. Please change to: m_cachedRepeatDur = clockValue <= 0 ? SMILTime::unresolved() : clockValue; return m_cachedRepeatDur; > LayoutTests/svg/animations/repeatDur-zero.xhtml:10 > +</svg> > \ No newline at end of file Please add the newline. 302977 3 72570 mdelaney7 2010-11-01 15:08:48 -0700 Created attachment 72570 Patch 302999 4 mdelaney7 2010-11-01 15:41:03 -0700 Committed r71066: <http://trac.webkit.org/changeset/71066> 303023 5 webkit.review.bot 2010-11-01 16:05:05 -0700 http://trac.webkit.org/changeset/71066 might have broken GTK Linux 64-bit Debug The following tests are not passing: accessibility/aria-activedescendant-crash.html accessibility/aria-checkbox-text.html accessibility/aria-hidden-update.html accessibility/contenteditable-hidden-div.html accessibility/crash-with-noelement-selectbox.html accessibility/crashing-a-tag-in-map.html accessibility/document-attributes.html accessibility/first-letter-text-transform-causes-crash.html accessibility/hang-in-isignored.html accessibility/nested-layout-crash.html accessibility/nochildren-elements.html accessibility/non-data-table-cell-title-ui-element.html accessibility/non-native-image-crash.html accessibility/radio-button-checkbox-size.html accessibility/removed-anonymous-block-child-causes-crash.html accessibility/removed-continuation-element-causes-crash.html accessibility/table-modification-crash.html accessibility/table-nofirstbody.html accessibility/table-notbody.html accessibility/table-with-empty-thead-causes-crash.html 304043 6 zimmermann 2010-11-03 08:38:58 -0700 Matthew, can you change the testcase to include if (window.layoutTestController) layoutTestController.dumpAsText() there's no need to dump render tree information there. At the moment the expected.png/checksum files are missing, but it's useless to add them anyway. When doing that, you might also want to remove the existing expected.txt files from platform/mac/svg/animations, and from the gtk/qt/win/chromium* platform directories (in case they have already landed their own results), and move the expected.txt file right into svg/animations/ Thanks in advance! 72563 2010-11-01 14:44:20 -0700 2010-11-01 15:08:45 -0700 Patch bug-48785-20101101144418.patch text/plain 3320 mdelaney7 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTA1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMDEgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTZXR0aW5nIGF0dHIgcmVwZWF0RHVyPTAgb24gU1ZHIGVsZW1lbnQgY2F1c2VzIGhhbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4Nzg1CisKKyAg ICAgICAgVGVzdDogc3ZnL2FuaW1hdGlvbnMvcmVwZWF0RHVyLXplcm8ueGh0bWwKKworICAgICAg ICAqIHN2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwOiBGaXhpbmcgYm91bmQgY2hlY2tp bmcgZm9yIGxlZ2FsIHJlcGVhdER1ciB2YWx1ZXMuCisKIDIwMTAtMTEtMDEgIERhdmlkIEh5YXR0 ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CkluZGV4OiBXZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAJKHJldmlzaW9u IDcxMDQ0KQorKysgV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTI4LDcgKzUyOCw3IEBAIFNNSUxUaW1lIFNWR1NNSUxFbGVtZW50Ojpy ZXBlYXREdXIoKSBjb24KICAgICAgICAgcmV0dXJuIG1fY2FjaGVkUmVwZWF0RHVyOwogICAgIGNv bnN0IEF0b21pY1N0cmluZyYgdmFsdWUgPSBnZXRBdHRyaWJ1dGUoU1ZHTmFtZXM6OnJlcGVhdER1 ckF0dHIpOwogICAgIFNNSUxUaW1lIGNsb2NrVmFsdWUgPSBwYXJzZUNsb2NrVmFsdWUodmFsdWUp OwotICAgIHJldHVybiBtX2NhY2hlZFJlcGVhdER1ciA9IGNsb2NrVmFsdWUgPCAwID8gU01JTFRp bWU6OnVucmVzb2x2ZWQoKSA6IGNsb2NrVmFsdWU7CisgICAgcmV0dXJuIG1fY2FjaGVkUmVwZWF0 RHVyID0gY2xvY2tWYWx1ZSA8PSAwID8gU01JTFRpbWU6OnVucmVzb2x2ZWQoKSA6IGNsb2NrVmFs dWU7CiB9CiAgICAgCiAvLyBTbyBhIGNvdW50IGlzIG5vdCByZWFsbHkgYSB0aW1lIGJ1dCBsZXQg anVzdCBhbGwgcHJldGVuZCB3ZSBkaWQgbm90IG5vdGljZS4KSW5kZXg6IExheW91dFRlc3RzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcx MDU4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTIgQEAKKzIwMTAtMTEtMDEgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTZXR0aW5n IGF0dHIgcmVwZWF0RHVyPTAgb24gU1ZHIGVsZW1lbnQgY2F1c2VzIGhhbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4Nzg1CisKKyAgICAgICAgKiBz dmcvYW5pbWF0aW9ucy9yZXBlYXREdXItemVyby54aHRtbDogQWRkZWQuIFRlc3RzIGlmIHNldHRp bmcgYXR0ciByZXBlYXREdXI9MCBjYXVzZXMgYSBoYW5nIG9yIG5vdC4KKwogMjAxMC0xMS0wMSAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdGVz dCBmYWlsdXJlcyBvbiBRdCBieSBhdm9pZGluZyByZWZlcmVuY2VzIHRvIGV4dGVybmFsIGltYWdl IGZpbGVzLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9hbmltYXRpb25zL3Jl cGVhdER1ci16ZXJvLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvc3ZnL2FuaW1hdGlvbnMvcmVwZWF0RHVyLXplcm8tZXhwZWN0ZWQudHh0CShyZXZp c2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL3N2Zy9hbmltYXRpb25zL3JlcGVh dER1ci16ZXJvLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3IEBACitsYXll ciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2 MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJTVkdSb290IHtzdmd9IGF0 ICg1LDUpIHNpemUgOTN4MTgKKyAgICBSZW5kZXJTVkdUZXh0IHt0ZXh0fSBhdCAoNSw1KSBzaXpl IDkzeDE4IGNvbnRhaW5zIDEgY2h1bmsocykKKyAgICAgIFJlbmRlclNWR0lubGluZVRleHQgeyN0 ZXh0fSBhdCAoMCwwKSBzaXplIDkzeDE4CisgICAgICAgIGNodW5rIDEgdGV4dCBydW4gMSBhdCAo NS4wMCwyMC4wMCkgc3RhcnRPZmZzZXQgMCBlbmRPZmZzZXQgMTIgd2lkdGggOTMuMDA6ICJUZXN0 IFBhc3Nlcy4iCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9yZXBlYXREdXItemVy by54aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9yZXBlYXRE dXItemVyby54aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3N2Zy9hbmltYXRpb25z L3JlcGVhdER1ci16ZXJvLnhodG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDkgQEAKKzw/eG1s IHZlcnNpb249IjEuMCIgc3RhbmRhbG9uZT0ibm8iPz48IURPQ1RZUEUgc3ZnIFBVQkxJQyAiLS8v VzNDLy9EVEQKK1NWRyAxLjEvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEu MS9EVEQvc3ZnMTEuZHRkIj4KKzxzdmcgd2lkdGg9IjEwMCUiIGhlaWdodD0iMTAwJSIgdmVyc2lv bj0iMS4xIgoreG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj4KKzxzZXQgcmVwZWF0 RHVyPSIwIi8+Cis8dGV4dCB4PSI1IiB5PSIyMCIgZm9udC1mYW1pbHk9IlZlcmRhbmEiIGZvbnQt c2l6ZT0iMTUiPgorCVRlc3QgUGFzc2VzLgorPC90ZXh0PgorPC9zdmc+ClwgTm8gbmV3bGluZSBh dCBlbmQgb2YgZmlsZQo= 72570 2010-11-01 15:08:48 -0700 2010-11-01 15:10:51 -0700 Patch bug-48785-20101101150847.patch text/plain 3316 mdelaney7 SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTA1OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTEtMDEgIE1hdHRoZXcgRGVsYW5leSAgPG1kZWxhbmV5QGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBTZXR0aW5nIGF0dHIgcmVwZWF0RHVyPTAgb24gU1ZHIGVsZW1lbnQgY2F1c2VzIGhhbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4Nzg1CisKKyAg ICAgICAgVGVzdDogc3ZnL2FuaW1hdGlvbnMvcmVwZWF0RHVyLXplcm8ueGh0bWwKKworICAgICAg ICAqIHN2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwOiBGaXhpbmcgYm91bmQgY2hlY2tp bmcgZm9yIGxlZ2FsIHJlcGVhdER1ciB2YWx1ZXMuCisKIDIwMTAtMTEtMDEgIERhdmlkIEh5YXR0 ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4u CkluZGV4OiBXZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAJKHJldmlzaW9u IDcxMDQ0KQorKysgV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNTI4LDcgKzUyOCw4IEBAIFNNSUxUaW1lIFNWR1NNSUxFbGVtZW50Ojpy ZXBlYXREdXIoKSBjb24KICAgICAgICAgcmV0dXJuIG1fY2FjaGVkUmVwZWF0RHVyOwogICAgIGNv bnN0IEF0b21pY1N0cmluZyYgdmFsdWUgPSBnZXRBdHRyaWJ1dGUoU1ZHTmFtZXM6OnJlcGVhdER1 ckF0dHIpOwogICAgIFNNSUxUaW1lIGNsb2NrVmFsdWUgPSBwYXJzZUNsb2NrVmFsdWUodmFsdWUp OwotICAgIHJldHVybiBtX2NhY2hlZFJlcGVhdER1ciA9IGNsb2NrVmFsdWUgPCAwID8gU01JTFRp bWU6OnVucmVzb2x2ZWQoKSA6IGNsb2NrVmFsdWU7CisgICAgbV9jYWNoZWRSZXBlYXREdXIgPSBj bG9ja1ZhbHVlIDw9IDAgPyBTTUlMVGltZTo6dW5yZXNvbHZlZCgpIDogY2xvY2tWYWx1ZTsKKyAg ICByZXR1cm4gbV9jYWNoZWRSZXBlYXREdXI7CiB9CiAgICAgCiAvLyBTbyBhIGNvdW50IGlzIG5v dCByZWFsbHkgYSB0aW1lIGJ1dCBsZXQganVzdCBhbGwgcHJldGVuZCB3ZSBkaWQgbm90IG5vdGlj ZS4KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcxMDU4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMDEgIE1hdHRoZXcgRGVsYW5l eSAgPG1kZWxhbmV5QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTZXR0aW5nIGF0dHIgcmVwZWF0RHVyPTAgb24gU1ZHIGVsZW1lbnQg Y2F1c2VzIGhhbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ4Nzg1CisKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9ucy9yZXBlYXREdXItemVyby54aHRt bDogQWRkZWQuIFRlc3RzIGlmIHNldHRpbmcgYXR0ciByZXBlYXREdXI9MCBjYXVzZXMgYSBoYW5n IG9yIG5vdC4KKwogMjAxMC0xMS0wMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxl LmNvbT4KIAogICAgICAgICBGaXggdGVzdCBmYWlsdXJlcyBvbiBRdCBieSBhdm9pZGluZyByZWZl cmVuY2VzIHRvIGV4dGVybmFsIGltYWdlIGZpbGVzLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL3N2Zy9hbmltYXRpb25zL3JlcGVhdER1ci16ZXJvLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvc3ZnL2FuaW1hdGlvbnMvcmVwZWF0RHVy LXplcm8tZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL3N2Zy9hbmltYXRpb25zL3JlcGVhdER1ci16ZXJvLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw3IEBACitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVy VmlldyBhdCAoMCwwKSBzaXplIDgwMHg2MDAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAor ICBSZW5kZXJTVkdSb290IHtzdmd9IGF0ICg1LDUpIHNpemUgOTN4MTgKKyAgICBSZW5kZXJTVkdU ZXh0IHt0ZXh0fSBhdCAoNSw1KSBzaXplIDkzeDE4IGNvbnRhaW5zIDEgY2h1bmsocykKKyAgICAg IFJlbmRlclNWR0lubGluZVRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDkzeDE4CisgICAgICAg IGNodW5rIDEgdGV4dCBydW4gMSBhdCAoNS4wMCwyMC4wMCkgc3RhcnRPZmZzZXQgMCBlbmRPZmZz ZXQgMTIgd2lkdGggOTMuMDA6ICJUZXN0IFBhc3Nlcy4iCkluZGV4OiBMYXlvdXRUZXN0cy9zdmcv YW5pbWF0aW9ucy9yZXBlYXREdXItemVyby54aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9zdmcvYW5pbWF0aW9ucy9yZXBlYXREdXItemVyby54aHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL3JlcGVhdER1ci16ZXJvLnhodG1sCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDkgQEAKKzw/eG1sIHZlcnNpb249IjEuMCIgc3RhbmRhbG9uZT0ibm8iPz48 IURPQ1RZUEUgc3ZnIFBVQkxJQyAiLS8vVzNDLy9EVEQKK1NWRyAxLjEvL0VOIiAiaHR0cDovL3d3 dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEuZHRkIj4KKzxzdmcgd2lkdGg9IjEw MCUiIGhlaWdodD0iMTAwJSIgdmVyc2lvbj0iMS4xIgoreG1sbnM9Imh0dHA6Ly93d3cudzMub3Jn LzIwMDAvc3ZnIj4KKzxzZXQgcmVwZWF0RHVyPSIwIi8+Cis8dGV4dCB4PSI1IiB5PSIyMCIgZm9u dC1mYW1pbHk9IlZlcmRhbmEiIGZvbnQtc2l6ZT0iMTUiPgorCVRlc3QgUGFzc2VzLgorPC90ZXh0 PgorPC9zdmc+Cg==