48779 2010-11-01 14:10:37 -0700 add plugin event logging for linux 2010-11-01 18:00:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony abarth andersca eric tkent webkit.review.bot oldest_to_newest 302916 0 tony 2010-11-01 14:10:37 -0700 add plugin event logging for linux 302926 1 72558 tony 2010-11-01 14:18:28 -0700 Created attachment 72558 Patch 302931 2 tony 2010-11-01 14:21:21 -0700 This fixes LayoutTests/plugins/mouse-events.html for Chromium Linux. 303026 3 72558 tkent 2010-11-01 16:08:07 -0700 Comment on attachment 72558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72558&action=review > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:587 > + // TODO: extract key code TODO -> FIXME > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:593 > + // TODO: extract key code ditto. 303092 4 tony 2010-11-01 17:05:27 -0700 Committed r71078: <http://trac.webkit.org/changeset/71078> 303096 5 tony 2010-11-01 17:06:05 -0700 (In reply to comment #3) > (From update of attachment 72558 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72558&action=review > > > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:587 > > + // TODO: extract key code > > TODO -> FIXME > > > WebKitTools/DumpRenderTree/TestNetscapePlugIn/main.cpp:593 > > + // TODO: extract key code > > ditto. fixed before landing. thanks! 303128 6 webkit.review.bot 2010-11-01 18:00:17 -0700 http://trac.webkit.org/changeset/71078 might have broken GTK Linux 64-bit Debug The following tests are not passing: http/tests/websocket/tests/alert-in-event-handler.html http/tests/websocket/tests/bad-handshake-crash.html http/tests/websocket/tests/bufferedAmount-after-close.html http/tests/websocket/tests/close-on-navigate-new-location.html http/tests/websocket/tests/close-on-unload-and-force-gc.html http/tests/websocket/tests/close-on-unload-reference-in-parent.html http/tests/websocket/tests/close-on-unload.html http/tests/websocket/tests/cross-origin.html http/tests/websocket/tests/error-detect.html http/tests/websocket/tests/frame-length-longer-than-buffer.html http/tests/websocket/tests/frame-length-overflow.html http/tests/websocket/tests/frame-length-skip.html http/tests/websocket/tests/frame-lengths.html http/tests/websocket/tests/handshake-challenge-randomness.html http/tests/websocket/tests/handshake-error.html http/tests/websocket/tests/handshake-fail-by-cross-origin.html http/tests/websocket/tests/handshake-fail-by-no-cr.html http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html http/tests/websocket/tests/httponly-cookie.pl http/tests/websocket/tests/long-invalid-header.html 72558 2010-11-01 14:18:28 -0700 2010-11-01 16:08:07 -0700 Patch bug-48779-20101101141855.patch text/plain 3811 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiMDQ3ZGE4MGNhN2I0MzIxMGRiY2MwNDQ2MmRmNjljYmZiZmQwZTRhLi45YTVjNGE4 OTJiNDBhMWQ5NjY2NDYwMGMxM2Y0YzhhOWZlYmE4NTE5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMTEtMDEgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBhZGQgcGx1Z2luIGV2ZW50IGxv Z2dpbmcgZm9yIGxpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00ODc3OQorCisgICAgICAgIFRoaXMgaXMgdGFrZW4gZnJvbSBDaHJvbWl1bSdzIGZv cmsgb2YgdGhlIGxheW91dCB0ZXN0IHBsdWdpbjoKKyAgICAgICAgaHR0cDovL2dpdC5jaHJvbWl1 bS5vcmcvZ2l0d2ViLz9wPWNocm9taXVtLmdpdC8uZ2l0O2E9YmxvYjtmPXdlYmtpdC90b29scy9u cGFwaV9sYXlvdXRfdGVzdF9wbHVnaW4vbWFpbi5jcHA7aD0zZWJkYWRhMmYwNDliMzYyNDc1NjQz OGNmZjg1MjM2NGY4NmEyZWRlO2hiPUhFQUQjbDM0OAorCisgICAgICAgICogRHVtcFJlbmRlclRy ZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4uY3BwOgorICAgICAgICAoaGFuZGxlRXZlbnRYMTEp OgorICAgICAgICAoTlBQX0hhbmRsZUV2ZW50KToKKwogMjAxMC0xMS0wMSAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3Vs bGl2YW4uCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vbWFpbi5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2Nh cGVQbHVnSW4vbWFpbi5jcHAKaW5kZXggZTUyNDZjNDczZTRmZjRhYTcxNTc3ZjkzNTdjZWI1ODlh NzNkNDA4OS4uNjE4YTY2ODg0N2IwZWIzMWY1MTNiNjc0MTVhMDJhYjA2Y2ZmZDdlNiAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL21haW4u Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3ROZXRzY2FwZVBsdWdJbi9t YWluLmNwcApAQCAtMjksNiArMjksMTAgQEAKICNpbmNsdWRlIDxjc3RkbGliPgogI2luY2x1ZGUg PHN0cmluZz4KIAorI2lmZGVmIFhQX1VOSVgKKyNpbmNsdWRlIDxYMTEvWGxpYi5oPgorI2VuZGlm CisKICNpZiAhZGVmaW5lZChOUF9OT19DQVJCT04pICYmIGRlZmluZWQoUURfSEVBREVSU19BUkVf UFJJVkFURSkgJiYgUURfSEVBREVSU19BUkVfUFJJVkFURQogZXh0ZXJuICJDIiB2b2lkIEdsb2Jh bFRvTG9jYWwoUG9pbnQqKTsKICNlbmRpZgpAQCAtNTY1LDYgKzU2OSw1NCBAQCBzdGF0aWMgaW50 MTZfdCBoYW5kbGVFdmVudENvY29hKE5QUCBpbnN0YW5jZSwgUGx1Z2luT2JqZWN0KiBvYmosIE5Q Q29jb2FFdmVudCogZQogCiAjZW5kaWYgLy8gWFBfTUFDT1NYCiAKKyNpZmRlZiBYUF9VTklYCitz dGF0aWMgaW50MTZfdCBoYW5kbGVFdmVudFgxMShOUFAgaW5zdGFuY2UsIFBsdWdpbk9iamVjdCog b2JqLCBYRXZlbnQqIGV2ZW50KQoreworICAgIFhCdXR0b25QcmVzc2VkRXZlbnQqIGJ1dHRvblBy ZXNzRXZlbnQgPSByZWludGVycHJldF9jYXN0PFhCdXR0b25QcmVzc2VkRXZlbnQqPihldmVudCk7 CisgICAgWEJ1dHRvblJlbGVhc2VkRXZlbnQqIGJ1dHRvblJlbGVhc2VFdmVudCA9IHJlaW50ZXJw cmV0X2Nhc3Q8WEJ1dHRvblJlbGVhc2VkRXZlbnQqPihldmVudCk7CisgICAgc3dpdGNoIChldmVu dC0+dHlwZSkgeworICAgIGNhc2UgQnV0dG9uUHJlc3M6CisgICAgICAgIHBsdWdpbkxvZyhpbnN0 YW5jZSwgIm1vdXNlRG93biBhdCAoJWQsICVkKSIsIGJ1dHRvblByZXNzRXZlbnQtPngsIGJ1dHRv blByZXNzRXZlbnQtPnkpOworICAgICAgICBpZiAob2JqLT5ldmFsdWF0ZVNjcmlwdE9uTW91c2VE b3duT3JLZXlEb3duICYmIG9iai0+bW91c2VEb3duRm9yRXZhbHVhdGVTY3JpcHQpCisgICAgICAg ICAgICBleGVjdXRlU2NyaXB0KG9iaiwgb2JqLT5ldmFsdWF0ZVNjcmlwdE9uTW91c2VEb3duT3JL ZXlEb3duKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBCdXR0b25SZWxlYXNlOgorICAgICAg ICBwbHVnaW5Mb2coaW5zdGFuY2UsICJtb3VzZVVwIGF0ICglZCwgJWQpIiwgYnV0dG9uUmVsZWFz ZUV2ZW50LT54LCBidXR0b25SZWxlYXNlRXZlbnQtPnkpOworICAgICAgICBicmVhazsKKyAgICBj YXNlIEtleVByZXNzOgorICAgICAgICAvLyBUT0RPOiBleHRyYWN0IGtleSBjb2RlCisgICAgICAg IHBsdWdpbkxvZyhpbnN0YW5jZSwgIk5PVElNUExFTUVOVEVEOiBrZXlEb3duICclYyciLCAnICcp OworICAgICAgICBpZiAob2JqLT5ldmFsdWF0ZVNjcmlwdE9uTW91c2VEb3duT3JLZXlEb3duICYm ICFvYmotPm1vdXNlRG93bkZvckV2YWx1YXRlU2NyaXB0KQorICAgICAgICAgICAgZXhlY3V0ZVNj cmlwdChvYmosIG9iai0+ZXZhbHVhdGVTY3JpcHRPbk1vdXNlRG93bk9yS2V5RG93bik7CisgICAg ICAgIGJyZWFrOworICAgIGNhc2UgS2V5UmVsZWFzZToKKyAgICAgICAgLy8gVE9ETzogZXh0cmFj dCBrZXkgY29kZQorICAgICAgICBwbHVnaW5Mb2coaW5zdGFuY2UsICJOT1RJTVBMRU1FTlRFRDog a2V5VXAgJyVjJyIsICcgJyk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgR3JhcGhpY3NFeHBv c2U6CisgICAgICAgIHBsdWdpbkxvZyhpbnN0YW5jZSwgInVwZGF0ZUV2dCIpOworICAgICAgICBi cmVhazsKKyAgICAvLyBOUEFQSSBldmVudHMKKyAgICBjYXNlIEZvY3VzSW46CisgICAgICAgIHBs dWdpbkxvZyhpbnN0YW5jZSwgImdldEZvY3VzRXZlbnQiKTsKKyAgICAgICAgYnJlYWs7CisgICAg Y2FzZSBGb2N1c091dDoKKyAgICAgICAgcGx1Z2luTG9nKGluc3RhbmNlLCAibG9zZUZvY3VzRXZl bnQiKTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBFbnRlck5vdGlmeToKKyAgICBjYXNlIExl YXZlTm90aWZ5OgorICAgIGNhc2UgTW90aW9uTm90aWZ5OgorICAgICAgICBwbHVnaW5Mb2coaW5z dGFuY2UsICJhZGp1c3RDdXJzb3JFdmVudCIpOworICAgICAgICBicmVhazsKKyAgICBkZWZhdWx0 OgorICAgICAgICBwbHVnaW5Mb2coaW5zdGFuY2UsICJldmVudCAlZCIsIGV2ZW50LT50eXBlKTsK KyAgICB9CisKKyAgICBmZmx1c2goc3Rkb3V0KTsKKyAgICByZXR1cm4gMDsKK30KKyNlbmRpZiAv LyBYUF9VTklYCisKIGludDE2X3QgTlBQX0hhbmRsZUV2ZW50KE5QUCBpbnN0YW5jZSwgdm9pZCAq ZXZlbnQpCiB7CiAgICAgUGx1Z2luT2JqZWN0KiBvYmogPSBzdGF0aWNfY2FzdDxQbHVnaW5PYmpl Y3QqPihpbnN0YW5jZS0+cGRhdGEpOwpAQCAtNTc5LDYgKzYzMSw4IEBAIGludDE2X3QgTlBQX0hh bmRsZUV2ZW50KE5QUCBpbnN0YW5jZSwgdm9pZCAqZXZlbnQpCiAKICAgICBhc3NlcnQob2JqLT5l dmVudE1vZGVsID09IE5QRXZlbnRNb2RlbENvY29hKTsKICAgICByZXR1cm4gaGFuZGxlRXZlbnRD b2NvYShpbnN0YW5jZSwgb2JqLCBzdGF0aWNfY2FzdDxOUENvY29hRXZlbnQqPihldmVudCkpOwor I2VsaWYgZGVmaW5lZChYUF9VTklYKQorICAgIHJldHVybiBoYW5kbGVFdmVudFgxMShpbnN0YW5j ZSwgb2JqLCBzdGF0aWNfY2FzdDxYRXZlbnQqPihldmVudCkpOwogI2Vsc2UKICAgICAvLyBGSVhN RTogSW1wbGVtZW50IGZvciBvdGhlciBwbGF0Zm9ybXMuCiAgICAgcmV0dXJuIDA7Cg==