48772 2010-11-01 11:47:54 -0700 Fixing a bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer 2010-12-26 08:05:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 1 inferno webkit-unassigned eric hyatt jamesr mitz simon.fraser oldest_to_newest 302818 0 inferno 2010-11-01 11:47:54 -0700 Fixing a bad assert in paintPaginatedChildLayer, hitTestPaginatedChildLayer by using the childLayer's renderer instead of this's->renderer 302843 1 inferno 2010-11-01 12:24:41 -0700 Removing the assert altogether. auto z-index case will hit it. 302846 2 72541 inferno 2010-11-01 12:31:07 -0700 Created attachment 72541 Patch 320595 3 eric 2010-12-10 22:18:22 -0800 @hyatt: ping? 326770 4 eric 2010-12-24 17:03:03 -0800 The assert definitely looks bogus. But maybe Hyatt intended columns to be ignored when boxes were positioned or something? 326790 5 inferno 2010-12-24 18:17:00 -0800 (In reply to comment #4) > The assert definitely looks bogus. But maybe Hyatt intended columns to be ignored when boxes were positioned or something? Dave had said ok on this to remove the assert on irc some time back. I forgot to follow up with him to gave a r+. 326885 6 72541 inferno 2010-12-26 08:05:13 -0800 Comment on attachment 72541 Patch Clearing flags on attachment: 72541 Committed r74666: <http://trac.webkit.org/changeset/74666> 326886 7 inferno 2010-12-26 08:05:18 -0800 All reviewed patches have been landed. Closing bug. 72541 2010-11-01 12:31:07 -0700 2010-12-26 08:05:13 -0800 Patch bug-48772-20101101123105.patch text/plain 4362 inferno SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTA0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTEtMDEgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgdGhlIGJhZCBhc3NlcnQgaW4gcGFpbnRQYWdpbmF0ZWRDaGlsZExheWVyLCBoaXRU ZXN0UGFnaW5hdGVkQ2hpbGRMYXllci4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00ODc3MgorCisgICAgICAgIFRlc3Q6IGZhc3QvbXVsdGljb2wvcmVu ZGVyZXItcG9zaXRpb25lZC1hc3NlcnQtY3Jhc2guaHRtbAorCisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpwYWludFBh Z2luYXRlZENoaWxkTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OmhpdFRl c3RQYWdpbmF0ZWRDaGlsZExheWVyKToKKwogMjAxMC0xMS0wMSAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJ bmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAkocmV2aXNpb24gNzA3OTYpCisrKyBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI1NDYsMTIg KzI1NDYsMTEgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMaXN0KFZlY3RvcjxSZW5kZQogfQog CiB2b2lkIFJlbmRlckxheWVyOjpwYWludFBhZ2luYXRlZENoaWxkTGF5ZXIoUmVuZGVyTGF5ZXIq IGNoaWxkTGF5ZXIsIFJlbmRlckxheWVyKiByb290TGF5ZXIsIEdyYXBoaWNzQ29udGV4dCogY29u dGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IEludFJlY3QmIHBhaW50RGlydHlSZWN0LCBQYWludEJlaGF2aW9yIHBhaW50QmVoYXZpb3IsCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSZW5kZXJPYmplY3Qq IHBhaW50aW5nUm9vdCwgT3ZlcmxhcFRlc3RSZXF1ZXN0TWFwKiBvdmVybGFwVGVzdFJlcXVlc3Rz LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUGFpbnRMYXll ckZsYWdzIHBhaW50RmxhZ3MpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3QgSW50UmVjdCYgcGFpbnREaXJ0eVJlY3QsIFBhaW50QmVoYXZpb3IgcGFpbnRC ZWhhdmlvciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBSZW5k ZXJPYmplY3QqIHBhaW50aW5nUm9vdCwgT3ZlcmxhcFRlc3RSZXF1ZXN0TWFwKiBvdmVybGFwVGVz dFJlcXVlc3RzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBh aW50TGF5ZXJGbGFncyBwYWludEZsYWdzKQogewogICAgIC8vIFdlIG5lZWQgdG8gZG8gbXVsdGlw bGUgcGFzc2VzLCBicmVha2luZyB1cCBvdXIgY2hpbGQgbGF5ZXIgaW50byBzdHJpcHMuCi0gICAg QVNTRVJUKCFyZW5kZXJlcigpLT5pc1Bvc2l0aW9uZWQoKSk7CiAgICAgVmVjdG9yPFJlbmRlckxh eWVyKj4gY29sdW1uTGF5ZXJzOwogICAgIFJlbmRlckxheWVyKiBhbmNlc3RvckxheWVyID0gaXNO b3JtYWxGbG93T25seSgpID8gcGFyZW50KCkgOiBzdGFja2luZ0NvbnRleHQoKTsKICAgICBmb3Ig KFJlbmRlckxheWVyKiBjdXJyID0gY2hpbGRMYXllci0+cGFyZW50KCk7IGN1cnI7IGN1cnIgPSBj dXJyLT5wYXJlbnQoKSkgewpAQCAtMzAxOCw3ICszMDE3LDYgQEAgUmVuZGVyTGF5ZXIqIFJlbmRl ckxheWVyOjpoaXRUZXN0TGlzdChWZQogUmVuZGVyTGF5ZXIqIFJlbmRlckxheWVyOjpoaXRUZXN0 UGFnaW5hdGVkQ2hpbGRMYXllcihSZW5kZXJMYXllciogY2hpbGRMYXllciwgUmVuZGVyTGF5ZXIq IHJvb3RMYXllciwgY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQm IHJlc3VsdCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3QgSW50UmVjdCYgaGl0VGVzdFJlY3QsIGNvbnN0IEludFBvaW50JiBoaXRUZXN0 UG9pbnQsIGNvbnN0IEhpdFRlc3RpbmdUcmFuc2Zvcm1TdGF0ZSogdHJhbnNmb3JtU3RhdGUsIGRv dWJsZSogek9mZnNldCkKIHsKLSAgICBBU1NFUlQoIXJlbmRlcmVyKCktPmlzUG9zaXRpb25lZCgp KTsKICAgICBWZWN0b3I8UmVuZGVyTGF5ZXIqPiBjb2x1bW5MYXllcnM7CiAgICAgUmVuZGVyTGF5 ZXIqIGFuY2VzdG9yTGF5ZXIgPSBpc05vcm1hbEZsb3dPbmx5KCkgPyBwYXJlbnQoKSA6IHN0YWNr aW5nQ29udGV4dCgpOwogICAgIGZvciAoUmVuZGVyTGF5ZXIqIGN1cnIgPSBjaGlsZExheWVyLT5w YXJlbnQoKTsgY3VycjsgY3VyciA9IGN1cnItPnBhcmVudCgpKSB7CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biA3MTA0MikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEwLTExLTAxICBBYmhpc2hlayBBcnlhICA8aW5mZXJub0BjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVz dHMgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg3NzIKKworICAgICAgICAqIGZhc3QvbXVsdGljb2wv cmVuZGVyZXItcG9zaXRpb25lZC1hc3NlcnQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L211bHRpY29sL3JlbmRlcmVyLXBvc2l0aW9uZWQtYXNzZXJ0LWNyYXNoLmh0 bWw6IEFkZGVkLgorCiAyMDEwLTExLTAxICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L211bHRpY29sL3JlbmRlcmVyLXBvc2l0aW9uZWQtYXNzZXJ0LWNyYXNoLWV4cGVj dGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL3JlbmRlcmVy LXBvc2l0aW9uZWQtYXNzZXJ0LWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvcmVuZGVyZXItcG9zaXRpb25lZC1hc3NlcnQtY3Jhc2gt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitQQVNTCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L211bHRpY29sL3JlbmRlcmVyLXBvc2l0aW9uZWQtYXNzZXJ0LWNyYXNoLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9yZW5kZXJlci1wb3Np dGlvbmVkLWFzc2VydC1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFz dC9tdWx0aWNvbC9yZW5kZXJlci1wb3NpdGlvbmVkLWFzc2VydC1jcmFzaC5odG1sCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDE3IEBACis8aHRtbD4NCisgICAgPHNjcmlwdD4NCisgICAgICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpDQorICAgICAgICAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOw0KKyAgICA8L3NjcmlwdD4NCisgICAgPHN0eWxlPg0KKyAg ICAgICAgLmJveA0KKyAgICAgICAgew0KKyAgICAgICAgICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsN CisgICAgICAgICAgICAtd2Via2l0LWNvbHVtbnM6IDFweDsNCisgICAgICAgIH0NCisgICAgPC9z dHlsZT4NCisgICAgPGRpdiBjbGFzcz0iYm94Ij4NCisgICAgICAgIFBBU1MNCisgICAgICAgIDx2 aWRlbz4NCisgICAgPC9kaXY+DQorPC9odG1sPg0K