48767 2010-11-01 11:00:22 -0700 [Qt] QtTestBrowser : set mmp rule pageddata in Symbian 2010-11-08 08:40:31 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Normal --- 47918 1 dinu.jacob george.guo ademar commit-queue george.guo suresh.voruganti oldest_to_newest 302786 0 dinu.jacob 2010-11-01 11:00:22 -0700 QtTestBrowser runs out of memory with most of javascript benchmarks (for example, Dromaeo ). On Symbian it improves memory consumption when pageddata is enabled. 302801 1 george.guo 2010-11-01 11:26:29 -0700 agreed with Dinu to fix this. 303350 2 72663 george.guo 2010-11-02 07:23:14 -0700 Created attachment 72663 adding paged memory will resolve this issue 303370 3 72663 kling 2010-11-02 08:29:16 -0700 Comment on attachment 72663 adding paged memory will resolve this issue View in context: https://bugs.webkit.org/attachment.cgi?id=72663&action=review > WebKitTools/ChangeLog:5 > + [Qt] QtTestBrowser : set mmp rule pageddata in Symbian This ChangeLog entry only covers the "What?" - we also need the "Why?" Why is this change needed? 303675 4 george.guo 2010-11-02 14:36:23 -0700 Paing is needed on Symbian devices to support benchmarks test like dromaeo.com and Celtic Kane that need a lot of memory to run. 303699 5 72744 george.guo 2010-11-02 14:58:21 -0700 Created attachment 72744 Added why to the patch in addtion to what as reviewer suggested Made changes to answer why as reviewer suggested. 303924 6 72744 kling 2010-11-03 01:19:49 -0700 Comment on attachment 72744 Added why to the patch in addtion to what as reviewer suggested LGTM 303926 7 72744 commit-queue 2010-11-03 01:22:23 -0700 Comment on attachment 72744 Added why to the patch in addtion to what as reviewer suggested Rejecting patch 72744 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72744]" exit_code: 2 Last 500 characters of output: rom bug 48767. Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Parsed 2 diffs from patch file(s). patching file WebKitTools/ChangeLog patch: **** malformed patch at line 18: 2010-11-01 Jenn Braithwaite <jennb@chromium.org> patching file WebKitTools/QtTestBrowser/QtTestBrowser.pro Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 2 Full output: http://queues.webkit.org/results/5036015 303980 8 george.guo 2010-11-03 04:46:04 -0700 Thanks for the patience, i'm fixing the format and preparing the patch 303985 9 72814 george.guo 2010-11-03 05:32:58 -0700 Created attachment 72814 Not sure why last patch failed in commit. Remake a patch 303986 10 72814 kling 2010-11-03 05:39:53 -0700 Comment on attachment 72814 Not sure why last patch failed in commit. Remake a patch Let's try again. In the future, please tick the "patch" checkbox when uploading patches :) 303990 11 suresh.voruganti 2010-11-03 05:49:47 -0700 This patch is required for Qtwebkit 2.1 for increasing Browser stability, so adding dependency to 39121. 304458 12 72814 commit-queue 2010-11-03 20:40:22 -0700 Comment on attachment 72814 Not sure why last patch failed in commit. Remake a patch Clearing flags on attachment: 72814 Committed r71302: <http://trac.webkit.org/changeset/71302> 304459 13 commit-queue 2010-11-03 20:40:28 -0700 All reviewed patches have been landed. Closing bug. 304699 14 ademar 2010-11-04 09:20:21 -0700 Revision r71302 cherry-picked into qtwebkit-2.1 with commit 68f99d0 <http://gitorious.org/webkit/qtwebkit/commit/68f99d0> 72663 2010-11-02 07:23:14 -0700 2010-11-02 14:58:21 -0700 adding paged memory will resolve this issue 48767.patch text/plain 998 george.guo SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMTEyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMDIgIEdlb3JnZSBHdW8gIDxnZW9y Z2UuZ3VvQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIFF0VGVzdEJyb3dzZXIgOiBzZXQgbW1wIHJ1bGUgcGFnZWRkYXRhIGlu IFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4NzY3CisKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJvOgorCiAy MDEwLTExLTAxICBKZW5uIEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJLaXRUb29scy9RdFRlc3RCcm93 c2VyL1F0VGVzdEJyb3dzZXIucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1F0VGVzdEJy b3dzZXIvUXRUZXN0QnJvd3Nlci5wcm8JKHJldmlzaW9uIDcxMTEyKQorKysgV2ViS2l0VG9vbHMv UXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93c2VyLnBybwkod29ya2luZyBjb3B5KQpAQCAtNDksNiAr NDksNyBAQCBsaW51eC0qIHsKIHN5bWJpYW4gewogICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTU0 MwogICAgIFRBUkdFVC5DQVBBQklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0 d29ya1NlcnZpY2VzIExvY2F0aW9uCisgICAgTU1QX1JVTEVTICo9IHBhZ2VkZGF0YQogfQogCiBj b250YWlucyhRVF9DT05GSUcsIG9wZW5nbCkgewo= 72744 2010-11-02 14:58:21 -0700 2010-11-03 05:32:58 -0700 Added why to the patch in addtion to what as reviewer suggested 48767.patch text/plain 1157 george.guo SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMTEyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTEtMDIgIEdlb3JnZSBHdW8gIDxnZW9y Z2UuZ3VvQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIFF0VGVzdEJyb3dzZXIgOiBzZXQgbW1wIHJ1bGUgcGFnZWRkYXRhIGlu IFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4NzY3CisgICAgICAgIAorICAgICAgICBQYWdpbmcgaXMgbmVlZGVkIG9uIFN5bWJpYW4gZGV2 aWNlcyB0byBzdXBwb3J0IGJlbmNobWFya3MgdGVzdHMgbGlrZSAKKyAgICAgICAgZHJvbWFlby5j b20gYW5kIENlbHRpYyBLYW5lIHRoYXQgbmVlZCBhIGxvdCBvZiBtZW1vcnkgdG8gcnVuCisKKyAg ICAgICAgKiBRdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJvOgorCiAyMDEwLTExLTAxICBK ZW5uIEJyYWl0aHdhaXRlICA8amVubmJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL1F0VGVzdEJy b3dzZXIucHJvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0 QnJvd3Nlci5wcm8JKHJldmlzaW9uIDcxMTEyKQorKysgV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nl ci9RdFRlc3RCcm93c2VyLnBybwkod29ya2luZyBjb3B5KQpAQCAtNDksNiArNDksNyBAQCBsaW51 eC0qIHsKIHN5bWJpYW4gewogICAgIFRBUkdFVC5VSUQzID0gMHhBMDAwRTU0MwogICAgIFRBUkdF VC5DQVBBQklMSVRZID0gUmVhZFVzZXJEYXRhIFdyaXRlVXNlckRhdGEgTmV0d29ya1NlcnZpY2Vz IExvY2F0aW9uCisgICAgTU1QX1JVTEVTICo9IHBhZ2VkZGF0YQogfQogCiBjb250YWlucyhRVF9D T05GSUcsIG9wZW5nbCkgewo= 72814 2010-11-03 05:32:58 -0700 2010-11-03 20:40:22 -0700 Not sure why last patch failed in commit. Remake a patch 48767.patch text/plain 1153 george.guo SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcxMjMyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTEtMDMgIEdlb3JnZSBHdW8gIDxHZW9y Z2UuR3VvQE5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbUXRdIFF0VGVzdEJyb3dzZXIgOiBzZXQgbW1wIHJ1bGUgcGFnZWRkYXRhIGlu IFN5bWJpYW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4NzY3CisgICAgCisgICAgICAgIFBhZ2luZyBpcyBuZWVkZCBvbiBTeW1iaWFuIGRldmljZXMg dG8gc3VwcG9ydCBiZW5jaG1hcmtzIHRlc3RzIGxpa2UKKyAgICAgICAgZHJvbWFlby5jb20gYW5k IENlbHRpYyBLYW5lIHRoYXQgbmVlZCBhIGxvdCBvZiBtZW1vcnkgdG8gcnVuICAKKworICAgICAg ICAqIFF0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5wcm86CisKIDIwMTAtMTEtMDMgIEtlbnQg VGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0 cmkgR2xhemtvdi4KSW5kZXg6IFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nl ci5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93 c2VyLnBybwkocmV2aXNpb24gNzEyMjMpCisrKyBXZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL1F0 VGVzdEJyb3dzZXIucHJvCSh3b3JraW5nIGNvcHkpCkBAIC00OSw2ICs0OSw3IEBAIGxpbnV4LSog ewogc3ltYmlhbiB7CiAgICAgVEFSR0VULlVJRDMgPSAweEEwMDBFNTQzCiAgICAgVEFSR0VULkNB UEFCSUxJVFkgPSBSZWFkVXNlckRhdGEgV3JpdGVVc2VyRGF0YSBOZXR3b3JrU2VydmljZXMgTG9j YXRpb24KKyAgICBNTVBfUlVMRVMgKj0gcGFnZWRkYXRhCiB9CiAKIGNvbnRhaW5zKFFUX0NPTkZJ Rywgb3BlbmdsKSB7Cg==