48764 2010-11-01 09:44:30 -0700 [Qt] Need to implement WebKit::pluginWillHandleLoadError for WebKit2 2010-11-12 13:11:39 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Normal --- 1 aroben webkit-unassigned benjamin commit-queue kling oldest_to_newest 302748 0 aroben 2010-11-01 09:44:30 -0700 WebErrorsQt.cpp needs an implementation of pluginWillHandleLoadError. See bug 48561. 308524 1 73737 benjamin 2010-11-12 07:09:42 -0800 Created attachment 73737 Add the missing error. Untested (I don't have phonon). 308592 2 73737 kling 2010-11-12 09:21:41 -0800 Comment on attachment 73737 Add the missing error. r=me 308594 3 73737 commit-queue 2010-11-12 09:25:10 -0800 Comment on attachment 73737 Add the missing error. Rejecting patch 73737 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 73737]" exit_code: 2 Last 500 characters of output: s Kling', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file WebKit/qt/ChangeLog patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp patching file WebKit2/ChangeLog Hunk #1 FAILED at 1. 1 out of 1 hunk FAILED -- saving rejects to file WebKit2/ChangeLog.rej patching file WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/5774027 308725 4 benjamin 2010-11-12 13:08:32 -0800 Committed r71938: <http://trac.webkit.org/changeset/71938> 308726 5 benjamin 2010-11-12 13:11:39 -0800 Damn, commit-log-editor failed me over the commit message. :( Sorry about that. 73737 2010-11-12 07:09:42 -0800 2010-11-12 09:25:10 -0800 Add the missing error. 48764.diff text/plain 4268 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGNhOTk0MmMuLjlkZWZiNGEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTExLTEyICBCZW5q YW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBOZWVkIHRvIGltcGxlbWVu dCBXZWJLaXQ6OnBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IgZm9yIFdlYktpdDIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NzY0CisKKyAgICAgICAg QWRkIHRoZSBtaXNzaW5nIGVycm9yLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRnJhbWVM b2FkZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudFF0 OjpwbHVnaW5XaWxsSGFuZGxlTG9hZEVycm9yKToKKwogMjAxMC0xMS0xMSAgWWkgU2hlbiAgPHlp LjQuc2hlbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4K ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0 LmNwcCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcApp bmRleCBjMjRhODdmLi41YzYzNjRlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0 L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCkBAIC04OTYsNiArODk2LDcgQEAgZW51bSB7CiAgICAg V2ViS2l0RXJyb3JDYW5ub3RGaW5kUGx1Z0luID0gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgMjAwLAogICAgIFdlYktpdEVycm9yQ2Fubm90TG9hZFBsdWdJbiA9ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIDIwMSwKICAgICBXZWJLaXRFcnJvckphdmFVbmF2YWlsYWJsZSA9ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAyMDIsCisgICAgV2ViS2l0RXJyb3JQbHVnaW5X aWxsSGFuZGxlTG9hZCA9ICAgICAgICAgICAgICAgICAgICAgICAgICAgMjAzCiB9OwogCiBXZWJD b3JlOjpSZXNvdXJjZUVycm9yIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmJsb2NrZWRFcnJvcihjb25z dCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCkBAIC05MjksMTAgKzkzMCwxMCBA QCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmZpbGVEb2VzTm90 RXhpc3RFcnJvcihjb25zdCBXZWJDb3JlOgogICAgICAgICAgICAgUUNvcmVBcHBsaWNhdGlvbjo6 dHJhbnNsYXRlKCJRV2ViRnJhbWUiLCAiRmlsZSBkb2VzIG5vdCBleGlzdCIsIDAsIFFDb3JlQXBw bGljYXRpb246OlVuaWNvZGVVVEY4KSk7CiB9CiAKLVdlYkNvcmU6OlJlc291cmNlRXJyb3IgRnJh bWVMb2FkZXJDbGllbnRRdDo6cGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihjb25zdCBXZWJDb3Jl OjpSZXNvdXJjZVJlc3BvbnNlJikKK1dlYkNvcmU6OlJlc291cmNlRXJyb3IgRnJhbWVMb2FkZXJD bGllbnRRdDo6cGx1Z2luV2lsbEhhbmRsZUxvYWRFcnJvcihjb25zdCBXZWJDb3JlOjpSZXNvdXJj ZVJlc3BvbnNlJiByZXNwb25zZSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVy biBSZXNvdXJjZUVycm9yKCk7CisgICAgcmV0dXJuIFJlc291cmNlRXJyb3IoIldlYktpdCIsIFdl YktpdEVycm9yUGx1Z2luV2lsbEhhbmRsZUxvYWQsIHJlc3BvbnNlLnVybCgpLnN0cmluZygpLAor ICAgICAgICAgICAgICAgICAgICAgICAgIFFDb3JlQXBwbGljYXRpb246OnRyYW5zbGF0ZSgiUVdl YkZyYW1lIiwgIkxvYWRpbmcgaXMgaGFuZGxlZCBieSB0aGUgbWVkaWEgZW5naW5lIiwgMCwgUUNv cmVBcHBsaWNhdGlvbjo6VW5pY29kZVVURjgpKTsKIH0KIAogYm9vbCBGcmFtZUxvYWRlckNsaWVu dFF0OjpzaG91bGRGYWxsQmFjayhjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJikKZGlmZiAt LWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMTdlNTc1 Yi4uMmI5NjdkYSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0Mi9D aGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAorMjAxMC0xMS0xMiAgQmVuamFtaW4gUG91bGFpbiAg PGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTmVlZCB0byBpbXBsZW1lbnQgV2ViS2l0OjpwbHVn aW5XaWxsSGFuZGxlTG9hZEVycm9yIGZvciBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODc2NAorCisgICAgICAgIEFkZCB0aGUgbWlzc2lu ZyBlcnJvciB0byBRdCBzdXBwb3J0LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9xdC9XZWJFcnJvcnNRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBsdWdpbldpbGxIYW5k bGVMb2FkRXJyb3IpOgorCiAyMDEwLTExLTEyICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4u cG91bGFpbkBub2tpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBmaXggYWZ0ZXIgcjcxODU3 LgogCiAgICAgICAgICogVUlQcm9jZXNzL3F0L1dlYkluc3BlY3RvclByb3h5UXQuY3BwOgpkaWZm IC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L3F0L1dlYkVycm9yc1F0 LmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9xdC9XZWJFcnJvcnNRdC5j cHAKaW5kZXggYzFkMzQwZS4uY2VlNjg0MiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYkNvcmVTdXBwb3J0L3F0L1dlYkVycm9yc1F0LmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvcXQvV2ViRXJyb3JzUXQuY3BwCkBAIC0yNiw3ICsyNiw2IEBACiAK ICNpbmNsdWRlICJXZWJFcnJvcnMuaCIKIAotI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAj aW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlcXVlc3QuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jl c291cmNlUmVzcG9uc2UuaD4KIApAQCAtNDYsNiArNDUsNyBAQCBlbnVtIHsKICAgICBXZWJLaXRF cnJvckNhbm5vdEZpbmRQbHVnSW4gPSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAyMDAs CiAgICAgV2ViS2l0RXJyb3JDYW5ub3RMb2FkUGx1Z0luID0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgMjAxLAogICAgIFdlYktpdEVycm9ySmF2YVVuYXZhaWxhYmxlID0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIDIwMiwKKyAgICBXZWJLaXRFcnJvclBsdWdpbldpbGxIYW5k bGVMb2FkID0gICAgICAgICAgICAgICAgICAgICAgICAgICAyMDMKIH07CiAKIFJlc291cmNlRXJy b3IgY2FuY2VsbGVkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0KQpAQCAtODYs MTAgKzg2LDEwIEBAIFJlc291cmNlRXJyb3IgZmlsZURvZXNOb3RFeGlzdEVycm9yKGNvbnN0IFJl c291cmNlUmVzcG9uc2UmIHJlc3BvbnNlKQogICAgICAgICAgICAgICAgICAgICAgICAgIFFDb3Jl QXBwbGljYXRpb246OnRyYW5zbGF0ZSgiUVdlYkZyYW1lIiwgIkZpbGUgZG9lcyBub3QgZXhpc3Qi LCAwLCBRQ29yZUFwcGxpY2F0aW9uOjpVbmljb2RlVVRGOCkpOwogfQogCi1SZXNvdXJjZUVycm9y IHBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpCitSZXNv dXJjZUVycm9yIHBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3QgUmVzb3VyY2VSZXNwb25z ZSYgcmVzcG9uc2UpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gUmVzb3Vy Y2VFcnJvcigpOworICAgIHJldHVybiBSZXNvdXJjZUVycm9yKCJXZWJLaXQiLCBXZWJLaXRFcnJv clBsdWdpbldpbGxIYW5kbGVMb2FkLCByZXNwb25zZS51cmwoKS5zdHJpbmcoKSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICBRQ29yZUFwcGxpY2F0aW9uOjp0cmFuc2xhdGUoIlFXZWJGcmFtZSIs ICJMb2FkaW5nIGlzIGhhbmRsZWQgYnkgdGhlIG1lZGlhIGVuZ2luZSIsIDAsIFFDb3JlQXBwbGlj YXRpb246OlVuaWNvZGVVVEY4KSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=