<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>48760</bug_id>
          
          <creation_ts>2010-11-01 08:33:46 -0700</creation_ts>
          <short_desc>Web Inspector: highlight frame on hover in resources panel.</short_desc>
          <delta_ts>2010-11-02 03:25:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pavel Feldman">pfeldman</reporter>
          <assigned_to name="Pavel Feldman">pfeldman</assigned_to>
          <cc>apavlov</cc>
    
    <cc>bweinstein</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>rik</cc>
    
    <cc>timothy</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>302706</commentid>
    <comment_count>0</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2010-11-01 08:33:46 -0700</bug_when>
    <thetext>When I hover over a frame element in the new resources panel, I&apos;d like to see it highlighted in the UI (i.e. its owner element is highlighted).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>302710</commentid>
    <comment_count>1</comment_count>
      <attachid>72509</attachid>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2010-11-01 08:39:31 -0700</bug_when>
    <thetext>Created attachment 72509
[PATCH] Proposed change.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>302973</commentid>
    <comment_count>2</comment_count>
      <attachid>72509</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2010-11-01 15:05:13 -0700</bug_when>
    <thetext>Comment on attachment 72509
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=72509&amp;action=review

r+ with comments and a question about the early return in _onmouseout.

&gt; WebCore/ChangeLog:18
&gt; +        (WebInspector.StoragePanel.prototype._treeElementFromEvent):

Nit: remove if the method gets removed.

&gt; WebCore/inspector/InspectorController.cpp:307
&gt; +    for (Frame* frame = m_inspectedPage-&gt;mainFrame(); frame; frame = frame-&gt;tree()-&gt;traverseNext(m_inspectedPage-&gt;mainFrame())) {

I&apos;d feel better if &quot;m_inspectedPage-&gt;mainFrame()&quot; was cached in a local variable. I never know when the calls are optimized out or not, and it might make readability easier here.

&gt; WebCore/inspector/front-end/StoragePanel.js:726
&gt; +        if (!nodeUnderMouse)
&gt; +            return;
&gt; +        var listNode = nodeUnderMouse.enclosingNodeOrSelfWithNodeName(&quot;li&quot;);

Nit: Adding a newline after the return would be nice.

&gt; WebCore/inspector/front-end/StoragePanel.js:749
&gt; +    _onmouseout: function(event)
&gt; +    {
&gt; +        var nodeUnderMouse = document.elementFromPoint(event.pageX, event.pageY);
&gt; +        if (nodeUnderMouse &amp;&amp; nodeUnderMouse.isDescendant(this.sidebarElement))
&gt; +            return;

In what cases does mouseout still have a node that is a descendant of the sidebar element? Is this like moving your mouse of the left edge of an undocked inspector?

&gt; WebCore/inspector/front-end/StoragePanel.js:757
&gt; +    _treeElementFromEvent: function(event)

Can be removed. Don&apos;t forget to remove from the ChangeLog as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>303291</commentid>
    <comment_count>3</comment_count>
    <who name="Pavel Feldman">pfeldman</who>
    <bug_when>2010-11-02 03:25:33 -0700</bug_when>
    <thetext>Landed as r71104.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>72509</attachid>
            <date>2010-11-01 08:39:31 -0700</date>
            <delta_ts>2010-11-01 15:05:12 -0700</delta_ts>
            <desc>[PATCH] Proposed change.</desc>
            <filename>hover_frame</filename>
            <type>text/plain</type>
            <size>8183</size>
            <attacher name="Pavel Feldman">pfeldman</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NmZiNDk5NC4uNjdjYmEwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzMiBAQAogMjAxMC0xMS0wMSAgUGF2ZWwgRmVsZG1h
biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBoaWdobGlnaHQgZnJhbWUgb24gaG92
ZXIgaW4gcmVzb3VyY2VzIHBhbmVsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9NDg3NjAKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3IuaWRs
OgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OmhpZ2hsaWdodEZyYW1lKToKKyAgICAgICAg
KiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oOgorICAgICAgICAoV2ViQ29yZTo6SW5z
cGVjdG9yQ29udHJvbGxlcjo6aGlkZUZyYW1lSGlnaGxpZ2h0KToKKyAgICAgICAgKiBpbnNwZWN0
b3IvZnJvbnQtZW5kL1N0b3JhZ2VQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9y
YWdlUGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUu
c2hvd1ZpZXcpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUu
X29ubW91c2Vtb3ZlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwucHJvdG90
eXBlLl9vbm1vdXNlb3V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwucHJv
dG90eXBlLl90cmVlRWxlbWVudEZyb21FdmVudCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRnJh
bWVUcmVlRWxlbWVudC5wcm90b3R5cGUub25zZWxlY3QpOgorICAgICAgICAoV2ViSW5zcGVjdG9y
LkZyYW1lVHJlZUVsZW1lbnQucHJvdG90eXBlLm9uZGVzZWxlY3QpOgorICAgICAgICAoV2ViSW5z
cGVjdG9yLkZyYW1lVHJlZUVsZW1lbnQucHJvdG90eXBlLnNldCBkaXNwbGF5TmFtZSk6CisgICAg
ICAgIChXZWJJbnNwZWN0b3IuRnJhbWVUcmVlRWxlbWVudC5wcm90b3R5cGUuc2V0IGhvdmVyZWQp
OgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmNzczoKKyAgICAgICAg
KC5zdG9yYWdlLnBhbmVsIC5zaWRlYmFyIGxpLnNlbGVjdGVkIC5zZWxlY3Rpb24pOgorICAgICAg
ICAoLnN0b3JhZ2UucGFuZWwgLnNpZGViYXIgOmZvY3VzIGxpLnNlbGVjdGVkIC5zZWxlY3Rpb24p
OgorICAgICAgICAoYm9keS5pbmFjdGl2ZSAuc3RvcmFnZS5wYW5lbCAuc2lkZWJhciBsaS5zZWxl
Y3RlZCAuc2VsZWN0aW9uKToKKworMjAxMC0xMS0wMSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFu
QGNocm9taXVtLm9yZz4KKwogICAgICAgICBOb3QgcmV2aWV3ZWQ6IHNpbXBsaWZ5IGluc3BlY3Rv
ciBzdHlsZXMgdGVzdCB0byBtYWtlIGFsbCBib3RzIGhhcHB5LgogICAgICAgICAoZHJpdmUtYnkg
Zml4IGZvciBvdmVycmlkZW4gaW5zcGVjdG9yIHN0eWxlcyBpbiBuZXR3b3JrIHBhbmVsKS4KIApk
aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmlkbCBiL1dlYkNvcmUvaW5z
cGVjdG9yL0luc3BlY3Rvci5pZGwKaW5kZXggZTZlMGE3Zi4uZmExYjM4YiAxMDA2NDQKLS0tIGEv
V2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yLmlkbAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9J
bnNwZWN0b3IuaWRsCkBAIC0xOTYsNiArMTk2LDkgQEAgbW9kdWxlIGNvcmUgewogICAgICAgICBb
aGFuZGxlcj1Db250cm9sbGVyXSB2b2lkIGhpZGVET01Ob2RlSGlnaGxpZ2h0KCk7CiAgICAgICAg
IFtoYW5kbGVyPUNvbnRyb2xsZXJdIHZvaWQgb3BlbkluSW5zcGVjdGVkV2luZG93KGluIFN0cmlu
ZyB1cmwpOwogCisgICAgICAgIFtoYW5kbGVyPUNvbnRyb2xsZXJdIHZvaWQgaGlnaGxpZ2h0RnJh
bWUoaW4gdW5zaWduZWQgbG9uZyBmcmFtZUlkKTsKKyAgICAgICAgW2hhbmRsZXI9Q29udHJvbGxl
cl0gdm9pZCBoaWRlRnJhbWVIaWdobGlnaHQoKTsKKwogICAgICAgICBbaGFuZGxlcj1ET01dIHZv
aWQgZ2V0U3R5bGVzKGluIGxvbmcgbm9kZUlkLCBpbiBib29sZWFuIGF1dGhPbmx5LCBvdXQgVmFs
dWUgc3R5bGVzKTsKICAgICAgICAgW2hhbmRsZXI9RE9NXSB2b2lkIGdldEFsbFN0eWxlcyhvdXQg
QXJyYXkgc3R5bGVzKTsKICAgICAgICAgW2hhbmRsZXI9RE9NXSB2b2lkIGdldElubGluZVN0eWxl
KGluIGxvbmcgbm9kZUlkLCBvdXQgVmFsdWUgc3R5bGUpOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9p
bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNw
ZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCAxYmIzOTE5Li5lNDA3ODNkIDEwMDY0NAotLS0gYS9X
ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2lu
c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcApAQCAtMzAyLDYgKzMwMiwxNiBAQCB2b2lk
IEluc3BlY3RvckNvbnRyb2xsZXI6OmhpZ2hsaWdodERPTU5vZGUobG9uZyBub2RlSWQpCiAgICAg
ICAgIGhpZ2hsaWdodChub2RlKTsKIH0KIAordm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpoaWdo
bGlnaHRGcmFtZSh1bnNpZ25lZCBsb25nIGZyYW1lSWQpCit7CisgICAgZm9yIChGcmFtZSogZnJh
bWUgPSBtX2luc3BlY3RlZFBhZ2UtPm1haW5GcmFtZSgpOyBmcmFtZTsgZnJhbWUgPSBmcmFtZS0+
dHJlZSgpLT50cmF2ZXJzZU5leHQobV9pbnNwZWN0ZWRQYWdlLT5tYWluRnJhbWUoKSkpIHsKKyAg
ICAgICAgaWYgKHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90PihmcmFtZSkgPT0gZnJhbWVJZCAm
JiBmcmFtZS0+b3duZXJFbGVtZW50KCkpIHsKKyAgICAgICAgICAgIGhpZ2hsaWdodChmcmFtZS0+
b3duZXJFbGVtZW50KCkpOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisgICAgfQor
fQorCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OmhpZGVIaWdobGlnaHQoKQogewogICAgIGlm
ICghZW5hYmxlZCgpKQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29u
dHJvbGxlci5oIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCmluZGV4
IDY0MDk4N2IuLjFiNjY4Y2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv
ckNvbnRyb2xsZXIuaAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy
LmgKQEAgLTE0Miw2ICsxNDIsOSBAQCBwdWJsaWM6CiAgICAgdm9pZCBoaWdobGlnaHRET01Ob2Rl
KGxvbmcgbm9kZUlkKTsKICAgICB2b2lkIGhpZGVET01Ob2RlSGlnaGxpZ2h0KCkgeyBoaWRlSGln
aGxpZ2h0KCk7IH0KIAorICAgIHZvaWQgaGlnaGxpZ2h0RnJhbWUodW5zaWduZWQgbG9uZyBmcmFt
ZUlkKTsKKyAgICB2b2lkIGhpZGVGcmFtZUhpZ2hsaWdodCgpIHsgaGlkZUhpZ2hsaWdodCgpOyB9
CisKICAgICB2b2lkIHNob3coKTsKICAgICB2b2lkIHNob3dQYW5lbChjb25zdCBTdHJpbmcmKTsK
ICAgICB2b2lkIGNsb3NlKCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l
bmQvU3RvcmFnZVBhbmVsLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1N0b3JhZ2VQ
YW5lbC5qcwppbmRleCAwMjA1ZjBhLi43MmRlMmM5IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3Bl
Y3Rvci9mcm9udC1lbmQvU3RvcmFnZVBhbmVsLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zy
b250LWVuZC9TdG9yYWdlUGFuZWwuanMKQEAgLTc2LDYgKzc2LDkgQEAgV2ViSW5zcGVjdG9yLlN0
b3JhZ2VQYW5lbCA9IGZ1bmN0aW9uKGRhdGFiYXNlKQogICAgIHRoaXMuX2Nvb2tpZVZpZXdzID0g
e307CiAgICAgdGhpcy5fb3JpZ2lucyA9IHt9OwogICAgIHRoaXMuX2RvbWFpbnMgPSB7fTsKKwor
ICAgIHRoaXMuc2lkZWJhckVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vtb3ZlIiwgdGhp
cy5fb25tb3VzZW1vdmUuYmluZCh0aGlzKSwgZmFsc2UpOworICAgIHRoaXMuc2lkZWJhckVsZW1l
bnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdXQiLCB0aGlzLl9vbm1vdXNlb3V0LmJpbmQodGhp
cyksIGZhbHNlKTsKIH0KIAogV2ViSW5zcGVjdG9yLlN0b3JhZ2VQYW5lbC5wcm90b3R5cGUgPSB7
CkBAIC03MTMsNiArNzE2LDU0IEBAIFdlYkluc3BlY3Rvci5TdG9yYWdlUGFuZWwucHJvdG90eXBl
ID0gewogICAgIHsKICAgICAgICAgaWYgKHZpZXcpCiAgICAgICAgICAgICB0aGlzLnNob3dSZXNv
dXJjZSh2aWV3LnJlc291cmNlKTsKKyAgICB9LAorCisgICAgX29ubW91c2Vtb3ZlOiBmdW5jdGlv
bihldmVudCkKKyAgICB7CisgICAgICAgIHZhciBub2RlVW5kZXJNb3VzZSA9IGRvY3VtZW50LmVs
ZW1lbnRGcm9tUG9pbnQoZXZlbnQucGFnZVgsIGV2ZW50LnBhZ2VZKTsKKyAgICAgICAgaWYgKCFu
b2RlVW5kZXJNb3VzZSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgdmFyIGxpc3ROb2Rl
ID0gbm9kZVVuZGVyTW91c2UuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFtZSgibGkiKTsK
KyAgICAgICAgaWYgKCFsaXN0Tm9kZSkKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICB2
YXIgZWxlbWVudCA9IGxpc3ROb2RlLnRyZWVFbGVtZW50OworICAgICAgICBpZiAodGhpcy5fcHJl
dmlvdXNIb3ZlcmVkRWxlbWVudCA9PT0gZWxlbWVudCkKKyAgICAgICAgICAgIHJldHVybjsKKwor
ICAgICAgICBpZiAodGhpcy5fcHJldmlvdXNIb3ZlcmVkRWxlbWVudCkgeworICAgICAgICAgICAg
dGhpcy5fcHJldmlvdXNIb3ZlcmVkRWxlbWVudC5ob3ZlcmVkID0gZmFsc2U7CisgICAgICAgICAg
ICBkZWxldGUgdGhpcy5fcHJldmlvdXNIb3ZlcmVkRWxlbWVudDsKKyAgICAgICAgfQorCisgICAg
ICAgIGlmIChlbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkZyYW1lVHJlZUVsZW1lbnQp
IHsKKyAgICAgICAgICAgIHRoaXMuX3ByZXZpb3VzSG92ZXJlZEVsZW1lbnQgPSBlbGVtZW50Owor
ICAgICAgICAgICAgZWxlbWVudC5ob3ZlcmVkID0gdHJ1ZTsKKyAgICAgICAgfQorICAgIH0sCisK
KyAgICBfb25tb3VzZW91dDogZnVuY3Rpb24oZXZlbnQpCisgICAgeworICAgICAgICB2YXIgbm9k
ZVVuZGVyTW91c2UgPSBkb2N1bWVudC5lbGVtZW50RnJvbVBvaW50KGV2ZW50LnBhZ2VYLCBldmVu
dC5wYWdlWSk7CisgICAgICAgIGlmIChub2RlVW5kZXJNb3VzZSAmJiBub2RlVW5kZXJNb3VzZS5p
c0Rlc2NlbmRhbnQodGhpcy5zaWRlYmFyRWxlbWVudCkpCisgICAgICAgICAgICByZXR1cm47CisK
KyAgICAgICAgaWYgKHRoaXMuX3ByZXZpb3VzSG92ZXJlZEVsZW1lbnQpIHsKKyAgICAgICAgICAg
IHRoaXMuX3ByZXZpb3VzSG92ZXJlZEVsZW1lbnQuaG92ZXJlZCA9IGZhbHNlOworICAgICAgICAg
ICAgZGVsZXRlIHRoaXMuX3ByZXZpb3VzSG92ZXJlZEVsZW1lbnQ7CisgICAgICAgIH0KKyAgICB9
LAorCisgICAgX3RyZWVFbGVtZW50RnJvbUV2ZW50OiBmdW5jdGlvbihldmVudCkKKyAgICB7Cisg
ICAgICAgIHZhciByb290ID0gdGhpcy5zaWRlYmFyRWxlbWVudDsKKworICAgICAgICAvLyBXZSBj
aG9vc2UgdGhpcyBYIGNvb3JkaW5hdGUgYmFzZWQgb24gdGhlIGtub3dsZWRnZSB0aGF0IG91ciBs
aXN0CisgICAgICAgIC8vIGl0ZW1zIGV4dGVuZCBuZWFybHkgdG8gdGhlIHJpZ2h0IGVkZ2Ugb2Yg
dGhlIG91dGVyIDxvbD4uCisgICAgICAgIHZhciB4ID0gcm9vdC50b3RhbE9mZnNldExlZnQgKyBy
b290Lm9mZnNldFdpZHRoIC0gMjA7CisgICAgICAgIHZhciB5ID0gZXZlbnQucGFnZVk7CisKKyAg
ICAgICAgcmV0dXJuIHRoaXMuc2lkZWJhclRyZWUudHJlZUVsZW1lbnRGcm9tUG9pbnQoeCwgeSk7
CiAgICAgfQogfQogCkBAIC04MzQsNiArODg1LDE0IEBAIFdlYkluc3BlY3Rvci5GcmFtZVRyZWVF
bGVtZW50LnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5CYXNlU3Rv
cmFnZVRyZWVFbGVtZW50LnByb3RvdHlwZS5vbnNlbGVjdC5jYWxsKHRoaXMpOwogICAgICAgICB0
aGlzLl9zdG9yYWdlUGFuZWwuc2hvd0NhdGVnb3J5Vmlldyh0aGlzLl9kaXNwbGF5TmFtZSk7CisK
KyAgICAgICAgdGhpcy5saXN0SXRlbUVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygiaG92ZXJlZCIp
OworICAgICAgICBJbnNwZWN0b3JCYWNrZW5kLmhpZGVGcmFtZUhpZ2hsaWdodCgpOworICAgIH0s
CisKKyAgICBvbmRlc2VsZWN0OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBJbnNwZWN0b3JC
YWNrZW5kLmhpZGVGcmFtZUhpZ2hsaWdodCgpOwogICAgIH0sCiAKICAgICBnZXQgZGlzcGxheU5h
bWUoKQpAQCAtODQ1LDYgKzkwNCwxNyBAQCBXZWJJbnNwZWN0b3IuRnJhbWVUcmVlRWxlbWVudC5w
cm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICB0aGlzLl9kaXNwbGF5TmFtZSA9IGRpc3BsYXlO
YW1lOwogICAgICAgICB0aGlzLnRpdGxlVGV4dCA9IGRpc3BsYXlOYW1lOworICAgIH0sCisKKyAg
ICBzZXQgaG92ZXJlZChob3ZlcmVkKQorICAgIHsKKyAgICAgICAgaWYgKGhvdmVyZWQpIHsKKyAg
ICAgICAgICAgIHRoaXMubGlzdEl0ZW1FbGVtZW50LmFkZFN0eWxlQ2xhc3MoImhvdmVyZWQiKTsK
KyAgICAgICAgICAgIEluc3BlY3RvckJhY2tlbmQuaGlnaGxpZ2h0RnJhbWUodGhpcy5fZnJhbWVJ
ZCk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICB0aGlzLmxpc3RJdGVtRWxlbWVudC5y
ZW1vdmVTdHlsZUNsYXNzKCJob3ZlcmVkIik7CisgICAgICAgICAgICBJbnNwZWN0b3JCYWNrZW5k
LmhpZGVGcmFtZUhpZ2hsaWdodCgpOworICAgICAgICB9CiAgICAgfQogfQogV2ViSW5zcGVjdG9y
LkZyYW1lVHJlZUVsZW1lbnQucHJvdG90eXBlLl9fcHJvdG9fXyA9IFdlYkluc3BlY3Rvci5CYXNl
U3RvcmFnZVRyZWVFbGVtZW50LnByb3RvdHlwZTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVj
dG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k
L2luc3BlY3Rvci5jc3MKaW5kZXggMGY1NTFlYS4uYzdkZjViNSAxMDA2NDQKLS0tIGEvV2ViQ29y
ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIvV2ViQ29yZS9pbnNwZWN0
b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKQEAgLTE5NjgsMTggKzE5NjgsMTggQEAgYm9keS5p
bmFjdGl2ZSAuc2lkZWJhciB7CiAgICAgZm9udC13ZWlnaHQ6IGJvbGQ7CiB9CiAKLS5zdG9yYWdl
LnBhbmVsIC5zaWRlYmFyIGxpIC5zZWxlY3Rpb24geworLnN0b3JhZ2UucGFuZWwgLnNpZGViYXIg
bGkuc2VsZWN0ZWQgLnNlbGVjdGlvbiB7CiAgICAgYmFja2dyb3VuZC1pbWFnZTogLXdlYmtpdC1n
cmFkaWVudChsaW5lYXIsIGxlZnQgdG9wLCBsZWZ0IGJvdHRvbSwgZnJvbShyZ2IoMTYyLCAxNzcs
IDIwNykpLCB0byhyZ2IoMTIwLCAxMzgsIDE3NykpKTsKICAgICBib3JkZXItdG9wOiAxcHggc29s
aWQgIzk3OTc5NzsKICAgICBoZWlnaHQ6IDE3cHg7CiB9CiAKLS5zdG9yYWdlLnBhbmVsIC5zaWRl
YmFyIDpmb2N1cyBsaSAuc2VsZWN0aW9uIHsKKy5zdG9yYWdlLnBhbmVsIC5zaWRlYmFyIDpmb2N1
cyBsaS5zZWxlY3RlZCAuc2VsZWN0aW9uIHsKICAgICBiYWNrZ3JvdW5kLWltYWdlOiAtd2Via2l0
LWdyYWRpZW50KGxpbmVhciwgbGVmdCB0b3AsIGxlZnQgYm90dG9tLCBmcm9tKHJnYig5MiwgMTQ3
LCAyMTMpKSwgdG8ocmdiKDIxLCA4MywgMTcwKSkpOwogICAgIGJvcmRlci10b3A6IDFweCBzb2xp
ZCByZ2IoNjgsIDEyOCwgMjAwKTsKIH0KIAotYm9keS5pbmFjdGl2ZSAuc3RvcmFnZS5wYW5lbCAu
c2lkZWJhciBsaSAuc2VsZWN0aW9uIHsKK2JvZHkuaW5hY3RpdmUgLnN0b3JhZ2UucGFuZWwgLnNp
ZGViYXIgbGkuc2VsZWN0ZWQgLnNlbGVjdGlvbiB7CiAgICAgYmFja2dyb3VuZC1pbWFnZTogLXdl
YmtpdC1ncmFkaWVudChsaW5lYXIsIGxlZnQgdG9wLCBsZWZ0IGJvdHRvbSwgZnJvbShyZ2IoMTgw
LCAxODAsIDE4MCkpLCB0byhyZ2IoMTM4LCAxMzgsIDEzOCkpKTsKICAgICBib3JkZXItdG9wOiAx
cHggc29saWQgcmdiKDE1MSwgMTUxLCAxNTEpOwogfQo=
</data>
<flag name="review"
          id="62772"
          type_id="1"
          status="+"
          setter="joepeck"
    />
    <flag name="commit-queue"
          id="62838"
          type_id="3"
          status="-"
          setter="joepeck"
    />
          </attachment>
      

    </bug>

</bugzilla>