4875 2005-09-07 12:45:14 -0700 link jumping should scroll to tallest object on line, not first object on line 2005-12-26 14:08:32 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 4964 1 mitz vicki vicki oldest_to_newest 19023 0 mitz 2005-09-07 12:45:14 -0700 Summary: If a named anchor comes right before a table (and there's no whitespace between them) then a link to the anchor scrolls to the first text in the table rather than to where the anchor is. To reproduce: 1) Open the testcase in Safari 2) Click the "Click here" link Expected: in step 2, page should scroll to "You came to the right place!". Actual: in step 2, page scrolls to "I didn't expect you to get this far!". (Similar to bug 4825, but this one is not a regression). 19024 1 3800 mitz 2005-09-07 12:45:58 -0700 Created attachment 3800 testcase 19025 2 mitz 2005-09-07 12:47:12 -0700 Forgot to mention that Firefox behaves as expected. 19029 3 vicki 2005-09-07 14:36:26 -0700 Scrolling to anchors is broken in many ways, in large part b/c the function that calculates the position to scroll to (getUpperLeftCorner) predates the line box tree. Let's use this bug as a master bug for this issue. 19590 4 vicki 2005-09-13 11:30:56 -0700 Two related bugs about scrolling to anchors: http://bugzilla.opendarwin.org/show_bug.cgi?id=3390 http://bugzilla.opendarwin.org/show_bug.cgi?id=4964 22230 5 hyatt 2005-10-18 16:16:32 -0700 Putting a border on the table makes this test case a bit more clear IMO. 23105 6 mitz 2005-10-28 01:41:32 -0700 Vicki fixed this but I'm not sure the bug can be closed because it's tracking other scroll-to-anchor issues. 23108 7 vicki 2005-10-28 01:57:07 -0700 I think we can close this. The only remaining bug that is related to this bug is http:// bugzilla.opendarwin.org/show_bug.cgi?id=3390, and the originator claims that bug has something to do with stylesheets. The fixes I made pertain only to the algorithm that calculates the position to scroll to. By the way Mitz, thanks for all of your great test cases! They really helped in coming up with a solution that covered a lot of edge cases. 3800 2005-09-07 12:45:58 -0700 2005-09-07 12:45:58 -0700 testcase scrollToAnchorAgain.html text/html 408 mitz PGh0bWw+PGhlYWQ+Cjx0aXRsZT5TY3JvbGxpbmcgdG8gYW5jaG9ycyBhZ2FpbjwvdGl0bGU+Cjwv aGVhZD4KPGJvZHk+CjxwPjxhIGhyZWY9IiMwIj5DbGljayBoZXJlPC9hPjwvcD4KPGRpdiBzdHls ZT0id2lkdGg6MTAwJTtoZWlnaHQ6MTAwMHB4OyI+PHNwYW4gc3R5bGU9InBvc2l0aW9uOnJlbGF0 aXZlOyB0b3A6MTAxMHB4OyI+WW91IGNhbWUgdG8gdGhlIHJpZ2h0IHBsYWNlITwvc3Bhbj48L2Rp dj4KPGEgbmFtZT0iMCI+PC9hPjx0YWJsZSBzdHlsZT0iaGVpZ2h0OjIwMDBweDsiPjx0cj48dGQ+ SSBkaWRuJnJzcXVvO3QgZXhwZWN0IHlvdSB0byBnZXQgdGhpcyBmYXIhPC90ZD48L3RyPjwvdGFi bGU+CjxkaXYgc3R5bGU9IndpZHRoOjEwMCU7IGhlaWdodDoxMDAwcHg7Ij48L2Rpdj4KPC9ib2R5 PjwvaHRtbD4K