48741 2010-10-31 19:59:59 -0700 Check for NULL node in SVGUseElement::associateInstancesWithShadowTreeElements loop 2010-11-01 08:23:57 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jschuh webkit-unassigned commit-queue mdelaney7 zimmermann oldest_to_newest 302547 0 jschuh 2010-10-31 19:59:59 -0700 Here's a test case that triggers a NULL deref crash: <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> <set id="set"/> <use id="use" xlink:href="#set">x</use> <use xlink:href="#use"/> </svg> Patch forthcoming. 302548 1 72482 jschuh 2010-10-31 20:02:03 -0700 Created attachment 72482 Patch 302581 2 72482 krit 2010-11-01 00:33:54 -0700 Comment on attachment 72482 Patch r=me 302697 3 commit-queue 2010-11-01 08:22:25 -0700 The commit-queue encountered the following flaky tests while processing attachment 72482: webarchive/test-link-rel-icon.html Please file bugs against the tests. These tests were authored by ddkilzer@webkit.org. The commit-queue is continuing to process your patch. 302699 4 72482 commit-queue 2010-11-01 08:23:51 -0700 Comment on attachment 72482 Patch Clearing flags on attachment: 72482 Committed r71027: <http://trac.webkit.org/changeset/71027> 302700 5 commit-queue 2010-11-01 08:23:57 -0700 All reviewed patches have been landed. Closing bug. 72482 2010-10-31 20:02:03 -0700 2010-11-01 08:23:50 -0700 Patch bug-48741-20101031200202.patch text/plain 2965 jschuh SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTAwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMzEgIEp1c3RpbiBTY2h1aCAgPGpzY2h1aEBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hlY2sgZm9yIE5VTEwgbm9kZSBpbiBTVkdVc2VFbGVtZW50Ojphc3NvY2lhdGVJbnN0YW5jZXNX aXRoU2hhZG93VHJlZUVsZW1lbnRzIGxvb3AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ4NzQxCisKKyAgICAgICAgVGVzdDogc3ZnL2N1c3RvbS91c2Ut b24tdXNlLXdpdGgtY2hpbGQtYW5kLWVtcHR5LXRhcmdldC5zdmcKKworICAgICAgICAqIHN2Zy9T VkdVc2VFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1VzZUVsZW1lbnQ6OmFzc29j aWF0ZUluc3RhbmNlc1dpdGhTaGFkb3dUcmVlRWxlbWVudHMpOgorCiAyMDEwLTEwLTMxICBLZW5p Y2hpIElzaGliYXNoaSAgPGJhc2hpQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBCYXJ0aC4KSW5kZXg6IFdlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQuY3BwCShyZXZpc2lvbiA3MDk5OSkKKysr IFdlYkNvcmUvc3ZnL1NWR1VzZUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NDgsNiAr OTQ4LDkgQEAgdm9pZCBTVkdVc2VFbGVtZW50Ojphc3NvY2lhdGVJbnN0YW5jZXNXaQogICAgICAg ICB3aGlsZSAobm9kZSAmJiAhbm9kZS0+aXNTVkdFbGVtZW50KCkpCiAgICAgICAgICAgIG5vZGUg PSBub2RlLT5uZXh0U2libGluZygpOwogCisgICAgICAgIGlmICghbm9kZSkKKyAgICAgICAgICAg IGJyZWFrOworCiAgICAgICAgIGFzc29jaWF0ZUluc3RhbmNlc1dpdGhTaGFkb3dUcmVlRWxlbWVu dHMobm9kZSwgaW5zdGFuY2UpOwogICAgICAgICBub2RlID0gbm9kZS0+bmV4dFNpYmxpbmcoKTsK ICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiA3MTAwNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTMxICBKdXN0aW4gU2No dWggIDxqc2NodWhAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoZWNrIGZvciBOVUxMIG5vZGUgaW4gU1ZHVXNlRWxlbWVudDo6 YXNzb2NpYXRlSW5zdGFuY2VzV2l0aFNoYWRvd1RyZWVFbGVtZW50cyBsb29wCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODc0MQorCisgICAgICAgICog c3ZnL2N1c3RvbS91c2Utb24tdXNlLXdpdGgtY2hpbGQtYW5kLWVtcHR5LXRhcmdldC1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vdXNlLW9uLXVzZS13aXRoLWNoaWxk LWFuZC1lbXB0eS10YXJnZXQuc3ZnOiBBZGRlZC4KKwogMjAxMC0xMC0zMSAgSmVyZW15IE1vc2tv dmljaCAgPGplcmVteUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBW YWZhaS4KSW5kZXg6IExheW91dFRlc3RzL3N2Zy9jdXN0b20vdXNlLW9uLXVzZS13aXRoLWNoaWxk LWFuZC1lbXB0eS10YXJnZXQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L3N2Zy9jdXN0b20vdXNlLW9uLXVzZS13aXRoLWNoaWxkLWFuZC1lbXB0eS10YXJnZXQtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2Utb24tdXNl LXdpdGgtY2hpbGQtYW5kLWVtcHR5LXRhcmdldC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBA IC0wLDAgKzEsMiBAQAorUEFTUzogVGhpcyBzaG91bGQgbm90IGNyYXNoLgorCkluZGV4OiBMYXlv dXRUZXN0cy9zdmcvY3VzdG9tL3VzZS1vbi11c2Utd2l0aC1jaGlsZC1hbmQtZW1wdHktdGFyZ2V0 LnN2Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS1vbi11c2Utd2l0 aC1jaGlsZC1hbmQtZW1wdHktdGFyZ2V0LnN2ZwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L3N2Zy9jdXN0b20vdXNlLW9uLXVzZS13aXRoLWNoaWxkLWFuZC1lbXB0eS10YXJnZXQuc3ZnCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEwIEBACis8c3ZnIHhtbG5zPSJodHRwOi8vd3d3LnczLm9y Zy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxpbmsiPg0K KyAgICA8c2NyaXB0Pg0KKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikN CisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7DQorICAgIDwv c2NyaXB0Pg0KKyAgICA8dGV4dCB5PSIyMCI+UEFTUzogVGhpcyBzaG91bGQgbm90IGNyYXNoLjwv dGV4dD4NCisgICAgPHNldCBpZD0ic2V0Ii8+DQorICAgIDx1c2UgaWQ9InVzZSIgeGxpbms6aHJl Zj0iI3NldCI+eDwvdXNlPg0KKyAgICA8dXNlIHhsaW5rOmhyZWY9IiN1c2UiLz4NCis8L3N2Zz4N Cg==