48736 2010-10-31 12:49:15 -0700 [Qt] Short-circuit QWebPage::selectedText() if frame has no selection 2010-10-31 19:43:30 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 302465 0 kling 2010-10-31 12:49:15 -0700 As mentioned on bug 48722, QWebPage::selectedText() could do an early return if the frame's selection is empty. 302466 1 72471 kling 2010-10-31 12:51:58 -0700 Created attachment 72471 Proposed patch 302483 2 72471 kling 2010-10-31 13:42:34 -0700 Comment on attachment 72471 Proposed patch Clearing flags on attachment: 72471 Committed r70999: <http://trac.webkit.org/changeset/70999> 302484 3 kling 2010-10-31 13:42:43 -0700 All reviewed patches have been landed. Closing bug. 302540 4 72471 tonikitoo 2010-10-31 19:43:30 -0700 Comment on attachment 72471 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=72471&action=review > WebKit/qt/Api/qwebpage.cpp:2422 > + if (frame->selection()->selection().selectionType() == VisibleSelection::NoSelection) This is a bad internal API =/ : 5 "selection"s for this single simple statement, being on of them "selection()->selection()" Nice shortcut though! 72471 2010-10-31 12:51:58 -0700 2010-10-31 19:43:30 -0700 Proposed patch bug-48736.diff text/plain 1352 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggNmEyODhkNS4uMDc1NGZjYiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTI0 MTgsNyArMjQxOCwxMCBAQCBib29sIFFXZWJQYWdlOjphY2NlcHROYXZpZ2F0aW9uUmVxdWVzdChR V2ViRnJhbWUgKmZyYW1lLCBjb25zdCBRTmV0d29ya1JlcXVlc3QgJgogUVN0cmluZyBRV2ViUGFn ZTo6c2VsZWN0ZWRUZXh0KCkgY29uc3QKIHsKICAgICBkLT5jcmVhdGVNYWluRnJhbWUoKTsKLSAg ICByZXR1cm4gZC0+cGFnZS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgp LT5lZGl0b3IoKS0+c2VsZWN0ZWRUZXh0KCk7CisgICAgV2ViQ29yZTo6RnJhbWUqIGZyYW1lID0g ZC0+cGFnZS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIGlm IChmcmFtZS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLnNlbGVjdGlvblR5cGUoKSA9PSBWaXNp YmxlU2VsZWN0aW9uOjpOb1NlbGVjdGlvbikKKyAgICAgICAgcmV0dXJuIFFTdHJpbmcoKTsKKyAg ICByZXR1cm4gZnJhbWUtPmVkaXRvcigpLT5zZWxlY3RlZFRleHQoKTsKIH0KIAogI2lmbmRlZiBR VF9OT19BQ1RJT04KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQv Q2hhbmdlTG9nCmluZGV4IGMzY2UzZGUuLmU1ZWE5NjUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9D aGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEw LTEwLTMxICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNob3J0LWNpcmN1aXQgUVdl YlBhZ2U6OnNlbGVjdGVkVGV4dCgpIGlmIGZyYW1lIGhhcyBubyBzZWxlY3Rpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NzM2CisKKyAgICAgICAg RG8gYW4gZWFybHkgcmV0dXJuIGlmIHRoZSBzZWxlY3Rpb24gaXMgZW1wdHkuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLCB0aGlzIGlzIGNvdmVyZWQgYnkgdHN0X1FXZWJQYWdlOjpmaW5kVGV4dCgp LgorCisgICAgICAgICogQXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjpzZWxl Y3RlZFRleHQpOgorCiAyMDEwLTEwLTMwICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgo=