48733 2010-10-31 10:53:25 -0700 [Qt] Remove GraphicsContext::pen() 2010-10-31 12:35:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned kenneth oldest_to_newest 302427 0 kling 2010-10-31 10:53:25 -0700 PathQt can obtain it through the platformContext() instead -> one less Qt-specific GraphicsContext method. 302428 1 72466 kling 2010-10-31 10:54:14 -0700 Created attachment 72466 Proposed patch 302433 2 72466 krit 2010-10-31 11:47:36 -0700 Comment on attachment 72466 Proposed patch r=me 302442 3 72466 kling 2010-10-31 11:57:54 -0700 Comment on attachment 72466 Proposed patch Clearing flags on attachment: 72466 Committed r70992: <http://trac.webkit.org/changeset/70992> 302443 4 kling 2010-10-31 11:58:03 -0700 All reviewed patches have been landed. Closing bug. 302459 5 72466 kenneth 2010-10-31 12:32:56 -0700 Comment on attachment 72466 Proposed patch Is this supposed to be up for review? 302460 6 kenneth 2010-10-31 12:33:33 -0700 oh sorry :-) I'm confused... 302461 7 kling 2010-10-31 12:35:36 -0700 (In reply to comment #6) > oh sorry :-) I'm confused... Hi Kenneth! :-) 72466 2010-10-31 10:54:14 -0700 2010-10-31 12:32:56 -0700 Proposed patch bug-48733.diff text/plain 3258 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjdlMDRmYi4uMDEyMDI3YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0zMSAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBSZW1vdmUgR3JhcGhpY3NDb250ZXh0OjpwZW4oKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg3MzMKKworICAgICAg ICBIYXZlIFBhdGhRdCBvYnRhaW4gdGhlIHBlbigpIHRocm91Z2ggdGhlIHBsYXRmb3JtQ29udGV4 dCgpIGluc3RlYWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRl eHQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHRRdC5j cHA6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBhdGg6OnN0cm9rZUNvbnRhaW5zKToKKyAgICAgICAgKFdlYkNvcmU6OlBhdGg6 OnN0cm9rZUJvdW5kaW5nUmVjdCk6CisKIDIwMTAtMTAtMzAgIFBhdmVsIEZlbGRtYW4gIDxwZmVs ZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVy LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQu aCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgKaW5kZXggMjQ2 NWE3Yy4uYWI3OWVhMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFw aGljc0NvbnRleHQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dC5oCkBAIC0zOTksNyArMzk5LDYgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBi b29sIGluVHJhbnNwYXJlbmN5TGF5ZXIoKSBjb25zdDsKICAgICAgICAgUGxhdGZvcm1QYXRoKiBj dXJyZW50UGF0aCgpOwogICAgICAgICB2b2lkIHB1c2hUcmFuc3BhcmVuY3lMYXllckludGVybmFs KGNvbnN0IFFSZWN0ICZyZWN0LCBxcmVhbCBvcGFjaXR5LCBRUGl4bWFwJiBhbHBoYU1hc2spOwot ICAgICAgICBRUGVuIHBlbigpOwogICAgICAgICBzdGF0aWMgUVBhaW50ZXI6OkNvbXBvc2l0aW9u TW9kZSB0b1F0Q29tcG9zaXRpb25Nb2RlKENvbXBvc2l0ZU9wZXJhdG9yIG9wKTsKICNlbmRpZgog CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQu Y3BwCmluZGV4IDUwOTcxYjUuLjJmZDM1ZTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCkBAIC01MDcsMTUgKzUwNyw2IEBAIHZv aWQgR3JhcGhpY3NDb250ZXh0OjpjbGlwQ29udmV4UG9seWdvbihzaXplX3QgbnVtUG9pbnRzLCBj b25zdCBGbG9hdFBvaW50KiBwb2luCiAgICAgbV9kYXRhLT5wKCktPnNldENsaXBQYXRoKHBhdGgs IFF0OjpJbnRlcnNlY3RDbGlwKTsKIH0KIAotUVBlbiBHcmFwaGljc0NvbnRleHQ6OnBlbigpCi17 Ci0gICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKLSAgICAgICAgcmV0dXJuIFFQZW4oKTsKLQot ICAgIFFQYWludGVyKiBwID0gbV9kYXRhLT5wKCk7Ci0gICAgcmV0dXJuIHAtPnBlbigpOwotfQot CiB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFBhdGgoKQogewogICAgIGlmIChwYWludGluZ0Rp c2FibGVkKCkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhR dC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAKaW5kZXggNTA4 YmE2YS4uYjY4NmZlZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Q YXRoUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvUGF0aFF0LmNwcApA QCAtMTM0LDEwICsxMzQsMTAgQEAgYm9vbCBQYXRoOjpzdHJva2VDb250YWlucyhTdHJva2VTdHls ZUFwcGxpZXIqIGFwcGxpZXIsIGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50KQogICAgIEFTU0VSVChh cHBsaWVyKTsKIAogICAgIFFQYWludGVyUGF0aFN0cm9rZXIgc3Ryb2tlOwotICAgIEdyYXBoaWNz Q29udGV4dCogZ2MgPSBzY3JhdGNoQ29udGV4dCgpOwotICAgIGFwcGxpZXItPnN0cm9rZVN0eWxl KGdjKTsKKyAgICBHcmFwaGljc0NvbnRleHQqIGNvbnRleHQgPSBzY3JhdGNoQ29udGV4dCgpOwor ICAgIGFwcGxpZXItPnN0cm9rZVN0eWxlKGNvbnRleHQpOwogCi0gICAgUVBlbiBwZW4gPSBnYy0+ cGVuKCk7CisgICAgUVBlbiBwZW4gPSBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+cGVuKCk7 CiAgICAgc3Ryb2tlLnNldFdpZHRoKHBlbi53aWR0aEYoKSk7CiAgICAgc3Ryb2tlLnNldENhcFN0 eWxlKHBlbi5jYXBTdHlsZSgpKTsKICAgICBzdHJva2Uuc2V0Sm9pblN0eWxlKHBlbi5qb2luU3R5 bGUoKSk7CkBAIC0xNjIsMTIgKzE2MiwxMiBAQCBGbG9hdFJlY3QgUGF0aDo6Ym91bmRpbmdSZWN0 KCkgY29uc3QKIAogRmxvYXRSZWN0IFBhdGg6OnN0cm9rZUJvdW5kaW5nUmVjdChTdHJva2VTdHls ZUFwcGxpZXIqIGFwcGxpZXIpCiB7Ci0gICAgR3JhcGhpY3NDb250ZXh0KiBnYyA9IHNjcmF0Y2hD b250ZXh0KCk7CisgICAgR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0ID0gc2NyYXRjaENvbnRleHQo KTsKICAgICBRUGFpbnRlclBhdGhTdHJva2VyIHN0cm9rZTsKICAgICBpZiAoYXBwbGllcikgewot ICAgICAgICBhcHBsaWVyLT5zdHJva2VTdHlsZShnYyk7CisgICAgICAgIGFwcGxpZXItPnN0cm9r ZVN0eWxlKGNvbnRleHQpOwogCi0gICAgICAgIFFQZW4gcGVuID0gZ2MtPnBlbigpOworICAgICAg ICBRUGVuIHBlbiA9IGNvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5wZW4oKTsKICAgICAgICAg c3Ryb2tlLnNldFdpZHRoKHBlbi53aWR0aEYoKSk7CiAgICAgICAgIHN0cm9rZS5zZXRDYXBTdHls ZShwZW4uY2FwU3R5bGUoKSk7CiAgICAgICAgIHN0cm9rZS5zZXRKb2luU3R5bGUocGVuLmpvaW5T dHlsZSgpKTsK