48726 2010-10-31 09:16:02 -0700 Remove the unused GraphicsContext::strokeRect(FloatRect) 2010-10-31 20:35:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kling webkit-unassigned jpetsovits tonikitoo oldest_to_newest 302400 0 kling 2010-10-31 09:16:02 -0700 This function is only implemented by GraphicsContextOpenVG and not called from anywhere. strokeRect(const FloatRect&, float lineWidth) is the real deal. 302401 1 72458 kling 2010-10-31 09:16:50 -0700 Created attachment 72458 Proposed patch 302436 2 72458 krit 2010-10-31 11:54:20 -0700 Comment on attachment 72458 Proposed patch r=me. 302447 3 72458 kling 2010-10-31 12:02:34 -0700 Comment on attachment 72458 Proposed patch Clearing flags on attachment: 72458 Committed r70994: <http://trac.webkit.org/changeset/70994> 302448 4 kling 2010-10-31 12:02:43 -0700 All reviewed patches have been landed. Closing bug. 302553 5 tonikitoo 2010-10-31 20:35:51 -0700 (In reply to comment #0) > This function is only implemented by GraphicsContextOpenVG and not called from anywhere. > strokeRect(const FloatRect&, float lineWidth) is the real deal. [+jakob] 72458 2010-10-31 09:16:50 -0700 2010-10-31 12:02:34 -0700 Proposed patch bug-48726.diff text/plain 1896 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjdlMDRmYi4uZGQzZGE2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMC0zMSAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSB1bnVzZWQgR3JhcGhpY3NDb250ZXh0OjpzdHJva2VS ZWN0KEZsb2F0UmVjdCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4NzI2CisKKyAgICAgICAgVGhpcyBmdW5jdGlvbiB3YXMgb25seSBpbXBsZW1lbnRl ZCBieSBHcmFwaGljc0NvbnRleHRPcGVuVkcgYW5kIG5vdAorICAgICAgICBjYWxsZWQgZnJvbSBh bnl3aGVyZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5o OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW52Zy9HcmFwaGljc0NvbnRleHRPcGVu VkcuY3BwOgorCiAyMDEwLTEwLTMwICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmggYi9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCmluZGV4IDI0NjVhN2MuLjlhMTZhYWYg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgK KysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaApAQCAtMjI1 LDcgKzIyNSw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2b2lkIGNsZWFyUmVj dChjb25zdCBGbG9hdFJlY3QmKTsKIAotICAgICAgICB2b2lkIHN0cm9rZVJlY3QoY29uc3QgRmxv YXRSZWN0Jik7CiAgICAgICAgIHZvaWQgc3Ryb2tlUmVjdChjb25zdCBGbG9hdFJlY3QmLCBmbG9h dCBsaW5lV2lkdGgpOwogCiAgICAgICAgIHZvaWQgZHJhd0ltYWdlKEltYWdlKiwgQ29sb3JTcGFj ZSBzdHlsZUNvbG9yU3BhY2UsIGNvbnN0IEludFBvaW50JiwgQ29tcG9zaXRlT3BlcmF0b3IgPSBD b21wb3NpdGVTb3VyY2VPdmVyKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3Mvb3BlbnZnL0dyYXBoaWNzQ29udGV4dE9wZW5WRy5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL29wZW52Zy9HcmFwaGljc0NvbnRleHRPcGVuVkcuY3BwCmluZGV4IDM3ZmQ4YWQuLjQ3 ZmUwNDkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnZnL0dyYXBo aWNzQ29udGV4dE9wZW5WRy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVu dmcvR3JhcGhpY3NDb250ZXh0T3BlblZHLmNwcApAQCAtMzQwLDE0ICszNDAsNiBAQCB2b2lkIEdy YXBoaWNzQ29udGV4dDo6Y2xlYXJSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKICAgICBtX2Rh dGEtPnNldENvbXBvc2l0ZU9wZXJhdGlvbihvcCk7CiB9CiAKLXZvaWQgR3JhcGhpY3NDb250ZXh0 OjpzdHJva2VSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCkKLXsKLSAgICBpZiAocGFpbnRpbmdE aXNhYmxlZCgpKQotICAgICAgICByZXR1cm47Ci0KLSAgICBtX2RhdGEtPmRyYXdSZWN0KHJlY3Qs IFZHX1NUUk9LRV9QQVRIKTsKLX0KLQogdm9pZCBHcmFwaGljc0NvbnRleHQ6OnN0cm9rZVJlY3Qo Y29uc3QgRmxvYXRSZWN0JiByZWN0LCBmbG9hdCBsaW5lV2lkdGgpCiB7CiAgICAgaWYgKHBhaW50 aW5nRGlzYWJsZWQoKSkK