48724 2010-10-31 04:13:20 -0700 [Qt] QWKPage::loadFinished is not emitted if document.open() is invoked on a new window 2010-12-14 04:18:58 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kimmo.t.kinnunen zalan abarth commit-queue eric webkit.review.bot zalan oldest_to_newest 302367 0 72452 kimmo.t.kinnunen 2010-10-31 04:13:20 -0700 Created attachment 72452 test-case QWKPage::loadFinished is not emitted if document.open() is invoked on a new window. Steps to reproduce: 1) open new window with js 2) use document.write or document.open on the new window doc 3) call document.close Expected: QWKPage::loadFinished emitted Result: QWKPage::loadFinished not emitted Can be observed with MiniBrowser. MiniBrowser Stop -button remains active even if the page load has finished. See attached test-case. 314030 1 74941 zalan 2010-11-26 08:23:00 -0800 Created attachment 74941 fix hanging UI state the root cause is tracked here: https://bugs.webkit.org/show_bug.cgi?id=50106 321872 2 74941 commit-queue 2010-12-14 03:48:34 -0800 Comment on attachment 74941 fix hanging UI state Clearing flags on attachment: 74941 Committed r74013: <http://trac.webkit.org/changeset/74013> 321873 3 commit-queue 2010-12-14 03:48:39 -0800 All reviewed patches have been landed. Closing bug. 321885 4 webkit.review.bot 2010-12-14 04:18:58 -0800 http://trac.webkit.org/changeset/74013 might have broken Qt Linux Release The following tests are not passing: inspector/styles-source-offsets.html 72452 2010-10-31 04:13:20 -0700 2010-10-31 04:13:20 -0700 test-case js-new-window-doc-open-close-01.html text/html 679 kimmo.t.kinnunen PGh0bWw+CjxoZWFkPgo8dGl0bGU+SmF2YVNjcmlwdCBXaW5kb3cgT3BlbiAvIENsb3NlIFRlc3Qg MTwvdGl0bGU+CjwvaGVhZD4KPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgp2YXIgbmV3 V2luOwpmdW5jdGlvbiBjcmVhdGVXaW5kb3coKSB7Cm5ld1dpbiA9IHdpbmRvdy5vcGVuKCIiLCAi YXdpbiIpOwpuZXdXaW4uZG9jdW1lbnQub3BlbigpOwpuZXdXaW4uZG9jdW1lbnQuY2xvc2UoKTsK fQoKZnVuY3Rpb24gY2xvc2VXaW5kb3coKSB7CmlmIChuZXdXaW4pIHsKICBuZXdXaW4uY2xvc2Uo KTsKICBuZXdXaW4gPSB2b2lkKDApOwp9IGVsc2UgewogIGFsZXJ0KCdXaW5kb3cgYWxyZWFkeSBj bG9zZWQnKTsKfQp9Cjwvc2NyaXB0Pgo8Ym9keT4KCjxwPiBDbGljayB0aGUgIm9wZW4gcG9wdXAg d2luZG93Ii4KCjxwPiBFeHBlY3RlZDogd2luZG93IG9wZW5zIGFuZCBubyBsb2FkIHByb2dyZXNz IGlzIHZpc2libGUuCgo8cD4gQnVnOiB3aW5kb3cgb3BlbnMgYnV0IGxvYWQgcHJvZ3Jlc3MgaW5k aWNhdG9yIGlzIHZpc2libGUuCgo8cD48YSBocmVmPSJqYXZhc2NyaXB0OmNyZWF0ZVdpbmRvdygp OyI+T3BlbiBQb3B1cCBXaW5kb3c8L2E+Cgo8cD48YSBocmVmPSJqYXZhc2NyaXB0OmNsb3NlV2lu ZG93KCk7Ij5DbG9zZSB0aGUgUG9wdXAgV2luZG93PC9hPgoKPC9ib2R5Pgo8L2h0bWw+Cg== 74941 2010-11-26 08:23:00 -0800 2010-12-14 03:48:34 -0800 fix hanging UI state loaderror.patch text/plain 2861 zalan SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3Mjc2MykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTEtMjYgIFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFk ZCBsb2FkRmluaXNoZWQoKSBmb3IgcHJvdmlzaW9uYWwgbG9hZCBlcnJvcgorICAgICAgICBUaGlz IGZpeGVzIHRoZSBoYW5naW5nIFVJIHN0YXRlLCB3aGVuIHByb3Zpc2lvbmFsIGxvYWQgZXJyb3Ig b2NjdXJzIGR1ZSB0bworICAgICAgICB0aGUgYXN5bmMgbmF0dXJlIG9mIHBvbGljeSBjaGVjay4K KworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg3MjQK KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChs b2FkRmluaXNoZWQpOgorICAgICAgICAocXRfd2tfZGlkRmFpbFByb3Zpc2lvbmFsTG9hZFdpdGhF cnJvckZvckZyYW1lKToKKyAgICAgICAgKHF0X3drX2RpZEZpbmlzaExvYWRGb3JGcmFtZSk6Cisg ICAgICAgIChxdF93a19kaWRGYWlsTG9hZFdpdGhFcnJvckZvckZyYW1lKToKKwogMjAxMC0xMS0y NCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg aW1wbGljaXRseSBieSBKb2huIFN1bGxpdmFuLgpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L0NsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9x dC9DbGllbnRJbXBsLmNwcAkocmV2aXNpb24gNzI3NjApCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvQ2xpZW50SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDE0IEBAIHN0 YXRpYyBRV0tQYWdlKiB0b1FXS1BhZ2UoY29uc3Qgdm9pZCogY2wKICAgICByZXR1cm4gMDsKIH0K IAorc3RhdGljIHZvaWQgbG9hZEZpbmlzaGVkKFdLRnJhbWVSZWYgZnJhbWUsIGNvbnN0IHZvaWQq IGNsaWVudEluZm8sIGJvb2wgb2spCit7CisgICAgaWYgKCFXS0ZyYW1lSXNNYWluRnJhbWUoZnJh bWUpKQorICAgICAgICByZXR1cm47CisgICAgZW1pdCB0b1FXS1BhZ2UoY2xpZW50SW5mbyktPmxv YWRGaW5pc2hlZChvayk7CisgICAgUVdLUGFnZVByaXZhdGU6OmdldCh0b1FXS1BhZ2UoY2xpZW50 SW5mbykpLT51cGRhdGVOYXZpZ2F0aW9uQWN0aW9ucygpOworfQorCiB2b2lkIHF0X3drX2RpZFN0 YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJh bWUsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKIHsKICAgICBp ZiAoIVdLRnJhbWVJc01haW5GcmFtZShmcmFtZSkpCkBAIC01MSw2ICs1OSw3IEBAIHZvaWQgcXRf d2tfZGlkUmVjZWl2ZVNlcnZlclJlZGlyZWN0Rm9yUHIKIAogdm9pZCBxdF93a19kaWRGYWlsUHJv dmlzaW9uYWxMb2FkV2l0aEVycm9yRm9yRnJhbWUoV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYg ZnJhbWUsIFdLRXJyb3JSZWYgZXJyb3IsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCog Y2xpZW50SW5mbykKIHsKKyAgICBsb2FkRmluaXNoZWQoZnJhbWUsIGNsaWVudEluZm8sIGZhbHNl KTsKIH0KIAogdm9pZCBxdF93a19kaWRDb21taXRMb2FkRm9yRnJhbWUoV0tQYWdlUmVmIHBhZ2Us IFdLRnJhbWVSZWYgZnJhbWUsIFdLVHlwZVJlZiB1c2VyRGF0YSwgY29uc3Qgdm9pZCogY2xpZW50 SW5mbykKQEAgLTcxLDE4ICs4MCwxMiBAQCB2b2lkIHF0X3drX2RpZEZpbmlzaERvY3VtZW50TG9h ZEZvckZyYW1lCiAKIHZvaWQgcXRfd2tfZGlkRmluaXNoTG9hZEZvckZyYW1lKFdLUGFnZVJlZiBw YWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS1R5cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZvaWQqIGNs aWVudEluZm8pCiB7Ci0gICAgaWYgKCFXS0ZyYW1lSXNNYWluRnJhbWUoZnJhbWUpKQotICAgICAg ICByZXR1cm47Ci0gICAgZW1pdCB0b1FXS1BhZ2UoY2xpZW50SW5mbyktPmxvYWRGaW5pc2hlZCh0 cnVlKTsKLSAgICBRV0tQYWdlUHJpdmF0ZTo6Z2V0KHRvUVdLUGFnZShjbGllbnRJbmZvKSktPnVw ZGF0ZU5hdmlnYXRpb25BY3Rpb25zKCk7CisgICAgbG9hZEZpbmlzaGVkKGZyYW1lLCBjbGllbnRJ bmZvLCB0cnVlKTsKIH0KIAogdm9pZCBxdF93a19kaWRGYWlsTG9hZFdpdGhFcnJvckZvckZyYW1l KFdLUGFnZVJlZiBwYWdlLCBXS0ZyYW1lUmVmIGZyYW1lLCBXS0Vycm9yUmVmIGVycm9yLCBXS1R5 cGVSZWYgdXNlckRhdGEsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7Ci0gICAgaWYgKCFXS0Zy YW1lSXNNYWluRnJhbWUoZnJhbWUpKQotICAgICAgICByZXR1cm47Ci0gICAgZW1pdCB0b1FXS1Bh Z2UoY2xpZW50SW5mbyktPmxvYWRGaW5pc2hlZChmYWxzZSk7Ci0gICAgUVdLUGFnZVByaXZhdGU6 OmdldCh0b1FXS1BhZ2UoY2xpZW50SW5mbykpLT51cGRhdGVOYXZpZ2F0aW9uQWN0aW9ucygpOwor ICAgIGxvYWRGaW5pc2hlZChmcmFtZSwgY2xpZW50SW5mbywgZmFsc2UpOwogfQogCiB2b2lkIHF0 X3drX2RpZFJlY2VpdmVUaXRsZUZvckZyYW1lKFdLUGFnZVJlZiBwYWdlLCBXS1N0cmluZ1JlZiB0 aXRsZSwgV0tGcmFtZVJlZiBmcmFtZSwgV0tUeXBlUmVmIHVzZXJEYXRhLCBjb25zdCB2b2lkKiBj bGllbnRJbmZvKQo=