48705 2010-10-29 18:31:26 -0700 [Qt] QtTestBrowser: Switching view type moves the embedded inspector 2010-10-30 07:48:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 302227 0 kling 2010-10-29 18:31:26 -0700 Steps to reproduce: 1. Start QtTestBrowser in normal mode 2. Open the embedded web inspector (Ctrl+Alt+I) 3. Switch to QGraphicsWebView mode 4. Open the embedded web inspector (Ctrl+Alt+I) The inspector is now above the QSplitter :( 302228 1 72425 kling 2010-10-29 18:32:11 -0700 Created attachment 72425 Proposed patch 302253 2 72425 tonikitoo 2010-10-29 21:53:09 -0700 Comment on attachment 72425 Proposed patch Also a regression of bug 35247? 302285 3 kling 2010-10-30 04:35:16 -0700 (In reply to comment #2) > Also a regression of bug 35247? Not sure. I seem to remember being slightly itched by this over a longer period of time.. 302303 4 72425 kling 2010-10-30 07:48:11 -0700 Comment on attachment 72425 Proposed patch Clearing flags on attachment: 72425 Committed r70980: <http://trac.webkit.org/changeset/70980> 302304 5 kling 2010-10-30 07:48:21 -0700 All reviewed patches have been landed. Closing bug. 72425 2010-10-29 18:32:11 -0700 2010-10-30 07:48:11 -0700 Proposed patch bug-48705.diff text/plain 2301 kling ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxYzdkMWJmLi5iMzY4MjljIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEgQEAKIDIwMTAtMTAt MjkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlcjogU3dpdGNo aW5nIHZpZXcgdHlwZSBtb3ZlcyB0aGUgZW1iZWRkZWQgaW5zcGVjdG9yCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODcwNQorCisgICAgICAgIFJlaW5z ZXJ0IHRoZSBlbWJlZGRlZCBpbnNwZWN0b3IgaW50byB0aGUgc3BsaXR0ZXIgYWZ0ZXIgY2hhbmdp bmcKKyAgICAgICAgYmV0d2VlbiBRV2ViVmlldy9RR3JhcGhpY3NXZWJWaWV3LgorCisgICAgICAg ICogUXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHA6CisgICAgICAgIChMYXVuY2hlcldp bmRvdzo6aW5pdCk6CisgICAgICAgIChMYXVuY2hlcldpbmRvdzo6aW5pdGlhbGl6ZVZpZXcpOgor ICAgICAgICAqIFF0VGVzdEJyb3dzZXIvd2ViaW5zcGVjdG9yLmg6CisgICAgICAgIChXZWJJbnNw ZWN0b3I6OldlYkluc3BlY3Rvcik6CisKKzIwMTAtMTAtMjkgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0 aWFuc2VuLgogCiAgICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlcjogQWRkIGtleWJvYXJkIHNob3J0 Y3V0IHRvIHRvZ2dsZSBmdWxsIHNjcmVlbiAoRjExKQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv UXRUZXN0QnJvd3Nlci9sYXVuY2hlcndpbmRvdy5jcHAgYi9XZWJLaXRUb29scy9RdFRlc3RCcm93 c2VyL2xhdW5jaGVyd2luZG93LmNwcAppbmRleCBlNWU0OWJlLi43NjA4MDYzIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcAorKysgYi9XZWJL aXRUb29scy9RdFRlc3RCcm93c2VyL2xhdW5jaGVyd2luZG93LmNwcApAQCAtNzAsMTIgKzcwLDEx IEBAIHZvaWQgTGF1bmNoZXJXaW5kb3c6OmluaXQoKQogICAgIHJlc2l6ZSg4MDAsIDYwMCk7CiAj ZW5kaWYKIAotICAgIG1faW5zcGVjdG9yID0gbmV3IFdlYkluc3BlY3RvcihzcGxpdHRlcik7Cisg ICAgbV9pbnNwZWN0b3IgPSBuZXcgV2ViSW5zcGVjdG9yOwogI2lmbmRlZiBRVF9OT19QUk9QRVJU SUVTCiAgICAgaWYgKCFtX3dpbmRvd09wdGlvbnMuaW5zcGVjdG9yVXJsLmlzRW1wdHkoKSkKICAg ICAgICAgbV9pbnNwZWN0b3ItPnNldFByb3BlcnR5KCJfcV9pbnNwZWN0b3JVcmwiLCBtX3dpbmRv d09wdGlvbnMuaW5zcGVjdG9yVXJsKTsKICNlbmRpZgotICAgIG1faW5zcGVjdG9yLT5oaWRlKCk7 CiAgICAgY29ubmVjdCh0aGlzLCBTSUdOQUwoZGVzdHJveWVkKCkpLCBtX2luc3BlY3RvciwgU0xP VChkZWxldGVMYXRlcigpKSk7CiAKICAgICAvLyB0aGUgem9vbSB2YWx1ZXMgYXJlIGNob3NlbiB0 byBiZSBsaWtlIGluIE1vemlsbGEgRmlyZWZveCAzCkBAIC0xMzAsNiArMTI5LDcgQEAgdm9pZCBM YXVuY2hlcldpbmRvdzo6aW5pdGlhbGl6ZVZpZXcoKQogCiAgICAgYXBwbHlQcmVmcygpOwogCisg ICAgc3BsaXR0ZXItPmFkZFdpZGdldChtX2luc3BlY3Rvcik7CiAgICAgbV9pbnNwZWN0b3ItPnNl dFBhZ2UocGFnZSgpKTsKICAgICBtX2luc3BlY3Rvci0+aGlkZSgpOwogCmRpZmYgLS1naXQgYS9X ZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL3dlYmluc3BlY3Rvci5oIGIvV2ViS2l0VG9vbHMvUXRU ZXN0QnJvd3Nlci93ZWJpbnNwZWN0b3IuaAppbmRleCBkMjUxYzVjLi41Y2M3ZjhhIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL3dlYmluc3BlY3Rvci5oCisrKyBiL1dlYktp dFRvb2xzL1F0VGVzdEJyb3dzZXIvd2ViaW5zcGVjdG9yLmgKQEAgLTM1LDcgKzM1LDcgQEAgY2xh c3MgV2ViSW5zcGVjdG9yIDogcHVibGljIFFXZWJJbnNwZWN0b3IgewogICAgIFFfT0JKRUNUCiAK IHB1YmxpYzoKLSAgICBXZWJJbnNwZWN0b3IoUVdpZGdldCogcGFyZW50KSA6IFFXZWJJbnNwZWN0 b3IocGFyZW50KSB7fQorICAgIFdlYkluc3BlY3RvcihRV2lkZ2V0KiBwYXJlbnQgPSAwKSA6IFFX ZWJJbnNwZWN0b3IocGFyZW50KSB7fQogCiBzaWduYWxzOgogICAgIHZvaWQgdmlzaWJsZUNoYW5n ZWQoYm9vbCBub3dWaXNpYmxlKTsK