4870 2005-09-06 19:53:59 -0700 win portability: fix IS_NEGATIVE_ZERO macro in simple_number.h 2005-09-10 22:11:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ PC Windows XP VERIFIED FIXED P2 Normal --- 1 kkowalczyk mjs oldest_to_newest 18941 0 kkowalczyk 2005-09-06 19:53:59 -0700 #define IS_NEGATIVE_ZERO(num) (_fpclass(num) == _FPCLASS_NZ) is much better test for negative zero on windows than #define IS_NEGATIVE_ZERO(num) (num == 0.0 && !memcmp(&num, &SimpleNumber::negZero, sizeof(double))) This reduces number of jsc tests failed on win from 86 to 75. 18942 1 3790 kkowalczyk 2005-09-06 19:54:38 -0700 Created attachment 3790 fix IS_NEGATIVE_ZERO macro on win 18946 2 3790 darin 2005-09-06 22:42:20 -0700 Comment on attachment 3790 fix IS_NEGATIVE_ZERO macro on win r=me 3790 2005-09-06 19:54:38 -0700 2005-09-06 22:42:20 -0700 fix IS_NEGATIVE_ZERO macro on win simple_number_diff.txt text/plain 647 kkowalczyk SW5kZXg6IGtqcy9zaW1wbGVfbnVtYmVyLmgNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3Jv b3QvSmF2YVNjcmlwdENvcmUva2pzL3NpbXBsZV9udW1iZXIuaCx2DQpyZXRyaWV2aW5nIHJldmlz aW9uIDEuMTENCmRpZmYgLXUgLXIxLjExIHNpbXBsZV9udW1iZXIuaA0KLS0tIGtqcy9zaW1wbGVf bnVtYmVyLmgJMTQgSnVsIDIwMDUgMTg6Mjc6MDMgLTAwMDAJMS4xMQ0KKysrIGtqcy9zaW1wbGVf bnVtYmVyLmgJNyBTZXAgMjAwNSAwMjo0NzoxNyAtMDAwMA0KQEAgLTI1LDggKzI1LDEyIEBADQog DQogI2luY2x1ZGUgPG1hdGguaD4NCiAjaW5jbHVkZSA8c3RyaW5nLmg+DQotDQorI2lmIFdJTjMy DQorI2luY2x1ZGUgPGZsb2F0Lmg+DQorI2RlZmluZSBJU19ORUdBVElWRV9aRVJPKG51bSkgKF9m cGNsYXNzKG51bSkgPT0gX0ZQQ0xBU1NfTlopDQorI2Vsc2UNCiAjZGVmaW5lIElTX05FR0FUSVZF X1pFUk8obnVtKSAobnVtID09IDAuMCAmJiAhbWVtY21wKCZudW0sICZTaW1wbGVOdW1iZXI6Om5l Z1plcm8sIHNpemVvZihkb3VibGUpKSkNCisjZW5kaWYNCiANCiBuYW1lc3BhY2UgS0pTIHsNCiAg ICAgY2xhc3MgVmFsdWVJbXA7DQo=