48692 2010-10-29 15:31:33 -0700 [Qt] QWebPage's InputMethod event handling calls ShortcutOverride handler too 2010-11-03 10:24:08 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned ademar oldest_to_newest 302137 0 kling 2010-10-29 15:31:33 -0700 Due to a missing break statement, QWebPage::event() falls through to QEvent::ShortcutOverride after handling QEvent::InputMethod and calls shortCutOverrideEvent() with a QInputMethodEvent cast to a QKeyEvent. Oops! 302140 1 72408 kling 2010-10-29 15:32:55 -0700 Created attachment 72408 Proposed patch 302164 2 72413 kling 2010-10-29 16:10:36 -0700 Created attachment 72413 Proposed patch Ahem.. 302172 3 72413 ariya.hidayat 2010-10-29 16:23:14 -0700 Comment on attachment 72413 Proposed patch LGTM. 302173 4 72413 kling 2010-10-29 16:25:04 -0700 Comment on attachment 72413 Proposed patch Clearing flags on attachment: 72413 Committed r70948: <http://trac.webkit.org/changeset/70948> 302174 5 kling 2010-10-29 16:25:13 -0700 All reviewed patches have been landed. Closing bug. 302177 6 kling 2010-10-29 16:28:54 -0700 Blocking 2.1 on this since it's trivial and obviously fixes a bug. 304106 7 ademar 2010-11-03 10:23:48 -0700 Revision r70948 cherry-picked into qtwebkit-2.1 with commit 0e4d96b <http://gitorious.org/webkit/qtwebkit/commit/0e4d96b> 72408 2010-10-29 15:32:55 -0700 2010-10-29 16:10:36 -0700 Proposed patch bug-48692.diff text/plain 559 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDBkYzgwOGUuLjMyZmM2MmIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTI5ICBBbmRy ZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFFXZWJQYWdlJ3MgSW5wdXRNZXRob2QgZXZlbnQg aGFuZGxpbmcgY2FsbHMgU2hvcnRjdXRPdmVycmlkZSBoYW5kbGVyIHRvbworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg2OTIKKworICAgICAgICAqIEFw aS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZTo6ZXZlbnQpOiBBZGQgbWlzc2luZyBi cmVhayBzdGF0ZW1lbnQuCisKIDIwMTAtMTAtMjkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCg== 72413 2010-10-29 16:10:36 -0700 2010-10-29 16:25:04 -0700 Proposed patch bug-48692-v2.diff text/plain 1017 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggZmE2NzJiOC4uNzUzM2E1NCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTI4 MzAsNiArMjgzMCw3IEBAIGJvb2wgUVdlYlBhZ2U6OmV2ZW50KFFFdmVudCAqZXYpCiAjZW5kaWYK ICAgICBjYXNlIFFFdmVudDo6SW5wdXRNZXRob2Q6CiAgICAgICAgIGQtPmlucHV0TWV0aG9kRXZl bnQoc3RhdGljX2Nhc3Q8UUlucHV0TWV0aG9kRXZlbnQqPihldikpOworICAgICAgICBicmVhazsK ICAgICBjYXNlIFFFdmVudDo6U2hvcnRjdXRPdmVycmlkZToKICAgICAgICAgZC0+c2hvcnRjdXRP dmVycmlkZUV2ZW50KHN0YXRpY19jYXN0PFFLZXlFdmVudCo+KGV2KSk7CiAgICAgICAgIGJyZWFr OwpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cK aW5kZXggMGRjODA4ZS4uMzJmYzYyYiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZwor KysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjkgIEFu ZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUVdlYlBhZ2UncyBJbnB1dE1ldGhvZCBldmVu dCBoYW5kbGluZyBjYWxscyBTaG9ydGN1dE92ZXJyaWRlIGhhbmRsZXIgdG9vCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODY5MgorCisgICAgICAgICog QXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjpldmVudCk6IEFkZCBtaXNzaW5n IGJyZWFrIHN0YXRlbWVudC4KKwogMjAxMC0xMC0yOSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFw QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4K