48688 2010-10-29 15:18:16 -0700 Disable media/video-canvas-alpha.html layout test for Qt & GTK 2010-11-02 03:02:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 acolwell webkit-unassigned kling mrobinson pnormand oldest_to_newest 302120 0 acolwell 2010-10-29 15:18:16 -0700 Disable layout test for platforms that don't support video 302124 1 72404 acolwell 2010-10-29 15:20:46 -0700 Created attachment 72404 Proposed Patch 302188 2 kling 2010-10-29 16:47:27 -0700 Committed r70952: <http://trac.webkit.org/changeset/70952> 302256 3 mrobinson 2010-10-29 22:34:23 -0700 GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive? 302325 4 acolwell 2010-10-30 10:14:06 -0700 (In reply to comment #3) > GTK+ supports video through Gstreamer and runs many of the media tests. Was this skip the result of a failure or was it preemptive? Check out the comments towards the bottom of https://bugs.webkit.org/show_bug.cgi?id=48094 Personally I didn't see where my new layout test broke the GTK build. I only saw positive confirmation on the Qt build. I was told to disable the tests for both Qt & GTK. I'm a newbie to this project so I just relied on what I was being told to do. Feel free to reenable it for the GTK build. 302326 5 mrobinson 2010-10-30 10:28:13 -0700 No problem, I was just curious. In general it's useful to has as much information about the failure as possible. If it's a bug with your patch or test, you'll probably be interested in fixing it. If it's a bug on Qt and GTK+ more information is useful for triaging it and getting the test unskipped. 303286 6 pnormand 2010-11-02 03:02:42 -0700 The test runs fine on GTK+ which, as Martin points out, supports HTML5 media since a while now. :) I will unskip the test and keep an eye on the buildbot. 72404 2010-10-29 15:20:46 -0700 2010-10-29 15:23:03 -0700 Proposed Patch blah.patch text/plain 1480 acolwell SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDcwOTM1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAtMjkgIEFhcm9uIENvbHdlbGwgIDxh Y29sd2VsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRGlzYWJsZSBtZWRpYS92aWRlby1jYW52YXMtYWxwaGEuaHRtbCBmb3Ig UXQgJiBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ4Njg4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDoKKyAgICAgICAgKiBwbGF0 Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTEwLTI5ICBCZW5qYW1pbiBLYWxtYW4gIDxrYWxtYW5A Z29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpJbmRleDogTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL1NraXBwZWQJKHJldmlzaW9uIDcwOTMyKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTU2OTMsMyArNTY5Myw2IEBAIGh0 dHAvdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUteGhyLWxvZ2dpbmcKIAogIyBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc3MjcKIG1hdGhtbC9wcmVzZW50YXRpb24KKwor IyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDgwOTQKK21lZGlhL3Zp ZGVvLWNhbnZhcy1hbHBoYS5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw cGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQJKHJldmlz aW9uIDcwOTMyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAkod29ya2luZyBj b3B5KQpAQCAtNTk3LDYgKzU5Nyw3IEBAIG1lZGlhL3ZpZGVvLWF1dG9wbGF5Lmh0bWwKIG1lZGlh L3ZpZGVvLWJ1ZmZlcmVkLmh0bWwKIG1lZGlhL3ZpZGVvLWNhbnZhcy5odG1sLWRpc2FibGVkCiBt ZWRpYS92aWRlby1jYW52YXMtc291cmNlLmh0bWwKK21lZGlhL3ZpZGVvLWNhbnZhcy1hbHBoYS5o dG1sCiBtZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25lLmh0bWwKIG1lZGlhL3Zp ZGVvLWNvbnRyb2xzLmh0bWwKIG1lZGlhL3ZpZGVvLWNvbnRyb2xzLXJlbmRlcmluZy5odG1sCg==