48675 2010-10-29 14:16:35 -0700 [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer 2010-10-29 16:19:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 302046 0 kling 2010-10-29 14:16:35 -0700 ==12248== Conditional jump or move depends on uninitialised value(s) ==12248== at 0x7ED0B7B: QTimerInfoList::unregisterTimer(int) (qeventdispatcher_unix.cpp:487) ==12248== by 0x42CD0D: FpsTimer::stop() (fpstimer.cpp:66) ==12248== by 0x42C4D5: WebViewGraphicsBased::setFrameRateMeasurementEnabled(bool) (webview.cpp:135) ==12248== by 0x41E9DD: LauncherWindow::applyPrefs() (launcherwindow.cpp:156) ==12248== by 0x41EB75: LauncherWindow::initializeView() (launcherwindow.cpp:131) ==12248== by 0x4226D2: LauncherWindow::init() (launcherwindow.cpp:90) ==12248== by 0x422EF7: LauncherWindow::LauncherWindow(WindowOptions*, QGraphicsScene*) (launcherwindow.cpp:49) ==12248== by 0x42753E: main (main.cpp:247) 302050 1 72391 kling 2010-10-29 14:18:50 -0700 Created attachment 72391 Proposed patch 302168 2 72391 kling 2010-10-29 16:19:49 -0700 Comment on attachment 72391 Proposed patch Clearing flags on attachment: 72391 Committed r70946: <http://trac.webkit.org/changeset/70946> 302169 3 kling 2010-10-29 16:19:57 -0700 All reviewed patches have been landed. Closing bug. 72391 2010-10-29 14:18:50 -0700 2010-10-29 16:19:49 -0700 Proposed patch bug-48675.diff text/plain 2151 kling ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0OWRkMDVjLi5iMWY3YTY3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAt MjkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUXRUZXN0QnJvd3NlcjogRml4IHVu aW5pdGlhbGl6ZWQgcmVhZCBpbiBGcHNUaW1lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg2NzUKKworICAgICAgICBGcHNUaW1lcjo6bV90aW1lciB3 YXMgbmV2ZXIgaW5pdGlhbGl6ZWQgYW5kIHBhc3NlZCB0byBRT2JqZWN0OjpraWxsVGltZXIoKQor ICAgICAgICBvbiBzdGFydHVwIHdpdGggaW4gLWdyYXBoaWNzYmFzZWQgbW9kZS4KKworICAgICAg ICAqIFF0VGVzdEJyb3dzZXIvZnBzdGltZXIuY3BwOgorICAgICAgICAoRnBzVGltZXI6OkZwc1Rp bWVyKToKKyAgICAgICAgKEZwc1RpbWVyOjpudW1GcmFtZXMpOgorICAgICAgICAoRnBzVGltZXI6 OnN0b3ApOgorICAgICAgICAoRnBzVGltZXI6OnRpbWVyRXZlbnQpOgorICAgICAgICAqIFF0VGVz dEJyb3dzZXIvZnBzdGltZXIuaDoKKwogMjAxMC0xMC0yOSAgRGltaXRyaSBHbGF6a292ICA8ZGds YXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkuCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2Zwc3RpbWVyLmNwcCBiL1dlYktp dFRvb2xzL1F0VGVzdEJyb3dzZXIvZnBzdGltZXIuY3BwCmluZGV4IDNiNzJjZWYuLmVhZTNkOWMg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvZnBzdGltZXIuY3BwCisrKyBi L1dlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvZnBzdGltZXIuY3BwCkBAIC0zNywxMSArMzcsMTIg QEAKICNkZWZpbmUgRlBTX01FQVNVUkVfSU5URVJWQUwgMTAwMCAvIDYwCiAKIEZwc1RpbWVyOjpG cHNUaW1lcihRT2JqZWN0KiBwYXJlbnQpCi0gICAgICAgIDogUU9iamVjdChwYXJlbnQpCisgICAg OiBRT2JqZWN0KHBhcmVudCkKKyAgICAsIG1fdGltZXIoMCkKIHsKIH0KIAotaW50IEZwc1RpbWVy OjpudW1GcmFtZXMoaW50IHNwYW5NaWxsaXMpCitpbnQgRnBzVGltZXI6Om51bUZyYW1lcyhpbnQg c3Bhbk1pbGxpcykgY29uc3QKIHsKICAgICBjb25zdCBRVGltZSBub3cgPSBRVGltZTo6Y3VycmVu dFRpbWUoKTsKIApAQCAtNjMsMTMgKzY0LDE1IEBAIHZvaWQgRnBzVGltZXI6OnN0YXJ0KCkKIAog dm9pZCBGcHNUaW1lcjo6c3RvcCgpCiB7CisgICAgaWYgKCFtX3RpbWVyKQorICAgICAgICByZXR1 cm47CiAgICAga2lsbFRpbWVyKG1fdGltZXIpOwogICAgIG1fZnJhbWVzLmNsZWFyKCk7CiB9CiAK IHZvaWQgRnBzVGltZXI6OnRpbWVyRXZlbnQoUVRpbWVyRXZlbnQqIGV2ZW50KQogewotICAgIGlm IChldmVudC0+dGltZXJJZCgpICE9ICBtX3RpbWVyKQorICAgIGlmIChldmVudC0+dGltZXJJZCgp ICE9IG1fdGltZXIpCiAgICAgICAgIHJldHVybjsKICAgICBtX2ZyYW1lcy5hcHBlbmQoUVRpbWU6 OmN1cnJlbnRUaW1lKCkpOwogICAgIGlmIChtX2ZyYW1lcy5sZW5ndGgoKSA+IE1BWF9GUkFNRVNf U0FWRUQpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2Zwc3RpbWVyLmgg Yi9XZWJLaXRUb29scy9RdFRlc3RCcm93c2VyL2Zwc3RpbWVyLmgKaW5kZXggYWNjZWNkMi4uZWVk MTE5OCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9mcHN0aW1lci5oCisr KyBiL1dlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvZnBzdGltZXIuaApAQCAtMzcsNyArMzcsNyBA QCBjbGFzcyBGcHNUaW1lciA6IHB1YmxpYyBRT2JqZWN0IHsKIAogcHVibGljOgogICAgIEZwc1Rp bWVyKFFPYmplY3QqIHBhcmVudCA9IDApOwotICAgIGludCBudW1GcmFtZXMoaW50IHNwYW5NaWxs aXMgPSAxMDAwKTsKKyAgICBpbnQgbnVtRnJhbWVzKGludCBzcGFuTWlsbGlzID0gMTAwMCkgY29u c3Q7CiAKIHB1YmxpYyBRX1NMT1RTOgogICAgIHZvaWQgc3RhcnQoKTsK