48657 2010-10-29 12:14:42 -0700 [chromium] add debug logging to help diagnose flakiness dashboard issues 2010-10-29 15:34:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth dglazkov eric tony webkit.review.bot oldest_to_newest 301939 0 ojan 2010-10-29 12:14:42 -0700 [chromium] add debug logging to help diagnose flakiness dashboard issues 301944 1 72365 ojan 2010-10-29 12:16:01 -0700 Created attachment 72365 Patch 301949 2 72365 tony 2010-10-29 12:19:54 -0700 Comment on attachment 72365 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72365&action=review > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:966 > files = [(file, os.path.join(self._options.results_directory, file)) > for file in json_files] Using a tuple here instead of a struct-like class makes me sad. 302025 3 ojan 2010-10-29 13:58:26 -0700 This seems to be resolved. Didn't end up committing. 302030 4 ojan 2010-10-29 14:02:41 -0700 Sigh. nm. Still need this. Will commit shortly. 302035 5 ojan 2010-10-29 14:06:26 -0700 Committed r70924: <http://trac.webkit.org/changeset/70924> 302144 6 webkit.review.bot 2010-10-29 15:34:08 -0700 http://trac.webkit.org/changeset/70924 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests) The following tests are not passing: media/controls-drag-timebar.html 72365 2010-10-29 12:16:01 -0700 2010-10-29 12:19:54 -0700 Patch bug-48657-20101029121559.patch text/plain 1733 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwNjFhZjdhYzg5NWNkOGE4YjExNzk4ZjNjMWIxZTkzZGYzNjE2NTYyLi5iYTNkOGYx NmY0NDdhNDU3N2FhNjM3Y2MwOWVlNjgzY2M5Y2ExNjU2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTAtMjkgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGFkZCBkZWJ1 ZyBsb2dnaW5nIHRvIGhlbHAgZGlhZ25vc2UgZmxha2luZXNzIGRhc2hib2FyZCBpc3N1ZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NjU3CisKKyAg ICAgICAgVGhlIGFwcGVuZ2luZSBhcHAgdGhpbmtzIGl0J3MgZ2V0dGluZyBlbXB0eSBmaWxlcyB1 cGxvYWRlZC4gQWRkIHNvbWUgbG9nZ2luZworICAgICAgICB0byBzZWUgaWYgbmV3LXJ1bi13ZWJr aXQtdGVzdHMgYWdyZWVzLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3Rz L3J1bl93ZWJraXRfdGVzdHMucHk6CisKIDIwMTAtMTAtMjggIE9qYW4gVmFmYWkgIDxvamFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUb255IENoYW5nLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93 ZWJraXRfdGVzdHMucHkKaW5kZXggMzlkMzQyYmI2ODFiNjg0OGMzNWIzYWM2Y2E0YmE1NTliZWZi OWZhNS4uMTg3N2QzNGU1ZDVlNTJkYzdlOWNmYWFlODEyNmE3M2Y2ZTZjMjQzOCAxMDA3NTUKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9y dW5fd2Via2l0X3Rlc3RzLnB5CkBAIC05NjUsNiArOTY1LDEzIEBAIGNsYXNzIFRlc3RSdW5uZXI6 CiAgICAgICAgIGZpbGVzID0gWyhmaWxlLCBvcy5wYXRoLmpvaW4oc2VsZi5fb3B0aW9ucy5yZXN1 bHRzX2RpcmVjdG9yeSwgZmlsZSkpCiAgICAgICAgICAgICBmb3IgZmlsZSBpbiBqc29uX2ZpbGVz XQogCisgICAgICAgICMgRklYTUU6IFJlbW92ZSB0aGlzLiBUaGlzIGlzIHRlbXBvcmFyeSBkZWJ1 ZyBsb2dnaW5nLgorICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmJ1aWxkZXJfbmFtZSA9PSAiV2Vi a2l0IExpbnV4IjoKKyAgICAgICAgICAgIGZvciBmaWxlbmFtZSBpbiBmaWxlczoKKyAgICAgICAg ICAgICAgICBfbG9nLmRlYnVnKGZpbGVuYW1lWzFdKQorICAgICAgICAgICAgICAgIHdpdGggY29k ZWNzLm9wZW4oZmlsZW5hbWVbMV0sICJyIikgYXMgcmVzdWx0c19maWxlOgorICAgICAgICAgICAg ICAgICAgICBfbG9nLmRlYnVnKCIlczpcbiVzIiAlIChmaWxlbmFtZVswXSwgcmVzdWx0c19maWxl LnJlYWQoKSkpCisKICAgICAgICAgdXBsb2FkZXIgPSB0ZXN0X3Jlc3VsdHNfdXBsb2FkZXIuVGVz dFJlc3VsdHNVcGxvYWRlcigKICAgICAgICAgICAgIHNlbGYuX29wdGlvbnMudGVzdF9yZXN1bHRz X3NlcnZlcikKICAgICAgICAgdHJ5Ogo=