48654 2010-10-29 12:05:26 -0700 ASSERTION FAILURE in WebProcessProxy::frameDestroyed when a Page is closed before it can send the DidCreateMainFrame message to the UIProcess 2010-10-29 12:32:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 jberlin jberlin andersca jberlin sam oldest_to_newest 301933 0 jberlin 2010-10-29 12:05:26 -0700 WebProcessProxy::frameDestroyed asserts that the frameID it was called with was registered in WebProcessProxy::frameCreated (which is called when the WebPageProxy is created). However, in the case where we close the page before it's had the chance to send the DidCreateMainFrame message back to the UI process, the UI Process will get the DidDestroyFrame message because it's sent directly to the WebProcessProxy and doesn't go through WebPageProxy. Therefore, the assert is invalid for that case and should be removed. <rdar://problem/8600977> 301947 1 72366 jberlin 2010-10-29 12:18:19 -0700 Created attachment 72366 Remove the invalid assertion 301960 2 72366 andersca 2010-10-29 12:26:04 -0700 Comment on attachment 72366 Remove the invalid assertion View in context: https://bugs.webkit.org/attachment.cgi?id=72366&action=review > WebKit2/UIProcess/WebProcessProxy.cpp:492 > + return; You can remove the call to m_frameMap.contains here, m_frameMap.remove will work just fine even if the frame doesn't exist in the map and it will avoid an extra hash lookup. 301963 3 jberlin 2010-10-29 12:28:24 -0700 (In reply to comment #2) > (From update of attachment 72366 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72366&action=review > > > WebKit2/UIProcess/WebProcessProxy.cpp:492 > > + return; > > You can remove the call to m_frameMap.contains here, m_frameMap.remove will work just fine even if the frame doesn't exist in the map and it will avoid an extra hash lookup. Done. 301968 4 72366 jberlin 2010-10-29 12:32:30 -0700 Comment on attachment 72366 Remove the invalid assertion Commited in r70915 http://trac.webkit.org/changeset/70915 72366 2010-10-29 12:18:19 -0700 2010-10-29 12:32:30 -0700 Remove the invalid assertion removeInvalidAssertInWebProcessProxyFrameDestroyed.patch text/plain 2003 jberlin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDkwOSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMTAtMjkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB U1NFUlRJT04gRkFJTFVSRSBpbiBXZWJQcm9jZXNzUHJveHk6OmZyYW1lRGVzdHJveWVkIHdoZW4g YSBQYWdlIGlzIGNsb3NlZCBiZWZvcmUgaXQgY2FuIHNlbmQKKyAgICAgICAgdGhlIERpZENyZWF0 ZU1haW5GcmFtZSBtZXNzc2FnZSB0byB0aGUgVUlQcm9jZXNzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg2NTQKKworICAgICAgICBXZWJQcm9jZXNz UHJveHk6OmZyYW1lRGVzdHJveWVkIHdhcyBhc3NlcnRpbmcgdGhhdCB0aGUgZnJhbWVJRCBpdCB3 YXMgY2FsbGVkIHdpdGggd2FzCisgICAgICAgIHJlZ2lzdGVyZWQgaW4gV2ViUHJvY2Vzc1Byb3h5 OjpmcmFtZUNyZWF0ZWQgKHdoaWNoIGlzIGNhbGxlZCB3aGVuIHRoZSBXZWJQYWdlUHJveHkgaXMK KyAgICAgICAgY3JlYXRlZCkuIEhvd2V2ZXIsIGluIHRoZSBjYXNlIHdoZXJlIHdlIGNsb3NlIHRo ZSBwYWdlIGJlZm9yZSBpdCdzIGhhZCB0aGUgY2hhbmNlIHRvIHNlbmQKKyAgICAgICAgdGhlIERp ZENyZWF0ZU1haW5GcmFtZSBtZXNzYWdlIGJhY2sgdG8gdGhlIFVJIHByb2Nlc3MsIHRoZSBVSSBQ cm9jZXNzIHdpbGwgZ2V0IHRoZQorICAgICAgICBEaWREZXN0cm95RnJhbWUgbWVzc2FnZSBiZWNh dXNlIGl0J3Mgc2VudCBkaXJlY3RseSB0byB0aGUgV2ViUHJvY2Vzc1Byb3h5IGFuZCBkb2Vzbid0 IGdvCisgICAgICAgIHRocm91Z2ggV2ViUGFnZVByb3h5LgorCisgICAgICAgIFJlbW92ZSB0aGUg YXNzZXJ0IGJlY2F1c2UgaXQgaXMgaW52YWxpZCBpbiB0aGlzIGNhc2UuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vz c1Byb3h5OjpmcmFtZURlc3Ryb3llZCk6CisKIDIwMTAtMTAtMjkgIEFkYW0gUm9iZW4gIDxhcm9i ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCB3aGVuIENhcmJvbiBwbHVnaW5zIGFy ZSBkaXNhYmxlZApJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Byb3h5LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCShyZXZp c2lvbiA3MDg4MikKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ4NSw3ICs0ODUsMTIgQEAgdm9pZCBXZWJQcm9jZXNzUHJveHk6OmZy YW1lQ3JlYXRlZCh1aW50NgogCiB2b2lkIFdlYlByb2Nlc3NQcm94eTo6ZnJhbWVEZXN0cm95ZWQo dWludDY0X3QgZnJhbWVJRCkKIHsKLSAgICBBU1NFUlQobV9mcmFtZU1hcC5jb250YWlucyhmcmFt ZUlEKSk7CisgICAgLy8gSWYgdGhlIHBhZ2UgaXMgY2xvc2VkIGJlZm9yZSBpdCBoYXMgaGFkIHRo ZSBjaGFuY2UgdG8gc2VuZCB0aGUgRGlkQ3JlYXRlTWFpbkZyYW1lIG1lc3NhZ2UKKyAgICAvLyBi YWNrIHRvIHRoZSBVSVByb2Nlc3MsIHRoZW4gdGhlIGZyYW1lRGVzdHJveWVkIG1lc3NhZ2Ugd2ls bCBzdGlsbCBiZSByZWNlaXZlZCBiZWNhdXNlIGl0CisgICAgLy8gZ2V0cyBzZW50IGRpcmVjdGx5 IHRvIHRoZSBXZWJQcm9jZXNzUHJveHkuCisgICAgaWYgKCFtX2ZyYW1lTWFwLmNvbnRhaW5zKGZy YW1lSUQpKQorICAgICAgICByZXR1cm47CisKICAgICBtX2ZyYW1lTWFwLnJlbW92ZShmcmFtZUlE KTsKIH0KIAo=