48647 2010-10-29 10:45:04 -0700 [Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium 2010-10-29 12:01:02 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue dglazkov ojan tony oldest_to_newest 301863 0 mihaip 2010-10-29 10:45:04 -0700 [Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium 301867 1 72348 mihaip 2010-10-29 10:46:26 -0700 Created attachment 72348 Patch 301869 2 mihaip 2010-10-29 10:47:33 -0700 Any of you mind reviewing? 301873 3 72348 tony 2010-10-29 10:50:09 -0700 Comment on attachment 72348 Patch It would be nice to add some text to the test describing what is being tested, but either way, this change seems fine. 301879 4 mihaip 2010-10-29 10:55:49 -0700 (In reply to comment #3) > (From update of attachment 72348 [details]) > It would be nice to add some text to the test describing what is being tested, but either way, this change seems fine. True. It used to have a description before http://trac.webkit.org/changeset/53672/trunk/LayoutTests/fast/loader/stateobjects/state-api-on-detached-frame-crash.html, I'll add it back. 301882 5 72350 mihaip 2010-10-29 10:59:38 -0700 Created attachment 72350 Patch 301927 6 72350 commit-queue 2010-10-29 12:00:56 -0700 Comment on attachment 72350 Patch Clearing flags on attachment: 72350 Committed r70913: <http://trac.webkit.org/changeset/70913> 301928 7 commit-queue 2010-10-29 12:01:02 -0700 All reviewed patches have been landed. Closing bug. 72348 2010-10-29 10:46:26 -0700 2010-10-29 10:59:35 -0700 Patch bug-48647-20101029104625.patch text/plain 3440 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYWYyNTlkMzgxZGU3MGE4NGY2N2NlNjI1NzllOWJmYjE1NjY2NzgzLi5kMDdlNzcy OWE1N2M4MmYxOGM3MGY5NTdjZWE4ZTVjZDg2NTBmMzZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMTAtMjkgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBm YXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNo Lmh0bWwgZG9lcyBub3QgcGFzcyBvbiBDaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg2NDcKKyAgICAgICAgCisgICAgICAgIENocm9taXVt IHRocm93cyBhbiBleGNlcHRpb24gaWYgY2FsbGluZyBwdXNoL3JlcGxhY2VTdGF0ZSBvbiBhIGRl dGFjaGVkCisgICAgICAgIGZyYW1lLCB3aGlsZSB0aGUgbWFjIHBvcnQgZmFpbHMgc2lsZW50bHkg KHByZXN1bWFibHkgYSBKU0MgdnMuIFY4IAorICAgICAgICBkaWZmZXJlbmNlKS4gRWl0aGVyIGJl aGF2aW9yIGlzIGNvcnJlY3QgKGFzIGxvbmcgYXMgd2UgZG9uJ3QgY3Jhc2gpLAorICAgICAgICBt YWtlIHRoZSB0ZXN0IGhhbmRsZSBib3RoLgorCisgICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVv YmplY3RzL3N0YXRlLWFwaS1vbi1kZXRhY2hlZC1mcmFtZS1jcmFzaC1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3N0YXRlLWFwaS1vbi1kZXRhY2hlZC1m cmFtZS1jcmFzaC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dDoKKwogMjAxMC0xMC0yOSAgTWlraGFpbCBOYWdhbm92ICA8bW5hZ2Fub3ZAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZCB0ZXN0X2V4cGVjdGF0 aW9ucyB1cGRhdGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9i amVjdHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1hcGktb24tZGV0YWNoZWQt ZnJhbWUtY3Jhc2gtZXhwZWN0ZWQudHh0CmluZGV4IDhiMTM3ODkxNzkxZmU5NjkyN2FkNzhlNjRi MGFhZDdiZGVkMDhiZGMuLjI0NjVlNWVjNzA2Y2Y4Y2UxYTJmYWUxODcyYTQxOTIwNTIzYzUwNDMg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1h cGktb24tZGV0YWNoZWQtZnJhbWUtY3Jhc2gtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1hcGktb24tZGV0YWNoZWQtZnJhbWUtY3Jh c2gtZXhwZWN0ZWQudHh0CkBAIC0xICsxIEBACi0KKyBQQVNTRUQKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1hcGktb24tZGV0YWNoZWQtZnJh bWUtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0 ZS1hcGktb24tZGV0YWNoZWQtZnJhbWUtY3Jhc2guaHRtbAppbmRleCBkOWU3YTJlOTBiMmNlNWMx OGEyNTI1N2I2YzQ1MDg5OTcyZjJjZjgzLi5jNDVmMDI2MzJlOTY4ZjMzM2IzNmFlYjUwMTQ5NTNi YTlhMjgyODU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVj dHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNoLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3N0YXRlLWFwaS1vbi1kZXRhY2hlZC1mcmFtZS1j cmFzaC5odG1sCkBAIC04LDEzICs4LDIzIEBAIGZ1bmN0aW9uIHJ1blRlc3QoKQogewogICAgIHZh ciBpZnIgPSBmcmFtZXNbMF07CiAgICAgZG9jdW1lbnQuYm9keS5yZW1vdmVDaGlsZChkb2N1bWVu dC5nZXRFbGVtZW50c0J5VGFnTmFtZSgiaWZyYW1lIilbMF0pCi0gICAgaWZyLmhpc3RvcnkucmVw bGFjZVN0YXRlKCJmb28iLCAiYmFyIik7Ci0gICAgaWZyLmhpc3RvcnkucHVzaFN0YXRlKCJmdSIs ICJiYXJyZWQiKTsKKyAgICB0cnkgeworICAgICAgICBpZnIuaGlzdG9yeS5yZXBsYWNlU3RhdGUo ImZvbyIsICJiYXIiKTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAgICAvLyBJZ25vcmUsIGV4cGVj dGVkCisgICAgfQorICAgIHRyeSB7CisgICAgICAgIGlmci5oaXN0b3J5LnB1c2hTdGF0ZSgiZnUi LCAiYmFycmVkIik7CisgICAgfSBjYXRjaCAoZSkgeworICAgICAgLy8gSWdub3JlLCBleHBlY3Rl ZCAgICAKKyAgICB9CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxvZyIpLnRleHRDb250 ZW50ID0gIlBBU1NFRCI7CiB9CiAKIDwvc2NyaXB0PgogPGJvZHkgb25sb2FkPSJydW5UZXN0KCk7 Ij4KIDxpZnJhbWUgc3JjPSJhYm91dDpibGFuayI+CiA8L2lmcmFtZT4KKzxwcmUgaWQ9ImxvZyI+ PC9wcmU+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9j aHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggZmE4MmMxMmY3NzdhNTlkMTcxZmQx MGRmMWI4YjkwYzUzNWRkODNmYy4uMmJmZmQ4MmVlOWIyZjZlNjJjMzFhNzAxMzAyOTU2ZTM3ODhi NDQ1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBl Y3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dApAQCAtMjE5Miw5ICsyMTkyLDYgQEAgQlVHMjkxNjcgTUFDIERFQlVHIDog ZmFzdC9kb20vcmVwbGFjZUNoaWxkLmh0bWwgPSBJTUFHRSBQQVNTCiAvLyBGYWlsdXJlIGZyb20g V2ViS2l0IG1lcmdlIDUxNjA3OjUxNjEzICg1MTYwOCBpcyB0aGUgY2F1c2UpCiBCVUcyOTIzOSBM SU5VWCBXSU4gOiBmYXN0L2Nzcy92YXJpYWJsZXMvbWlzcGxhY2VkLWltcG9ydC10ZXN0Lmh0bWwg PSBGQUlMCiAKLS8vIEZhaWx1cmVzIGZyb20gV2ViS2l0IG1lcmdlIDUxNjQyOjUxNjgxCi1CVUcy OTM5MyA6IGZhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1hcGktb24tZGV0YWNoZWQtZnJh bWUtY3Jhc2guaHRtbCA9IFRFWFQKLQogLy8gRmFpbHVyZXMgaW50cm9kdWNlZCBieSBVU0VfTkVX X0JVSUxERVIgaW4gU2tpYS4KIEJVRzMzMjg3IFdJTiBMSU5VWCA6IGZhc3QvY2FudmFzL3NldC1j b2xvcnMuaHRtbCA9IFRFWFQKIAo= 72350 2010-10-29 10:59:38 -0700 2010-10-29 12:00:56 -0700 Patch bug-48647-20101029105937.patch text/plain 3629 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYWYyNTlkMzgxZGU3MGE4NGY2N2NlNjI1NzllOWJmYjE1NjY2NzgzLi5kMDdlNzcy OWE1N2M4MmYxOGM3MGY5NTdjZWE4ZTVjZDg2NTBmMzZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMTAtMjkgIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBm YXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNo Lmh0bWwgZG9lcyBub3QgcGFzcyBvbiBDaHJvbWl1bQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg2NDcKKyAgICAgICAgCisgICAgICAgIENocm9taXVt IHRocm93cyBhbiBleGNlcHRpb24gaWYgY2FsbGluZyBwdXNoL3JlcGxhY2VTdGF0ZSBvbiBhIGRl dGFjaGVkCisgICAgICAgIGZyYW1lLCB3aGlsZSB0aGUgbWFjIHBvcnQgZmFpbHMgc2lsZW50bHkg KHByZXN1bWFibHkgYSBKU0MgdnMuIFY4IAorICAgICAgICBkaWZmZXJlbmNlKS4gRWl0aGVyIGJl aGF2aW9yIGlzIGNvcnJlY3QgKGFzIGxvbmcgYXMgd2UgZG9uJ3QgY3Jhc2gpLAorICAgICAgICBt YWtlIHRoZSB0ZXN0IGhhbmRsZSBib3RoLgorCisgICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVv YmplY3RzL3N0YXRlLWFwaS1vbi1kZXRhY2hlZC1mcmFtZS1jcmFzaC1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3N0YXRlLWFwaS1vbi1kZXRhY2hlZC1m cmFtZS1jcmFzaC5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dDoKKwogMjAxMC0xMC0yOSAgTWlraGFpbCBOYWdhbm92ICA8bW5hZ2Fub3ZAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZCB0ZXN0X2V4cGVjdGF0 aW9ucyB1cGRhdGUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9i amVjdHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1hcGktb24tZGV0YWNoZWQt ZnJhbWUtY3Jhc2gtZXhwZWN0ZWQudHh0CmluZGV4IDhiMTM3ODkxNzkxZmU5NjkyN2FkNzhlNjRi MGFhZDdiZGVkMDhiZGMuLmE1NGVkYmYxZDMzMTY4MzQyMGRkZmQ2MTFkZDU0MWE5NTkxNGIxMDYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1h cGktb24tZGV0YWNoZWQtZnJhbWUtY3Jhc2gtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1hcGktb24tZGV0YWNoZWQtZnJhbWUtY3Jh c2gtZXhwZWN0ZWQudHh0CkBAIC0xICsxLDIgQEAKLQorVGVzdHMgdGhhdCBjYWxsaW5nIHB1c2hT dGF0ZSBvciByZXBsYWNlU3RhdGUgb24gYSBkZXRhY2hlZCBmcmFtZSBkb2Vzbid0IGNyYXNoLgor UEFTU0VECmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMv c3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L2xvYWRlci9zdGF0ZW9iamVjdHMvc3RhdGUtYXBpLW9uLWRldGFjaGVkLWZyYW1lLWNyYXNoLmh0 bWwKaW5kZXggZDllN2EyZTkwYjJjZTVjMThhMjUyNTdiNmM0NTA4OTk3MmYyY2Y4My4uYmI3MWJm NzI2NzcxY2JlYTM0MTgyNjI2NmUwZjVmNTVhZWJhOTU0MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3N0YXRlLWFwaS1vbi1kZXRhY2hlZC1mcmFtZS1j cmFzaC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0 ZS1hcGktb24tZGV0YWNoZWQtZnJhbWUtY3Jhc2guaHRtbApAQCAtOCwxMyArOCwyNCBAQCBmdW5j dGlvbiBydW5UZXN0KCkKIHsKICAgICB2YXIgaWZyID0gZnJhbWVzWzBdOwogICAgIGRvY3VtZW50 LmJvZHkucmVtb3ZlQ2hpbGQoZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoImlmcmFtZSIp WzBdKQotICAgIGlmci5oaXN0b3J5LnJlcGxhY2VTdGF0ZSgiZm9vIiwgImJhciIpOwotICAgIGlm ci5oaXN0b3J5LnB1c2hTdGF0ZSgiZnUiLCAiYmFycmVkIik7CisgICAgdHJ5IHsKKyAgICAgICAg aWZyLmhpc3RvcnkucmVwbGFjZVN0YXRlKCJmb28iLCAiYmFyIik7CisgICAgfSBjYXRjaCAoZSkg eworICAgICAgLy8gSWdub3JlLCBleHBlY3RlZAorICAgIH0KKyAgICB0cnkgeworICAgICAgICBp ZnIuaGlzdG9yeS5wdXNoU3RhdGUoImZ1IiwgImJhcnJlZCIpOworICAgIH0gY2F0Y2ggKGUpIHsK KyAgICAgIC8vIElnbm9yZSwgZXhwZWN0ZWQgICAgCisgICAgfQorICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJsb2ciKS50ZXh0Q29udGVudCA9ICJQQVNTRUQiOwogfQogCiA8L3NjcmlwdD4K IDxib2R5IG9ubG9hZD0icnVuVGVzdCgpOyI+CitUZXN0cyB0aGF0IGNhbGxpbmcgPGNvZGU+cHVz aFN0YXRlPC9jb2RlPiBvciA8Y29kZT5yZXBsYWNlU3RhdGU8L2NvZGU+IG9uIGEgZGV0YWNoZWQg ZnJhbWUgZG9lc24ndCBjcmFzaC4KIDxpZnJhbWUgc3JjPSJhYm91dDpibGFuayI+CiA8L2lmcmFt ZT4KKzxwcmUgaWQ9ImxvZyI+PC9wcmU+CiA8L2JvZHk+CiA8L2h0bWw+CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggZmE4 MmMxMmY3NzdhNTlkMTcxZmQxMGRmMWI4YjkwYzUzNWRkODNmYy4uMmJmZmQ4MmVlOWIyZjZlNjJj MzFhNzAxMzAyOTU2ZTM3ODhiNDQ1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Y2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dApAQCAtMjE5Miw5ICsyMTkyLDYgQEAgQlVH MjkxNjcgTUFDIERFQlVHIDogZmFzdC9kb20vcmVwbGFjZUNoaWxkLmh0bWwgPSBJTUFHRSBQQVNT CiAvLyBGYWlsdXJlIGZyb20gV2ViS2l0IG1lcmdlIDUxNjA3OjUxNjEzICg1MTYwOCBpcyB0aGUg Y2F1c2UpCiBCVUcyOTIzOSBMSU5VWCBXSU4gOiBmYXN0L2Nzcy92YXJpYWJsZXMvbWlzcGxhY2Vk LWltcG9ydC10ZXN0Lmh0bWwgPSBGQUlMCiAKLS8vIEZhaWx1cmVzIGZyb20gV2ViS2l0IG1lcmdl IDUxNjQyOjUxNjgxCi1CVUcyOTM5MyA6IGZhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9zdGF0ZS1h cGktb24tZGV0YWNoZWQtZnJhbWUtY3Jhc2guaHRtbCA9IFRFWFQKLQogLy8gRmFpbHVyZXMgaW50 cm9kdWNlZCBieSBVU0VfTkVXX0JVSUxERVIgaW4gU2tpYS4KIEJVRzMzMjg3IFdJTiBMSU5VWCA6 IGZhc3QvY2FudmFzL3NldC1jb2xvcnMuaHRtbCA9IFRFWFQKIAo=