48624 2010-10-29 04:29:05 -0700 [Qt] GraphicsLayer: Don't notifySyncRequired() more than necessary 2010-10-29 06:39:43 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned ariya.hidayat noam oldest_to_newest 301685 0 kling 2010-10-29 04:29:05 -0700 If there's already a notifySyncRequired() queued, we should only update the ChangeMask. We currently queue a call (using QMetaMethod::invoke) every time notifyChange() is called. This is expensive, and also makes GraphicsLayerQt expensive to destroy (since all posted method invocation events have to be ripped out of the event queue.) 301686 1 72314 kling 2010-10-29 04:37:14 -0700 Created attachment 72314 Proposed patch 4% speedup on <http://ariya.github.com/clock.htm> 301724 2 kling 2010-10-29 06:39:43 -0700 Committed r70868: <http://trac.webkit.org/changeset/70868> 72314 2010-10-29 04:37:14 -0700 2010-10-29 06:29:50 -0700 Proposed patch bug-48624.diff text/plain 2488 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDkwMTIyZC4uNzhlMTc3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0yOSAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBHcmFwaGljc0xheWVyOiBEb24ndCBub3RpZnlTeW5jUmVxdWly ZWQoKSBtb3JlIHRoYW4gbmVjZXNzYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00ODYyNAorCisgICAgICAgIERvbid0IHF1ZXVlIG11bHRpcGxlIG1l dGEgbWV0aG9kIGludm9jYXRpb25zIGZvciBub3RpZnlTeW5jUmVxdWlyZWQoKQorCisgICAgICAg IDQlIHNwZWVkdXAgb24gPGh0dHA6Ly9hcml5YS5naXRodWIuY29tL2Nsb2NrLmh0bT4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJRdC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjpHcmFwaGljc0xheWVyUXRJbXBsKToKKyAg ICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJRdEltcGw6Om5vdGlmeVN5bmNSZXF1aXJlZCk6 CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyUXRJbXBsOjpub3RpZnlDaGFuZ2UpOgor CiAyMDEwLTEwLTI3ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERpcmsgU2NodWx6ZS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAppbmRleCBlMDk0MWY1Li44MzAwNGE5 IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5ZXJR dC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVyUXQu Y3BwCkBAIC0yMDAsNiArMjAwLDcgQEAgcHVibGljOgogICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4 IG1fdHJhbnNmb3JtUmVsYXRpdmVUb1Jvb3RMYXllcjsKICAgICBib29sIG1fdHJhbnNmb3JtQW5p bWF0aW9uUnVubmluZzsKICAgICBib29sIG1fb3BhY2l0eUFuaW1hdGlvblJ1bm5pbmc7CisgICAg Ym9vbCBtX3F1ZXVlZE5vdGlmeVN5bmNSZXF1aXJlZDsKICNpZm5kZWYgUVRfTk9fR1JBUEhJQ1NF RkZFQ1QKICAgICBRV2Vha1BvaW50ZXI8TWFza0VmZmVjdFF0PiBtX21hc2tFZmZlY3Q7CiAjZW5k aWYKQEAgLTMwMCw2ICszMDEsNyBAQCBHcmFwaGljc0xheWVyUXRJbXBsOjpHcmFwaGljc0xheWVy UXRJbXBsKEdyYXBoaWNzTGF5ZXJRdCogbmV3TGF5ZXIpCiAgICAgLCBtX2xheWVyKG5ld0xheWVy KQogICAgICwgbV90cmFuc2Zvcm1BbmltYXRpb25SdW5uaW5nKGZhbHNlKQogICAgICwgbV9vcGFj aXR5QW5pbWF0aW9uUnVubmluZyhmYWxzZSkKKyAgICAsIG1fcXVldWVkTm90aWZ5U3luY1JlcXVp cmVkKGZhbHNlKQogICAgICwgbV9jaGFuZ2VNYXNrKE5vQ2hhbmdlcykKICNpZiBFTkFCTEUoM0Rf Q0FOVkFTKQogICAgICwgbV9nYzNEKDApCkBAIC01OTMsNiArNTk1LDggQEAgdm9pZCBHcmFwaGlj c0xheWVyUXRJbXBsOjpwYWludChRUGFpbnRlciogcGFpbnRlciwgY29uc3QgUVN0eWxlT3B0aW9u R3JhcGhpY3NJdGUKIAogdm9pZCBHcmFwaGljc0xheWVyUXRJbXBsOjpub3RpZnlTeW5jUmVxdWly ZWQoKQogeworICAgIG1fcXVldWVkTm90aWZ5U3luY1JlcXVpcmVkID0gZmFsc2U7CisKICAgICBp ZiAobV9sYXllci0+Y2xpZW50KCkpCiAgICAgICAgIG1fbGF5ZXItPmNsaWVudCgpLT5ub3RpZnlT eW5jUmVxdWlyZWQobV9sYXllcik7CiB9CkBAIC02MDAsOCArNjA0LDE0IEBAIHZvaWQgR3JhcGhp Y3NMYXllclF0SW1wbDo6bm90aWZ5U3luY1JlcXVpcmVkKCkKIHZvaWQgR3JhcGhpY3NMYXllclF0 SW1wbDo6bm90aWZ5Q2hhbmdlKENoYW5nZU1hc2sgY2hhbmdlTWFzaykKIHsKICAgICBtX2NoYW5n ZU1hc2sgfD0gY2hhbmdlTWFzazsKKworICAgIGlmIChtX3F1ZXVlZE5vdGlmeVN5bmNSZXF1aXJl ZCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgc3RhdGljIFFNZXRhTWV0aG9kIHN5bmNNZXRob2Qg PSBzdGF0aWNNZXRhT2JqZWN0Lm1ldGhvZChzdGF0aWNNZXRhT2JqZWN0LmluZGV4T2ZNZXRob2Qo Im5vdGlmeVN5bmNSZXF1aXJlZCgpIikpOwogICAgIHN5bmNNZXRob2QuaW52b2tlKHRoaXMsIFF0 OjpRdWV1ZWRDb25uZWN0aW9uKTsKKworICAgIG1fcXVldWVkTm90aWZ5U3luY1JlcXVpcmVkID0g dHJ1ZTsKIH0KIAogdm9pZCBHcmFwaGljc0xheWVyUXRJbXBsOjpmbHVzaENoYW5nZXMoYm9vbCBy ZWN1cnNpdmUsIGJvb2wgZm9yY2VVcGRhdGVUcmFuc2Zvcm0pCg==