48605 2010-10-28 18:24:06 -0700 Move code to dispatch a sync message out into a separate function 2010-12-14 09:12:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca eric oldest_to_newest 301522 0 andersca 2010-10-28 18:24:06 -0700 Move code to dispatch a sync message out into a separate function 301523 1 72280 andersca 2010-10-28 18:26:06 -0700 Created attachment 72280 Patch 321820 2 eric 2010-12-14 01:49:44 -0800 I assume this was landed but not closed? (webkit-patch land! it slices, dices and even updates and closes bugs after landing!) 322001 3 andersca 2010-12-14 09:12:14 -0800 Committed r70833: <http://trac.webkit.org/changeset/70833> 72280 2010-10-28 18:26:06 -0700 2010-10-28 18:27:52 -0700 Patch bug-48605-20101028182605.patch text/plain 4565 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg NDg0NjY1NDRhOTI3ZTA0NTJhOTE2YmYwNmQzOWU3MGQ0YTMxOGI3Ni4uYWVjYmNiNTk5ZWQ4YjQ0 ZmVmMzYwYTVkMmE5MDEyOGRiNGIzMjhjOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0xMC0yOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgY29kZSB0byBkaXNwYXRjaCBhIHN5bmMg bWVzc2FnZSBvdXQgaW50byBhIHNlcGFyYXRlIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODYwNQorCisgICAgICAgICogUGxhdGZvcm0v Q29yZUlQQy9Db25uZWN0aW9uLmNwcDoKKyAgICAgICAgKENvcmVJUEM6OkNvbm5lY3Rpb246OmRp c3BhdGNoU3luY01lc3NhZ2UpOgorICAgICAgICBGYWN0b3IgY29kZSBvdXQgZnJvbSBkaXNwYXRj aE1lc3NhZ2UuIEhhbmRsZSByZWNlaXZpbmcgYSBtZXNzYWdlIHdpdGggYW4gaW52YWxpZCByZXBs eSBJRC4KKworICAgICAgICAoQ29yZUlQQzo6Q29ubmVjdGlvbjo6ZGlzcGF0Y2hNZXNzYWdlcyk6 CisgICAgICAgIENhbGwgZGlzcGF0Y2hTeW5jTWVzc2FnZS4KKworICAgICAgICAqIFBsYXRmb3Jt L0NvcmVJUEMvQ29ubmVjdGlvbi5oOgorCisyMDEwLTEwLTI4ICBBbmRlcnMgQ2FybHNzb24gIDxh bmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCiAK ICAgICAgICAgQWRkIE5QT2JqZWN0TWVzc2FnZVJlY2VpdmVyIGNsYXNzLgpkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwIGIvV2ViS2l0Mi9QbGF0Zm9y bS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCmluZGV4IDFmZWZhN2U2ZTFkYjkxZTliZTg2YzAwZjcx YWVmY2VkMWY1ZjZkYTEuLmM2NzhkMTcxMGI3ZGJiMTM1MzBlYTU2ZDUyZTM5Nzg1OTEzOWMxNDMg MTAwNjQ0Ci0tLSBhL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAorKysg Yi9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKQEAgLTMxMiw2ICszMTIs MzggQEAgdm9pZCBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlcygpCiAgICAgfQogfQog Cit2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoU3luY01lc3NhZ2UoTWVzc2FnZUlEIG1lc3NhZ2VJ RCwgQXJndW1lbnREZWNvZGVyKiBhcmd1bWVudHMpCit7CisgICAgQVNTRVJUKG1lc3NhZ2VJRC5p c1N5bmMoKSk7CisKKyAgICAvLyBEZWNvZGUgdGhlIHN5bmMgcmVxdWVzdCBJRC4KKyAgICB1aW50 NjRfdCBzeW5jUmVxdWVzdElEID0gMDsKKworICAgIGlmICghYXJndW1lbnRzLT5kZWNvZGVVSW50 NjQoc3luY1JlcXVlc3RJRCkgfHwgIXN5bmNSZXF1ZXN0SUQpIHsKKyAgICAgICAgLy8gV2UgcmVj ZWl2ZWQgYW4gaW52YWxpZCBzeW5jIG1lc3NhZ2UuCisgICAgICAgIGFyZ3VtZW50cy0+bWFya0lu dmFsaWQoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIENyZWF0ZSBvdXIgcmVw bHkgZW5jb2Rlci4KKyAgICBBcmd1bWVudEVuY29kZXIqIHJlcGx5RW5jb2RlciA9IG5ldyBBcmd1 bWVudEVuY29kZXIoc3luY1JlcXVlc3RJRCk7CisgICAgCisgICAgLy8gSGFuZCBvZmYgYm90aCB0 aGUgZGVjb2RlciBhbmQgZW5jb2RlciB0byB0aGUgY2xpZW50Li4KKyAgICBTeW5jUmVwbHlNb2Rl IHN5bmNSZXBseU1vZGUgPSBtX2NsaWVudC0+ZGlkUmVjZWl2ZVN5bmNNZXNzYWdlKHRoaXMsIG1l c3NhZ2VJRCwgYXJndW1lbnRzLCByZXBseUVuY29kZXIpOworCisgICAgLy8gRklYTUU6IElmIHRo ZSBtZXNzYWdlIHdhcyBpbnZhbGlkLCB3ZSBzaG91bGQgc2VuZCBiYWNrIGEgU3luY01lc3NhZ2VF cnJvci4KKyAgICBBU1NFUlQoIWFyZ3VtZW50cy0+aXNJbnZhbGlkKCkpOworCisgICAgaWYgKHN5 bmNSZXBseU1vZGUgPT0gTWFudWFsUmVwbHkpIHsKKyAgICAgICAgLy8gVGhlIGNsaWVudCB3aWxs IHRha2Ugb3duZXJzaGlwIG9mIHRoZSByZXBseSBlbmNvZGVyIGFuZCBzZW5kIGl0IGF0IHNvbWUg cG9pbnQgaW4gdGhlIGZ1dHVyZS4KKyAgICAgICAgLy8gV2Ugd29uJ3QgZG8gYW55dGhpbmcgaGVy ZS4KKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8vIFNlbmQgdGhlIHJlcGx5LgorICAg IHNlbmRTeW5jUmVwbHkocmVwbHlFbmNvZGVyKTsKK30KKwogdm9pZCBDb25uZWN0aW9uOjpkaXNw YXRjaE1lc3NhZ2VzKCkKIHsKICAgICBWZWN0b3I8SW5jb21pbmdNZXNzYWdlPiBpbmNvbWluZ01l c3NhZ2VzOwpAQCAtMzMwLDMyICszNjIsOSBAQCB2b2lkIENvbm5lY3Rpb246OmRpc3BhdGNoTWVz c2FnZXMoKQogICAgICAgICBJbmNvbWluZ01lc3NhZ2UmIG1lc3NhZ2UgPSBpbmNvbWluZ01lc3Nh Z2VzW2ldOwogICAgICAgICBPd25QdHI8QXJndW1lbnREZWNvZGVyPiBhcmd1bWVudHMgPSBtZXNz YWdlLnJlbGVhc2VBcmd1bWVudHMoKTsKIAotICAgICAgICBpZiAobWVzc2FnZS5tZXNzYWdlSUQo KS5pc1N5bmMoKSkgewotICAgICAgICAgICAgLy8gRGVjb2RlIHRoZSBzeW5jIHJlcXVlc3QgSUQu Ci0gICAgICAgICAgICB1aW50NjRfdCBzeW5jUmVxdWVzdElEID0gMDsKLQotICAgICAgICAgICAg aWYgKCFhcmd1bWVudHMtPmRlY29kZVVJbnQ2NChzeW5jUmVxdWVzdElEKSkgewotICAgICAgICAg ICAgICAgIC8vIEZJWE1FOiBIYW5kbGUgdGhpcyBjYXNlLgotICAgICAgICAgICAgICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICAgICAgfQotCi0gICAgICAgICAgICAvLyBDcmVhdGUg b3VyIHJlcGx5IGVuY29kZXIuCi0gICAgICAgICAgICBBcmd1bWVudEVuY29kZXIqIHJlcGx5RW5j b2RlciA9IG5ldyBBcmd1bWVudEVuY29kZXIoc3luY1JlcXVlc3RJRCk7Ci0gICAgICAgICAgICAK LSAgICAgICAgICAgIC8vIEhhbmQgb2ZmIGJvdGggdGhlIGRlY29kZXIgYW5kIGVuY29kZXIgdG8g dGhlIGNsaWVudC4uCi0gICAgICAgICAgICBTeW5jUmVwbHlNb2RlIHN5bmNSZXBseU1vZGUgPSBt X2NsaWVudC0+ZGlkUmVjZWl2ZVN5bmNNZXNzYWdlKHRoaXMsIG1lc3NhZ2UubWVzc2FnZUlEKCks IGFyZ3VtZW50cy5nZXQoKSwgcmVwbHlFbmNvZGVyKTsKLSAgICAgICAgICAgIAotICAgICAgICAg ICAgLy8gRklYTUU6IElmIHRoZSBtZXNzYWdlIHdhcyBpbnZhbGlkLCB3ZSBzaG91bGQgc2VuZCBi YWNrIGEgU3luY01lc3NhZ2VFcnJvci4KLSAgICAgICAgICAgIEFTU0VSVCghYXJndW1lbnRzLT5p c0ludmFsaWQoKSk7Ci0KLSAgICAgICAgICAgIGlmIChzeW5jUmVwbHlNb2RlID09IEF1dG9tYXRp Y1JlcGx5KSB7Ci0gICAgICAgICAgICAgICAgLy8gU2VuZCB0aGUgcmVwbHkuCi0gICAgICAgICAg ICAgICAgc2VuZFN5bmNSZXBseShyZXBseUVuY29kZXIpOwotICAgICAgICAgICAgfSBlbHNlIHsK LSAgICAgICAgICAgICAgICAvLyBUaGUgY2xpZW50IHdpbGwgdGFrZSBvd25lcnNoaXAgb2YgdGhl IHJlcGx5IGVuY29kZXIgYW5kIHNlbmQgaXQgYXQgc29tZSBwb2ludCBpbiB0aGUgZnV0dXJlLgot ICAgICAgICAgICAgICAgIC8vIFdlIHdvbid0IGRvIGFueXRoaW5nIGhlcmUuCi0gICAgICAgICAg ICB9Ci0gICAgICAgIH0gZWxzZQorICAgICAgICBpZiAobWVzc2FnZS5tZXNzYWdlSUQoKS5pc1N5 bmMoKSkKKyAgICAgICAgICAgIGRpc3BhdGNoU3luY01lc3NhZ2UobWVzc2FnZS5tZXNzYWdlSUQo KSwgYXJndW1lbnRzLmdldCgpKTsKKyAgICAgICAgZWxzZQogICAgICAgICAgICAgbV9jbGllbnQt PmRpZFJlY2VpdmVNZXNzYWdlKHRoaXMsIG1lc3NhZ2UubWVzc2FnZUlEKCksIGFyZ3VtZW50cy5n ZXQoKSk7CiAKICAgICAgICAgaWYgKGFyZ3VtZW50cy0+aXNJbnZhbGlkKCkpCmRpZmYgLS1naXQg YS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oIGIvV2ViS2l0Mi9QbGF0Zm9y bS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAppbmRleCBlNTE0NDUyOWY0MDYxN2MxOWNlMjBkNmFhYzY5 ODI0MmQ4YjcyZjY3Li5lZWVjMjZmZDYyMDU0Nzc1ZWYwN2JmM2E1NmJjMTQwMjA0YjlkZWRkIDEw MDY0NAotLS0gYS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oCisrKyBiL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKQEAgLTE2OCw3ICsxNjgsOCBAQCBw cml2YXRlOgogICAgIC8vIENhbGxlZCBvbiB0aGUgbGlzdGVuZXIgdGhyZWFkLgogICAgIHZvaWQg ZGlzcGF0Y2hDb25uZWN0aW9uRGlkQ2xvc2UoKTsKICAgICB2b2lkIGRpc3BhdGNoTWVzc2FnZXMo KTsKLSAgICAKKyAgICB2b2lkIGRpc3BhdGNoU3luY01lc3NhZ2UoTWVzc2FnZUlELCBBcmd1bWVu dERlY29kZXIqKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCiAgICAgQ2xpZW50KiBt X2NsaWVudDsKICAgICBib29sIG1faXNTZXJ2ZXI7CiAgICAgdWludDY0X3QgbV9zeW5jUmVxdWVz dElEOwo=