48592 2010-10-28 16:48:18 -0700 [Chrome] Need to fix an appcache regression introduced in r69226 2010-10-29 15:34:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 michaeln michaeln abarth ap eric webkit.review.bot oldest_to_newest 301456 0 michaeln 2010-10-28 16:48:18 -0700 r69226 fixed a bug with retrieving main resources out of webcore's appcache upon redirection. Ironically, chrome didn't exhibit a bug in this regard until this patch was landed. It broke chrome's handling of this case. 301507 1 72277 michaeln 2010-10-28 18:01:47 -0700 Created attachment 72277 fix regression 301557 2 72277 ap 2010-10-28 20:39:16 -0700 Comment on attachment 72277 fix regression OK. This code is overdue for refactoring - even the name ApplicationCacheHost conflicts with HTML5, and of course forking code is a recipe for continuing trouble. 301991 3 michaeln 2010-10-29 13:15:09 -0700 (In reply to comment #2) > (From update of attachment 72277 [details]) > OK. > > This code is overdue for refactoring - even the name ApplicationCacheHost conflicts with HTML5, and of course forking code is a recipe for continuing trouble. Why do you say that name conflicts? "A cache host is a Document or a SharedWorkerGlobalScope object. A cache host can be associated with an application cache." This class is the class that instills a document or shared worker with that ability. 301999 4 ap 2010-10-29 13:22:16 -0700 The translation of "is a" relationship into C++ is very unambiguous. It's inheritance. To match the HTML5 model, a class named ApplicationCacheHost (if one exists) has to be a parent class of Document. 302036 5 michaeln 2010-10-29 14:07:04 -0700 Committed r70923: <http://trac.webkit.org/changeset/70923> 302143 6 webkit.review.bot 2010-10-29 15:34:01 -0700 http://trac.webkit.org/changeset/70923 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests) The following tests are not passing: media/controls-drag-timebar.html 72277 2010-10-28 18:01:47 -0700 2010-10-28 20:39:16 -0700 fix regression regression.txt text/plain 4698 michaeln SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDgyOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMjggIE1pY2hhZWwgTm9yZG1hbiAgPG1pY2hhZWxuQGdv b2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0Nocm9tZV0gRml4IGFuIGFwcGNhY2hlIHJlZ3Jlc3Npb24gaW50cm9kdWNlZCBpbiByNjky MjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NTky CisgICAgICAgIERlZmluZSBhIG5ldyBBcHBsaWNhdGlvbkNhY2hlSG9zdCBtZXRob2QgZm9yIHRo ZSBzcGVjaWZpYyBjYXNlIG9mIG1haW4gcmVzb3VyY2UgcmVkaXJlY3QgaGFuZGxpbmcuCisKKyAg ICAgICAgVGVzdHM6IHRoZSBleGlzdGluZyBsYXlvdXQgdGVzdCBhcHBsaWVzCisKKyAgICAgICAg KiBsb2FkZXIvTWFpblJlc291cmNlTG9hZGVyLmNwcDogdXNlIHRoZSBuZXdseSBpbnRyb2R1Y2Vk IG1ldGhvZAorICAgICAgICAoV2ViQ29yZTo6TWFpblJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJl cXVlc3QpOgorICAgICAgICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkTWFp blJlc291cmNlRm9yUmVkaXJlY3QpOgorICAgICAgICAqIGxvYWRlci9hcHBjYWNoZS9BcHBsaWNh dGlvbkNhY2hlSG9zdC5oOgorCiAyMDEwLTEwLTI4ICBKaWEgUHUgIDxqcHVAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL2xvYWRl ci9NYWluUmVzb3VyY2VMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvbG9hZGVyL01h aW5SZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDcwODE4KQorKysgV2ViQ29yZS9sb2FkZXIv TWFpblJlc291cmNlTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAyLDkgKzIwMiw4IEBA IHZvaWQgTWFpblJlc291cmNlTG9hZGVyOjp3aWxsU2VuZFJlcXVlc3QKICNpZiBFTkFCTEUoT0ZG TElORV9XRUJfQVBQTElDQVRJT05TKQogICAgIGlmICghcmVkaXJlY3RSZXNwb25zZS5pc051bGwo KSkgewogICAgICAgICAvLyBXZSBjaGVja2VkIGFwcGxpY2F0aW9uIGNhY2hlIGZvciBpbml0aWFs IFVSTCwgbm93IHdlIG5lZWQgdG8gY2hlY2sgaXQgZm9yIHJlZGlyZWN0ZWQgb25lLgotICAgICAg ICBBU1NFUlQoZG9jdW1lbnRMb2FkZXIoKS0+YXBwbGljYXRpb25DYWNoZUhvc3QoKS0+c3RhdHVz KCkgPT0gQXBwbGljYXRpb25DYWNoZUhvc3Q6OlVOQ0FDSEVEKTsKICAgICAgICAgQVNTRVJUKCFt X3N1YnN0aXR1dGVEYXRhLmlzVmFsaWQoKSk7Ci0gICAgICAgIGRvY3VtZW50TG9hZGVyKCktPmFw cGxpY2F0aW9uQ2FjaGVIb3N0KCktPm1heWJlTG9hZE1haW5SZXNvdXJjZShuZXdSZXF1ZXN0LCBt X3N1YnN0aXR1dGVEYXRhKTsKKyAgICAgICAgZG9jdW1lbnRMb2FkZXIoKS0+YXBwbGljYXRpb25D YWNoZUhvc3QoKS0+bWF5YmVMb2FkTWFpblJlc291cmNlRm9yUmVkaXJlY3QobmV3UmVxdWVzdCwg bV9zdWJzdGl0dXRlRGF0YSk7CiAgICAgfQogI2VuZGlmCiAKSW5kZXg6IFdlYkNvcmUvbG9hZGVy L2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5jcHAJKHJldmlzaW9uIDcwODE4 KQorKysgV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05MSw2ICs5MSwxMiBAQCB2b2lkIEFwcGxpY2F0aW9uQ2FjaGVIb3N0 OjptYXliZUxvYWRNYWluCiAgICAgfQogfQogCit2b2lkIEFwcGxpY2F0aW9uQ2FjaGVIb3N0Ojpt YXliZUxvYWRNYWluUmVzb3VyY2VGb3JSZWRpcmVjdChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3Qs IFN1YnN0aXR1dGVEYXRhJiBzdWJzdGl0dXRlRGF0YSkKK3sKKyAgICBBU1NFUlQoc3RhdHVzKCkg PT0gVU5DQUNIRUQpOworICAgIG1heWJlTG9hZE1haW5SZXNvdXJjZShyZXF1ZXN0LCBzdWJzdGl0 dXRlRGF0YSk7Cit9CisKIGJvb2wgQXBwbGljYXRpb25DYWNoZUhvc3Q6Om1heWJlTG9hZEZhbGxi YWNrRm9yTWFpblJlc3BvbnNlKGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCwgY29uc3Qg UmVzb3VyY2VSZXNwb25zZSYgcikKIHsKICAgICBpZiAoci5odHRwU3RhdHVzQ29kZSgpIC8gMTAw ID09IDQgfHwgci5odHRwU3RhdHVzQ29kZSgpIC8gMTAwID09IDUpIHsKSW5kZXg6IFdlYkNvcmUv bG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGVIb3N0LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9sb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZUhvc3QuaAkocmV2aXNpb24gNzA4 MTgpCisrKyBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlSG9zdC5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjIsNiArMTIyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAg ICAgICB2b2lkIHNlbGVjdENhY2hlV2l0aE1hbmlmZXN0KGNvbnN0IEtVUkwmIG1hbmlmZXN0VVJM KTsKIAogICAgICAgICB2b2lkIG1heWJlTG9hZE1haW5SZXNvdXJjZShSZXNvdXJjZVJlcXVlc3Qm LCBTdWJzdGl0dXRlRGF0YSYpOworICAgICAgICB2b2lkIG1heWJlTG9hZE1haW5SZXNvdXJjZUZv clJlZGlyZWN0KFJlc291cmNlUmVxdWVzdCYsIFN1YnN0aXR1dGVEYXRhJik7CiAgICAgICAgIGJv b2wgbWF5YmVMb2FkRmFsbGJhY2tGb3JNYWluUmVzcG9uc2UoY29uc3QgUmVzb3VyY2VSZXF1ZXN0 JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYpOwogICAgICAgICBib29sIG1heWJlTG9hZEZhbGxi YWNrRm9yTWFpbkVycm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFJlc291cmNlRXJy b3ImKTsKICAgICAgICAgdm9pZCBtYWluUmVzb3VyY2VEYXRhUmVjZWl2ZWQoY29uc3QgY2hhciog ZGF0YSwgaW50IGxlbmd0aCwgbG9uZyBsb25nIGxlbmd0aFJlY2VpdmVkLCBib29sIGFsbEF0T25j ZSk7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcwODI5KQorKysgV2ViS2l0L2Nocm9taXVt L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEwLTEwLTI4ICBN aWNoYWVsIE5vcmRtYW4gIDxtaWNoYWVsbkBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWVdIEZpeCBhbiBhcHBjYWNoZSBy ZWdyZXNzaW9uIGludHJvZHVjZWQgaW4gcjY5MjI2CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODU5MgorICAgICAgICBQcm92aWRlIGEgbm9vcCBtZXRo b2QgYm9keSBBcHBsaWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkTWFpblJlc291cmNlRm9yUmVk aXJlY3QuCisKKyAgICAgICAgKiBzcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6QXBwbGljYXRpb25DYWNoZUhvc3Q6Om1heWJlTG9hZE1haW5SZXNvdXJjZUZv clJlZGlyZWN0KToKKwogMjAxMC0xMC0yOCAgTWloYWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktp dC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCShyZXZpc2lvbiA3MDgx OCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvQXBwbGljYXRpb25DYWNoZUhvc3QuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xMTMsNiArMTEzLDExIEBAIHZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6 OnNlbGVjdENhY2hlV2kKICAgICB9CiB9CiAKK3ZvaWQgQXBwbGljYXRpb25DYWNoZUhvc3Q6Om1h eWJlTG9hZE1haW5SZXNvdXJjZUZvclJlZGlyZWN0KFJlc291cmNlUmVxdWVzdCYsIFN1YnN0aXR1 dGVEYXRhJikKK3sKKyAgICAvLyBOL0EgdG8gdGhlIGNocm9taXVtIHBvcnQKK30KKwogYm9vbCBB cHBsaWNhdGlvbkNhY2hlSG9zdDo6bWF5YmVMb2FkRmFsbGJhY2tGb3JNYWluUmVzcG9uc2UoY29u c3QgUmVzb3VyY2VSZXF1ZXN0JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UpCiB7 CiAgICAgaWYgKG1faW50ZXJuYWwpIHsK