48573 2010-10-28 16:13:16 -0700 Include stddef.h unconditionally in Assertions.h 2010-10-28 17:44:00 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 skyul webkit-unassigned commit-queue darin oldest_to_newest 301411 0 skyul 2010-10-28 16:13:16 -0700 Because OBJECT_OFFSETOF macro in StdLibExtras.h uses ptrdiff_t, we must include stddef.h. <wtf/Assertions.h> indirectly includes stddef.h in many ports, but this is not true for Brew MP port. 301420 1 72253 skyul 2010-10-28 16:21:33 -0700 Created attachment 72253 Patch 301427 2 72253 darin 2010-10-28 16:27:06 -0700 Comment on attachment 72253 Patch I think a better fix would be to change Assertions.h to include <stddef.h> unconditionally. I don’t see any reason to have that include be MSVC-only. 301455 3 72258 skyul 2010-10-28 16:48:01 -0700 Created attachment 72258 Patch 301497 4 72258 commit-queue 2010-10-28 17:43:55 -0700 Comment on attachment 72258 Patch Clearing flags on attachment: 72258 Committed r70829: <http://trac.webkit.org/changeset/70829> 301498 5 commit-queue 2010-10-28 17:44:00 -0700 All reviewed patches have been landed. Closing bug. 72253 2010-10-28 16:21:33 -0700 2010-10-28 16:47:57 -0700 Patch bug-48573-20101028162133.patch text/plain 1184 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcwODIxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjggIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRlIHN0ZGRlZi5oIGZvciBwdHJkaWZmX3QgaW4g U3RkTGliRXh0cmFzLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4NTczCisKKyAgICAgICAgQmVjYXVzZSBPQkpFQ1RfT0ZGU0VUT0YgbWFjcm8gaW4g U3RkTGliRXh0cmFzLmggdXNlcyBwdHJkaWZmX3QsIHdlIG11c3QgaW5jbHVkZSBzdGRkZWYuaC4K KyAgICAgICAgPHd0Zi9Bc3NlcnRpb25zLmg+IGluZGlyZWN0bHkgaW5jbHVkZXMgc3RkZGVmLmgg aW4gbWFueSBwb3J0cywgYnV0IHRoaXMgaXMgbm90IHRydWUgZm9yIEJyZXcgTVAgcG9ydC4KKwor ICAgICAgICAqIHd0Zi9TdGRMaWJFeHRyYXMuaDoKKwogMjAxMC0xMC0yOCAgSGVyY3plZyBab2x0 YW4gIDx6aGVyY3plZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlciBzdGFtcGVkIGJ5IENz YWJhIE9zenRyb2dvbsOhYy4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9TdGRMaWJFeHRyYXMu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvU3RkTGliRXh0cmFzLmgJKHJldmlz aW9uIDcwODE4KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1N0ZExpYkV4dHJhcy5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIFdURl9TdGRMaWJFeHRyYXNfaAogI2Rl ZmluZSBXVEZfU3RkTGliRXh0cmFzX2gKIAorI2luY2x1ZGUgPHN0ZGRlZi5oPgogI2luY2x1ZGUg PHd0Zi9Bc3NlcnRpb25zLmg+CiAKIC8vIFVzZSB0aGVzZSB0byBkZWNsYXJlIGFuZCBkZWZpbmUg YSBzdGF0aWMgbG9jYWwgdmFyaWFibGUgKHN0YXRpYyBUOykgc28gdGhhdAo= 72258 2010-10-28 16:48:01 -0700 2010-10-28 17:43:55 -0700 Patch bug-48573-20101028164800.patch text/plain 974 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDcwODI0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjggIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJbmNsdWRlIHN0ZGRlZi5oIHVuY29uZGl0aW9uYWxseSBp biBBc3NlcnRpb25zLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ4NTczCisKKyAgICAgICAgVGhlcmUgaXMgbm8gcmVhc29uIHRvIGhhdmUgc3RkZGVm LmggaW5jbHVkZSBiZSBNU1ZDLW9ubHkuCisKKyAgICAgICAgKiB3dGYvQXNzZXJ0aW9ucy5oOgor CiAyMDEwLTEwLTI4ICBIZXJjemVnIFpvbHRhbiAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUnViYmVyIHN0YW1wZWQgYnkgQ3NhYmEgT3N6dHJvZ29uw6FjLgpJbmRleDogSmF2YVNj cmlwdENvcmUvd3RmL0Fzc2VydGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93 dGYvQXNzZXJ0aW9ucy5oCShyZXZpc2lvbiA3MDgyMykKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9B c3NlcnRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDkgKzQ0LDkgQEAKIAogI2luY2x1ZGUg IlBsYXRmb3JtLmgiCiAKLSNpZiBDT01QSUxFUihNU1ZDKQogI2luY2x1ZGUgPHN0ZGRlZi5oPgot I2Vsc2UKKworI2lmICFDT01QSUxFUihNU1ZDKQogI2luY2x1ZGUgPGludHR5cGVzLmg+CiAjZW5k aWYKIAo=