<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>48571</bug_id>
          
          <creation_ts>2010-10-28 15:54:18 -0700</creation_ts>
          <short_desc>[chromium] UUID generation does not work in Linux that has sandbox turned on</short_desc>
          <delta_ts>2010-10-29 11:29:40 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jian Li">jianli</reporter>
          <assigned_to name="Jian Li">jianli</assigned_to>
          <cc>abarth</cc>
    
    <cc>dimich</cc>
    
    <cc>levin</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>301398</commentid>
    <comment_count>0</comment_count>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-10-28 15:54:18 -0700</bug_when>
    <thetext>UUID generation does not work in Linux that has sandbox turned on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301471</commentid>
    <comment_count>1</comment_count>
      <attachid>72262</attachid>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-10-28 17:00:11 -0700</bug_when>
    <thetext>Created attachment 72262
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301485</commentid>
    <comment_count>2</comment_count>
      <attachid>72268</attachid>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-10-28 17:26:55 -0700</bug_when>
    <thetext>Created attachment 72268
Proposed Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301503</commentid>
    <comment_count>3</comment_count>
      <attachid>72268</attachid>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2010-10-28 17:53:10 -0700</bug_when>
    <thetext>Comment on attachment 72268
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72268&amp;action=review

A few nits.
r- because  it implements it in the case where it should probably stay unimplemented...

&gt; WebCore/platform/UUID.cpp:99
&gt;  #else

Is there a specific benefit in enabling it for everything else? Why not limit to LINUX + CHROMIUM? If the bug is about Chromium Linux implementation, then it should be narrowly scoped, otherwise there should be a note why specifically the previously unimplemented functionality should be implemented.

&gt; WebCore/platform/UUID.cpp:101
&gt; +    for (size_t i = 0; i &lt; sizeof(randomData) / sizeof(unsigned); ++i)

.. / sizeof(randomData[0]) ?

&gt; WebCore/platform/UUID.cpp:113
&gt; +    builder.append(String::format(&quot;%03x&quot;, randomData[2] &gt;&gt; 16));

seems it has to be (randomData[2]  &gt;&gt; 16 ) &amp; 0x00000fff here...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301506</commentid>
    <comment_count>4</comment_count>
      <attachid>72276</attachid>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-10-28 17:58:45 -0700</bug_when>
    <thetext>Created attachment 72276
Proposed Patch

All fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301509</commentid>
    <comment_count>5</comment_count>
      <attachid>72276</attachid>
    <who name="Dmitry Titov">dimich</who>
    <bug_when>2010-10-28 18:03:36 -0700</bug_when>
    <thetext>Comment on attachment 72276
Proposed Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301520</commentid>
    <comment_count>6</comment_count>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-10-28 18:18:21 -0700</bug_when>
    <thetext>Committed as http://trac.webkit.org/changeset/70830</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301604</commentid>
    <comment_count>7</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-10-28 23:41:19 -0700</bug_when>
    <thetext>Why don&apos;t we just use this code on all platforms?  I don&apos;t see the value in calling the platform-specific libraries.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>301905</commentid>
    <comment_count>8</comment_count>
    <who name="Jian Li">jianli</who>
    <bug_when>2010-10-29 11:29:40 -0700</bug_when>
    <thetext>(In reply to comment #7)
&gt; Why don&apos;t we just use this code on all platforms?  I don&apos;t see the value in calling the platform-specific libraries.

I will watch this for a while. If we do not see any problem, we can start to extend to all other platforms.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>72262</attachid>
            <date>2010-10-28 17:00:11 -0700</date>
            <delta_ts>2010-10-28 17:26:55 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>48571</filename>
            <type>text/plain</type>
            <size>2997</size>
            <attacher name="Jian Li">jianli</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
YWVmZWI2MC4uNTVkZDE5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0yOCAgSmlhbiBMaSAgPGpp
YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgW2Nocm9taXVtXSBVVUlEIGdlbmVyYXRpb24gZG9lcyBub3Qgd29yayBpbiBM
aW51eCB0aGF0IGhhcyBzYW5kYm94CisgICAgICAgIHR1cm5lZCBvbgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg1NzEKKworICAgICAgICBUaGlzIGlz
IGJlY2F1c2Ugd2UgY2Fubm90IGFjY2VzcyAvcHJvYyB3aGVuIHNhbmRib3ggaXMgb24uIFRoZSBm
aXggaXMgdG8KKyAgICAgICAgdXNlIHJhbmRvbSBudW1iZXJzIHRvIGNvbnN0cnVjdCBVVUlELiBU
aGlzIHNjaGVtZSBpcyBhbHNvIG1hZGUgYXZhaWxhYmxlCisgICAgICAgIHRvIGFsbCBvdGhlciBz
eXN0ZW1zIHRoYXQgd2UgZG8gbm90IHN1cHBvcnQgYmVmb3JlLgorCisgICAgICAgICogcGxhdGZv
cm0vVVVJRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVDYW5vbmljYWxVVUlEU3RyaW5n
KToKKwogMjAxMC0xMC0yOCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm
b3JtL1VVSUQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNwcAppbmRleCBmZGJmNjAxLi44
OTVjMDg1IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL1VVSUQuY3BwCisrKyBiL1dlYkNv
cmUvcGxhdGZvcm0vVVVJRC5jcHAKQEAgLTQ0LDggKzQ0LDExIEBACiAjZW5kaWYKICNlbGlmIE9T
KERBUldJTikKICNpbmNsdWRlIDxDb3JlRm91bmRhdGlvbi9Db3JlRm91bmRhdGlvbi5oPgotI2Vs
aWYgT1MoTElOVVgpCisjZWxpZiBPUyhMSU5VWCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKQogI2lu
Y2x1ZGUgPHN0ZGlvLmg+CisjZWxzZQorI2luY2x1ZGUgPHd0Zi9SYW5kb21OdW1iZXIuaD4KKyNp
bmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdl
YkNvcmUgewpAQCAtODAsNyArODMsOCBAQCBTdHJpbmcgY3JlYXRlQ2Fub25pY2FsVVVJRFN0cmlu
ZygpCiAgICAgU3RyaW5nIGNhbm9uaWNhbFV1aWRTdHIgPSB1dWlkU3RyLmxvd2VyKCk7IC8vIG1h
a2UgaXQgbG93ZXIuCiAgICAgQVNTRVJUKGNhbm9uaWNhbFV1aWRTdHJbdXVpZFZlcnNpb25JZGVu
dGlmaWVySW5kZXhdID09IHV1aWRWZXJzaW9uUmVxdWlyZWQpOwogICAgIHJldHVybiBjYW5vbmlj
YWxVdWlkU3RyOwotI2VsaWYgT1MoTElOVVgpCisjZWxpZiBPUyhMSU5VWCkgJiYgIVBMQVRGT1JN
KENIUk9NSVVNKQorICAgIC8vIFRoaXMgZG9lcyBub3Qgd29yayBmb3IgdGhlIGxpbnV4IHN5c3Rl
bSB0aGF0IHR1cm5zIG9uIHNhbmRib3guCiAgICAgRklMRSogZnB0ciA9IGZvcGVuKCIvcHJvYy9z
eXMva2VybmVsL3JhbmRvbS91dWlkIiwgInIiKTsKICAgICBpZiAoIWZwdHIpCiAgICAgICAgIHJl
dHVybiBTdHJpbmcoKTsKQEAgLTkzLDkgKzk3LDI1IEBAIFN0cmluZyBjcmVhdGVDYW5vbmljYWxV
VUlEU3RyaW5nKCkKICAgICBBU1NFUlQoY2Fub25pY2FsVXVpZFN0clt1dWlkVmVyc2lvbklkZW50
aWZpZXJJbmRleF0gPT0gdXVpZFZlcnNpb25SZXF1aXJlZCk7CiAgICAgcmV0dXJuIGNhbm9uaWNh
bFV1aWRTdHI7CiAjZWxzZQotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFN0cmlu
ZygpOwotI2VuZGlmICAgIAorICAgIHVuc2lnbmVkIHJhbmRvbURhdGFbNF07CisgICAgZm9yIChz
aXplX3QgaSA9IDA7IGkgPCBzaXplb2YocmFuZG9tRGF0YSkgLyBzaXplb2YodW5zaWduZWQpOyAr
K2kpCisgICAgICAgIHJhbmRvbURhdGFbaV0gPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmFuZG9t
TnVtYmVyKCkgKiAoc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpICsgMS4wKSk7
CisKKyAgICAvLyBGb3JtYXQgYXMgVmVyc2lvbiA0IFVVSUQuCisgICAgU3RyaW5nQnVpbGRlciBi
dWlsZGVyOworICAgIGJ1aWxkZXIuYXBwZW5kKFN0cmluZzo6Zm9ybWF0KCIlMDh4Iiwgc3RhdGlj
X2Nhc3Q8dW5zaWduZWQ+KHJhbmRvbURhdGFbMF0pKSk7CisgICAgYnVpbGRlci5hcHBlbmQoIi0i
KTsKKyAgICBidWlsZGVyLmFwcGVuZChTdHJpbmc6OmZvcm1hdCgiJTA0eCIsIHN0YXRpY19jYXN0
PHVuc2lnbmVkPihyYW5kb21EYXRhWzFdID4+IDE2KSkpOworICAgIGJ1aWxkZXIuYXBwZW5kKCIt
NCIpOworICAgIGJ1aWxkZXIuYXBwZW5kKFN0cmluZzo6Zm9ybWF0KCIlMDN4Iiwgc3RhdGljX2Nh
c3Q8dW5zaWduZWQ+KHJhbmRvbURhdGFbMV0pICYgMHgwMDAwMGZmZikpOworICAgIGJ1aWxkZXIu
YXBwZW5kKCItIik7CisgICAgYnVpbGRlci5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiV4Iiwgc3Rh
dGljX2Nhc3Q8dW5zaWduZWQ+KHJhbmRvbURhdGFbMl0gPj4gMzApIHwgMHg4KSk7IC8vIENvbmRl
bnNlIHRoaXMgYnl0ZSB0byA4LCA5LCBhLCBhbmQgYi4KKyAgICBidWlsZGVyLmFwcGVuZChTdHJp
bmc6OmZvcm1hdCgiJTAzeCIsIHN0YXRpY19jYXN0PHVuc2lnbmVkPihyYW5kb21EYXRhWzJdID4+
IDE2KSkpOworICAgIGJ1aWxkZXIuYXBwZW5kKCItIik7CisgICAgYnVpbGRlci5hcHBlbmQoU3Ry
aW5nOjpmb3JtYXQoIiUwNHgiLCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmFuZG9tRGF0YVsyXSkg
JiAweDAwMDBmZmZmKSk7CisgICAgYnVpbGRlci5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiUwOHgi
LCBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmFuZG9tRGF0YVszXSkpKTsKKyAgICByZXR1cm4gYnVp
bGRlci50b1N0cmluZygpOworI2VuZGlmCiB9CiAKIH0K
</data>
<flag name="commit-queue"
          id="62488"
          type_id="3"
          status="-"
          setter="jianli"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>72268</attachid>
            <date>2010-10-28 17:26:55 -0700</date>
            <delta_ts>2010-10-28 17:58:45 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>48571_2</filename>
            <type>text/plain</type>
            <size>2838</size>
            <attacher name="Jian Li">jianli</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
YWVmZWI2MC4uNTVkZDE5ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0yOCAgSmlhbiBMaSAgPGpp
YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgW2Nocm9taXVtXSBVVUlEIGdlbmVyYXRpb24gZG9lcyBub3Qgd29yayBpbiBM
aW51eCB0aGF0IGhhcyBzYW5kYm94CisgICAgICAgIHR1cm5lZCBvbgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg1NzEKKworICAgICAgICBUaGlzIGlz
IGJlY2F1c2Ugd2UgY2Fubm90IGFjY2VzcyAvcHJvYyB3aGVuIHNhbmRib3ggaXMgb24uIFRoZSBm
aXggaXMgdG8KKyAgICAgICAgdXNlIHJhbmRvbSBudW1iZXJzIHRvIGNvbnN0cnVjdCBVVUlELiBU
aGlzIHNjaGVtZSBpcyBhbHNvIG1hZGUgYXZhaWxhYmxlCisgICAgICAgIHRvIGFsbCBvdGhlciBz
eXN0ZW1zIHRoYXQgd2UgZG8gbm90IHN1cHBvcnQgYmVmb3JlLgorCisgICAgICAgICogcGxhdGZv
cm0vVVVJRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVDYW5vbmljYWxVVUlEU3RyaW5n
KToKKwogMjAxMC0xMC0yOCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAg
ICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm
b3JtL1VVSUQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNwcAppbmRleCBmZGJmNjAxLi41
ZWQ3Yzg5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL1VVSUQuY3BwCisrKyBiL1dlYkNv
cmUvcGxhdGZvcm0vVVVJRC5jcHAKQEAgLTQ0LDggKzQ0LDExIEBACiAjZW5kaWYKICNlbGlmIE9T
KERBUldJTikKICNpbmNsdWRlIDxDb3JlRm91bmRhdGlvbi9Db3JlRm91bmRhdGlvbi5oPgotI2Vs
aWYgT1MoTElOVVgpCisjZWxpZiBPUyhMSU5VWCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKQogI2lu
Y2x1ZGUgPHN0ZGlvLmg+CisjZWxzZQorI2luY2x1ZGUgPHd0Zi9SYW5kb21OdW1iZXIuaD4KKyNp
bmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAjZW5kaWYKIAogbmFtZXNwYWNlIFdl
YkNvcmUgewpAQCAtODAsNyArODMsOCBAQCBTdHJpbmcgY3JlYXRlQ2Fub25pY2FsVVVJRFN0cmlu
ZygpCiAgICAgU3RyaW5nIGNhbm9uaWNhbFV1aWRTdHIgPSB1dWlkU3RyLmxvd2VyKCk7IC8vIG1h
a2UgaXQgbG93ZXIuCiAgICAgQVNTRVJUKGNhbm9uaWNhbFV1aWRTdHJbdXVpZFZlcnNpb25JZGVu
dGlmaWVySW5kZXhdID09IHV1aWRWZXJzaW9uUmVxdWlyZWQpOwogICAgIHJldHVybiBjYW5vbmlj
YWxVdWlkU3RyOwotI2VsaWYgT1MoTElOVVgpCisjZWxpZiBPUyhMSU5VWCkgJiYgIVBMQVRGT1JN
KENIUk9NSVVNKQorICAgIC8vIFRoaXMgZG9lcyBub3Qgd29yayBmb3IgdGhlIGxpbnV4IHN5c3Rl
bSB0aGF0IHR1cm5zIG9uIHNhbmRib3guCiAgICAgRklMRSogZnB0ciA9IGZvcGVuKCIvcHJvYy9z
eXMva2VybmVsL3JhbmRvbS91dWlkIiwgInIiKTsKICAgICBpZiAoIWZwdHIpCiAgICAgICAgIHJl
dHVybiBTdHJpbmcoKTsKQEAgLTkzLDkgKzk3LDI1IEBAIFN0cmluZyBjcmVhdGVDYW5vbmljYWxV
VUlEU3RyaW5nKCkKICAgICBBU1NFUlQoY2Fub25pY2FsVXVpZFN0clt1dWlkVmVyc2lvbklkZW50
aWZpZXJJbmRleF0gPT0gdXVpZFZlcnNpb25SZXF1aXJlZCk7CiAgICAgcmV0dXJuIGNhbm9uaWNh
bFV1aWRTdHI7CiAjZWxzZQotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFN0cmlu
ZygpOwotI2VuZGlmICAgIAorICAgIHVuc2lnbmVkIHJhbmRvbURhdGFbNF07CisgICAgZm9yIChz
aXplX3QgaSA9IDA7IGkgPCBzaXplb2YocmFuZG9tRGF0YSkgLyBzaXplb2YodW5zaWduZWQpOyAr
K2kpCisgICAgICAgIHJhbmRvbURhdGFbaV0gPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmFuZG9t
TnVtYmVyKCkgKiAoc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpICsgMS4wKSk7
CisKKyAgICAvLyBGb3JtYXQgYXMgVmVyc2lvbiA0IFVVSUQuCisgICAgU3RyaW5nQnVpbGRlciBi
dWlsZGVyOworICAgIGJ1aWxkZXIuYXBwZW5kKFN0cmluZzo6Zm9ybWF0KCIlMDh4IiwgcmFuZG9t
RGF0YVswXSkpOworICAgIGJ1aWxkZXIuYXBwZW5kKCItIik7CisgICAgYnVpbGRlci5hcHBlbmQo
U3RyaW5nOjpmb3JtYXQoIiUwNHgiLCByYW5kb21EYXRhWzFdID4+IDE2KSk7CisgICAgYnVpbGRl
ci5hcHBlbmQoIi00Iik7CisgICAgYnVpbGRlci5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiUwM3gi
LCByYW5kb21EYXRhWzFdICYgMHgwMDAwMGZmZikpOworICAgIGJ1aWxkZXIuYXBwZW5kKCItIik7
CisgICAgYnVpbGRlci5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiV4IiwgKHJhbmRvbURhdGFbMl0g
Pj4gMzApIHwgMHg4KSk7IC8vIENvbmRlbnNlIHRoaXMgYnl0ZSB0byA4LCA5LCBhLCBhbmQgYi4K
KyAgICBidWlsZGVyLmFwcGVuZChTdHJpbmc6OmZvcm1hdCgiJTAzeCIsIHJhbmRvbURhdGFbMl0g
Pj4gMTYpKTsKKyAgICBidWlsZGVyLmFwcGVuZCgiLSIpOworICAgIGJ1aWxkZXIuYXBwZW5kKFN0
cmluZzo6Zm9ybWF0KCIlMDR4IiwgcmFuZG9tRGF0YVsyXSAmIDB4MDAwMGZmZmYpKTsKKyAgICBi
dWlsZGVyLmFwcGVuZChTdHJpbmc6OmZvcm1hdCgiJTA4eCIsIHJhbmRvbURhdGFbM10pKTsKKyAg
ICByZXR1cm4gYnVpbGRlci50b1N0cmluZygpOworI2VuZGlmCiB9CiAKIH0K
</data>
<flag name="review"
          id="62493"
          type_id="1"
          status="-"
          setter="dimich"
    />
    <flag name="commit-queue"
          id="62494"
          type_id="3"
          status="-"
          setter="jianli"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>72276</attachid>
            <date>2010-10-28 17:58:45 -0700</date>
            <delta_ts>2010-10-28 18:03:36 -0700</delta_ts>
            <desc>Proposed Patch</desc>
            <filename>48571_3</filename>
            <type>text/plain</type>
            <size>2908</size>
            <attacher name="Jian Li">jianli</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
YWVmZWI2MC4uMjE0MmE1MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0yOCAgSmlhbiBMaSAgPGpp
YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgW2Nocm9taXVtXSBVVUlEIGdlbmVyYXRpb24gZG9lcyBub3Qgd29yayBpbiBM
aW51eCB0aGF0IGhhcyBzYW5kYm94CisgICAgICAgIHR1cm5lZCBvbgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg1NzEKKworICAgICAgICBUaGlzIGlz
IGJlY2F1c2Ugd2UgY2Fubm90IGFjY2VzcyAvcHJvYyB3aGVuIHNhbmRib3ggaXMgb24uIFRoZSBm
aXggaXMgdG8KKyAgICAgICAgdXNlIHJhbmRvbSBudW1iZXJzIHRvIGNvbnN0cnVjdCBVVUlELgor
CisgICAgICAgICogcGxhdGZvcm0vVVVJRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVD
YW5vbmljYWxVVUlEU3RyaW5nKToKKwogMjAxMC0xMC0yOCAgRGF2aWQgSHlhdHQgIDxoeWF0dEBh
cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCmRpZmYgLS1n
aXQgYS9XZWJDb3JlL3BsYXRmb3JtL1VVSUQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9VVUlELmNw
cAppbmRleCBmZGJmNjAxLi41MjA4YmVlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL1VV
SUQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vVVVJRC5jcHAKQEAgLTQ0LDggKzQ0LDExIEBA
CiAjZW5kaWYKICNlbGlmIE9TKERBUldJTikKICNpbmNsdWRlIDxDb3JlRm91bmRhdGlvbi9Db3Jl
Rm91bmRhdGlvbi5oPgotI2VsaWYgT1MoTElOVVgpCisjZWxpZiBPUyhMSU5VWCkgJiYgIVBMQVRG
T1JNKENIUk9NSVVNKQogI2luY2x1ZGUgPHN0ZGlvLmg+CisjZWxpZiBPUyhMSU5VWCkgJiYgUExB
VEZPUk0oQ0hST01JVU0pCisjaW5jbHVkZSA8d3RmL1JhbmRvbU51bWJlci5oPgorI2luY2x1ZGUg
PHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7
CkBAIC04MCw3ICs4Myw4IEBAIFN0cmluZyBjcmVhdGVDYW5vbmljYWxVVUlEU3RyaW5nKCkKICAg
ICBTdHJpbmcgY2Fub25pY2FsVXVpZFN0ciA9IHV1aWRTdHIubG93ZXIoKTsgLy8gbWFrZSBpdCBs
b3dlci4KICAgICBBU1NFUlQoY2Fub25pY2FsVXVpZFN0clt1dWlkVmVyc2lvbklkZW50aWZpZXJJ
bmRleF0gPT0gdXVpZFZlcnNpb25SZXF1aXJlZCk7CiAgICAgcmV0dXJuIGNhbm9uaWNhbFV1aWRT
dHI7Ci0jZWxpZiBPUyhMSU5VWCkKKyNlbGlmIE9TKExJTlVYKSAmJiAhUExBVEZPUk0oQ0hST01J
VU0pCisgICAgLy8gVGhpcyBkb2VzIG5vdCB3b3JrIGZvciB0aGUgbGludXggc3lzdGVtIHRoYXQg
dHVybnMgb24gc2FuZGJveC4KICAgICBGSUxFKiBmcHRyID0gZm9wZW4oIi9wcm9jL3N5cy9rZXJu
ZWwvcmFuZG9tL3V1aWQiLCAiciIpOwogICAgIGlmICghZnB0cikKICAgICAgICAgcmV0dXJuIFN0
cmluZygpOwpAQCAtOTIsMTAgKzk2LDI5IEBAIFN0cmluZyBjcmVhdGVDYW5vbmljYWxVVUlEU3Ry
aW5nKCkKICAgICBTdHJpbmcgY2Fub25pY2FsVXVpZFN0ciA9IFN0cmluZyh1dWlkU3RyKS5sb3dl
cigpOyAvLyBtYWtlIGl0IGxvd2VyLgogICAgIEFTU0VSVChjYW5vbmljYWxVdWlkU3RyW3V1aWRW
ZXJzaW9uSWRlbnRpZmllckluZGV4XSA9PSB1dWlkVmVyc2lvblJlcXVpcmVkKTsKICAgICByZXR1
cm4gY2Fub25pY2FsVXVpZFN0cjsKKyNlbGlmIE9TKExJTlVYKSAmJiBQTEFURk9STShDSFJPTUlV
TSkKKyAgICB1bnNpZ25lZCByYW5kb21EYXRhWzRdOworICAgIGZvciAoc2l6ZV90IGkgPSAwOyBp
IDwgc2l6ZW9mKHJhbmRvbURhdGEpIC8gc2l6ZW9mKHJhbmRvbURhdGFbMF0pOyArK2kpCisgICAg
ICAgIHJhbmRvbURhdGFbaV0gPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmFuZG9tTnVtYmVyKCkg
KiAoc3RkOjpudW1lcmljX2xpbWl0czx1bnNpZ25lZD46Om1heCgpICsgMS4wKSk7CisKKyAgICAv
LyBGb3JtYXQgYXMgVmVyc2lvbiA0IFVVSUQuCisgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOwor
ICAgIGJ1aWxkZXIuYXBwZW5kKFN0cmluZzo6Zm9ybWF0KCIlMDh4IiwgcmFuZG9tRGF0YVswXSkp
OworICAgIGJ1aWxkZXIuYXBwZW5kKCItIik7CisgICAgYnVpbGRlci5hcHBlbmQoU3RyaW5nOjpm
b3JtYXQoIiUwNHgiLCByYW5kb21EYXRhWzFdID4+IDE2KSk7CisgICAgYnVpbGRlci5hcHBlbmQo
Ii00Iik7CisgICAgYnVpbGRlci5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiUwM3giLCByYW5kb21E
YXRhWzFdICYgMHgwMDAwMGZmZikpOworICAgIGJ1aWxkZXIuYXBwZW5kKCItIik7CisgICAgYnVp
bGRlci5hcHBlbmQoU3RyaW5nOjpmb3JtYXQoIiV4IiwgKHJhbmRvbURhdGFbMl0gPj4gMzApIHwg
MHg4KSk7IC8vIENvbmRlbnNlIHRoaXMgYnl0ZSB0byA4LCA5LCBhLCBhbmQgYi4KKyAgICBidWls
ZGVyLmFwcGVuZChTdHJpbmc6OmZvcm1hdCgiJTAzeCIsIChyYW5kb21EYXRhWzJdID4+IDE2KSAm
IDB4MDAwMDBmZmYpKTsKKyAgICBidWlsZGVyLmFwcGVuZCgiLSIpOworICAgIGJ1aWxkZXIuYXBw
ZW5kKFN0cmluZzo6Zm9ybWF0KCIlMDR4IiwgcmFuZG9tRGF0YVsyXSAmIDB4MDAwMGZmZmYpKTsK
KyAgICBidWlsZGVyLmFwcGVuZChTdHJpbmc6OmZvcm1hdCgiJTA4eCIsIHJhbmRvbURhdGFbM10p
KTsKKyAgICByZXR1cm4gYnVpbGRlci50b1N0cmluZygpOwogI2Vsc2UKICAgICBub3RJbXBsZW1l
bnRlZCgpOwogICAgIHJldHVybiBTdHJpbmcoKTsKLSNlbmRpZiAgICAKKyNlbmRpZgogfQogCiB9
Cg==
</data>
<flag name="review"
          id="62504"
          type_id="1"
          status="+"
          setter="dimich"
    />
    <flag name="commit-queue"
          id="62505"
          type_id="3"
          status="-"
          setter="jianli"
    />
          </attachment>
      

    </bug>

</bugzilla>