48564 2010-10-28 14:12:07 -0700 fast/dom/Window/window-property-descriptors test is broken 2010-10-28 15:28:10 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 enne enne commit-queue enne jamesr kbr oldest_to_newest 301325 0 enne 2010-10-28 14:12:07 -0700 https://bugs.webkit.org/show_bug.cgi?id=47853 appears to have broken window-property-descriptors on some platforms. It appears that the platform-specific expectations files were not changed as a part of that bug. 301330 1 72234 enne 2010-10-28 14:16:34 -0700 Created attachment 72234 Patch 301332 2 enne 2010-10-28 14:20:03 -0700 I just edited the expectations file manually, but I strongly suspect this will do the trick to fix the broken build. Sorry for missing these in the first place. (Maybe webkit-patch should warn about updating the main expectations file and not the platform-specific ones.) Is there some better way to do this rebaselining? The build error here just said failed (http://build.webkit.org/builders/Qt%20Linux%20Release/builds/22771/steps/layout-test/logs/stdio), and I couldn't find the actual output to use and feel more assured that this would fix the problem. 301359 3 72234 kbr 2010-10-28 15:00:24 -0700 Comment on attachment 72234 Patch OK. 301376 4 commit-queue 2010-10-28 15:27:11 -0700 The commit-queue encountered the following flaky tests while processing attachment 72234: http/tests/misc/copy-resolves-urls.html Please file bugs against the tests. These tests were authored by tony@chromium.org. The commit-queue is continuing to process your patch. 301377 5 72234 commit-queue 2010-10-28 15:28:06 -0700 Comment on attachment 72234 Patch Clearing flags on attachment: 72234 Committed r70818: <http://trac.webkit.org/changeset/70818> 301379 6 commit-queue 2010-10-28 15:28:10 -0700 All reviewed patches have been landed. Closing bug. 72234 2010-10-28 14:16:34 -0700 2010-10-28 15:28:05 -0700 Patch bug-48564-20101028141633.patch text/plain 4169 enne ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0YzI4NTczYzk3MmQ4ZGQ2NDZlZGViZWYxYzIxMDdlMTA5YTBmOTJmLi4xZDBhNGFm ODJjNjU2NmYzMTJiMzMwNWRhNTE2YmEzYTM3Y2M1YTcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMTAtMjggIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNaXNzaW5nIGV4cGVjdGF0 aW9uIGZpbGUgY2hhbmdlcyBmcm9tIGJ1ZyA0Nzg1My4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NTY0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv ZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQ6 CisgICAgICAgICogcGxhdGZvcm0vcXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1k ZXNjcmlwdG9ycy1leHBlY3RlZC50eHQ6CisgICAgICAgICogcGxhdGZvcm0vd2luL2Zhc3QvZG9t L1dpbmRvdy93aW5kb3ctcHJvcGVydHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0OgorCiAyMDEw LTEwLTI4ICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LWRlc2NyaXB0b3Jz LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2RvbS9XaW5kb3cv d2luZG93LXByb3BlcnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4dAppbmRleCA4YTJiNWI1ZDg1 MzJlNjc0MDg2NWNhOWMwNTA3Y2U4MWU5ZjQ4OTg4Li5hMzhkOTBkNmQxYjUzNDcyMTg1NDRjN2E4 ZGYwNjIyODdmZTFjZTE3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFz dC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVy dHktZGVzY3JpcHRvcnMtZXhwZWN0ZWQudHh0CkBAIC00NTgsNiArNDU4LDcgQEAgUEFTUyB0eXBl b2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdzY3JvbGxiYXJzJykg aXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Io d2luZG93LCAnc2VsZicpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJv cGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3Nlc3Npb25TdG9yYWdlJykgaXMgJ29iamVjdCcKIFBB U1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2hvdWxk QmUnKSBpcyAnb2JqZWN0JworUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3Jp cHRvcih3aW5kb3csICdzaG91bGRCZURlZmluZWQnKSBpcyAnb2JqZWN0JwogUEFTUyB0eXBlb2Yg T2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdzaG91bGRCZUVxdWFsVG9T dHJpbmcnKSBpcyAnb2JqZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVz Y3JpcHRvcih3aW5kb3csICdzaG91bGRCZUZhbHNlJykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9m IE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2hvdWxkQmVHcmVhdGVy VGhhbk9yRXF1YWwnKSBpcyAnb2JqZWN0JwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vcXQvZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXBy b3BlcnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4dAppbmRleCBiMWMzODY3OThkNzA1MjNjYTI1 OWRjYzUzOGJiYTU3MzFlNWQ5YjEwLi4wZGNlY2ZhZWM0NGM4MmQ3OTM3YzBjOGFiZjE3OTYxODY2 ZjUzYjY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5k b3cvd2luZG93LXByb3BlcnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LWRlc2NyaXB0 b3JzLWV4cGVjdGVkLnR4dApAQCAtNDQ4LDYgKzQ0OCw3IEBAIFBBU1MgdHlwZW9mIE9iamVjdC5n ZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2Nyb2xsYmFycycpIGlzICdvYmplY3Qn CiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3Nl bGYnKSBpcyAnb2JqZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3Jp cHRvcih3aW5kb3csICdzZXNzaW9uU3RvcmFnZScpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBP YmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3Nob3VsZEJlJykgaXMgJ29i amVjdCcKK1BBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93 LCAnc2hvdWxkQmVEZWZpbmVkJykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRP d25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2hvdWxkQmVFcXVhbFRvU3RyaW5nJykgaXMg J29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2lu ZG93LCAnc2hvdWxkQmVGYWxzZScpIGlzICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0 T3duUHJvcGVydHlEZXNjcmlwdG9yKHdpbmRvdywgJ3Nob3VsZEJlR3JlYXRlclRoYW5PckVxdWFs JykgaXMgJ29iamVjdCcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0 L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LWRlc2NyaXB0b3JzLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2RvbS9XaW5kb3cvd2luZG93LXByb3BlcnR5LWRl c2NyaXB0b3JzLWV4cGVjdGVkLnR4dAppbmRleCBjNzI2NmU5OTY4OWRkODNlYjgwYzk0NTJlN2Y0 NTcyMmRiYzc2ZGJkLi4wNjAwMzU2YjBlMWFiYjA0NmJlNzMwOTA4YjAxOGU1OTkzM2E2MGU2IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vZmFzdC9kb20vV2luZG93L3dpbmRv dy1wcm9wZXJ0eS1kZXNjcmlwdG9ycy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vd2luL2Zhc3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydHktZGVzY3JpcHRvcnMtZXhw ZWN0ZWQudHh0CkBAIC00NTcsNiArNDU3LDcgQEAgUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blBy b3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdzY3JvbGxiYXJzJykgaXMgJ29iamVjdCcKIFBBU1Mg dHlwZW9mIE9iamVjdC5nZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2VsZicpIGlz ICdvYmplY3QnCiBQQVNTIHR5cGVvZiBPYmplY3QuZ2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKHdp bmRvdywgJ3Nlc3Npb25TdG9yYWdlJykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5n ZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2hvdWxkQmUnKSBpcyAnb2JqZWN0Jwor UEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdzaG91 bGRCZURlZmluZWQnKSBpcyAnb2JqZWN0JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3Bl cnR5RGVzY3JpcHRvcih3aW5kb3csICdzaG91bGRCZUVxdWFsVG9TdHJpbmcnKSBpcyAnb2JqZWN0 JwogUEFTUyB0eXBlb2YgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcih3aW5kb3csICdz aG91bGRCZUZhbHNlJykgaXMgJ29iamVjdCcKIFBBU1MgdHlwZW9mIE9iamVjdC5nZXRPd25Qcm9w ZXJ0eURlc2NyaXB0b3Iod2luZG93LCAnc2hvdWxkQmVHcmVhdGVyVGhhbk9yRXF1YWwnKSBpcyAn b2JqZWN0Jwo=