48559 2010-10-28 13:43:52 -0700 Crash in WebKit::PluginView::manualLoadDidReceiveResponse when navigating to a .wav file in WebKit2 on Mac 2010-11-19 08:00:58 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED http://www.nch.com.au/acm/sample.wav InRadar, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned andersca sam oldest_to_newest 301304 0 aroben 2010-10-28 13:43:52 -0700 To reproduce: 1. Go to http://www.nch.com.au/acm/sample.wav in WebKit2 on Mac You'll crash in WebKit::PluginView::manualLoadDidReceiveResponse. Here's the crashing line: m_plugin->manualStreamDidReceiveResponse(responseURL, streamLength, response.lastModifiedDate(), mimeType, headers); m_plugin is 0. Here's the backtrace: #0 0x000000010023539e in WebKit::PluginView::manualLoadDidReceiveResponse (this=0x11be72660, response=@0x107816948) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebKit2/WebProcess/Plugins/PluginView.cpp:303 #1 0x000000010025e6db in WebKit::WebFrameLoaderClient::committedLoad (this=0x106c162b8, loader=0x107816400, data=0x108027800 "RIFF\034\023\001", length=1124) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:685 #2 0x00000001011de31d in WebCore::DocumentLoader::commitLoad (this=0x107816400, data=0x108027800 "RIFF\034\023\001", length=1124) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/loader/DocumentLoader.cpp:292 #3 0x00000001011de376 in WebCore::DocumentLoader::receivedData (this=0x107816400, data=0x108027800 "RIFF\034\023\001", length=1124) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/loader/DocumentLoader.cpp:319 #4 0x00000001018596b2 in WebCore::MainResourceLoader::addData (this=0x10701a800, data=0x108027800 "RIFF\034\023\001", length=1124, allAtOnce=false) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/loader/MainResourceLoader.cpp:156 #5 0x0000000101a5f7fc in WebCore::ResourceLoader::didReceiveData (this=0x10701a800, data=0x108027800 "RIFF\034\023\001", length=1124, lengthReceived=1124, allAtOnce=false) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/loader/ResourceLoader.cpp:262 #6 0x0000000101858e1b in WebCore::MainResourceLoader::didReceiveData (this=0x10701a800, data=0x108027800 "RIFF\034\023\001", length=1124, lengthReceived=1124, allAtOnce=false) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/loader/MainResourceLoader.cpp:436 #7 0x0000000101a5effe in WebCore::ResourceLoader::didReceiveData (this=0x10701a800, data=0x108027800 "RIFF\034\023\001", length=1124, lengthReceived=1124) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/loader/ResourceLoader.cpp:415 #8 0x0000000101a59cf6 in -[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:] (self=0x106a10580, _cmd=0x7fff84304021, connection=0x106aca8c0, data=0x106c49fa0, lengthReceived=1124) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebCore/platform/network/mac/ResourceHandleMac.mm:876 #9 0x00007fff841dd06b in _NSURLConnectionDidReceiveData () #10 0x00007fff832e20c0 in URLConnectionClient::_clientDidReceiveData () #11 0x00007fff833499a2 in URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload () #12 0x00007fff83349c32 in URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload () #13 0x00007fff832d096d in URLConnectionClient::processEvents () #14 0x00007fff832d0748 in MultiplexerSource::perform () #15 0x00007fff835df401 in __CFRunLoopDoSources0 () #16 0x00007fff835dd5f9 in __CFRunLoopRun () #17 0x00007fff835dcdbf in CFRunLoopRunSpecific () #18 0x00007fff887619f6 in RunCurrentEventLoopInMode () #19 0x00007fff887617fb in ReceiveNextEventCommon () #20 0x00007fff887616b4 in BlockUntilNextEventMatchingListInMode () #21 0x00007fff82389e64 in _DPSNextEvent () #22 0x00007fff823897a9 in -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] () #23 0x00007fff8234f48b in -[NSApplication run] () #24 0x0000000100241d64 in RunLoop::run () at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebKit2/Platform/mac/RunLoopMac.mm:55 #25 0x000000010028e7db in WebKit::WebProcessMain (commandLine=@0x7fff5fbff080) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebKit2/WebProcess/mac/WebProcessMainMac.mm:136 #26 0x0000000100265f39 in WebKitMain (commandLine=@0x7fff5fbff080) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebKit2/WebProcess/WebKitMain.cpp:47 #27 0x0000000100265ff3 in WebKitMain (argc=8, argv=0x7fff5fbff158) at /Volumes/Data/Users/aroben/dev/WebKit/OpenSource/WebKit2/WebProcess/WebKitMain.cpp:71 #28 0x0000000100000e33 in main () 301306 1 aroben 2010-10-28 13:44:22 -0700 It's possible this will be hidden once bug 48546 is fixed, so we should investigate it soon! 301307 2 aroben 2010-10-28 13:44:47 -0700 <rdar://problem/8606622> 311105 3 74294 andersca 2010-11-18 15:01:26 -0800 Created attachment 74294 Patch 311464 4 andersca 2010-11-19 08:00:58 -0800 Committed r72401: <http://trac.webkit.org/changeset/72401> 74294 2010-11-18 15:01:26 -0800 2010-11-18 15:47:41 -0800 Patch bug-48559-20101118150125.patch text/plain 2464 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MWI4MDRjNzU4NzU5ZDkwZTQxNWY3OWEyY2M0ZWVlOGZmOWU0NWMyMy4uZjA2ZjlhYjcxOTdhYWFj YzFhNzRkZmMzODk2ZTUwMjE5YjFjNWFiMyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0xMS0xOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyYXNoIGluIFdlYktpdDo6UGx1Z2luVmlldzo6 bWFudWFsTG9hZERpZFJlY2VpdmVSZXNwb25zZSB3aGVuIG5hdmlnYXRpbmcgdG8gYSAud2F2IGZp bGUgaW4gV2ViS2l0MiBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ4NTU5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84NjA2NjIyPgorCisg ICAgICAgIEFkZCBudWxsIGNoZWNrcyBmb3IgbV9wbHVnaW4uCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6 Om1hbnVhbExvYWREaWRSZWNlaXZlUmVzcG9uc2UpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5W aWV3OjptYW51YWxMb2FkRGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5W aWV3OjptYW51YWxMb2FkRGlkRmluaXNoTG9hZGluZyk6CisgICAgICAgIChXZWJLaXQ6OlBsdWdp blZpZXc6Om1hbnVhbExvYWREaWRGYWlsKToKKworMjAxMC0xMS0xOCAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEpvaG4gU3VsbGl2 YW4uCiAKICAgICAgICAgUGFnZSBvdmVybGF5cyBzaG91bGQgYmUgYWJsZSB0byBoYW5kbGUgbW91 c2UgZXZlbnRzCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4 IDQyNzIxZjQ2ODM0YjdmOGQ2MGZjYmFhNTgxMmZlMGEzODA5MzAwNWQuLjc3ODYxOWEyMDFjMWVm NTBhYmUxYjJjM2IzOGNlZTE5YjI0ZDJlMWMgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvV2ViUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5z L1BsdWdpblZpZXcuY3BwCkBAIC0yOTEsNiArMjkxLDEwIEBAIEZyYW1lKiBQbHVnaW5WaWV3Ojpm cmFtZSgpCiAKIHZvaWQgUGx1Z2luVmlldzo6bWFudWFsTG9hZERpZFJlY2VpdmVSZXNwb25zZShj b25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSkKIHsKKyAgICAvLyBUaGUgcGx1Zy1pbiBj YW4gYmUgbnVsbCBoZXJlIGlmIGl0IGZhaWxlZCB0byBpbml0aWFsaXplLgorICAgIGlmICghbV9w bHVnaW4pCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIENvbXB1dGUgdGhlIHN0cmVhbSByZWxh dGVkIGRhdGEgZnJvbSB0aGUgcmVzb3VyY2UgcmVzcG9uc2UuCiAgICAgY29uc3QgS1VSTCYgcmVz cG9uc2VVUkwgPSByZXNwb25zZS51cmwoKTsKICAgICBjb25zdCBTdHJpbmcmIG1pbWVUeXBlID0g cmVzcG9uc2UubWltZVR5cGUoKTsKQEAgLTMwNywxNiArMzExLDI4IEBAIHZvaWQgUGx1Z2luVmll dzo6bWFudWFsTG9hZERpZFJlY2VpdmVSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiBy ZXNwb25zZSkKIAogdm9pZCBQbHVnaW5WaWV3OjptYW51YWxMb2FkRGlkUmVjZWl2ZURhdGEoY29u c3QgY2hhciogYnl0ZXMsIGludCBsZW5ndGgpCiB7CisgICAgLy8gVGhlIHBsdWctaW4gY2FuIGJl IG51bGwgaGVyZSBpZiBpdCBmYWlsZWQgdG8gaW5pdGlhbGl6ZS4KKyAgICBpZiAoIW1fcGx1Z2lu KQorICAgICAgICByZXR1cm47CisKICAgICBtX3BsdWdpbi0+bWFudWFsU3RyZWFtRGlkUmVjZWl2 ZURhdGEoYnl0ZXMsIGxlbmd0aCk7CiB9CiAKIHZvaWQgUGx1Z2luVmlldzo6bWFudWFsTG9hZERp ZEZpbmlzaExvYWRpbmcoKQogeworICAgIC8vIFRoZSBwbHVnLWluIGNhbiBiZSBudWxsIGhlcmUg aWYgaXQgZmFpbGVkIHRvIGluaXRpYWxpemUuCisgICAgaWYgKCFtX3BsdWdpbikKKyAgICAgICAg cmV0dXJuOworCiAgICAgbV9wbHVnaW4tPm1hbnVhbFN0cmVhbURpZEZpbmlzaExvYWRpbmcoKTsK IH0KIAogdm9pZCBQbHVnaW5WaWV3OjptYW51YWxMb2FkRGlkRmFpbChjb25zdCBSZXNvdXJjZUVy cm9yJiBlcnJvcikKIHsKKyAgICAvLyBUaGUgcGx1Zy1pbiBjYW4gYmUgbnVsbCBoZXJlIGlmIGl0 IGZhaWxlZCB0byBpbml0aWFsaXplLgorICAgIGlmICghbV9wbHVnaW4pCisgICAgICAgIHJldHVy bjsKKwogICAgIG1fcGx1Z2luLT5tYW51YWxTdHJlYW1EaWRGYWlsKGVycm9yLmlzQ2FuY2VsbGF0 aW9uKCkpOwogfQogCg==