48551 2010-10-28 12:53:55 -0700 HTMLDocument::isFrameSet() should not depend on renderer 2010-10-28 13:36:17 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 301249 0 ap 2010-10-28 12:53:55 -0700 It's confusing to have both DOM and renderer checks in one function. There are only two callers of Document::isFrameSet(): 1. LegacyWebArchive::createFromSelection(). It doesn't seem to depend on render tree at all. 2. FrameLoader::shouldScrollToAnchor(). Returning true from Document::isFrameSet() means that we won't scroll, which seems like a good idea if there's no renderer. 301258 1 ap 2010-10-28 13:12:36 -0700 The check has been there since the method was added in <http://trac.webkit.org/changeset/1564>. 301260 2 72222 ap 2010-10-28 13:13:11 -0700 Created attachment 72222 proposed patch 301293 3 ap 2010-10-28 13:36:17 -0700 Committed <http://trac.webkit.org/changeset/70804>. 72222 2010-10-28 13:13:11 -0700 2010-10-28 13:20:30 -0700 proposed patch NoRenderer.txt text/plain 1934 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDc5OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NTUxCisgICAgICAgIEhU TUxEb2N1bWVudDo6aXNGcmFtZVNldCgpIHNob3VsZCBub3QgZGVwZW5kIG9uIHJlbmRlcmVyCisK KyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHksIHNvIG5vIG5ldyB0ZXN0cy4KKwor ICAgICAgICAqIGh0bWwvSFRNTERvY3VtZW50LmNwcDogKFdlYkNvcmU6OkhUTUxEb2N1bWVudDo6 aXNGcmFtZVNldCk6IE9taXQgdGhlIGNoZWNrIGZvciByZW5kZXJlci4KKworICAgICAgICAqIHJl bmRlcmluZy9SZW5kZXJMYXllci5oOiBSZW1vdmVkIHVubmVlZGVkIGluY2x1ZGVzIGFuZCBmb3J3 YXJkIGRlY2xhcmF0aW9ucy4KKwogMjAxMC0xMC0yOCAgWXV6byBGdWppc2hpbWEgIDx5dXpvQGdv b2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgSHlhdHQuCkluZGV4OiBXZWJD b3JlL2h0bWwvSFRNTERvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvSFRN TERvY3VtZW50LmNwcAkocmV2aXNpb24gNzA1ODMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTERvY3Vt ZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDM5LDcgKzQzOSw3IEBAIHZvaWQgSFRNTERvY3Vt ZW50OjpjbGVhcigpCiBib29sIEhUTUxEb2N1bWVudDo6aXNGcmFtZVNldCgpIGNvbnN0CiB7CiAg ICAgSFRNTEVsZW1lbnQqIGJvZHlFbGVtZW50ID0gYm9keSgpOwotICAgIHJldHVybiBib2R5RWxl bWVudCAmJiBib2R5RWxlbWVudC0+cmVuZGVyZXIoKSAmJiBib2R5RWxlbWVudC0+aGFzVGFnTmFt ZShmcmFtZXNldFRhZyk7CisgICAgcmV0dXJuIGJvZHlFbGVtZW50ICYmIGJvZHlFbGVtZW50LT5o YXNUYWdOYW1lKGZyYW1lc2V0VGFnKTsKIH0KIAogfQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ci5oCShyZXZpc2lvbiA3MDU4MykKKysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgJ KHdvcmtpbmcgY29weSkKQEAgLTQ3LDIyICs0NywxNyBAQAogI2luY2x1ZGUgIlJlbmRlckJveC5o IgogI2luY2x1ZGUgIlNjcm9sbEJlaGF2aW9yLmgiCiAjaW5jbHVkZSAiU2Nyb2xsYmFyQ2xpZW50 LmgiCi0jaW5jbHVkZSAiVGltZXIuaCIKICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAKIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAotY2xhc3MgQ2FjaGVkUmVzb3VyY2U7CiBjbGFzcyBIaXRUZXN0UmVx dWVzdDsKIGNsYXNzIEhpdFRlc3RSZXN1bHQ7CiBjbGFzcyBIaXRUZXN0aW5nVHJhbnNmb3JtU3Rh dGU7Ci1jbGFzcyBSZW5kZXJGcmFtZVNldDsKIGNsYXNzIFJlbmRlck1hcnF1ZWU7CiBjbGFzcyBS ZW5kZXJSZXBsaWNhOwogY2xhc3MgUmVuZGVyU2Nyb2xsYmFyUGFydDsKIGNsYXNzIFJlbmRlclN0 eWxlOwotY2xhc3MgUmVuZGVyVGFibGU7Ci1jbGFzcyBSZW5kZXJUZXh0OwogY2xhc3MgUmVuZGVy VmlldzsKIGNsYXNzIFNjcm9sbGJhcjsKIGNsYXNzIFRyYW5zZm9ybWF0aW9uTWF0cml4Owo=