48549 2010-10-28 12:19:09 -0700 [Qt] refcount assertion on WebPageProxy, when closing a window 2010-11-19 22:29:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 zalan zalan christian.webkit commit-queue darin sam oldest_to_newest 301227 0 zalan 2010-10-28 12:19:09 -0700 ASSERTION FAILED: m_refCount > 0 (../../../qtwebkit-webkit2-dev/JavaScriptCore/wtf/RefCounted.h:83 bool WTF::RefCountedBase::derefBase()) occurs when closing a window. Apparently a ref is missing, when WebPageProxy is destroyed. I am still yet to check it out on Mac, but with Qt, it is easy to reproduce. It looks like, during the construction of a new page, we lose one ref in WebUIClient::createNewPage(), when we call adoptRef on the WebPageProxy object. I'm puzzled why this adoptRef is called (WebUIClient.cpp line#78), when we already call adoptRef on the object, when it is being created (WebPageProxy::create()). Looking at the 'new page' callback backtrace, I can't see where this extra (adopted) ref would come from. When adoptRef() is removed, refcount goes back to normal and no assert on window.close(). 307768 1 73586 zalan 2010-11-11 00:39:03 -0800 Created attachment 73586 remove extra adoptref 308242 2 73586 sam 2010-11-11 16:04:51 -0800 Comment on attachment 73586 remove extra adoptref The implementation of createNewPage should return a retained WKPageRef, so the existing code is correct. 308258 3 darin 2010-11-11 16:34:02 -0800 This is probably a bug in the test program, not WebKit2 itself. 308413 4 zalan 2010-11-11 23:56:20 -0800 ok, thanks for the clarification. 311406 5 74380 zalan 2010-11-19 06:12:39 -0800 Created attachment 74380 retain WKPageRef 311707 6 74380 kling 2010-11-19 15:00:58 -0800 Comment on attachment 74380 retain WKPageRef LGTM 311872 7 commit-queue 2010-11-19 22:26:28 -0800 The commit-queue encountered the following flaky tests while processing attachment 74380: fast/profiler/throw-exception-from-eval.html Please file bugs against the tests. These tests were authored by kmccullough@apple.com, oliver@apple.com, and timothy@apple.com. The commit-queue is continuing to process your patch. 311873 8 74380 commit-queue 2010-11-19 22:29:23 -0800 Comment on attachment 74380 retain WKPageRef Clearing flags on attachment: 74380 Committed r72468: <http://trac.webkit.org/changeset/72468> 311874 9 commit-queue 2010-11-19 22:29:30 -0800 All reviewed patches have been landed. Closing bug. 73586 2010-11-11 00:39:03 -0800 2010-11-11 16:04:51 -0800 remove extra adoptref remove_adoptref.pathc text/plain 1316 zalan SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MTc5OSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMTEgIFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHJl bW92ZSBleHRyYSBhZG9wdFJlZigpIGZyb20gY3JlYXRlTmV3UGFnZSgpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODU0OQorCisgICAgICAgICogVUlQ cm9jZXNzL1dlYlVJQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViVUlDbGllbnQ6OmNy ZWF0ZU5ld1BhZ2UpOgorCiAyMDEwLTExLTEwICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCkluZGV4OiBXZWJLaXQyL1VJ UHJvY2Vzcy9XZWJVSUNsaWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViVUlDbGllbnQuY3BwCShyZXZpc2lvbiA3MTc5NykKKysrIFdlYktpdDIvVUlQcm9jZXNzL1dl YlVJQ2xpZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMsNyArNjMsNyBAQCBQYXNzUmVmUHRy PFdlYlBhZ2VQcm94eT4gV2ViVUlDbGllbnQ6OmNyCiAgICAgbWFwLnNldCgiZGlhbG9nIiwgV2Vi Qm9vbGVhbjo6Y3JlYXRlKHdpbmRvd0ZlYXR1cmVzLmRpYWxvZykpOwogICAgIFJlZlB0cjxJbW11 dGFibGVEaWN0aW9uYXJ5PiBmZWF0dXJlc01hcCA9IEltbXV0YWJsZURpY3Rpb25hcnk6OmFkb3B0 KG1hcCk7CiAKLSAgICByZXR1cm4gYWRvcHRSZWYodG9JbXBsKG1fY2xpZW50LmNyZWF0ZU5ld1Bh Z2UodG9BUEkocGFnZSksIHRvQVBJKGZlYXR1cmVzTWFwLmdldCgpKSwgdG9BUEkobW9kaWZpZXJz KSwgdG9BUEkoYnV0dG9uKSwgbV9jbGllbnQuY2xpZW50SW5mbykpKTsKKyAgICByZXR1cm4gdG9J bXBsKG1fY2xpZW50LmNyZWF0ZU5ld1BhZ2UodG9BUEkocGFnZSksIHRvQVBJKGZlYXR1cmVzTWFw LmdldCgpKSwgdG9BUEkobW9kaWZpZXJzKSwgdG9BUEkoYnV0dG9uKSwgbV9jbGllbnQuY2xpZW50 SW5mbykpOwogfSAKIAogdm9pZCBXZWJVSUNsaWVudDo6c2hvd1BhZ2UoV2ViUGFnZVByb3h5KiBw YWdlKQo= 74380 2010-11-19 06:12:39 -0800 2010-11-19 22:29:23 -0800 retain WKPageRef retain.patch text/plain 1252 zalan SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MjM4NykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMTEtMTkgIFphbGFuIEJ1anRhcyAgPHpidWp0YXNAZ21haWwu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl YlVJQ2xpZW50OjpjcmVhdGVOZXdQYWdlKCkgZXhwZWN0cyBhIHJldGFpbmVkIFdLUGFnZVJlZi4g CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODU0OQor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9DbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKHF0 X3drX2NyZWF0ZU5ld1BhZ2UpOgorCiAyMDEwLTExLTE4ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBs ZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWRhbSBSb2Jlbi4KSW5kZXg6IFdl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9DbGllbnRJbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDcyMzY5KQorKysg V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L0NsaWVudEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNiw2ICsyNiw3IEBACiAjaW5jbHVkZSA8cXdrcGFnZS5oPgogI2luY2x1ZGUgPHF3a3BhZ2Vf cC5oPgogI2luY2x1ZGUgPFdLRnJhbWUuaD4KKyNpbmNsdWRlIDxXS1R5cGUuaD4KIAogdXNpbmcg bmFtZXNwYWNlIFdlYktpdDsKIApAQCAtMTQzLDggKzE0NCwxMCBAQCBXS1BhZ2VSZWYgcXRfd2tf Y3JlYXRlTmV3UGFnZShXS1BhZ2VSZWYgCiAgICAgaWYgKCFjcmVhdGVOZXdQYWdlRm4pCiAgICAg ICAgIHJldHVybiAwOwogCi0gICAgaWYgKFFXS1BhZ2UqIG5ld1BhZ2UgPSBjcmVhdGVOZXdQYWdl Rm4od2tQYWdlKSkKKyAgICBpZiAoUVdLUGFnZSogbmV3UGFnZSA9IGNyZWF0ZU5ld1BhZ2VGbih3 a1BhZ2UpKSB7CisgICAgICAgIFdLUmV0YWluKG5ld1BhZ2UtPnBhZ2VSZWYoKSk7CiAgICAgICAg IHJldHVybiBuZXdQYWdlLT5wYWdlUmVmKCk7CisgICAgfQogCiAgICAgcmV0dXJuIDA7CiB9Cg==