48535 2010-10-28 11:40:32 -0700 WKURLRefs should be allowed to be null 2010-10-28 12:35:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 sam webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 301185 0 sam 2010-10-28 11:40:32 -0700 Unlike WKStringRefs, we should allow returning null WKURLRefs as the concept of an empty URL makes little sense. 301203 1 72215 sam 2010-10-28 11:55:27 -0700 Created attachment 72215 Patch 301209 2 sam 2010-10-28 11:58:08 -0700 <rdar://problem/8575621> 301221 3 sam 2010-10-28 12:09:56 -0700 Landed in r70795. 301238 4 webkit.review.bot 2010-10-28 12:35:15 -0700 http://trac.webkit.org/changeset/70795 might have broken Qt Linux Release The following tests are not passing: fast/dom/Window/window-property-descriptors.html 72215 2010-10-28 11:55:27 -0700 2010-10-28 11:59:09 -0700 Patch url2.diff text/plain 4813 sam SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDc5MSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXS1VSTFJl ZnMgc2hvdWxkIGJlIGFsbG93ZWQgdG8gYmUgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg1MzUKKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9X S1NoYXJlZEFQSUNhc3QuaDoKKyAgICAgICAgKFdlYktpdDo6dG9VUkxSZWYpOgorICAgICAgICAo V2ViS2l0Ojp0b0NvcGllZFVSTEFQSSk6CisgICAgICAgIFR1cm4gYSBudWxsIFdURjo6U3RyaW5n IGludG8gYSBudWxsIFdLVVJMUmVmLgorCiAyMDEwLTEwLTI4ICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kZXJzIENhcmxzc29uLgpJbmRleDog V2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgJKHJldmlzaW9uIDcwNzg5KQorKysg V2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgJKHdvcmtpbmcgY29weSkKQEAg LTExNywxMiArMTE3LDYgQEAgaW5saW5lIFByb3h5aW5nUmVmUHRyPFdlYlN0cmluZz4gdG9BUEko UwogICAgIHJldHVybiBQcm94eWluZ1JlZlB0cjxXZWJTdHJpbmc+KFdlYlN0cmluZzo6Y3JlYXRl KFN0cmluZyhpbXBsKSkpOwogfQogCi1pbmxpbmUgUHJveHlpbmdSZWZQdHI8V2ViVVJMPiB0b1VS TFJlZihTdHJpbmdJbXBsKiBzdHJpbmcpCi17Ci0gICAgU3RyaW5nSW1wbCogaW1wbCA9IHN0cmlu ZyA/IHN0cmluZyA6IFN0cmluZ0ltcGw6OmVtcHR5KCk7Ci0gICAgcmV0dXJuIFByb3h5aW5nUmVm UHRyPFdlYlVSTD4oV2ViVVJMOjpjcmVhdGUoU3RyaW5nKGltcGwpKSk7Ci19Ci0KIGlubGluZSBX S1N0cmluZ1JlZiB0b0NvcGllZEFQSShjb25zdCBTdHJpbmcmIHN0cmluZykKIHsKICAgICBTdHJp bmdJbXBsKiBpbXBsID0gc3RyaW5nLmltcGwoKSA/IHN0cmluZy5pbXBsKCkgOiBTdHJpbmdJbXBs OjplbXB0eSgpOwpAQCAtMTMwLDEwICsxMjQsMTggQEAgaW5saW5lIFdLU3RyaW5nUmVmIHRvQ29w aWVkQVBJKGNvbnN0IFN0cgogICAgIHJldHVybiB0b0FQSSh3ZWJTdHJpbmcucmVsZWFzZSgpLnJl bGVhc2VSZWYoKSk7CiB9CiAKK2lubGluZSBQcm94eWluZ1JlZlB0cjxXZWJVUkw+IHRvVVJMUmVm KFN0cmluZ0ltcGwqIHN0cmluZykKK3sKKyAgICBpZiAoIXN0cmluZykKKyAgICAgICAgUHJveHlp bmdSZWZQdHI8V2ViVVJMPigwKTsKKyAgICByZXR1cm4gUHJveHlpbmdSZWZQdHI8V2ViVVJMPihX ZWJVUkw6OmNyZWF0ZShTdHJpbmcoc3RyaW5nKSkpOworfQorCiBpbmxpbmUgV0tVUkxSZWYgdG9D b3BpZWRVUkxBUEkoY29uc3QgU3RyaW5nJiBzdHJpbmcpCiB7Ci0gICAgU3RyaW5nSW1wbCogaW1w bCA9IHN0cmluZy5pbXBsKCkgPyBzdHJpbmcuaW1wbCgpIDogU3RyaW5nSW1wbDo6ZW1wdHkoKTsK LSAgICBSZWZQdHI8V2ViVVJMPiB3ZWJVUkwgPSBXZWJVUkw6OmNyZWF0ZShTdHJpbmcoaW1wbCkp OworICAgIGlmICghc3RyaW5nKQorICAgICAgICByZXR1cm4gMDsKKyAgICBSZWZQdHI8V2ViVVJM PiB3ZWJVUkwgPSBXZWJVUkw6OmNyZWF0ZShzdHJpbmcpOwogICAgIHJldHVybiB0b0FQSSh3ZWJV UkwucmVsZWFzZSgpLnJlbGVhc2VSZWYoKSk7CiB9CiAKSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDcwNzkx KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTAtMTAtMjggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXS1VSTFJlZnMgc2hvdWxkIGJl IGFsbG93ZWQgdG8gYmUgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDg1MzUKKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQ SS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz dHMvV2ViS2l0Mi9QYWdlTG9hZEJhc2ljLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmRp ZFN0YXJ0UHJvdmlzaW9uYWxMb2FkRm9yRnJhbWUpOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6 ZGlkQ29tbWl0TG9hZEZvckZyYW1lKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmRpZEZpbmlz aExvYWRGb3JGcmFtZSk6CisgICAgICAgIFRlc3QgdGhhdCBVUkxzIGFyZSBudWxsIHBvaW50ZXJz IHdoZW4gdW5zZXQuCisKIDIwMTAtMTAtMjcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBXZWJLaXRUb29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvago9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24gNzA3OTEpCisrKyBXZWJLaXRUb29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagkod29y a2luZyBjb3B5KQpAQCAtMjU2LDggKzI1Niw4IEBACiAJCUJDOTA5NzdCMTI1NTcxQUUwMDA4Mzc1 NiAvKiBSZXNvdXJjZXMgKi8gPSB7CiAJCQlpc2EgPSBQQlhHcm91cDsKIAkJCWNoaWxkcmVuID0g KAotCQkJCUJDQkQzNzJFMTI1QUJCRTYwMEQyQzI5RiAvKiBpY29uLnBuZyAqLywKIAkJCQkxQTAy Qzg0QjEyNUQ0QTVFMDBFM0Y0QkQgLyogZmluZC5odG1sICovLAorCQkJCUJDQkQzNzJFMTI1QUJC RTYwMEQyQzI5RiAvKiBpY29uLnBuZyAqLywKIAkJCQlCQzkwOTc3ODEyNTU3MUFCMDAwODM3NTYg Lyogc2ltcGxlLmh0bWwgKi8sCiAJCQkJQzAyQjc4ODIxMjY2MTU0MTAwMjZCRjBGIC8qIHNwYWNl YmFyLXNjcm9sbGluZy5odG1sICovLAogCQkJKTsKSW5kZXg6IFdlYktpdFRvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Mi9QYWdlTG9hZEJhc2ljLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXRUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvUGFnZUxvYWRCYXNpYy5jcHAJKHJl dmlzaW9uIDcwNzkxKQorKysgV2ViS2l0VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQy L1BhZ2VMb2FkQmFzaWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw4ICs1MiwxMyBAQCBzdGF0 aWMgdm9pZCBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyCiAgICAgU3RhdGUqIHN0YXRlID0g cmVpbnRlcnByZXRfY2FzdDxTdGF0ZSo+KGNvbnN0X2Nhc3Q8dm9pZCo+KGNsaWVudEluZm8pKTsK ICAgICBURVNUX0FTU0VSVChzdGF0ZS0+ZGlkRGVjaWRlUG9saWN5Rm9yTmF2aWdhdGlvbkFjdGlv bik7CiAgICAgVEVTVF9BU1NFUlQoIXN0YXRlLT5kaWRDb21taXRMb2FkRm9yRnJhbWUpOworCisg ICAgLy8gVGhlIGNvbW1pdGVkIFVSTCBzaG91bGQgYmUgbnVsbC4KKyAgICBURVNUX0FTU0VSVCgh V0tGcmFtZUNvcHlVUkwoZnJhbWUpKTsKKwogICAgIFRFU1RfQVNTRVJUKCFzdGF0ZS0+ZGlkU3Rh cnRQcm92aXNpb25hbExvYWRGb3JGcmFtZSk7CiAKKwogICAgIHN0YXRlLT5kaWRTdGFydFByb3Zp c2lvbmFsTG9hZEZvckZyYW1lID0gdHJ1ZTsKIH0KIApAQCAtNjMsNiArNjgsOSBAQCBzdGF0aWMg dm9pZCBkaWRDb21taXRMb2FkRm9yRnJhbWUoV0tQYWdlCiAgICAgVEVTVF9BU1NFUlQoc3RhdGUt PmRpZERlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rpb24pOwogICAgIFRFU1RfQVNTRVJUKHN0 YXRlLT5kaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZvckZyYW1lKTsKIAorICAgIC8vIFRoZSBwcm92 aXNpb25hbCBVUkwgc2hvdWxkIGJlIG51bGwuCisgICAgVEVTVF9BU1NFUlQoIVdLRnJhbWVDb3B5 UHJvdmlzaW9uYWxVUkwoZnJhbWUpKTsKKwogICAgIHN0YXRlLT5kaWRDb21taXRMb2FkRm9yRnJh bWUgPSB0cnVlOwogfQogCkBAIC03Myw2ICs4MSw5IEBAIHN0YXRpYyB2b2lkIGRpZEZpbmlzaExv YWRGb3JGcmFtZShXS1BhZ2UKICAgICBURVNUX0FTU0VSVChzdGF0ZS0+ZGlkU3RhcnRQcm92aXNp b25hbExvYWRGb3JGcmFtZSk7CiAgICAgVEVTVF9BU1NFUlQoc3RhdGUtPmRpZENvbW1pdExvYWRG b3JGcmFtZSk7CiAKKyAgICAvLyBUaGUgcHJvdmlzaW9uYWwgVVJMIHNob3VsZCBiZSBudWxsLgor ICAgIFRFU1RfQVNTRVJUKCFXS0ZyYW1lQ29weVByb3Zpc2lvbmFsVVJMKGZyYW1lKSk7CisKICAg ICB0ZXN0MURvbmUgPSB0cnVlOwogfQogCg==