48521 2010-10-28 07:06:57 -0700 [GTK] Crash in TextEncoding.cpp when using glib unicode 2010-10-29 15:15:18 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 301050 0 cgarcia 2010-10-28 07:06:57 -0700 In TextEncoding::encode() we need to convert the utf16 input string to utf8 to normalize it using g_utf8_normalize(). We are assuming that the conversion always work, but when it fails g_utf8_normalize() crashes due to NULL pointer. It's reproducible with some of the fast/url tests: Testing 20 test cases. fast/url . fast/url/anchor.html -> crashed ... fast/url/host.html -> failed ....... fast/url/query.html -> crashed ....... fast/url/standard-url.html -> crashed .. 0.96s total testing time 16 test cases (80%) succeeded 1 test case (5%) had incorrect layout 3 test cases (15%) crashed Starting webkit launcher. 301054 1 72187 cgarcia 2010-10-28 07:10:47 -0700 Created attachment 72187 Patch to fix the crash When utf8 conversion fails, just try with the original string 301064 2 72187 kling 2010-10-28 07:22:29 -0700 Comment on attachment 72187 Patch to fix the crash Nice catch, r=me 302117 3 72187 commit-queue 2010-10-29 15:15:13 -0700 Comment on attachment 72187 Patch to fix the crash Clearing flags on attachment: 72187 Committed r70935: <http://trac.webkit.org/changeset/70935> 302118 4 commit-queue 2010-10-29 15:15:18 -0700 All reviewed patches have been landed. Closing bug. 72187 2010-10-28 07:10:47 -0700 2010-10-29 15:15:13 -0700 Patch to fix the crash url-crash.diff text/plain 1515 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTU1OTc3Yy4uMGFkYzJjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0yOCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ3Jhc2ggaW4gVGV4dEVuY29kaW5nLmNwcCB3 aGVuIHVzaW5nIGdsaWIgdW5pY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDg1MjEKKworICAgICAgICBXaGVuIHRoZSBjb252ZXJzaW9uIHRvIFVU Ri04IGZhaWxzLCB0cnkgdG8gZW5jb2RlIHRoZSBvcmlnaW5hbCBzdHJpbmcKKyAgICAgICAgd2l0 aG91dCBub3JtYWxpemluZy4gRml4ZXMgdGVzdHMgY2FzZXM6CisgICAgICAgICBmYXN0L3VybC9h bmNob3IuaHRtbAorICAgICAgICAgZmFzdC91cmwvcXVlcnkuaHRtbAorICAgICAgICAgZmFzdC91 cmwvc3RhbmRhcmQtdXJsLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvVGV4dEVuY29k aW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHRFbmNvZGluZzo6ZW5jb2RlKToKKwogMjAx MC0xMC0yMSAgS3dhbmcgWXVsIFNlbyAgPHNreXVsQGNvbXBhbnkxMDAubmV0PgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS90 ZXh0L1RleHRFbmNvZGluZy5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5n LmNwcAppbmRleCA5MjFjZWViLi41OGU2OTFmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L3RleHQvVGV4dEVuY29kaW5nLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVu Y29kaW5nLmNwcApAQCAtMTIwLDYgKzEyMCwxMCBAQCBDU3RyaW5nIFRleHRFbmNvZGluZzo6ZW5j b2RlKGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzLCBzaXplX3QgbGVuZ3RoLCBVbmVuY29kYWJsZQog I2VsaWYgVVNFKEdMSUJfVU5JQ09ERSkKICAgICBHT3duUHRyPGNoYXI+IFVURjhTb3VyY2U7CiAg ICAgVVRGOFNvdXJjZS5zZXQoZ191dGYxNl90b191dGY4KGNoYXJhY3RlcnMsIGxlbmd0aCwgMCwg MCwgMCkpOworICAgIGlmICghVVRGOFNvdXJjZSkgeworICAgICAgICAvLyBJZiBjb252ZXJzaW9u IHRvIFVURi04IGZhaWxlZCwgdHJ5IHdpdGggdGhlIHN0cmluZyB3aXRob3V0IG5vcm1hbGl6YXRp b24KKyAgICAgICAgcmV0dXJuIG5ld1RleHRDb2RlYygqdGhpcyktPmVuY29kZShjaGFyYWN0ZXJz LCBsZW5ndGgsIGhhbmRsaW5nKTsKKyAgICB9CiAKICAgICBHT3duUHRyPGNoYXI+IFVURjhOb3Jt YWxpemVkOwogICAgIFVURjhOb3JtYWxpemVkLnNldChnX3V0Zjhfbm9ybWFsaXplKFVURjhTb3Vy Y2UuZ2V0KCksIC0xLCBHX05PUk1BTElaRV9ORkMpKTsK