48504 2010-10-28 02:57:28 -0700 Remove obsolete public/API methods in chromium port 2010-10-28 05:57:00 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 satish webkit-unassigned commit-queue steveblock oldest_to_newest 300964 0 satish 2010-10-28 02:57:28 -0700 In http://trac.webkit.org/changeset/70567 the speech input API was changed to include additional parameters. Now that chromium has picked up this change we no longer need the old style wrappers which were left in place for a clean transition. 300965 1 72165 satish 2010-10-28 02:59:23 -0700 Created attachment 72165 Patch 300967 2 72165 steveblock 2010-10-28 03:10:23 -0700 Comment on attachment 72165 Patch Is this correct? It looks like we've taken the implementation from the deprecated method. 300969 3 satish 2010-10-28 03:15:10 -0700 The method with 2 parameters is deprecated and WebKit currently calls the 3 parameter method. In chromium, the class implementing this interface only implements the 3 parameter variant. So the 2 parameter variant is no longer needed and is removed here. 300970 4 satish 2010-10-28 03:15:29 -0700 Pointer to the chromium class which implements this interface: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/speech_input_dispatcher.cc?revision=64213&view=markup 301005 5 72165 steveblock 2010-10-28 05:35:45 -0700 Comment on attachment 72165 Patch r=me 301013 6 72165 commit-queue 2010-10-28 05:56:55 -0700 Comment on attachment 72165 Patch Clearing flags on attachment: 72165 Committed r70769: <http://trac.webkit.org/changeset/70769> 301014 7 commit-queue 2010-10-28 05:57:00 -0700 All reviewed patches have been landed. Closing bug. 72165 2010-10-28 02:59:23 -0700 2010-10-28 05:56:54 -0700 Patch bug-48504-20101028105921.patch text/plain 1465 satish ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGEyZDc1Mjk3ZTdmNTI5N2JjZDM4ZmM5NDZhZjNlYjBhOGNmODViYTAu Ljg3NTllY2VhZjRiNjJmODJlNjFjZDAyMGMxZWVjOTFhMWUyNzBkZTAgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDEwLTEwLTI4ICBTYXRpc2ggU2FtcGF0aCAgPHNhdGlzaEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIG9ic29sZXRlIHB1YmxpYy9BUEkgbWV0aG9kcyBpbiBjaHJvbWl1bSBwb3J0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODUwNAorCisg ICAgICAgICogcHVibGljL1dlYlNwZWVjaElucHV0Q29udHJvbGxlci5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXI6OnN0YXJ0UmVjb2duaXRpb24pOgorCiAyMDEw LTEwLTI3ICBFcmljIFVocmhhbmUgIDxlcmljdUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlNwZWVjaElucHV0Q29udHJvbGxlci5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJT cGVlY2hJbnB1dENvbnRyb2xsZXIuaAppbmRleCA2MzI1MGNkZmMxZGJiMGM4YTdlM2U5NThkMzU2 ZDFjNDQ3NWM0YjdmLi5hODBkYWZkZTRkMTY0M2ViNDgyODY2ODlkMzdiNmM2ZmRkMGFmM2FiIDEw MDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWVjaElucHV0Q29udHJvbGxl ci5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlZWNoSW5wdXRDb250cm9sbGVy LmgKQEAgLTQ2LDEzICs0Niw2IEBAIHB1YmxpYzoKICAgICAvLyB0ZXh0IGFyZSByZXR1cm5lZCB2 aWEgdGhlIGxpc3RlbmVyIGludGVyZmFjZS4KICAgICB2aXJ0dWFsIGJvb2wgc3RhcnRSZWNvZ25p dGlvbihpbnQgcmVxdWVzdElkLCBjb25zdCBXZWJSZWN0JiBlbGVtZW50UmVjdCwgY29uc3QgV2Vi U3RyaW5nJiBncmFtbWFyKQogICAgIHsKLSAgICAgICAgc3RhcnRSZWNvZ25pdGlvbihyZXF1ZXN0 SWQsIGVsZW1lbnRSZWN0KTsKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KLQotICAgIC8v IEZJWE1FOiBSZW1vdmUgdGhpcyBtZXRob2Qgb25jZSBjaHJvbWl1bSBpbXBsZW1lbnRzIHRoZSBh Ym92ZSBtZXRob2QuCi0gICAgdmlydHVhbCBib29sIHN0YXJ0UmVjb2duaXRpb24oaW50IHJlcXVl c3RJZCwgY29uc3QgV2ViUmVjdCYpCi0gICAgewogICAgICAgICBXRUJLSVRfQVNTRVJUX05PVF9S RUFDSEVEKCk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9Cg==