48499 2010-10-27 21:18:28 -0700 [EFL] remove multiple definition with libcurl 2010-11-02 03:11:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ryuan.choi webkit-unassigned antognolli+webkit bfulgham commit-queue gyuyoung.kim leandro lucas.de.marchi ryuan.choi oldest_to_newest 300856 0 ryuan.choi 2010-10-27 21:18:28 -0700 ../WebCore/libwebcore_efl.a(CookieJarCurl.cpp.o): In function `WebCore::setCookieStoragePrivateBrowsingEnabled(bool)': CookieJarCurl.cpp:(.text+0xe70): multiple definition of `WebCore::setCookieStoragePrivateBrowsingEnabled(bool)' ../WebCore/libwebcore_efl.a(TemporaryLinkStubs.cpp.o):TemporaryLinkStubs.cpp:(.text+0x40): first defined here collect2: ld returned 1 exit status EFL port already have setCookieStoragePrivateBrowsingEnabled and curl also. 300859 1 72136 ryuan.choi 2010-10-27 21:26:56 -0700 Created attachment 72136 Patch 301739 2 ryuan.choi 2010-10-29 07:12:07 -0700 dear bfulgham, Could you help this? In other ports, this method is implemented in each platform. 303214 3 72136 dbates 2010-11-01 22:17:45 -0700 Comment on attachment 72136 Patch Looks sane. r=me 303288 4 commit-queue 2010-11-02 03:10:43 -0700 The commit-queue encountered the following flaky tests while processing attachment 72136: webarchive/test-link-rel-icon.html Please file bugs against the tests. These tests were authored by ddkilzer@webkit.org. The commit-queue is continuing to process your patch. 303289 5 72136 commit-queue 2010-11-02 03:11:46 -0700 Comment on attachment 72136 Patch Clearing flags on attachment: 72136 Committed r71105: <http://trac.webkit.org/changeset/71105> 303290 6 commit-queue 2010-11-02 03:11:52 -0700 All reviewed patches have been landed. Closing bug. 72136 2010-10-27 21:26:56 -0700 2010-11-02 03:11:46 -0700 Patch bug-48499-20101028132839.patch text/plain 1161 ryuan.choi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDc0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjcgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4IGZvciBFRkwgYnVpbGQgd2l0 aCBsaWJjdXJsCisKKyAgICAgICAgW0VGTF0gcmVtb3ZlIG11bHRpcGxlIGRlZmluaXRpb24gd2l0 aCBsaWJjdXJsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00ODQ5OQorCisgICAgICAgIEFkZCBtYWNybyB0byBpc29sYXRlIHNldENvb2tpZVN0b3JhZ2VQ cml2YXRlQnJvd3NpbmdFbmFibGVkIGZyb20gRUZMCisgICAgICAgIGJ1aWxkIGJlY2F1c2UgaXQg d2FzIGR1cGxpY2F0ZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2ll SmFyQ3VybC5jcHA6CisKIDIwMTAtMTAtMjcgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwCShyZXZpc2lvbiA3 MDc0NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC02MSw5ICs2MSwxMSBAQCB2b2lkIGRlbGV0ZUNvb2tpZShjb25z dCBEb2N1bWVudCosIGNvbnN0CiAgICAgLy8gRklYTUU6IE5vdCB5ZXQgaW1wbGVtZW50ZWQKIH0K IAorI2lmICFQTEFURk9STShFRkwpCiB2b2lkIHNldENvb2tpZVN0b3JhZ2VQcml2YXRlQnJvd3Np bmdFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICAgICAvLyBGSVhNRTogTm90IHlldCBpbXBsZW1l bnRlZAogfQorI2VuZGlmCiAKIH0K