48494 2010-10-27 19:17:23 -0700 fix setSize() order in WebP image decoding 2010-10-28 01:22:13 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 pascal.massimino webkit-unassigned abarth commit-queue pkasting webkit.review.bot oldest_to_newest 300806 0 pascal.massimino 2010-10-27 19:17:23 -0700 Hi, in WEBPImageDecoder.cpp, setSize() was only called when onlySize was true, causing refresh problems. This patch makes sure setSize() is always called appropriately. detective work: pkasting@ Pascal 300808 1 72130 pascal.massimino 2010-10-27 19:18:08 -0700 Created attachment 72130 fix setSize() calls in WEBPImageDecoder.cpp 300818 2 72130 abarth 2010-10-27 19:29:15 -0700 Comment on attachment 72130 fix setSize() calls in WEBPImageDecoder.cpp Looks good, but we need a ChangeLog and (ideally) a test. 300866 3 72139 pascal.massimino 2010-10-27 21:48:56 -0700 Created attachment 72139 fix setSize() calls in WEBPImageDecoder.cpp added the missing ChangeLog 300868 4 webkit.review.bot 2010-10-27 21:51:08 -0700 Attachment 72139 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 300869 5 72139 abarth 2010-10-27 21:52:23 -0700 Comment on attachment 72139 fix setSize() calls in WEBPImageDecoder.cpp You need to fill out all those fields in the ChangeLog (except the Reviewed by NOBODY line). Also, we can't land a patch with tabs. 300875 6 pascal.massimino 2010-10-27 21:56:31 -0700 Adam, oops... added the missing ChangeLog... (In reply to comment #2) > (From update of attachment 72130 [details]) > Looks good, but we need a ChangeLog and (ideally) a test. to exercise the bug (lack of refresh) there's some manual intervention required: - load a big picture - switch to another tab - switch back to the picture tab - scroll up/down => some parts were blank. I'm not sure how a test can reproduce that... Pascal 300878 7 72144 pascal.massimino 2010-10-27 22:08:39 -0700 Created attachment 72144 fix setSize() calls in WEBPImageDecoder.cpp ... and now, without the tabs 300882 8 72144 abarth 2010-10-27 22:18:49 -0700 Comment on attachment 72144 fix setSize() calls in WEBPImageDecoder.cpp View in context: https://bugs.webkit.org/attachment.cgi?id=72144&action=review > WebCore/ChangeLog:3 > + Reviewed by NOBODY (OOPS!). This line is ok because the tools fill in the reviewer automatically for you. > WebCore/ChangeLog:6 > + fix setSize() call flow: it was only called the first > + time (when onlySize is true) Also, you should link to the bug from the ChangeLog so folks can find it from the SVN revision history. > WebCore/ChangeLog:8 > + No new tests. (OOPS!) There's an SVN pre-commit hook that rejects OOPS in files. This line will prevent the patch from being landed. You should replace this line with an explanation of why there is no test. 300883 9 72145 pascal.massimino 2010-10-27 22:24:27 -0700 Created attachment 72145 fix setSize() calls in WEBPImageDecoder.cpp fix the changeLog: add bug URL, explain the missing test. 300885 10 72145 abarth 2010-10-27 22:28:10 -0700 Comment on attachment 72145 fix setSize() calls in WEBPImageDecoder.cpp Thanks. Your TPS reports are now in order! 300937 11 72145 commit-queue 2010-10-28 01:22:07 -0700 Comment on attachment 72145 fix setSize() calls in WEBPImageDecoder.cpp Clearing flags on attachment: 72145 Committed r70758: <http://trac.webkit.org/changeset/70758> 300938 12 commit-queue 2010-10-28 01:22:13 -0700 All reviewed patches have been landed. Closing bug. 72130 2010-10-27 19:18:08 -0700 2010-10-27 21:48:56 -0700 fix setSize() calls in WEBPImageDecoder.cpp patch_test text/plain 978 pascal.massimino SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNv ZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dl YnAvV0VCUEltYWdlRGVjb2Rlci5jcHAJKHJldmlzaW9uIDcwNTQ1KQorKysgV2ViQ29yZS9wbGF0 Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC04NiwxNCArODYsMTUgQEAKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgaWYgKCFX ZWJQR2V0SW5mbyhkYXRhQnl0ZXMsIGRhdGFTaXplLCAmd2lkdGgsICZoZWlnaHQpKQogICAgICAg ICByZXR1cm4gc2V0RmFpbGVkKCk7CisgICAgaWYgKCFJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWls YWJsZSgpICYmICFzZXRTaXplKHdpZHRoLCBoZWlnaHQpKQorICAgICAgICByZXR1cm4gc2V0RmFp bGVkKCk7CiAgICAgaWYgKG9ubHlTaXplKQotICAgICAgICByZXR1cm4gc2V0U2l6ZSh3aWR0aCwg aGVpZ2h0KSB8fCBzZXRGYWlsZWQoKTsKKyAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAvLyBG SVhNRTogQWRkIHN1cHBvcnQgZm9yIHByb2dyZXNzaXZlIGRlY29kaW5nLgogICAgIGlmICghaXNB bGxEYXRhUmVjZWl2ZWQoKSkKICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgaWYgKG1fZnJhbWVC dWZmZXJDYWNoZS5pc0VtcHR5KCkpCi0gICAgICAgIHJldHVybiB0cnVlOworICAgIEFTU0VSVCgh bV9mcmFtZUJ1ZmZlckNhY2hlLmlzRW1wdHkoKSk7CiAgICAgUkdCQTMyQnVmZmVyJiBidWZmZXIg PSBtX2ZyYW1lQnVmZmVyQ2FjaGVbMF07CiAgICAgaWYgKGJ1ZmZlci5zdGF0dXMoKSA9PSBSR0JB MzJCdWZmZXI6OkZyYW1lRW1wdHkpIHsKICAgICAgICAgQVNTRVJUKHdpZHRoID09IHNpemUoKS53 aWR0aCgpKTsK 72139 2010-10-27 21:48:56 -0700 2010-10-27 22:08:39 -0700 fix setSize() calls in WEBPImageDecoder.cpp patch_test text/plain 1600 pascal.massimino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDc0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMjcgIFBhc2NhbCBNYXNzaW1pbm8gIDxwYXNjYWwubWFz c2ltaW5vQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQor CisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldFQlBJbWFnZURlY29kZXI6OmRlY29kZSk6CisJICBmaXg6IGNhbGwgc2V0U2l6ZSgpIGV2ZW4g d2hlbiBvbmx5U2l6ZSBpcyBmYWxzZQorCiAyMDEwLTEwLTI3ICBFcmljIFVocmhhbmUgIDxlcmlj dUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4uCkluZGV4 OiBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dF QlBJbWFnZURlY29kZXIuY3BwCShyZXZpc2lvbiA3MDY5MSkKKysrIFdlYkNvcmUvcGxhdGZvcm0v aW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtODYsMTQgKzg2LDE1IEBACiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIGlmICghV2ViUEdl dEluZm8oZGF0YUJ5dGVzLCBkYXRhU2l6ZSwgJndpZHRoLCAmaGVpZ2h0KSkKICAgICAgICAgcmV0 dXJuIHNldEZhaWxlZCgpOworICAgIGlmICghSW1hZ2VEZWNvZGVyOjppc1NpemVBdmFpbGFibGUo KSAmJiAhc2V0U2l6ZSh3aWR0aCwgaGVpZ2h0KSkKKyAgICAgICAgcmV0dXJuIHNldEZhaWxlZCgp OwogICAgIGlmIChvbmx5U2l6ZSkKLSAgICAgICAgcmV0dXJuIHNldFNpemUod2lkdGgsIGhlaWdo dCkgfHwgc2V0RmFpbGVkKCk7CisgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgLy8gRklYTUU6 IEFkZCBzdXBwb3J0IGZvciBwcm9ncmVzc2l2ZSBkZWNvZGluZy4KICAgICBpZiAoIWlzQWxsRGF0 YVJlY2VpdmVkKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwotICAgIGlmIChtX2ZyYW1lQnVmZmVy Q2FjaGUuaXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBBU1NFUlQoIW1fZnJh bWVCdWZmZXJDYWNoZS5pc0VtcHR5KCkpOwogICAgIFJHQkEzMkJ1ZmZlciYgYnVmZmVyID0gbV9m cmFtZUJ1ZmZlckNhY2hlWzBdOwogICAgIGlmIChidWZmZXIuc3RhdHVzKCkgPT0gUkdCQTMyQnVm ZmVyOjpGcmFtZUVtcHR5KSB7CiAgICAgICAgIEFTU0VSVCh3aWR0aCA9PSBzaXplKCkud2lkdGgo KSk7Cg== 72144 2010-10-27 22:08:39 -0700 2010-10-27 22:24:27 -0700 fix setSize() calls in WEBPImageDecoder.cpp patch_test text/plain 1655 pascal.massimino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDc0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMjcgIFBhc2NhbCBNYXNzaW1pbm8gIDxwYXNjYWwubWFz c2ltaW5vQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBmaXggc2V0U2l6ZSgpIGNhbGwgZmxvdzogaXQgd2FzIG9ubHkgY2FsbGVkIHRo ZSBmaXJzdAorICAgICAgICB0aW1lICh3aGVuIG9ubHlTaXplIGlzIHRydWUpCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pbWFnZS1kZWNvZGVy cy93ZWJwL1dFQlBJbWFnZURlY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0VCUEltYWdl RGVjb2Rlcjo6ZGVjb2RlKToKKyAgICAgICAgICAgZml4OiBjYWxsIHNldFNpemUoKSBldmVuIHdo ZW4gb25seVNpemUgaXMgZmFsc2UKKwogMjAxMC0xMC0yNyAgRXJpYyBVaHJoYW5lICA8ZXJpY3VA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJbmRleDog V2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJbWFnZURlY29kZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQ SW1hZ2VEZWNvZGVyLmNwcAkocmV2aXNpb24gNzA2OTEpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2lt YWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTg2LDE0ICs4NiwxNSBAQAogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICBpZiAoIVdlYlBHZXRJ bmZvKGRhdGFCeXRlcywgZGF0YVNpemUsICZ3aWR0aCwgJmhlaWdodCkpCiAgICAgICAgIHJldHVy biBzZXRGYWlsZWQoKTsKKyAgICBpZiAoIUltYWdlRGVjb2Rlcjo6aXNTaXplQXZhaWxhYmxlKCkg JiYgIXNldFNpemUod2lkdGgsIGhlaWdodCkpCisgICAgICAgIHJldHVybiBzZXRGYWlsZWQoKTsK ICAgICBpZiAob25seVNpemUpCi0gICAgICAgIHJldHVybiBzZXRTaXplKHdpZHRoLCBoZWlnaHQp IHx8IHNldEZhaWxlZCgpOworICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIC8vIEZJWE1FOiBB ZGQgc3VwcG9ydCBmb3IgcHJvZ3Jlc3NpdmUgZGVjb2RpbmcuCiAgICAgaWYgKCFpc0FsbERhdGFS ZWNlaXZlZCgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICBpZiAobV9mcmFtZUJ1ZmZlckNh Y2hlLmlzRW1wdHkoKSkKLSAgICAgICAgcmV0dXJuIHRydWU7CisgICAgQVNTRVJUKCFtX2ZyYW1l QnVmZmVyQ2FjaGUuaXNFbXB0eSgpKTsKICAgICBSR0JBMzJCdWZmZXImIGJ1ZmZlciA9IG1fZnJh bWVCdWZmZXJDYWNoZVswXTsKICAgICBpZiAoYnVmZmVyLnN0YXR1cygpID09IFJHQkEzMkJ1ZmZl cjo6RnJhbWVFbXB0eSkgewogICAgICAgICBBU1NFUlQod2lkdGggPT0gc2l6ZSgpLndpZHRoKCkp Owo= 72145 2010-10-27 22:24:27 -0700 2010-10-28 01:22:07 -0700 fix setSize() calls in WEBPImageDecoder.cpp patch_test text/plain 1803 pascal.massimino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3MDc0NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTAtMjcgIFBhc2NhbCBNYXNzaW1pbm8gIDxwYXNjYWwubWFz c2ltaW5vQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBmaXggc2V0U2l6ZSgpIGNhbGwgZmxvdzogaXQgd2FzIG9ubHkgY2FsbGVkIHRo ZSBmaXJzdAorICAgICAgICB0aW1lICh3aGVuIG9ubHlTaXplIGlzIHRydWUpCisgICAgICAgIEJ1 ZyBVUkw6IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODQ5NAorCisg ICAgICAgIFRlc3Rpbmc6IGRpZmZpY3VsdCB0byBleGVyY2lzZSB0aGUgYnVnLCBhcyBpdCByZXF1 aXJlcworICAgICAgICBzb21lIG1hbnVhbCBmbG93IChjaGFuZ2UgdGFiLCBzY3JvbGwsLi4uKQor CisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldFQlBJbWFnZURlY29kZXI6OmRlY29kZSk6CisgICAg ICAgICAgIGZpeDogY2FsbCBzZXRTaXplKCkgZXZlbiB3aGVuIG9ubHlTaXplIGlzIGZhbHNlCisK IDIwMTAtMTAtMjcgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2Ut ZGVjb2RlcnMvd2VicC9XRUJQSW1hZ2VEZWNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L3BsYXRmb3JtL2ltYWdlLWRlY29kZXJzL3dlYnAvV0VCUEltYWdlRGVjb2Rlci5jcHAJKHJldmlz aW9uIDcwNjkxKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy93ZWJwL1dFQlBJ bWFnZURlY29kZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04NiwxNCArODYsMTUgQEAKICAgICAg ICAgcmV0dXJuIHRydWU7CiAgICAgaWYgKCFXZWJQR2V0SW5mbyhkYXRhQnl0ZXMsIGRhdGFTaXpl LCAmd2lkdGgsICZoZWlnaHQpKQogICAgICAgICByZXR1cm4gc2V0RmFpbGVkKCk7CisgICAgaWYg KCFJbWFnZURlY29kZXI6OmlzU2l6ZUF2YWlsYWJsZSgpICYmICFzZXRTaXplKHdpZHRoLCBoZWln aHQpKQorICAgICAgICByZXR1cm4gc2V0RmFpbGVkKCk7CiAgICAgaWYgKG9ubHlTaXplKQotICAg ICAgICByZXR1cm4gc2V0U2l6ZSh3aWR0aCwgaGVpZ2h0KSB8fCBzZXRGYWlsZWQoKTsKKyAgICAg ICAgcmV0dXJuIHRydWU7CiAKICAgICAvLyBGSVhNRTogQWRkIHN1cHBvcnQgZm9yIHByb2dyZXNz aXZlIGRlY29kaW5nLgogICAgIGlmICghaXNBbGxEYXRhUmVjZWl2ZWQoKSkKICAgICAgICAgcmV0 dXJuIHRydWU7Ci0gICAgaWYgKG1fZnJhbWVCdWZmZXJDYWNoZS5pc0VtcHR5KCkpCi0gICAgICAg IHJldHVybiB0cnVlOworICAgIEFTU0VSVCghbV9mcmFtZUJ1ZmZlckNhY2hlLmlzRW1wdHkoKSk7 CiAgICAgUkdCQTMyQnVmZmVyJiBidWZmZXIgPSBtX2ZyYW1lQnVmZmVyQ2FjaGVbMF07CiAgICAg aWYgKGJ1ZmZlci5zdGF0dXMoKSA9PSBSR0JBMzJCdWZmZXI6OkZyYW1lRW1wdHkpIHsKICAgICAg ICAgQVNTRVJUKHdpZHRoID09IHNpemUoKS53aWR0aCgpKTsK