48488 2010-10-27 17:25:51 -0700 [chromium] add a master-name flag to new-run-webkit-tests 2010-10-28 09:27:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan dglazkov dpranke tony victorw oldest_to_newest 300730 0 ojan 2010-10-27 17:25:51 -0700 [chromium] add a master-name flag to new-run-webkit-tests 300732 1 72120 ojan 2010-10-27 17:27:09 -0700 Created attachment 72120 Patch 300735 2 72120 dpranke 2010-10-27 17:33:28 -0700 Comment on attachment 72120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72120&action=review LGTM with the minor comment about the FIXME (I don't feel strongly about it one way or another). > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958 > + Is there a reason you didn't just add if not self._options.test_results_server: raise AssertionError() or something here instead of adding a FIXME? 300756 3 72120 tony 2010-10-27 18:03:14 -0700 Comment on attachment 72120 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72120&action=review >> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958 >> + > > Is there a reason you didn't just add > > if not self._options.test_results_server: > raise AssertionError() > > or something here instead of adding a FIXME? I assume we need to add the flags to the bots, which is a server change? I guess we could do that first. Once we require it, we can unit tests this requirement. Seems fine for now. 301056 4 ojan 2010-10-28 07:14:41 -0700 (In reply to comment #3) > >> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:958 > > > > Is there a reason you didn't just add > > > > if not self._options.test_results_server: > > raise AssertionError() > > > > or something here instead of adding a FIXME? > > I assume we need to add the flags to the bots, which is a server change? I guess we could do that first. Once we require it, we can unit tests this requirement. Right. The bots need to add the flag. But in order to add the flag to the bots, the script needs to allow the flag in the first place. 301106 5 ojan 2010-10-28 09:27:30 -0700 Committed r70782: <http://trac.webkit.org/changeset/70782> 72120 2010-10-27 17:27:09 -0700 2010-10-27 18:03:14 -0700 Patch bug-48488-20101027172708.patch text/plain 2337 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0MzEwNDFjYzMzZGJhOWFhNzFhMDg1YTdlOTc3YmY4ZDdkNDk2YzNiLi4wN2Q1N2Y2 MzRiN2RmOTBiMDI0OWU4YWJiNDNjNThlNjQ3YzFiODhjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAK IDIwMTAtMTAtMjcgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGFkZCBhIG1h c3Rlci1uYW1lIGZsYWcgdG8gbmV3LXJ1bi13ZWJraXQtdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ4NDg4CisKKyAgICAgICAgVGhlIHRlc3Qg cmVzdWx0cyBzZXJ2ZXIgbm93IGFsbG93cyBhZGRpbmcgYSBtYXN0ZXIgbmFtZSB0bworICAgICAg ICB0aGUgdXBsb2FkZWQgZmlsZXMuIFRoaXMgbGV0cyB1cyBkaXN0aW5ndWlzaCBib3RzIHRoYXQg aGF2ZQorICAgICAgICB0aGUgc2FtZSBuYW1lLCBidXQgYXJlIG9uIGRpZmZlcmVudCBtYXN0ZXJz LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90 ZXN0cy5weToKKworMjAxMC0xMC0yNyAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21pdW0ub3JnPgor CiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KIAogICAgICAgICBbY2hyb21p dW1dIE1ha2UgdGhlIHRlc3QgcmVzdWx0cyBzZXJ2ZXIgc3RvcmUgd2hpY2ggbWFzdGVyIHRoZSBi b3QgaXMgb24KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IDE0Y2Y5ODc0MGYxMDgwNGY5 YzJlY2E4NWVlZDFlZjg2MTQwNjNmYTcuLjZmYjZmOWFlN2RlMzIwZWUzMzJkMDYxOTQ3OTBkNDZm OGZiYTkyMDMgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtOTUwLDcgKzk1MCwxMiBA QCBjbGFzcyBUZXN0UnVubmVyOgogICAgICAgICBfbG9nLmluZm8oIlVwbG9hZGluZyBKU09OIGZp bGVzIGZvciBidWlsZGVyOiAlcyIsCiAgICAgICAgICAgICAgICAgICAgc2VsZi5fb3B0aW9ucy5i dWlsZGVyX25hbWUpCiAKLSAgICAgICAgYXR0cnMgPSBbKCJidWlsZGVyIiwgc2VsZi5fb3B0aW9u cy5idWlsZGVyX25hbWUpXQorICAgICAgICBhdHRycyA9IFsoImJ1aWxkZXIiLCBzZWxmLl9vcHRp b25zLmJ1aWxkZXJfbmFtZSksICgidGVzdHR5cGUiLCAibGF5b3V0LXRlc3RzIildCisgICAgICAg ICMgRklYTUU6IG1hc3Rlcl9uYW1lIHNob3VsZCBiZSByZXF1aXJlZCBpZiB0ZXN0X3Jlc3VsdHNf c2VydmVyIGlzIHNldC4KKyAgICAgICAgIyBUaHJvdyBhbiBlcnJvciBpZiBtYXN0ZXJfbmFtZSBp c24ndCBzZXQuCisgICAgICAgIGlmIHNlbGYuX29wdGlvbnMubWFzdGVyX25hbWU6CisgICAgICAg ICAgICBhdHRycy5hcHBlbmQoKCJtYXN0ZXIiLCBzZWxmLl9vcHRpb25zLm1hc3Rlcl9uYW1lKSkK KwogICAgICAgICBqc29uX2ZpbGVzID0gWyJleHBlY3RhdGlvbnMuanNvbiJdCiAgICAgICAgIGlm IHNlbGYuX29wdGlvbnMudXBsb2FkX2Z1bGxfcmVzdWx0czoKICAgICAgICAgICAgIGpzb25fZmls ZXMuYXBwZW5kKCJyZXN1bHRzLmpzb24iKQpAQCAtMTY4MCw2ICsxNjg1LDcgQEAgZGVmIHBhcnNl X2FyZ3MoYXJncz1Ob25lKToKIAogICAgICMgRklYTUU6IE1vdmUgdGhlc2UgaW50byBqc29uX3Jl c3VsdHNfZ2VuZXJhdG9yLnB5CiAgICAgcmVzdWx0c19qc29uX29wdGlvbnMgPSBbCisgICAgICAg IG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLW1hc3Rlci1uYW1lIiwgaGVscD0iVGhlIG5hbWUgb2Yg dGhlIGJ1aWxkYm90IG1hc3Rlci4iKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0t YnVpbGRlci1uYW1lIiwgZGVmYXVsdD0iRFVNTVlfQlVJTERFUl9OQU1FIiwKICAgICAgICAgICAg IGhlbHA9KCJUaGUgbmFtZSBvZiB0aGUgYnVpbGRlciBzaG93biBvbiB0aGUgd2F0ZXJmYWxsIHJ1 bm5pbmcgIgogICAgICAgICAgICAgICAgICAgInRoaXMgc2NyaXB0IGUuZy4gV2ViS2l0LiIpKSwK