48487 2010-10-27 17:18:43 -0700 [chromium] fix textInputController.{selectedRange,markedRange} 2010-10-28 10:10:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony dglazkov rniwa oldest_to_newest 300725 0 tony 2010-10-27 17:18:43 -0700 [chromium] fix textInputController.{selectedRange,markedRange} 300727 1 72119 tony 2010-10-27 17:20:10 -0700 Created attachment 72119 Patch 300728 2 tony 2010-10-27 17:21:04 -0700 This doesn't fix any tests, but it gets us closer to fixing some firstRectForCharacterRange tests. 300754 3 72119 rniwa 2010-10-27 18:02:13 -0700 Comment on attachment 72119 Patch LGTM. 300785 4 72119 tkent 2010-10-27 18:41:04 -0700 Comment on attachment 72119 Patch ok 301135 5 tony 2010-10-28 10:10:33 -0700 Committed r70786: <http://trac.webkit.org/changeset/70786> 72119 2010-10-27 17:20:10 -0700 2010-10-28 10:10:42 -0700 Patch bug-48487-20101027172033.patch text/plain 4879 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNDcyMDgxYzk4YzBmYjAxOTFlNDVjOTkwMzBmNDM1OGMyZjllMDFjLi41N2MxNjEw YmM4MTYzOWU3YTZjZDNmNmFiYTMyOGZiNGY0ZTExOWU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMTAtMjcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGZpeCB0ZXh0 SW5wdXRDb250cm9sbGVyLntzZWxlY3RlZFJhbmdlLG1hcmtlZFJhbmdlfQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0ODcKKworICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dDogY29ycmVjdCBzb21lIGNvbW1l bnRzIGFib3V0CisgICAgICAgICAgICBmaXJzdFJlY3RGb3JDaGFyYWN0ZXJSYW5nZS4KKwogMjAx MC0xMC0yNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZW1vdmUgTGVvcGFyZC1zcGVjaWZpYyByZXN1bHRzIHRoYXQgYXJlIG5vIGxvbmdlciByZXF1 aXJlZC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0 YXRpb25zLnR4dAppbmRleCAxZWY5YTMxYmNjNzA1YThiOGE4NzljMTQ4YTM3ODgyZTgyZGE0ZWJi Li5kZTVhN2UyY2U2YTM3NmUyNzBmNjFkZDIzYzQ4NDE5NDAzZTE0Y2VmIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC02 NjAsMTkgKzY2MCwyMSBAQCBCVUcyMDg0NCBMSU5VWCBXSU4gREVCVUcgOiBlZGl0aW5nL3NlbGVj dGlvbi9kZXNpZ25tb2RlLW5vLWNhcmV0Lmh0bWwgPSBGQUlMCiAvLyBSZWdyZXNzaW9uIGZyb20g bWVyZ2UgNDEyNjg6NDEyODYKIEJVRzEwNDM1IE1BQyA6IGVkaXRpbmcvc2VsZWN0aW9uL2Rlc2ln bm1vZGUtbm8tY2FyZXQuaHRtbCA9IEZBSUwKIAotLy8gSXNzdWUgMzI3MzogVGV4dElucHV0Q29u dHJvbGxlcjo6Zmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2Ugbm90IGltcGxlbWVudGVkLgorLy8g SXNzdWUgMzI3MzogVGV4dElucHV0Q29udHJvbGxlcjo6Zmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFu Z2Ugbm90IHJldHVybmluZworLy8gdGhlIGNvcnJlY3QgdmFsdWVzIGZvciBiaWRpL3J0bCB0ZXh0 LgogQlVHMzI3MyA6IGVkaXRpbmcvc2VsZWN0aW9uL21vdmUtbGVmdC1yaWdodC5odG1sID0gRkFJ TAogQlVHMzI3MyBNQUMgOiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9jYXJldC1wcmltYXJ5 LWJpZGkuaHRtbCA9IEZBSUwgUEFTUwogQlVHMzI3MyBNQUMgOiBwbGF0Zm9ybS9tYWMvZWRpdGlu Zy9pbnB1dC9maXJzdHJlY3Rmb3JjaGFyYWN0ZXJyYW5nZS1wbGFpbi5odG1sID0gRkFJTCBQQVNT CiBCVUczMjczIE1BQyA6IHBsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L3JhbmdlLWZvci1lbXB0 eS1kb2N1bWVudC5odG1sID0gRkFJTCBQQVNTCiBCVUdXSzM4MTAwIDogZWRpdGluZy9pbnNlcnRp bmcvY2FyZXQtcG9zaXRpb24uaHRtbCA9IFRFWFQgUEFTUworLy8gVGhlc2UgdGVzdHMgYWxzbyB1 c2UgZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2UsIGJ1dCB0aGV5IGdlbmVyYXRlIHNsaWdodGx5 CisvLyBkaWZmZXJlbnQgdmFsdWVzLgorQlVHMzI3MyA6IGVkaXRpbmcvc2VsZWN0aW9uLzU4MjUz NTAtMS5odG1sID0gVEVYVAorQlVHMzI3MyA6IGVkaXRpbmcvc2VsZWN0aW9uLzU4MjUzNTAtMi5o dG1sID0gVEVYVAorQlVHMzI3MyA6IGVkaXRpbmcvc2VsZWN0aW9uL21peGVkLWVkaXRhYmlsaXR5 LTEwLmh0bWwgPSBURVhUCiAKIC8vIFdlYktpdCA1MDM1ODo1MDM5NQogQlVHMzI3MyBXSU4gTElO VVggOiBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC90aGFpLWN1cnNvci1wb3NpdGlvbi5odG1sID0g VEVYVAotLy8gV2ViS2l0IHJvbGwgNTE1MTI6NTE1MjQKLUJVRzMyNzMgOiBlZGl0aW5nL3NlbGVj dGlvbi81ODI1MzUwLTEuaHRtbCA9IEZBSUwKLUJVRzMyNzMgOiBlZGl0aW5nL3NlbGVjdGlvbi81 ODI1MzUwLTIuaHRtbCA9IEZBSUwKLUJVRzMyNzMgOiBlZGl0aW5nL3NlbGVjdGlvbi9taXhlZC1l ZGl0YWJpbGl0eS0xMC5odG1sID0gRkFJTAogCiAvLyBMaW51eCBwaXhlbHRlc3QgZmFpbHVyZTog Y2FyZXQgaXMgaW4gdGhlIHdyb25nIHBsYWNlCiAvLyBVcHN0cmVhbSBXZWJLaXQgYWxzbyBza2lw cyB0aGlzIHRlc3QgYW5kIFNhZmFyaSB3aXRoIGxhdGVzdCBXZWJLaXQgc2hvd3MKZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAx YWI5YzVjOWE1ZjRhZTZkOGUxZTFjMDE0MGE4MGExMjdkMzIyNmVjLi4wZDgxNzliYzBhMTQzMmU0 ODk0MTM1MzAyNjc5YzZkMGIzNGQxMWVlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAt MjcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGZpeCB0ZXh0SW5wdXRDb250 cm9sbGVyLntzZWxlY3RlZFJhbmdlLG1hcmtlZFJhbmdlfQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0ODcKKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL2Nocm9taXVtL1RleHRJbnB1dENvbnRyb2xsZXIuY3BwOgorICAgICAgICAoVGV4dElucHV0 Q29udHJvbGxlcjo6bWFya2VkUmFuZ2UpOiBSZXR1cm4gYXJyYXlzIG9mIGludHMsIHJhdGhlciB0 aGFuIGEgc3RyaW5nCisgICAgICAgIChUZXh0SW5wdXRDb250cm9sbGVyOjpzZWxlY3RlZFJhbmdl KTogRGl0dG8uCisKIDIwMTAtMTAtMjcgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNzA2NzQuCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXh0SW5wdXRDb250 cm9sbGVyLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1RleHRJbnB1 dENvbnRyb2xsZXIuY3BwCmluZGV4IGQ5Yzc5NGM0MzI4MWNkYjVlYThkZWNiZjMzYTdlOWQ3MDNj YzNmODAuLjM2MDM4NDA5OTFhZmY0MWE3ZTg4NWU5NjQwN2YxNWE2ZWJlNGYwMDAgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1RleHRJbnB1dENvbnRyb2xs ZXIuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1RleHRJbnB1 dENvbnRyb2xsZXIuY3BwCkBAIC00Myw3ICs0Myw2IEBACiAjaW5jbHVkZSA8c3RyaW5nPgogCiB1 c2luZyBuYW1lc3BhY2UgV2ViS2l0OwotdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAogVGVzdFNoZWxs KiBUZXh0SW5wdXRDb250cm9sbGVyOjp0ZXN0U2hlbGwgPSAwOwogCkBAIC0xNzAsOSArMTY5LDEw IEBAIHZvaWQgVGV4dElucHV0Q29udHJvbGxlcjo6bWFya2VkUmFuZ2UoY29uc3QgQ3BwQXJndW1l bnRMaXN0JiwgQ3BwVmFyaWFudCogcmVzdWx0CiAgICAgICAgIHJldHVybjsKIAogICAgIFdlYlJh bmdlIHJhbmdlID0gbWFpbkZyYW1lLT5tYXJrZWRSYW5nZSgpOwotICAgIGNoYXIgYnVmZmVyWzMw XTsKLSAgICBzbnByaW50ZihidWZmZXIsIDMwLCAiJWQsJWQiLCByYW5nZS5zdGFydE9mZnNldCgp LCByYW5nZS5lbmRPZmZzZXQoKSk7Ci0gICAgcmVzdWx0LT5zZXQoc3RyaW5nKGJ1ZmZlcikpOwor ICAgIFZlY3RvcjxpbnQ+IGludEFycmF5KDIpOworICAgIGludEFycmF5WzBdID0gcmFuZ2Uuc3Rh cnRPZmZzZXQoKTsKKyAgICBpbnRBcnJheVsxXSA9IHJhbmdlLmVuZE9mZnNldCgpOworICAgIHJl c3VsdC0+c2V0KFdlYkJpbmRpbmdzOjptYWtlSW50QXJyYXkoaW50QXJyYXkpKTsKIH0KIAogdm9p ZCBUZXh0SW5wdXRDb250cm9sbGVyOjpzZWxlY3RlZFJhbmdlKGNvbnN0IENwcEFyZ3VtZW50TGlz dCYsIENwcFZhcmlhbnQqIHJlc3VsdCkKQEAgLTE4NCw5ICsxODQsMTAgQEAgdm9pZCBUZXh0SW5w dXRDb250cm9sbGVyOjpzZWxlY3RlZFJhbmdlKGNvbnN0IENwcEFyZ3VtZW50TGlzdCYsIENwcFZh cmlhbnQqIHJlc3UKICAgICAgICAgcmV0dXJuOwogCiAgICAgV2ViUmFuZ2UgcmFuZ2UgPSBtYWlu RnJhbWUtPnNlbGVjdGlvblJhbmdlKCk7Ci0gICAgY2hhciBidWZmZXJbMzBdOwotICAgIHNucHJp bnRmKGJ1ZmZlciwgMzAsICIlZCwlZCIsIHJhbmdlLnN0YXJ0T2Zmc2V0KCksIHJhbmdlLmVuZE9m ZnNldCgpKTsKLSAgICByZXN1bHQtPnNldChzdHJpbmcoYnVmZmVyKSk7CisgICAgVmVjdG9yPGlu dD4gaW50QXJyYXkoMik7CisgICAgaW50QXJyYXlbMF0gPSByYW5nZS5zdGFydE9mZnNldCgpOwor ICAgIGludEFycmF5WzFdID0gcmFuZ2UuZW5kT2Zmc2V0KCk7CisgICAgcmVzdWx0LT5zZXQoV2Vi QmluZGluZ3M6Om1ha2VJbnRBcnJheShpbnRBcnJheSkpOwogfQogCiB2b2lkIFRleHRJbnB1dENv bnRyb2xsZXI6OmZpcnN0UmVjdEZvckNoYXJhY3RlclJhbmdlKGNvbnN0IENwcEFyZ3VtZW50TGlz dCYgYXJndW1lbnRzLCBDcHBWYXJpYW50KiByZXN1bHQpCg==