48486 2010-10-27 17:16:22 -0700 [GTK] Move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk 2010-12-20 23:09:00 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 47836 1 mrobinson mrobinson eric gustavo webkit.review.bot xan.lopez oldest_to_newest 300722 0 mrobinson 2010-10-27 17:16:22 -0700 We want to move button rendering from gtk{2,3}drawing.cpp to RenderThemeGtk, which an important step in moving away from the Mozilla theme drawing code and fixing menu list rendering. 300773 1 72125 mrobinson 2010-10-27 18:29:52 -0700 Created attachment 72125 Patch for this issue 300776 2 webkit.review.bot 2010-10-27 18:31:32 -0700 Attachment 72125 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/gtk/RenderThemeGtk.cpp:473: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 300781 3 mrobinson 2010-10-27 18:35:06 -0700 (In reply to comment #2) > If any of these errors are false positives, please file a bug against check-webkit-style. This is a false positive. We need to add an exception for gtk_widget_style_get. 301549 4 webkit.review.bot 2010-10-28 20:08:59 -0700 Attachment 72125 did not build on gtk: Build output: http://queues.webkit.org/results/4748081 303895 5 72789 mrobinson 2010-11-02 22:06:43 -0700 Created attachment 72789 Patch with slightly different design 303896 6 webkit.review.bot 2010-11-02 22:08:13 -0700 Attachment 72789 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/platform/gtk/RenderThemeGtk.cpp']" exit_code: 1 WebCore/platform/gtk/RenderThemeGtk.cpp:473: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 304715 7 webkit.review.bot 2010-11-04 09:45:32 -0700 Attachment 72789 did not build on gtk: Build output: http://queues.webkit.org/results/5164016 317564 8 72789 gustavo 2010-12-06 04:58:05 -0800 Comment on attachment 72789 Patch with slightly different design This one looks right to me, now I'll review the one it depends on (doh). 322267 9 eric 2010-12-14 15:14:49 -0800 Attachment 72789 was posted by a committer and has review+, assigning to Martin Robinson for commit. 324836 10 eric 2010-12-20 22:58:25 -0800 r74132. Please close your bugs after landing. :) 324852 11 72789 mrobinson 2010-12-20 23:09:00 -0800 Comment on attachment 72789 Patch with slightly different design Sorry. Will try to be better about this in the future. 72125 2010-10-27 18:29:52 -0700 2010-11-02 22:06:39 -0700 Patch for this issue bug-48486-20101027182954.patch text/plain 3749 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjllN2YzZjEzNjQzYTFhYjQ0ZTI5Y2YxNjRhMTIwMjAyOWFkY2EzZC4uZjVjNjg2ODNlYjUyOTBl ZDVmYzVjNmUwY2ZiNDgzZjBhMDMyM2JkZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMC0yNyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTW92ZSBidXR0b24gcmVuZGVyaW5n IGZyb20gZ3RrezIsM31kcmF3aW5nLmNwcCB0byBSZW5kZXJUaGVtZUd0aworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0ODYKKworICAgICAgICBJbXBs ZW1lbnQgYnV0dG9uIHJlbmRlcmluZyBpbiBSZW5kZXJUaGVtZUd0ay4gVGhlIGltcGxlbWVudGF0 aW9uCisgICAgICAgIGZyb20gZ3RrezIsM31kcmF3aW5nLmNwcCB3aWxsIGJlIHJlbW92ZWQgb25j ZSBtZW51IGxpc3QgYnV0dG9uIHJlbmRlcmluZworICAgICAgICBpcyBpbXBsZW1lbnRlZCBpbiBS ZW5kZXJUaGVtZUd0ayBhcyB3ZWxsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhpcyBz aG91bGQgbm90IGNoYW5nZSBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpw YWludEJ1dHRvbik6IEFkZCBhbiBpbXBsZW1lbnRhdGlvbiBvZiBidXR0b24KKyAgICAgICAgcmVu ZGVyaW5nIHRoYXQgdXNlcyBXaWRnZXRSZW5kZXJpbmdDb250ZXh0LgorCiAyMDEwLTEwLTE4ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Jl bmRlclRoZW1lR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNw cAppbmRleCA5ZTY2MzllMGZlZmFkMzFjZmYzZGJkYTA5OWQzNzViNDAwNzA0MDg1Li5iY2QwY2Jj NGMwYzdlOWQ3YmRlNjRkMjhkNjE5NmRlODM1NjY5ZDYwIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UmVuZGVyVGhlbWVHdGsuY3BwCkBAIC0zNjksOSArMzY5LDUzIEBAIHZvaWQgUmVuZGVyVGhlbWVH dGs6OmFkanVzdEJ1dHRvblN0eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBSZW5kZXJT dHlsZSoKICAgICAgICAgc3R5bGUtPnNldExpbmVIZWlnaHQoUmVuZGVyU3R5bGU6OmluaXRpYWxM aW5lSGVpZ2h0KCkpOwogfQogCi1ib29sIFJlbmRlclRoZW1lR3RrOjpwYWludEJ1dHRvbihSZW5k ZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50UmVjdCYgcmVjdCkKK2Jv b2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50QnV0dG9uKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25z dCBQYWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCiB7Ci0gICAgcmV0dXJuIHBh aW50UmVuZGVyT2JqZWN0KE1PWl9HVEtfQlVUVE9OLCBvLCBpLmNvbnRleHQsIHJlY3QsIEdUS19S RUxJRUZfTk9STUFMKTsKKyAgICBpZiAoaW5mby5jb250ZXh0LT5wYWludGluZ0Rpc2FibGVkKCkp CisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIEd0a1dpZGdldCogd2lkZ2V0ID0gZ3RrQnV0 dG9uKCk7CisgICAgSW50U2l6ZSBmb2N1c1NocmluazsKKyAgICBJbnRTaXplIGJ1dHRvblNocmlu azsKKworICAgIEd0a1N0YXRlVHlwZSBzdGF0ZSA9IGdldEd0a1N0YXRlVHlwZShvYmplY3QpOwor ICAgIGd0a193aWRnZXRfc2V0X3N0YXRlKHdpZGdldCwgc3RhdGUpOworICAgIGd0a193aWRnZXRf c2V0X2RpcmVjdGlvbih3aWRnZXQsIGd0a1RleHREaXJlY3Rpb24ob2JqZWN0LT5zdHlsZSgpLT5k aXJlY3Rpb24oKSkpOworCisgICAgaWYgKGlzRm9jdXNlZChvYmplY3QpKSB7CisgICAgICAgIGlm IChpc0VuYWJsZWQob2JqZWN0KSkgeworI2lmICFHVEtfQ0hFQ0tfVkVSU0lPTigyLCAyMiwgMCkK KyAgICAgICAgICAgIEdUS19XSURHRVRfU0VUX0ZMQUdTKHdpZGdldCwgR1RLX0hBU19GT0NVUyk7 CisjZW5kaWYKKyAgICAgICAgICAgIGdfb2JqZWN0X3NldCh3aWRnZXQsICJoYXMtZm9jdXMiLCBU UlVFLCBOVUxMKTsKKyAgICAgICAgfQorCisgICAgICAgIGdib29sZWFuIGludGVyaW9yRm9jdXMg PSAwLCBmb2N1c1dpZHRoID0gMCwgZm9jdXNQYWRkaW5nID0gMDsKKyAgICAgICAgZ3RrX3dpZGdl dF9zdHlsZV9nZXQod2lkZ2V0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiaW50ZXJp b3ItZm9jdXMiLCAmaW50ZXJpb3JGb2N1cywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ImZvY3VzLWxpbmUtd2lkdGgiLCAmZm9jdXNXaWR0aCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgImZvY3VzLXBhZGRpbmciLCAmZm9jdXNQYWRkaW5nLCBOVUxMKTsKKyAgICAgICAgLy8g SWYgd2UgYXJlIHVzaW5nIGV4dGVyaW9yIGZvY3VzLCB3ZSBzaHJpbmsgdGhlIGJ1dHRvbiByZWN0 IGRvd24gYmVmb3JlCisgICAgICAgIC8vIGRyYXdpbmcuIElmIHdlIGFyZSB1c2luZyBpbnRlcmlv ciBmb2N1cyB3ZSBzaHJpbmsgdGhlIGZvY3VzIHJlY3QuIFRoaXMKKyAgICAgICAgLy8gYXBwcm9h Y2ggb3JpZ2luYXRlcyBmcm9tIHRoZSBNb3ppbGxhIHRoZW1lIGRyYXdpbmcgY29kZSAoZ3RrMmRy YXdpbmcuYykuCisgICAgICAgIGlmIChpbnRlcmlvckZvY3VzKSB7CisgICAgICAgICAgICBHdGtT dHlsZSogc3R5bGUgPSBndGtfd2lkZ2V0X2dldF9zdHlsZSh3aWRnZXQpOworICAgICAgICAgICAg Zm9jdXNTaHJpbmsgPSBJbnRTaXplKHN0eWxlLT54dGhpY2tuZXNzICsgZm9jdXNQYWRkaW5nLCBz dHlsZS0+eXRoaWNrbmVzcyArIGZvY3VzUGFkZGluZyk7CisgICAgICAgIH0gZWxzZQorICAgICAg ICAgICAgYnV0dG9uU2hyaW5rID0gSW50U2l6ZShmb2N1c1dpZHRoICsgZm9jdXNQYWRkaW5nLCBm b2N1c1dpZHRoICsgZm9jdXNQYWRkaW5nKTsKKyAgICB9CisKKyAgICBXaWRnZXRSZW5kZXJpbmdD b250ZXh0IHdpZGdldENvbnRleHQoaW5mby5jb250ZXh0LCByZWN0KTsKKyAgICB3aWRnZXRDb250 ZXh0Lmd0a1BhaW50Qm94KHdpZGdldCwgc3RhdGUsIHN0YXRlID09IEdUS19TVEFURV9BQ1RJVkUg PyBHVEtfU0hBRE9XX0lOIDogR1RLX1NIQURPV19PVVQsCisgICAgICAgICJidXR0b24iLCBidXR0 b25TaHJpbmspOworICAgIGlmIChpc0ZvY3VzZWQob2JqZWN0KSkKKyAgICAgICAgd2lkZ2V0Q29u dGV4dC5ndGtQYWludEZvY3VzKHdpZGdldCwgc3RhdGUsICJidXR0b24iLCBmb2N1c1Nocmluayk7 CisKKyNpZiAhR1RLX0NIRUNLX1ZFUlNJT04oMiwgMjIsIDApCisgICAgR1RLX1dJREdFVF9VTlNF VF9GTEFHUyh3aWRnZXQsIEdUS19IQVNfRk9DVVMpOworI2VuZGlmCisgICAgZ19vYmplY3Rfc2V0 KHdpZGdldCwgImhhcy1mb2N1cyIsIEZBTFNFLCBOVUxMKTsKKyAgICByZXR1cm4gZmFsc2U7CiB9 CiAKIHN0YXRpYyB2b2lkIGdldENvbWJvQm94UGFkZGluZyhSZW5kZXJTdHlsZSogc3R5bGUsIGlu dCYgbGVmdCwgaW50JiB0b3AsIGludCYgcmlnaHQsIGludCYgYm90dG9tKQo= 72789 2010-11-02 22:06:43 -0700 2010-12-20 23:09:00 -0800 Patch with slightly different design bug-48486-20101102220641.patch text/plain 3893 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2FmZDQ2NjdhMGQyODlmYzc0YWUyNjA0ODRkOWEwNzA0ZWY5MzE2Ni4uMzlhYmY5ZjAyY2ZlZDlk MWY0MWU5ODRiNjE3Y2ZhZWFjNDBkMzRiOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0xMC0yNyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTW92ZSBidXR0b24gcmVuZGVyaW5n IGZyb20gZ3RrezIsM31kcmF3aW5nLmNwcCB0byBSZW5kZXJUaGVtZUd0aworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0ODYKKworICAgICAgICBJbXBs ZW1lbnQgYnV0dG9uIHJlbmRlcmluZyBpbiBSZW5kZXJUaGVtZUd0ay4gVGhlIGltcGxlbWVudGF0 aW9uCisgICAgICAgIGZyb20gZ3RrezIsM31kcmF3aW5nLmNwcCB3aWxsIGJlIHJlbW92ZWQgb25j ZSBtZW51IGxpc3QgYnV0dG9uIHJlbmRlcmluZworICAgICAgICBpcyBpbXBsZW1lbnRlZCBpbiBS ZW5kZXJUaGVtZUd0ayBhcyB3ZWxsLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhpcyBz aG91bGQgbm90IGNoYW5nZSBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L1JlbmRlclRoZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpw YWludEJ1dHRvbik6IEFkZCBhbiBpbXBsZW1lbnRhdGlvbiBvZiBidXR0b24KKyAgICAgICAgcmVu ZGVyaW5nIHRoYXQgdXNlcyBXaWRnZXRSZW5kZXJpbmdDb250ZXh0LgorCiAyMDEwLTEwLTE4ICBN YXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Jl bmRlclRoZW1lR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNw cAppbmRleCAzMjA1OTQxYzBjYmE2MmQ0NzdmZDc4ZjY2ZDRlN2U1MzIwOTcxNjZkLi4zYTY0Mzc4 NzQzOGE1OTA1MTdiYjQxOWNhM2RkMGFlM2U5NzdlNmMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UmVuZGVyVGhlbWVHdGsuY3BwCkBAIC0zNjksOSArMzY5LDU2IEBAIHZvaWQgUmVuZGVyVGhlbWVH dGs6OmFkanVzdEJ1dHRvblN0eWxlKENTU1N0eWxlU2VsZWN0b3IqIHNlbGVjdG9yLCBSZW5kZXJT dHlsZSoKICAgICAgICAgc3R5bGUtPnNldExpbmVIZWlnaHQoUmVuZGVyU3R5bGU6OmluaXRpYWxM aW5lSGVpZ2h0KCkpOwogfQogCi1ib29sIFJlbmRlclRoZW1lR3RrOjpwYWludEJ1dHRvbihSZW5k ZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgaSwgY29uc3QgSW50UmVjdCYgcmVjdCkKK2Jv b2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50QnV0dG9uKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25z dCBQYWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCiB7Ci0gICAgcmV0dXJuIHBh aW50UmVuZGVyT2JqZWN0KE1PWl9HVEtfQlVUVE9OLCBvLCBpLmNvbnRleHQsIHJlY3QsIEdUS19S RUxJRUZfTk9STUFMKTsKKyAgICBpZiAoaW5mby5jb250ZXh0LT5wYWludGluZ0Rpc2FibGVkKCkp CisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIEd0a1dpZGdldCogd2lkZ2V0ID0gZ3RrQnV0 dG9uKCk7CisgICAgSW50UmVjdCBidXR0b25SZWN0KEludFBvaW50KCksIHJlY3Quc2l6ZSgpKTsK KyAgICBJbnRSZWN0IGZvY3VzUmVjdChidXR0b25SZWN0KTsKKworICAgIEd0a1N0YXRlVHlwZSBz dGF0ZSA9IGdldEd0a1N0YXRlVHlwZShvYmplY3QpOworICAgIGd0a193aWRnZXRfc2V0X3N0YXRl KHdpZGdldCwgc3RhdGUpOworICAgIGd0a193aWRnZXRfc2V0X2RpcmVjdGlvbih3aWRnZXQsIGd0 a1RleHREaXJlY3Rpb24ob2JqZWN0LT5zdHlsZSgpLT5kaXJlY3Rpb24oKSkpOworCisgICAgaWYg KGlzRm9jdXNlZChvYmplY3QpKSB7CisgICAgICAgIGlmIChpc0VuYWJsZWQob2JqZWN0KSkgewor I2lmICFHVEtfQ0hFQ0tfVkVSU0lPTigyLCAyMiwgMCkKKyAgICAgICAgICAgIEdUS19XSURHRVRf U0VUX0ZMQUdTKHdpZGdldCwgR1RLX0hBU19GT0NVUyk7CisjZW5kaWYKKyAgICAgICAgICAgIGdf b2JqZWN0X3NldCh3aWRnZXQsICJoYXMtZm9jdXMiLCBUUlVFLCBOVUxMKTsKKyAgICAgICAgfQor CisgICAgICAgIGdib29sZWFuIGludGVyaW9yRm9jdXMgPSAwLCBmb2N1c1dpZHRoID0gMCwgZm9j dXNQYWRkaW5nID0gMDsKKyAgICAgICAgZ3RrX3dpZGdldF9zdHlsZV9nZXQod2lkZ2V0LAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiaW50ZXJpb3ItZm9jdXMiLCAmaW50ZXJpb3JGb2N1 cywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImZvY3VzLWxpbmUtd2lkdGgiLCAmZm9j dXNXaWR0aCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImZvY3VzLXBhZGRpbmciLCAm Zm9jdXNQYWRkaW5nLCBOVUxMKTsKKyAgICAgICAgLy8gSWYgd2UgYXJlIHVzaW5nIGV4dGVyaW9y IGZvY3VzLCB3ZSBzaHJpbmsgdGhlIGJ1dHRvbiByZWN0IGRvd24gYmVmb3JlCisgICAgICAgIC8v IGRyYXdpbmcuIElmIHdlIGFyZSB1c2luZyBpbnRlcmlvciBmb2N1cyB3ZSBzaHJpbmsgdGhlIGZv Y3VzIHJlY3QuIFRoaXMKKyAgICAgICAgLy8gYXBwcm9hY2ggb3JpZ2luYXRlcyBmcm9tIHRoZSBN b3ppbGxhIHRoZW1lIGRyYXdpbmcgY29kZSAoZ3RrMmRyYXdpbmcuYykuCisgICAgICAgIGlmIChp bnRlcmlvckZvY3VzKSB7CisgICAgICAgICAgICBHdGtTdHlsZSogc3R5bGUgPSBndGtfd2lkZ2V0 X2dldF9zdHlsZSh3aWRnZXQpOworICAgICAgICAgICAgZm9jdXNSZWN0LmluZmxhdGVYKC1zdHls ZS0+eHRoaWNrbmVzcyAtIGZvY3VzUGFkZGluZyk7CisgICAgICAgICAgICBmb2N1c1JlY3QuaW5m bGF0ZVkoLXN0eWxlLT55dGhpY2tuZXNzIC0gZm9jdXNQYWRkaW5nKTsKKyAgICAgICAgfSBlbHNl IHsKKyAgICAgICAgICAgIGJ1dHRvblJlY3QuaW5mbGF0ZVgoLWZvY3VzV2lkdGggLSBmb2N1c1Bh ZGRpbmcpOworICAgICAgICAgICAgYnV0dG9uUmVjdC5pbmZsYXRlWSgtZm9jdXNQYWRkaW5nIC0g Zm9jdXNQYWRkaW5nKTsKKyAgICAgICAgfQorICAgIH0KKworICAgIFdpZGdldFJlbmRlcmluZ0Nv bnRleHQgd2lkZ2V0Q29udGV4dChpbmZvLmNvbnRleHQsIHJlY3QpOworICAgIEd0a1NoYWRvd1R5 cGUgc2hhZG93VHlwZSA9IHN0YXRlID09IEdUS19TVEFURV9BQ1RJVkUgPyBHVEtfU0hBRE9XX0lO IDogR1RLX1NIQURPV19PVVQ7CisgICAgd2lkZ2V0Q29udGV4dC5ndGtQYWludEJveChidXR0b25S ZWN0LCB3aWRnZXQsIHN0YXRlLCBzaGFkb3dUeXBlLCAiYnV0dG9uIik7CisgICAgaWYgKGlzRm9j dXNlZChvYmplY3QpKQorICAgICAgICB3aWRnZXRDb250ZXh0Lmd0a1BhaW50Rm9jdXMoZm9jdXNS ZWN0LCB3aWRnZXQsIHN0YXRlLCAiYnV0dG9uIik7CisKKyNpZiAhR1RLX0NIRUNLX1ZFUlNJT04o MiwgMjIsIDApCisgICAgR1RLX1dJREdFVF9VTlNFVF9GTEFHUyh3aWRnZXQsIEdUS19IQVNfRk9D VVMpOworI2VuZGlmCisgICAgZ19vYmplY3Rfc2V0KHdpZGdldCwgImhhcy1mb2N1cyIsIEZBTFNF LCBOVUxMKTsKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAKIHN0YXRpYyB2b2lkIGdldENvbWJvQm94 UGFkZGluZyhSZW5kZXJTdHlsZSogc3R5bGUsIGludCYgbGVmdCwgaW50JiB0b3AsIGludCYgcmln aHQsIGludCYgYm90dG9tKQo=