48458 2010-10-27 13:03:32 -0700 WebPageProxy::isValid should return false if the page has been explicitly closed 2010-10-27 13:11:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 300486 0 andersca 2010-10-27 13:03:32 -0700 WebPageProxy::isValid should return false if the page has been explicitly closed 300488 1 72074 andersca 2010-10-27 13:04:42 -0700 Created attachment 72074 Patch 300490 2 72074 sam 2010-10-27 13:07:06 -0700 Comment on attachment 72074 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72074&action=review > WebKit2/UIProcess/WebPageProxy.cpp:387 > + printf("is in window: %d %d\n", m_isInWindow, isInWindow); Please don't land this. 300494 3 andersca 2010-10-27 13:11:04 -0700 Committed r70696: <http://trac.webkit.org/changeset/70696> 72074 2010-10-27 13:04:42 -0700 2010-10-27 13:07:05 -0700 Patch bug-48458-20101027130441.patch text/plain 3739 andersca ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg OWQ2NGU1ZjEwNGY1MWFjMmRiYmI3MmU5MmZlYWI0YjMyYTRhMDdjOC4uNmU1YzI2ZjVlYmVlNjlk ZTIyOTFhOWY2OTlhNDYyNzQzZjY0YjMzMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMC0xMC0yNyAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYlBhZ2VQcm94eTo6aXNWYWxpZCBzaG91bGQg cmV0dXJuIGZhbHNlIGlmIHRoZSBwYWdlIGhhcyBiZWVuIGV4cGxpY2l0bHkgY2xvc2VkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00ODQ1OAorCisgICAg ICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2VQcm94eTo6V2ViUGFnZVByb3h5KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojpp c1ZhbGlkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpyZWxhdW5jaCk6CisgICAg ICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6Y2xvc2UpOgorICAgICAgICAoV2ViS2l0OjpXZWJQ YWdlUHJveHk6OnNldElzSW5XaW5kb3cpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6 OnByb2Nlc3NEaWRDcmFzaCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgor ICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmlzQ2xvc2VkKToKKworMjAxMC0xMC0yNyAg QW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gUm9iZW4uCiAKICAgICAgICAgQmVnaW4gc3R1YmJpbmcgb3V0IHRoZSBEb3dubG9h ZCBjbGFzcwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBi L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggNTBmYTg2NDMwMjU5ZWVk OTQxMmFiZTA4YTNiZWE5NTMyNWUxMWU4OC4uMDY0M2ZlMDNkYjE4NzI5YWUyNGQzZTUxZDI0M2Vi ZDE4OGU1NGY4YyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC04Myw4ICs4Myw4 IEBAIFdlYlBhZ2VQcm94eTo6V2ViUGFnZVByb3h5KFdlYlBhZ2VOYW1lc3BhY2UqIHBhZ2VOYW1l c3BhY2UsIHVpbnQ2NF90IHBhZ2VJRCkKICAgICAsIG1fYmFja0ZvcndhcmRMaXN0KFdlYkJhY2tG b3J3YXJkTGlzdDo6Y3JlYXRlKHRoaXMpKQogICAgICwgbV90ZXh0Wm9vbUZhY3RvcigxKQogICAg ICwgbV9wYWdlWm9vbUZhY3RvcigxKQotICAgICwgbV92YWxpZCh0cnVlKQotICAgICwgbV9jbG9z ZWQoZmFsc2UpCisgICAgLCBtX2lzVmFsaWQodHJ1ZSkKKyAgICAsIG1faXNDbG9zZWQoZmFsc2Up CiAgICAgLCBtX3BhZ2VJRChwYWdlSUQpCiB7CiAjaWZuZGVmIE5ERUJVRwpAQCAtMTA2LDcgKzEw NiwxMSBAQCBXZWJQcm9jZXNzUHJveHkqIFdlYlBhZ2VQcm94eTo6cHJvY2VzcygpIGNvbnN0CiAK IGJvb2wgV2ViUGFnZVByb3h5Ojppc1ZhbGlkKCkKIHsKLSAgICByZXR1cm4gbV92YWxpZDsKKyAg ICAvLyBBIHBhZ2UgdGhhdCBoYXMgYmVlbiBleHBsaWNpdGx5IGNsb3NlZCBpcyBuZXZlciB2YWxp ZC4KKyAgICBpZiAobV9pc0Nsb3NlZCkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgcmV0 dXJuIG1faXNWYWxpZDsKIH0KIAogdm9pZCBXZWJQYWdlUHJveHk6OnNldFBhZ2VDbGllbnQoUGFn ZUNsaWVudCogcGFnZUNsaWVudCkKQEAgLTE0OSw3ICsxNTMsNyBAQCB2b2lkIFdlYlBhZ2VQcm94 eTo6aW5pdGlhbGl6ZUZpbmRDbGllbnQoY29uc3QgV0tQYWdlRmluZENsaWVudCogY2xpZW50KQog CiB2b2lkIFdlYlBhZ2VQcm94eTo6cmVsYXVuY2goKQogewotICAgIG1fdmFsaWQgPSB0cnVlOwor ICAgIG1faXNWYWxpZCA9IHRydWU7CiAgICAgbV9wYWdlTmFtZXNwYWNlLT5jb250ZXh0KCktPnJl bGF1bmNoUHJvY2Vzc0lmTmVjZXNzYXJ5KCk7CiAgICAgbV9wYWdlTmFtZXNwYWNlLT5wcm9jZXNz KCktPmFkZEV4aXN0aW5nV2ViUGFnZSh0aGlzLCBtX3BhZ2VJRCk7CiAKQEAgLTE4MSw3ICsxODUs NyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6Y2xvc2UoKQogICAgIGlmICghaXNWYWxpZCgpKQogICAg ICAgICByZXR1cm47CiAKLSAgICBtX2Nsb3NlZCA9IHRydWU7CisgICAgbV9pc0Nsb3NlZCA9IHRy dWU7CiAKICAgICBwcm9jZXNzKCktPmRpc2Nvbm5lY3RGcmFtZXNGcm9tUGFnZSh0aGlzKTsKICAg ICBtX21haW5GcmFtZSA9IDA7CkBAIC0zODAsNiArMzg0LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6 OmV4ZWN1dGVFZGl0Q29tbWFuZChjb25zdCBTdHJpbmcmIGNvbW1hbmROYW1lKQogICAgIAogdm9p ZCBXZWJQYWdlUHJveHk6OnNldElzSW5XaW5kb3coYm9vbCBpc0luV2luZG93KQogeworICAgIHBy aW50ZigiaXMgaW4gd2luZG93OiAlZCAlZFxuIiwgbV9pc0luV2luZG93LCBpc0luV2luZG93KTsK KwogICAgIGlmIChtX2lzSW5XaW5kb3cgPT0gaXNJbldpbmRvdykKICAgICAgICAgcmV0dXJuOwog ICAgIApAQCAtMTIwNiw3ICsxMjEyLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnByb2Nlc3NEaWRD cmFzaCgpCiB7CiAgICAgQVNTRVJUKG1fcGFnZUNsaWVudCk7CiAKLSAgICBtX3ZhbGlkID0gZmFs c2U7CisgICAgbV9pc1ZhbGlkID0gZmFsc2U7CiAKICAgICBpZiAobV9tYWluRnJhbWUpCiAgICAg ICAgIG1fdXJsQXRQcm9jZXNzRXhpdCA9IG1fbWFpbkZyYW1lLT51cmwoKTsKZGlmZiAtLWdpdCBh L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmgKaW5kZXggNDQ0ZmEwNzgwODBmNzM4OTU2OTc2ZTgxMDczOGUwZGY4NjhmYjI1 Yi4uYjQ1YWU5N2ZlZWFjYTBjOTE3M2NkMmJkNmQ5YTY4ZjhhYjYzNjRlOSAxMDA2NDQKLS0tIGEv V2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmgKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKQEAgLTEyNCw3ICsxMjQsNyBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGNs b3NlKCk7CiAgICAgYm9vbCB0cnlDbG9zZSgpOwotICAgIGJvb2wgaXNDbG9zZWQoKSBjb25zdCB7 IHJldHVybiBtX2Nsb3NlZDsgfQorICAgIGJvb2wgaXNDbG9zZWQoKSBjb25zdCB7IHJldHVybiBt X2lzQ2xvc2VkOyB9CiAKICAgICB2b2lkIGxvYWRVUkwoY29uc3QgU3RyaW5nJik7CiAgICAgdm9p ZCBsb2FkVVJMUmVxdWVzdChXZWJVUkxSZXF1ZXN0Kik7CkBAIC0zNjIsOCArMzYyLDExIEBAIHBy aXZhdGU6CiAgICAgZG91YmxlIG1fdGV4dFpvb21GYWN0b3I7CiAgICAgZG91YmxlIG1fcGFnZVpv b21GYWN0b3I7CiAgICAgCi0gICAgYm9vbCBtX3ZhbGlkOwotICAgIGJvb2wgbV9jbG9zZWQ7Cisg ICAgLy8gSWYgdGhlIHByb2Nlc3MgYmFja2luZyB0aGUgd2ViIHBhZ2UgaXMgYWxpdmUgYW5kIGtp Y2tpbmcuCisgICAgYm9vbCBtX2lzVmFsaWQ7CisKKyAgICAvLyBXaGV0aGVyIFdlYlBhZ2VQcm94 eTo6Y2xvc2UoKSBoYXMgYmVlbiBjYWxsZWQgb24gdGhpcyBwYWdlLgorICAgIGJvb2wgbV9pc0Ns b3NlZDsKIAogICAgIHVpbnQ2NF90IG1fcGFnZUlEOwogCg==