48446 2010-10-27 11:28:58 -0700 Wrong parameter when getting MIME type from extension 2011-01-26 13:17:26 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 haizhang webkit-unassigned ademar ap commit-queue dbates eric.carlson tonikitoo oldest_to_newest 300387 0 72060 haizhang 2010-10-27 11:28:58 -0700 Created attachment 72060 patch Should pass extension to MIMETypeRegistry::getMIMETypeForExtension(). 300433 1 72069 haizhang 2010-10-27 12:14:13 -0700 Created attachment 72069 patch Update commit log. 300448 2 72069 eric.carlson 2010-10-27 12:30:28 -0700 Comment on attachment 72069 patch Nice catch! r=me 300478 3 72069 commit-queue 2010-10-27 12:53:17 -0700 Comment on attachment 72069 patch Clearing flags on attachment: 72069 Committed r70695: <http://trac.webkit.org/changeset/70695> 300480 4 commit-queue 2010-10-27 12:53:23 -0700 All reviewed patches have been landed. Closing bug. 300558 5 ap 2010-10-27 14:09:41 -0700 Why was it OK to land this without a regression test? 340428 6 ademar 2011-01-26 13:17:18 -0800 Revision r70695 cherry-picked into qtwebkit-2.1.x with commit 5454ae3 <http://gitorious.org/webkit/qtwebkit/commit/5454ae3> 72060 2010-10-27 11:28:58 -0700 2010-10-27 12:14:13 -0700 patch 0001-2010-10-26-Crystal-Zhang-.patch text/plain 1342 haizhang RnJvbSA1NTliZjgyNDhkZWNhYzM2ODVkOGI4ODE3ZjI1MjliZjg4M2FkNjRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl OiBXZWQsIDI3IE9jdCAyMDEwIDE0OjE2OjA4IC0wNDAwClN1YmplY3Q6IFtQQVRDSCAxLzJdIDIw MTAtMTAtMjYgIENyeXN0YWwgWmhhbmcgIDxoYWl6aGFuZ0ByaW0uY29tPgoKICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgRml4IGFuIGlzc3VlIHdoZXJlIHdlIHdl cmUgcGFzc2luZyB0aGUgd3JvbmcgcGFyYW1ldGVyCiAgICAgICAgdG8gTUlNRVR5cGVSZWdpc3Ry eTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24oKS4KCiAgICAgICAgKiBwbGF0Zm9ybS9NSU1FVHlw ZVJlZ2lzdHJ5LmNwcDoKLS0tCiBXZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3Bw IHwgICAgMiArLQogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcCBi L1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHAKaW5kZXggMjM5Nzc3ZS4uMTRi NTE2ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAor KysgYi9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBlUmVnaXN0cnkuY3BwCkBAIC0zMzIsNyArMzMy LDcgQEAgc3RhdGljIE1lZGlhTUlNRVR5cGVNYXAmIG1lZGlhTUlNRVR5cGVNYXAoKQogCiAgICAg ICAgICAgICAvLyBJZiB0aGVyZSBpcyBhIHN5c3RlbSBzcGVjaWZpYyB0eXBlIGZvciB0aGlzIGV4 dGVuc2lvbiwgYWRkIGl0IGFzIHRoZSBmaXJzdCB0eXBlIHNvCiAgICAgICAgICAgICAvLyBnZXRN ZWRpYU1JTUVUeXBlRm9yRXh0ZW5zaW9uIHdpbGwgYWx3YXlzIHJldHVybiBpdC4KLSAgICAgICAg ICAgIFN0cmluZyBzeXN0ZW1UeXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JF eHRlbnNpb24ocGFpcnNbbmR4XS50eXBlKTsKKyAgICAgICAgICAgIFN0cmluZyBzeXN0ZW1UeXBl ID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24ocGFpcnNbbmR4XS5l eHRlbnNpb24pOwogICAgICAgICAgICAgaWYgKCFzeXN0ZW1UeXBlLmlzRW1wdHkoKSAmJiBwYWly c1tuZHhdLnR5cGUgIT0gc3lzdGVtVHlwZSkKICAgICAgICAgICAgICAgICBzeW5vbnltcy0+YXBw ZW5kKHN5c3RlbVR5cGUpOwogICAgICAgICAgICAgc3lub255bXMtPmFwcGVuZChwYWlyc1tuZHhd LnR5cGUpOwotLSAKMS43LjIuMy5tc3lzZ2l0LjAKCg== 72069 2010-10-27 12:14:13 -0700 2010-10-27 12:53:17 -0700 patch 0001-2010-10-26-Crystal-Zhang-haizhang-rim.com.patch text/plain 1997 haizhang RnJvbSBiZGY4YzE2Mzk2YTk2NTU1NzYzOTBlNzUwMDYyYzY4ZmM2M2FmMTU1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl OiBXZWQsIDI3IE9jdCAyMDEwIDE1OjEyOjI4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0x MC0yNiAgQ3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CgogICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDg0NDYKCiAgICAgICAgRml4IGFuIGlzc3VlIHdoZXJlIHdlIHdlcmUgcGFz c2luZyB0aGUgd3JvbmcgcGFyYW1ldGVyCiAgICAgICAgdG8gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0 TUlNRVR5cGVGb3JFeHRlbnNpb24oKS4KCiAgICAgICAgKiBwbGF0Zm9ybS9NSU1FVHlwZVJlZ2lz dHJ5LmNwcDoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgICAx MSArKysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcCB8ICAg IDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGI4OTkzOWYuLjZiYTNkMjggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMjYgIENyeXN0YWwgWmhh bmcgIDxoYWl6aGFuZ0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 ODQ0NgorCisgICAgICAgIEZpeCBhbiBpc3N1ZSB3aGVyZSB3ZSB3ZXJlIHBhc3NpbmcgdGhlIHdy b25nIHBhcmFtZXRlcgorICAgICAgICB0byBNSU1FVHlwZVJlZ2lzdHJ5OjpnZXRNSU1FVHlwZUZv ckV4dGVuc2lvbigpLgorCisgICAgICAgICogcGxhdGZvcm0vTUlNRVR5cGVSZWdpc3RyeS5jcHA6 CisKIDIwMTAtMTAtMjYgIEFiaGlzaGVrIEFyeWEgIDxpbmZlcm5vQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vTUlNRVR5cGVSZWdp c3RyeS5jcHAKaW5kZXggMjM5Nzc3ZS4uMTRiNTE2ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0 Zm9ybS9NSU1FVHlwZVJlZ2lzdHJ5LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL01JTUVUeXBl UmVnaXN0cnkuY3BwCkBAIC0zMzIsNyArMzMyLDcgQEAgc3RhdGljIE1lZGlhTUlNRVR5cGVNYXAm IG1lZGlhTUlNRVR5cGVNYXAoKQogCiAgICAgICAgICAgICAvLyBJZiB0aGVyZSBpcyBhIHN5c3Rl bSBzcGVjaWZpYyB0eXBlIGZvciB0aGlzIGV4dGVuc2lvbiwgYWRkIGl0IGFzIHRoZSBmaXJzdCB0 eXBlIHNvCiAgICAgICAgICAgICAvLyBnZXRNZWRpYU1JTUVUeXBlRm9yRXh0ZW5zaW9uIHdpbGwg YWx3YXlzIHJldHVybiBpdC4KLSAgICAgICAgICAgIFN0cmluZyBzeXN0ZW1UeXBlID0gTUlNRVR5 cGVSZWdpc3RyeTo6Z2V0TUlNRVR5cGVGb3JFeHRlbnNpb24ocGFpcnNbbmR4XS50eXBlKTsKKyAg ICAgICAgICAgIFN0cmluZyBzeXN0ZW1UeXBlID0gTUlNRVR5cGVSZWdpc3RyeTo6Z2V0TUlNRVR5 cGVGb3JFeHRlbnNpb24ocGFpcnNbbmR4XS5leHRlbnNpb24pOwogICAgICAgICAgICAgaWYgKCFz eXN0ZW1UeXBlLmlzRW1wdHkoKSAmJiBwYWlyc1tuZHhdLnR5cGUgIT0gc3lzdGVtVHlwZSkKICAg ICAgICAgICAgICAgICBzeW5vbnltcy0+YXBwZW5kKHN5c3RlbVR5cGUpOwogICAgICAgICAgICAg c3lub255bXMtPmFwcGVuZChwYWlyc1tuZHhdLnR5cGUpOwotLSAKMS42LjUuMS4xMzY3LmdjZDQ4 Cgo=