48445 2010-10-27 11:21:44 -0700 [GTK] r69296 includes a cast from GdkWindow* to GtkWindow* 2010-10-27 11:39:06 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned cgarcia gustavo xan.lopez oldest_to_newest 300382 0 mrobinson 2010-10-27 11:21:44 -0700 r69296 includes a cast from GdkWindow* to GtkWindow*. This is causing a crash in plugins/null-npp-getvalue-pointer.html. 300386 1 72059 mrobinson 2010-10-27 11:27:51 -0700 Created attachment 72059 Patch for this issue 300388 2 72059 gustavo 2010-10-27 11:31:15 -0700 Comment on attachment 72059 Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=72059&action=review > WebCore/ChangeLog:10 > + GdkWindow*. The widget is used to get the proper visual for the > + widget. "The widget is used to get the proper visual for the widget." sounds really weird. Perhaps "for the plugin's container widget"? Otherwise looks right! 300397 3 mrobinson 2010-10-27 11:39:06 -0700 Committed r70677: <http://trac.webkit.org/changeset/70677> 72059 2010-10-27 11:27:51 -0700 2010-10-27 11:31:15 -0700 Patch for this issue bug-48445-20101027112751.patch text/plain 3823 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjVkOGIxYTI2NGE2ZTgxOTRiOWM4ODcyMDk2MDU4MmRhYWU0MGI4Yi4uMGMzNTAwNDQ1YzBmNDE1 NWVlNDA3MTMxY2I5ODVjZmQ4NTYzZmM2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMC0xMC0yNyAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gcjY5Mjk2IGluY2x1ZGVzIGEgY2Fz dCBmcm9tIEdka1dpbmRvdyogdG8gR3RrV2luZG93KgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDg0NDUKKworICAgICAgICBQYXNzIHRoZSBwYWdlQ2xp ZW50IEd0a1dpZGdldCogdG8gZ3RrX3h0YmluX25ldyBpbnN0ZWFkIG9mIHRoZQorICAgICAgICBH ZGtXaW5kb3cqLiBUaGUgd2lkZ2V0IGlzIHVzZWQgdG8gZ2V0IHRoZSBwcm9wZXIgdmlzdWFsIGZv ciB0aGUKKyAgICAgICAgd2lkZ2V0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gVGhpcyBwYXRj aCBzaG91bGQgcHJldmVudCBwbHVnaW5zL251bGwtbnBwLWdldHZhbHVlLXBvaW50ZXIuaHRtbAor ICAgICAgICBmcm9tIGNyYXNoaW5nLgorCisgICAgICAgICogcGx1Z2lucy9ndGsvUGx1Z2luVmll d0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpwbGF0Zm9ybVN0YXJ0KTog UGFzcyB0aGUgd2lkZ2V0IGluc3RlYWQgb2YgdGhlIHdpbmRvdy4KKyAgICAgICAgKiBwbHVnaW5z L2d0ay9ndGsyeHRiaW4uYzogQWNjZXB0IHRoZSB3aWRnZXQgaW5zdGVhZCBvZiB0aGUgd2luZG93 LgorICAgICAgICAoZ3RrX3h0YmluX25ldyk6CisgICAgICAgICogcGx1Z2lucy9ndGsvZ3RrMnh0 YmluLmg6IFVwZGF0ZSB0aGUgZGVjbGFyYXRpb24uCisKIDIwMTAtMTAtMjcgIFJlbmF0YSBIb2Rv dmFuICA8cmVuaUBpbmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBT Y2h1bHplLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNw cCBiL1dlYkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAKaW5kZXggNjk1NGFmMzNl MDVjN2VjNDA5ZjBlZmJjNDhhNzc3NmJjNGEzYmI1OC4uODA2NDFhMTc4MTAxMjcxM2I5YjBiZDM5 ZTZkZTlmN2JjODQ1YWM5YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5W aWV3R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBA IC03OTAsNyArNzkwLDcgQEAgYm9vbCBQbHVnaW5WaWV3OjpwbGF0Zm9ybVN0YXJ0KCkKICAgICAg ICAgICAgIGdfc2lnbmFsX2Nvbm5lY3QocGxhdGZvcm1QbHVnaW5XaWRnZXQoKSwgInBsdWctYWRk ZWQiLCBHX0NBTExCQUNLKHBsdWdBZGRlZENhbGxiYWNrKSwgdGhpcyk7CiAgICAgICAgICAgICBn X3NpZ25hbF9jb25uZWN0KHBsYXRmb3JtUGx1Z2luV2lkZ2V0KCksICJwbHVnLXJlbW92ZWQiLCBH X0NBTExCQUNLKHBsdWdSZW1vdmVkQ2FsbGJhY2spLCBOVUxMKTsKICAgICAgICAgfSBlbHNlCi0g ICAgICAgICAgICBzZXRQbGF0Zm9ybVdpZGdldChndGtfeHRiaW5fbmV3KGd0a193aWRnZXRfZ2V0 X3dpbmRvdyhwYWdlQ2xpZW50KSwgMCkpOworICAgICAgICAgICAgc2V0UGxhdGZvcm1XaWRnZXQo Z3RrX3h0YmluX25ldyhwYWdlQ2xpZW50LCAwKSk7CiAjZWxzZQogICAgICAgICBzZXRQbGF0Zm9y bVdpZGdldChndGtfc29ja2V0X25ldygpKTsKICAgICAgICAgZ3RrX2NvbnRhaW5lcl9hZGQoR1RL X0NPTlRBSU5FUihwYWdlQ2xpZW50KSwgcGxhdGZvcm1QbHVnaW5XaWRnZXQoKSk7CmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5jIGIvV2ViQ29yZS9wbHVnaW5zL2d0 ay9ndGsyeHRiaW4uYwppbmRleCAzMWM1NjRmNDFkMzllOWM0ZGI4MTc4MWI2YzZkMzYxOGRkNjAx OWNkLi5mNjY4YmZmNWIxNjMzMjVjMTk3ZDAxMmJiMDM5Yzc2YzE0NjIxZDc3IDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5jCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9n dGsvZ3RrMnh0YmluLmMKQEAgLTMyMiwxMyArMzIyLDE0IEBAIGd0a194dGJpbl9yZWFsaXplIChH dGtXaWRnZXQgKndpZGdldCkKIAogCiBHdGtXaWRnZXQqCi1ndGtfeHRiaW5fbmV3IChHZGtXaW5k b3cgKnBhcmVudF93aW5kb3csIFN0cmluZyAqIGYpCitndGtfeHRiaW5fbmV3IChHdGtXaWRnZXQg KnBhcmVudF93aWRnZXQsIFN0cmluZyAqZikKIHsKICAgR3RrWHRCaW4gKnh0YmluOwogICBncG9p bnRlciB1c2VyX2RhdGE7CiAgIEdka1NjcmVlbiAqc2NyZWVuOwogICBHZGtWaXN1YWwqIHZpc3Vh bDsKICAgQ29sb3JtYXAgY29sb3JtYXA7CisgIEdka1dpbmRvdyogcGFyZW50X3dpbmRvdyA9IGd0 a193aWRnZXRfZ2V0X3dpbmRvdyhwYXJlbnRfd2lkZ2V0KTsKIAogICBhc3NlcnQocGFyZW50X3dp bmRvdyAhPSBOVUxMKTsKICAgeHRiaW4gPSBnX29iamVjdF9uZXcgKEdUS19UWVBFX1hUQklOLCBO VUxMKTsKQEAgLTM0Miw3ICszNDMsNyBAQCBndGtfeHRiaW5fbmV3IChHZGtXaW5kb3cgKnBhcmVu dF93aW5kb3csIFN0cmluZyAqIGYpCiAgIC8qIEluaXRpYWxpemUgdGhlIFh0IHRvb2xraXQgKi8K ICAgeHRiaW4tPnBhcmVudF93aW5kb3cgPSBwYXJlbnRfd2luZG93OwogCi0gIHNjcmVlbiA9IGd0 a193aWRnZXRfZ2V0X3NjcmVlbihHVEtfV0lER0VUKHBhcmVudF93aW5kb3cpKTsKKyAgc2NyZWVu ID0gZ3RrX3dpZGdldF9nZXRfc2NyZWVuKHBhcmVudF93aWRnZXQpOwogICB2aXN1YWwgPSBnZGtf c2NyZWVuX2dldF9zeXN0ZW1fdmlzdWFsKHNjcmVlbik7CiAgIGNvbG9ybWFwID0gWENyZWF0ZUNv bG9ybWFwKEdES19ESVNQTEFZX1hESVNQTEFZKGdka19zY3JlZW5fZ2V0X2Rpc3BsYXkoc2NyZWVu KSksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdES19XSU5ET1dfWFdJTkRPVyhnZGtf c2NyZWVuX2dldF9yb290X3dpbmRvdyhzY3JlZW4pKSwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1 Z2lucy9ndGsvZ3RrMnh0YmluLmggYi9XZWJDb3JlL3BsdWdpbnMvZ3RrL2d0azJ4dGJpbi5oCmlu ZGV4IDdiY2ZhYjZlNTU5MmY3YmZkZGUxNDEzNDZlOTM5YjkyYTMxODdkODUuLjExZjZlMDZlOGFh NGY5OGM3ZThiNzU4MTAxMDUxYzEwOTUyM2IyN2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lu cy9ndGsvZ3RrMnh0YmluLmgKKysrIGIvV2ViQ29yZS9wbHVnaW5zL2d0ay9ndGsyeHRiaW4uaApA QCAtMTAxLDcgKzEwMSw3IEBAIHN0cnVjdCBfR3RrWHRCaW5DbGFzcwogfTsKIAogR1RLWFRCSU5f QVBJKEdUeXBlKSAgICAgICBndGtfeHRiaW5fZ2V0X3R5cGUgKHZvaWQpOwotR1RLWFRCSU5fQVBJ KEd0a1dpZGdldCAqKSBndGtfeHRiaW5fbmV3IChHZGtXaW5kb3cgKnBhcmVudF93aW5kb3csIFN0 cmluZyAqZik7CitHVEtYVEJJTl9BUEkoR3RrV2lkZ2V0ICopIGd0a194dGJpbl9uZXcgKEd0a1dp ZGdldCAqcGFyZW50X3dpZGdldCwgU3RyaW5nICpmKTsKIEdUS1hUQklOX0FQSSh2b2lkKSAgICAg ICAgZ3RrX3h0YmluX3NldF9wb3NpdGlvbiAoR3RrWHRCaW4gKnh0YmluLAogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnaW50ICAgICAgIHgsCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdpbnQgICAgICAg eSk7Cg==